Issues in class.jetpack-client-server.php - Fixed Issues - Inspection of "Merge r135817-wpcom to fix LinkedIn count" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — branch-4.0 ( fc0d6f...bf547c )

unknown

created 2016-06-06 03:47 UTC

class.jetpack-client-server.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Client = Plugin
 * Client Server = API Methods the Plugin must respond to
 */
class Jetpack_Client_Server {

	/**
	 * Authorizations
	 */
	function client_authorize() {
		$data              = stripslashes_deep( $_GET );
		$data['auth_type'] = 'client';
		$jetpack           = $this->get_jetpack();
		$role              = $jetpack->translate_current_user_to_role();
		$redirect          = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';

		$this->check_admin_referer( "jetpack-authorize_{$role}_{$redirect}" );

		$result = $this->authorize( $data );
		if ( is_wp_error( $result ) ) {
			Jetpack::state( 'error', $result->get_error_code() );
		}

		if ( wp_validate_redirect( $redirect ) ) {
			$this->wp_safe_redirect( $redirect );
		} else {
			$this->wp_safe_redirect( Jetpack::admin_url() );
		}

		$this->do_exit();
	}

	function authorize( $data = array() ) {
		$redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';

		$jetpack_unique_connection = Jetpack_Options::get_option( 'unique_connection' );
		// Checking if site has been active/connected previously before recording unique connection
		if ( ! $jetpack_unique_connection ) {
			// jetpack_unique_connection option has never been set
			$jetpack_unique_connection = array(
				'connected'     => 0,
				'disconnected'  => 0,
				'version'       => '3.6.1'
			);

			update_option( 'jetpack_unique_connection', $jetpack_unique_connection );

			//track unique connection
			$jetpack = Jetpack::init();

			$jetpack->stat( 'connections', 'unique-connection' );
			$jetpack->do_stats( 'server_side' );
		}

		// increment number of times connected
		$jetpack_unique_connection['connected'] += 1;
		Jetpack_Options::update_option( 'unique_connection', $jetpack_unique_connection );

		do {
			$jetpack = $this->get_jetpack();
			$role = $jetpack->translate_current_user_to_role();

			if ( ! $role ) {
				return new Jetpack_Error( 'no_role', 'Invalid request.', 400 );
			}

			$cap = $jetpack->translate_role_to_cap( $role );
			if ( !$cap ) {
				return new Jetpack_Error( 'no_cap', 'Invalid request.', 400 );
			}

			if ( ! empty( $data['error'] ) ) {
				return new Jetpack_Error( $data['error'], 'Error included in the request.', 400 );
			}

			if ( ! isset( $data['state'] ) ) {
				return new Jetpack_Error( 'no_state', 'Request must include state.', 400 );
			}

			if ( ! ctype_digit( $data['state'] ) ) {
				return new Jetpack_Error( $data['error'], 'State must be an integer.', 400 );
			}

			$current_user_id = get_current_user_id();
			if ( $current_user_id != $data['state'] ) {
				return new Jetpack_Error( 'wrong_state', 'State does not match current user.', 400 );
			}

			if ( empty( $data['code'] ) ) {
				return new Jetpack_Error( 'no_code', 'Request must include an authorization code.', 400 );
			}

			$token = $this->get_token( $data );

			if ( is_wp_error( $token ) ) {
				$code = $token->get_error_code();
				if ( empty( $code ) ) {
					$code = 'invalid_token';
				}
				return new Jetpack_Error( $code, $token->get_error_message(), 400 );
			}

			if ( ! $token ) {
				return new Jetpack_Error( 'no_token', 'Error generating token.', 400 );
			}

			$is_master_user = ! Jetpack::is_active();

			Jetpack::update_user_token( $current_user_id, sprintf( '%s.%d', $token, $current_user_id ), $is_master_user );


			if ( ! $is_master_user ) {
				// Don't activate anything since we are just connecting a user.
				return 'linked';
			}

			$redirect_on_activation_error = ( 'client' === $data['auth_type'] ) ? true : false;
			if ( $active_modules = Jetpack_Options::get_option( 'active_modules' ) ) {
				Jetpack_Options::delete_option( 'active_modules' );

				Jetpack::activate_default_modules( 999, 1, $active_modules, $redirect_on_activation_error );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			} else {
				Jetpack::activate_default_modules( false, false, array(), $redirect_on_activation_error );
			}

			// Sync all registers options and constants
			/** This action is documented in class.jetpack.php */
			do_action( 'jetpack_sync_all_registered_options' );

			// Start nonce cleaner
			wp_clear_scheduled_hook( 'jetpack_clean_nonces' );
			wp_schedule_event( time(), 'hourly', 'jetpack_clean_nonces' );
		} while ( false );

		return 'authorized';
	}

	public static function deactivate_plugin( $probable_file, $probable_title ) {
		include_once( ABSPATH . 'wp-admin/includes/plugin.php' );
		if ( is_plugin_active( $probable_file ) ) {
			deactivate_plugins( $probable_file );
			return 1;
		} else {
			// If the plugin is not in the usual place, try looking through all active plugins.
			$active_plugins = Jetpack::get_active_plugins();
			foreach ( $active_plugins as $plugin ) {
				$data = get_plugin_data( WP_PLUGIN_DIR . '/' . $plugin );
				if ( $data['Name'] == $probable_title ) {
					deactivate_plugins( $plugin );
					return 1;
				}
			}
		}

		return 0;
	}

	/**
	 * @return object|WP_Error
	 */
	function get_token( $data ) {
		$jetpack = $this->get_jetpack();
		$role = $jetpack->translate_current_user_to_role();

		if ( ! $role ) {
			return new Jetpack_Error( 'role', __( 'An administrator for this blog must set up the Jetpack connection.', 'jetpack' ) );
		}

		$client_secret = Jetpack_Data::get_access_token();
		if ( !$client_secret ) {
			return new Jetpack_Error( 'client_secret', __( 'You need to register your Jetpack before connecting it.', 'jetpack' ) );
		}

		$redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';
		$redirect_uri = ( 'calypso' === $data['auth_type'] )
			? $data['redirect_uri']
			: add_query_arg( array(
				'action' => 'authorize',
				'_wpnonce' => wp_create_nonce( "jetpack-authorize_{$role}_{$redirect}" ),
				'redirect' => $redirect ? urlencode( $redirect ) : false,
			), menu_page_url( 'jetpack', false ) );

		$body = array(
			'client_id' => Jetpack_Options::get_option( 'id' ),
			'client_secret' => $client_secret->secret,
			'grant_type' => 'authorization_code',
			'code' => $data['code'],
			'redirect_uri' => $redirect_uri,
		);

		$args = array(
			'method' => 'POST',
			'body' => $body,
			'headers' => array(
				'Accept' => 'application/json',
			),
		);
		$response = Jetpack_Client::_wp_remote_request( Jetpack::fix_url_for_bad_hosts( Jetpack::api_url( 'token' ) ), $args );

		if ( is_wp_error( $response ) ) {
			return new Jetpack_Error( 'token_http_request_failed', $response->get_error_message() );
		}

		$code = wp_remote_retrieve_response_code( $response );
		$entity = wp_remote_retrieve_body( $response );

		if ( $entity )
			$json = json_decode( $entity );
		else
			$json = false;

		if ( 200 != $code || !empty( $json->error ) ) {
			if ( empty( $json->error ) )
				return new Jetpack_Error( 'unknown', '', $code );

			$error_description = isset( $json->error_description ) ? sprintf( __( 'Error Details: %s', 'jetpack' ), (string) $json->error_description ) : '';

			return new Jetpack_Error( (string) $json->error, $error_description, $code );
		}

		if ( empty( $json->access_token ) || !is_scalar( $json->access_token ) ) {
			return new Jetpack_Error( 'access_token', '', $code );
		}

		if ( empty( $json->token_type ) || 'X_JETPACK' != strtoupper( $json->token_type ) ) {
			return new Jetpack_Error( 'token_type', '', $code );
		}

		if ( empty( $json->scope ) ) {
			return new Jetpack_Error( 'scope', 'No Scope', $code );
		}
		@list( $role, $hmac ) = explode( ':', $json->scope );
		if ( empty( $role ) || empty( $hmac ) ) {
			return new Jetpack_Error( 'scope', 'Malformed Scope', $code );
		}
		if ( $jetpack->sign_role( $role ) !== $json->scope ) {
			return new Jetpack_Error( 'scope', 'Invalid Scope', $code );
		}

		if ( !$cap = $jetpack->translate_role_to_cap( $role ) )
			return new Jetpack_Error( 'scope', 'No Cap', $code );
		if ( ! current_user_can( $cap ) )
			return new Jetpack_Error( 'scope', 'current_user_cannot', $code );

		/**
		 * Fires after user has successfully received an auth token.
		 *
		 * @since 3.9.0
		 */
		do_action( 'jetpack_user_authorized' );

		return (string) $json->access_token;
	}

	public function get_jetpack() {
		return Jetpack::init();
	}

	public function check_admin_referer( $action ) {
		return check_admin_referer( $action );
	}

	public function wp_safe_redirect( $redirect ) {
		return wp_safe_redirect( $redirect );
	}

	public function do_exit() {
		exit;
	}

}


1			<?php
2
3			/**
4			* Client = Plugin
5			* Client Server = API Methods the Plugin must respond to
6			*/
7			class Jetpack_Client_Server {
8
9			/**
10			* Authorizations
11			*/
12			function client_authorize() {
13			$data = stripslashes_deep( $_GET );
14			$data['auth_type'] = 'client';
15			$jetpack = $this->get_jetpack();
16			$role = $jetpack->translate_current_user_to_role();
17			$redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';
18
19			$this->check_admin_referer( "jetpack-authorize_{$role}_{$redirect}" );
20
21			$result = $this->authorize( $data );
22			if ( is_wp_error( $result ) ) {
23			Jetpack::state( 'error', $result->get_error_code() );
24			}
25
26			if ( wp_validate_redirect( $redirect ) ) {
27			$this->wp_safe_redirect( $redirect );
28			} else {
29			$this->wp_safe_redirect( Jetpack::admin_url() );
30			}
31
32			$this->do_exit();
33			}
34
35			function authorize( $data = array() ) {
36			$redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';
37
38			$jetpack_unique_connection = Jetpack_Options::get_option( 'unique_connection' );
39			// Checking if site has been active/connected previously before recording unique connection
40			if ( ! $jetpack_unique_connection ) {
41			// jetpack_unique_connection option has never been set
42			$jetpack_unique_connection = array(
43			'connected' => 0,
44			'disconnected' => 0,
45			'version' => '3.6.1'
46			);
47
48			update_option( 'jetpack_unique_connection', $jetpack_unique_connection );
49
50			//track unique connection
51			$jetpack = Jetpack::init();
52
53			$jetpack->stat( 'connections', 'unique-connection' );
54			$jetpack->do_stats( 'server_side' );
55			}
56
57			// increment number of times connected
58			$jetpack_unique_connection['connected'] += 1;
59			Jetpack_Options::update_option( 'unique_connection', $jetpack_unique_connection );
60
61			do {
62			$jetpack = $this->get_jetpack();
63			$role = $jetpack->translate_current_user_to_role();
64
65			if ( ! $role ) {
66			return new Jetpack_Error( 'no_role', 'Invalid request.', 400 );
67			}
68
69			$cap = $jetpack->translate_role_to_cap( $role );
70			if ( !$cap ) {
71			return new Jetpack_Error( 'no_cap', 'Invalid request.', 400 );
72			}
73
74			if ( ! empty( $data['error'] ) ) {
75			return new Jetpack_Error( $data['error'], 'Error included in the request.', 400 );
76			}
77
78			if ( ! isset( $data['state'] ) ) {
79			return new Jetpack_Error( 'no_state', 'Request must include state.', 400 );
80			}
81
82			if ( ! ctype_digit( $data['state'] ) ) {
83			return new Jetpack_Error( $data['error'], 'State must be an integer.', 400 );
84			}
85
86			$current_user_id = get_current_user_id();
87			if ( $current_user_id != $data['state'] ) {
88			return new Jetpack_Error( 'wrong_state', 'State does not match current user.', 400 );
89			}
90
91			if ( empty( $data['code'] ) ) {
92			return new Jetpack_Error( 'no_code', 'Request must include an authorization code.', 400 );
93			}
94
95			$token = $this->get_token( $data );
96
97			if ( is_wp_error( $token ) ) {
98			$code = $token->get_error_code();
99			if ( empty( $code ) ) {
100			$code = 'invalid_token';
101			}
102			return new Jetpack_Error( $code, $token->get_error_message(), 400 );
103			}
104
105			if ( ! $token ) {
106			return new Jetpack_Error( 'no_token', 'Error generating token.', 400 );
107			}
108
109			$is_master_user = ! Jetpack::is_active();
110
111			Jetpack::update_user_token( $current_user_id, sprintf( '%s.%d', $token, $current_user_id ), $is_master_user );
112
113
114			if ( ! $is_master_user ) {
115			// Don't activate anything since we are just connecting a user.
116			return 'linked';
117			}
118
119			$redirect_on_activation_error = ( 'client' === $data['auth_type'] ) ? true : false;
120			if ( $active_modules = Jetpack_Options::get_option( 'active_modules' ) ) {
121			Jetpack_Options::delete_option( 'active_modules' );
122
123			Jetpack::activate_default_modules( 999, 1, $active_modules, $redirect_on_activation_error );
			0 ignored issues – show Documentation introduced 2016-03-29 15:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this `999` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
124			} else {
125			Jetpack::activate_default_modules( false, false, array(), $redirect_on_activation_error );
126			}
127
128			// Sync all registers options and constants
129			/** This action is documented in class.jetpack.php */
130			do_action( 'jetpack_sync_all_registered_options' );
131
132			// Start nonce cleaner
133			wp_clear_scheduled_hook( 'jetpack_clean_nonces' );
134			wp_schedule_event( time(), 'hourly', 'jetpack_clean_nonces' );
135			} while ( false );
136
137			return 'authorized';
138			}
139
140			public static function deactivate_plugin( $probable_file, $probable_title ) {
141			include_once( ABSPATH . 'wp-admin/includes/plugin.php' );
142			if ( is_plugin_active( $probable_file ) ) {
143			deactivate_plugins( $probable_file );
144			return 1;
145			} else {
146			// If the plugin is not in the usual place, try looking through all active plugins.
147			$active_plugins = Jetpack::get_active_plugins();
148			foreach ( $active_plugins as $plugin ) {
149			$data = get_plugin_data( WP_PLUGIN_DIR . '/' . $plugin );
150			if ( $data['Name'] == $probable_title ) {
151			deactivate_plugins( $plugin );
152			return 1;
153			}
154			}
155			}
156
157			return 0;
158			}
159
160			/**
161			* @return object\|WP_Error
162			*/
163			function get_token( $data ) {
164			$jetpack = $this->get_jetpack();
165			$role = $jetpack->translate_current_user_to_role();
166
167			if ( ! $role ) {
168			return new Jetpack_Error( 'role', __( 'An administrator for this blog must set up the Jetpack connection.', 'jetpack' ) );
169			}
170
171			$client_secret = Jetpack_Data::get_access_token();
172			if ( !$client_secret ) {
173			return new Jetpack_Error( 'client_secret', __( 'You need to register your Jetpack before connecting it.', 'jetpack' ) );
174			}
175
176			$redirect = isset( $data['redirect'] ) ? esc_url_raw( (string) $data['redirect'] ) : '';
177			$redirect_uri = ( 'calypso' === $data['auth_type'] )
178			? $data['redirect_uri']
179			: add_query_arg( array(
180			'action' => 'authorize',
181			'_wpnonce' => wp_create_nonce( "jetpack-authorize_{$role}_{$redirect}" ),
182			'redirect' => $redirect ? urlencode( $redirect ) : false,
183			), menu_page_url( 'jetpack', false ) );
184
185			$body = array(
186			'client_id' => Jetpack_Options::get_option( 'id' ),
187			'client_secret' => $client_secret->secret,
188			'grant_type' => 'authorization_code',
189			'code' => $data['code'],
190			'redirect_uri' => $redirect_uri,
191			);
192
193			$args = array(
194			'method' => 'POST',
195			'body' => $body,
196			'headers' => array(
197			'Accept' => 'application/json',
198			),
199			);
200			$response = Jetpack_Client::_wp_remote_request( Jetpack::fix_url_for_bad_hosts( Jetpack::api_url( 'token' ) ), $args );
201
202			if ( is_wp_error( $response ) ) {
203			return new Jetpack_Error( 'token_http_request_failed', $response->get_error_message() );
204			}
205
206			$code = wp_remote_retrieve_response_code( $response );
207			$entity = wp_remote_retrieve_body( $response );
208
209			if ( $entity )
210			$json = json_decode( $entity );
211			else
212			$json = false;
213
214			if ( 200 != $code \|\| !empty( $json->error ) ) {
215			if ( empty( $json->error ) )
216			return new Jetpack_Error( 'unknown', '', $code );
217
218			$error_description = isset( $json->error_description ) ? sprintf( __( 'Error Details: %s', 'jetpack' ), (string) $json->error_description ) : '';
219
220			return new Jetpack_Error( (string) $json->error, $error_description, $code );
221			}
222
223			if ( empty( $json->access_token ) \|\| !is_scalar( $json->access_token ) ) {
224			return new Jetpack_Error( 'access_token', '', $code );
225			}
226
227			if ( empty( $json->token_type ) \|\| 'X_JETPACK' != strtoupper( $json->token_type ) ) {
228			return new Jetpack_Error( 'token_type', '', $code );
229			}
230
231			if ( empty( $json->scope ) ) {
232			return new Jetpack_Error( 'scope', 'No Scope', $code );
233			}
234			@list( $role, $hmac ) = explode( ':', $json->scope );
235			if ( empty( $role ) \|\| empty( $hmac ) ) {
236			return new Jetpack_Error( 'scope', 'Malformed Scope', $code );
237			}
238			if ( $jetpack->sign_role( $role ) !== $json->scope ) {
239			return new Jetpack_Error( 'scope', 'Invalid Scope', $code );
240			}
241
242			if ( !$cap = $jetpack->translate_role_to_cap( $role ) )
243			return new Jetpack_Error( 'scope', 'No Cap', $code );
244			if ( ! current_user_can( $cap ) )
245			return new Jetpack_Error( 'scope', 'current_user_cannot', $code );
246
247			/**
248			* Fires after user has successfully received an auth token.
249			*
250			* @since 3.9.0
251			*/
252			do_action( 'jetpack_user_authorized' );
253
254			return (string) $json->access_token;
255			}
256
257			public function get_jetpack() {
258			return Jetpack::init();
259			}
260
261			public function check_admin_referer( $action ) {
262			return check_admin_referer( $action );
263			}
264
265			public function wp_safe_redirect( $redirect ) {
266			return wp_safe_redirect( $redirect );
267			}
268
269			public function do_exit() {
270			exit;
271			}
272
273			}
274

Automattic / jetpack

Push — branch-4.0 ( fc0d6f...bf547c )

class.jetpack-client-server.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like