Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | class Classes_Handler { |
||
8 | |||
9 | /** |
||
10 | * The Plugins_Handler object. |
||
11 | * |
||
12 | * @var Plugins_Handler |
||
13 | */ |
||
14 | private $plugins_handler = null; |
||
15 | |||
16 | /** |
||
17 | * The Version_Selector object. |
||
18 | * |
||
19 | * @var Version_Selector |
||
20 | */ |
||
21 | private $version_selector = null; |
||
22 | |||
23 | /** |
||
24 | * The constructor. |
||
25 | * |
||
26 | * @param Plugins_Handler $plugins_handler The Plugins_Handler object. |
||
27 | * @param Version_Selector $version_selector The Version_Selector object. |
||
28 | */ |
||
29 | public function __construct( $plugins_handler, $version_selector ) { |
||
33 | |||
34 | /** |
||
35 | * Adds the version of a package to the $jetpack_packages_classmap global |
||
36 | * array so that the autoloader is able to find it. |
||
37 | * |
||
38 | * @param string $class_name Name of the class that you want to autoload. |
||
39 | * @param string $version Version of the class. |
||
40 | * @param string $path Absolute path to the class so that we can load it. |
||
41 | */ |
||
42 | View Code Duplication | public function enqueue_package_class( $class_name, $version, $path ) { |
|
58 | |||
59 | /** |
||
60 | * Creates an array containing paths to the plugins' classmaps. The classmap filename is the filename |
||
61 | * generated by Jetpack Autoloader version >= 2.0. |
||
62 | * |
||
63 | * @param String $plugin The plugin name. |
||
64 | * |
||
65 | * @return Array An array of plugin names and classmap paths. |
||
66 | */ |
||
67 | View Code Duplication | public function create_classmap_path_array( $plugin ) { |
|
76 | |||
77 | /** |
||
78 | * Initializes the classmap. |
||
79 | */ |
||
80 | View Code Duplication | public function set_class_paths() { |
|
96 | } |
||
97 |