Conditions | 21 |
Paths | 366 |
Total Lines | 120 |
Lines | 7 |
Ratio | 5.83 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
122 | function github_gist_shortcode( $atts, $content = '' ) { |
||
123 | |||
124 | View Code Duplication | if ( empty( $atts[0] ) && empty( $content ) ) { |
|
125 | if ( current_user_can( 'edit_posts' ) ) { |
||
126 | return esc_html__( 'Please specify a Gist URL or ID.', 'jetpack' ); |
||
127 | } else { |
||
128 | return '<!-- Missing Gist ID -->'; |
||
129 | } |
||
130 | } |
||
131 | |||
132 | $id = ( ! empty( $content ) ) ? $content : $atts[0]; |
||
133 | |||
134 | // Parse a URL to get an ID we can use. |
||
135 | $gist_info = jetpack_gist_get_shortcode_id( $id ); |
||
136 | if ( empty( $gist_info['id'] ) ) { |
||
137 | if ( current_user_can( 'edit_posts' ) ) { |
||
138 | return esc_html__( 'The Gist ID you provided is not valid. Please try a different one.', 'jetpack' ); |
||
139 | } else { |
||
140 | return '<!-- Invalid Gist ID -->'; |
||
141 | } |
||
142 | } else { |
||
143 | // Add trailing .json to all unique gist identifiers. |
||
144 | $id = $gist_info['id'] . '.json'; |
||
145 | } |
||
146 | |||
147 | // The file name can come from the URL passed, or from a shortcode attribute. |
||
148 | if ( ! empty( $gist_info['file'] ) ) { |
||
149 | $file = $gist_info['file']; |
||
150 | } elseif ( ! empty( $atts['file'] ) ) { |
||
151 | $file = $atts['file']; |
||
152 | } else { |
||
153 | $file = ''; |
||
154 | } |
||
155 | |||
156 | // Replace - by . to get a real file name from slug. |
||
157 | if ( ! empty( $file ) ) { |
||
158 | // Find the last -. |
||
159 | $dash_position = strrpos( $file, '-' ); |
||
160 | if ( false !== $dash_position ) { |
||
161 | // Replace the - by a period. |
||
162 | $file = substr_replace( $file, '.', $dash_position, 1 ); |
||
163 | } |
||
164 | |||
165 | $file = rawurlencode( $file ); |
||
166 | } |
||
167 | |||
168 | // Set the tab size, allowing attributes to override the query string. |
||
169 | $tab_size = $gist_info['ts']; |
||
170 | if ( ! empty( $atts['ts'] ) ) { |
||
171 | $tab_size = absint( $atts['ts'] ); |
||
172 | } |
||
173 | |||
174 | if ( |
||
175 | class_exists( 'Jetpack_AMP_Support' ) |
||
176 | && Jetpack_AMP_Support::is_amp_request() |
||
177 | ) { |
||
178 | /* |
||
179 | * According to <https://www.ampproject.org/docs/reference/components/amp-gist#height-(required)>: |
||
180 | * |
||
181 | * > Note: You must find the height of the gist by inspecting it with your browser (e.g., Chrome Developer Tools). |
||
182 | * |
||
183 | * However, this does not seem to be the case any longer. The actual height of the content does get set in the |
||
184 | * page after loading. So this is just the initial height. |
||
185 | * See <https://github.com/ampproject/amphtml/pull/17738>. |
||
186 | */ |
||
187 | $height = 240; |
||
188 | |||
189 | $amp_tag = sprintf( |
||
190 | '<amp-gist layout="fixed-height" data-gistid="%s" height="%s"', |
||
191 | esc_attr( basename( $id, '.json' ) ), |
||
192 | esc_attr( $height ) |
||
193 | ); |
||
194 | if ( ! empty( $file ) ) { |
||
195 | $amp_tag .= sprintf( ' data-file="%s"', esc_attr( $file ) ); |
||
196 | } |
||
197 | $amp_tag .= '></amp-gist>'; |
||
198 | return $amp_tag; |
||
199 | } |
||
200 | |||
201 | // URL points to the entire gist, including the file name if there was one. |
||
202 | $id = ( ! empty( $file ) ? $id . '?file=' . $file : $id ); |
||
203 | $return = false; |
||
204 | |||
205 | $request = wp_remote_get( esc_url_raw( 'https://gist.github.com/' . esc_attr( $id ) ) ); |
||
206 | $request_code = wp_remote_retrieve_response_code( $request ); |
||
207 | |||
208 | if ( 200 === $request_code ) { |
||
209 | $request_body = wp_remote_retrieve_body( $request ); |
||
210 | $request_data = json_decode( $request_body ); |
||
211 | |||
212 | wp_enqueue_style( 'jetpack-gist-styling', esc_url( $request_data->stylesheet ), array(), JETPACK__VERSION ); |
||
213 | |||
214 | $gist = substr_replace( $request_data->div, sprintf( 'style="tab-size: %1$s" ', absint( $tab_size ) ), 5, 0 ); |
||
|
|||
215 | |||
216 | // Add inline styles for the tab style in the opening div of the gist. |
||
217 | $gist = preg_replace( |
||
218 | '#(\<div\s)+(id=\"gist[0-9]+\")+(\sclass=\"gist\"\>)?#', |
||
219 | sprintf( '$1style="tab-size: %1$s" $2$3', absint( $tab_size ) ), |
||
220 | $request_data->div, |
||
221 | 1 |
||
222 | ); |
||
223 | |||
224 | // Add inline style to prevent the bottom margin to the embed that themes like TwentyTen, et al., add to tables. |
||
225 | $return = sprintf( '<style>.gist table { margin-bottom: 0; }</style>%1$s', $gist ); |
||
226 | } |
||
227 | |||
228 | if ( |
||
229 | // No need to check for a nonce here, that's already handled by Core further up. |
||
230 | // phpcs:disable WordPress.Security.NonceVerification.Missing |
||
231 | isset( $_POST['type'] ) |
||
232 | && 'embed' === $_POST['type'] |
||
233 | && isset( $_POST['action'] ) |
||
234 | && 'parse-embed' === $_POST['action'] |
||
235 | // phpcs:enable WordPress.Security.NonceVerification.Missing |
||
236 | ) { |
||
237 | return github_gist_simple_embed( $id, $tab_size ); |
||
238 | } |
||
239 | |||
240 | return $return; |
||
241 | } |
||
242 | |||
257 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.