Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 5 | class Jetpack_Sync_Module_Callables extends Jetpack_Sync_Module { |
||
| 6 | const CALLABLES_CHECKSUM_OPTION_NAME = 'jetpack_callables_sync_checksum'; |
||
| 7 | const CALLABLES_AWAIT_TRANSIENT_NAME = 'jetpack_sync_callables_await'; |
||
| 8 | |||
| 9 | private $callable_whitelist; |
||
| 10 | |||
| 11 | public function name() { |
||
| 14 | |||
| 15 | public function set_defaults() { |
||
| 22 | |||
| 23 | public function init_listeners( $callable ) { |
||
| 33 | |||
| 34 | public function init_before_send() { |
||
| 35 | add_action( 'jetpack_sync_before_send', array( $this, 'maybe_sync_callables' ) ); |
||
| 36 | |||
| 37 | // full sync |
||
| 38 | add_filter( 'jetpack_sync_before_send_jetpack_full_sync_callables', array( $this, 'expand_callables' ) ); |
||
| 39 | } |
||
| 40 | |||
| 41 | public function reset_data() { |
||
| 45 | |||
| 46 | function set_callable_whitelist( $callables ) { |
||
| 49 | |||
| 50 | function get_callable_whitelist() { |
||
| 53 | |||
| 54 | public function get_all_callables() { |
||
| 65 | |||
| 66 | private function get_callable( $callable ) { |
||
| 67 | return call_user_func( $callable ); |
||
| 68 | } |
||
| 69 | |||
| 70 | public function enqueue_full_sync_actions() { |
||
| 71 | /** |
||
| 72 | * Tells the client to sync all callables to the server |
||
| 73 | * |
||
| 74 | * @since 4.2.0 |
||
| 75 | * |
||
| 76 | * @param boolean Whether to expand callables (should always be true) |
||
| 77 | */ |
||
| 78 | do_action( 'jetpack_full_sync_callables', true ); |
||
| 79 | return 1; // The number of actions enqueued |
||
| 80 | } |
||
| 81 | |||
| 82 | public function get_full_sync_actions() { |
||
| 83 | return array( 'jetpack_full_sync_callables' ); |
||
| 84 | } |
||
| 85 | |||
| 86 | public function force_sync_callables() { |
||
| 91 | |||
| 92 | View Code Duplication | public function maybe_sync_callables() { |
|
| 128 | |||
| 129 | public function expand_callables( $args ) { |
||
| 130 | if ( $args[0] ) { |
||
| 131 | return $this->get_all_callables(); |
||
| 132 | } |
||
| 135 | } |
||
| 136 |
This check looks for access to properties that are not accessible from the current context.
If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class.