Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
16 | class Jetpack_EU_Cookie_Law_Widget extends WP_Widget { |
||
17 | /** |
||
18 | * EU Cookie Law cookie name. |
||
19 | * |
||
20 | * @var string |
||
21 | */ |
||
22 | public static $cookie_name = 'eucookielaw'; |
||
23 | |||
24 | /** |
||
25 | * Default hide options. |
||
26 | * |
||
27 | * @var array |
||
28 | */ |
||
29 | private $hide_options = array( |
||
30 | 'button', |
||
31 | 'scroll', |
||
32 | 'time', |
||
33 | ); |
||
34 | |||
35 | /** |
||
36 | * Default text options. |
||
37 | * |
||
38 | * @var array |
||
39 | */ |
||
40 | private $text_options = array( |
||
41 | 'default', |
||
42 | 'custom', |
||
43 | ); |
||
44 | |||
45 | /** |
||
46 | * Default color scheme options. |
||
47 | * |
||
48 | * @var array |
||
49 | */ |
||
50 | private $color_scheme_options = array( |
||
51 | 'default', |
||
52 | 'negative', |
||
53 | ); |
||
54 | |||
55 | /** |
||
56 | * Default policy URL options. |
||
57 | * |
||
58 | * @var array |
||
59 | */ |
||
60 | private $policy_url_options = array( |
||
61 | 'default', |
||
62 | 'custom', |
||
63 | ); |
||
64 | |||
65 | /** |
||
66 | * Constructor. |
||
67 | */ |
||
68 | function __construct() { |
||
84 | |||
85 | /** |
||
86 | * Enqueue scripts and styles. |
||
87 | */ |
||
88 | function enqueue_frontend_scripts() { |
||
101 | |||
102 | /** |
||
103 | * Return an associative array of default values. |
||
104 | * |
||
105 | * These values are used in new widgets. |
||
106 | * |
||
107 | * @return array Default values for the widget options. |
||
108 | */ |
||
109 | public function defaults() { |
||
110 | return array( |
||
111 | 'hide' => $this->hide_options[0], |
||
112 | 'hide-timeout' => 30, |
||
113 | 'consent-expiration' => 180, |
||
114 | 'text' => $this->text_options[0], |
||
115 | 'customtext' => '', |
||
116 | 'color-scheme' => $this->color_scheme_options[0], |
||
117 | 'policy-url' => get_option( 'wp_page_for_privacy_policy' ) ? $this->policy_url_options[1] : $this->policy_url_options[0], |
||
118 | 'default-policy-url' => 'https://automattic.com/cookies/', |
||
119 | 'custom-policy-url' => get_option( 'wp_page_for_privacy_policy' ) ? get_permalink( (int) get_option( 'wp_page_for_privacy_policy' ) ) : '', |
||
120 | 'policy-link-text' => esc_html__( 'Cookie Policy', 'jetpack' ), |
||
121 | 'button' => esc_html__( 'Close and accept', 'jetpack' ), |
||
122 | 'default-text' => esc_html__( "Privacy & Cookies: This site uses cookies. By continuing to use this website, you agree to their use. \r\nTo find out more, including how to control cookies, see here:", 'jetpack' ), |
||
123 | ); |
||
124 | } |
||
125 | |||
126 | /** |
||
127 | * Front-end display of the widget. |
||
128 | * |
||
129 | * @param array $args Widget arguments. |
||
130 | * @param array $instance Saved values from database. |
||
131 | */ |
||
132 | public function widget( $args, $instance ) { |
||
163 | |||
164 | /** |
||
165 | * Back-end widget form. |
||
166 | * |
||
167 | * @param array $instance Previously saved values from database. |
||
168 | */ |
||
169 | public function form( $instance ) { |
||
187 | |||
188 | /** |
||
189 | * Sanitize widget form values as they are saved. |
||
190 | * |
||
191 | * @param array $new_instance Values just sent to be saved. |
||
192 | * @param array $old_instance Previously saved values from database. |
||
193 | * @return array Updated safe values to be saved. |
||
194 | */ |
||
195 | public function update( $new_instance, $old_instance ) { |
||
261 | |||
262 | /** |
||
263 | * Check if the value is allowed and not empty. |
||
264 | * |
||
265 | * @param string $value Value to check. |
||
266 | * @param array $allowed Array of allowed values. |
||
267 | * |
||
268 | * @return string $value if pass the check or first value from allowed values. |
||
269 | */ |
||
270 | function filter_value( $value, $allowed = array() ) { |
||
277 | } |
||
278 | |||
286 |