Issues in class.jetpack-client.php - All Issues - Inspection of "Make sure we're checking the correct state when vp..." - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — fix/vp-request-loop ( ab6ce3...2a194d )

unknown

created 2018-01-12 20:56 UTC

class.jetpack-client.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class Jetpack_Client {
	const WPCOM_JSON_API_VERSION = '1.1';

	/**
	 * Makes an authorized remote request using Jetpack_Signature
	 *
	 * @return array|WP_Error WP HTTP response on success
	 */
	public static function remote_request( $args, $body = null ) {
		$defaults = array(
			'url' => '',
			'user_id' => 0,
			'blog_id' => 0,
			'auth_location' => JETPACK_CLIENT__AUTH_LOCATION,
			'method' => 'POST',
			'timeout' => 10,
			'redirection' => 0,
			'headers' => array(),
			'stream' => false,
			'filename' => null,
			'sslverify' => true,
		);

		$args = wp_parse_args( $args, $defaults );

		$args['blog_id'] = (int) $args['blog_id'];

		if ( 'header' != $args['auth_location'] ) {
			$args['auth_location'] = 'query_string';
		}

		$token = Jetpack_Data::get_access_token( $args['user_id'] );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		if ( !$token ) {
			return new Jetpack_Error( 'missing_token' );
		}

		$method = strtoupper( $args['method'] );

		$timeout = intval( $args['timeout'] );

		$redirection = $args['redirection'];
		$stream = $args['stream'];
		$filename = $args['filename'];
		$sslverify = $args['sslverify'];

		$request = compact( 'method', 'body', 'timeout', 'redirection', 'stream', 'filename', 'sslverify' );

		@list( $token_key, $secret ) = explode( '.', $token->secret );
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		if ( empty( $token ) || empty( $secret ) ) {
			return new Jetpack_Error( 'malformed_token' );
		}

		$token_key = sprintf( '%s:%d:%d', $token_key, JETPACK__API_VERSION, $token->external_user_id );

		require_once JETPACK__PLUGIN_DIR . 'class.jetpack-signature.php';

		$time_diff = (int) Jetpack_Options::get_option( 'time_diff' );
		$jetpack_signature = new Jetpack_Signature( $token->secret, $time_diff );

		$timestamp = time() + $time_diff;

		if( function_exists( 'wp_generate_password' ) ) {
			$nonce = wp_generate_password( 10, false );
		} else {
			$nonce = substr( sha1( rand( 0, 1000000 ) ), 0, 10);
		}

		// Kind of annoying.  Maybe refactor Jetpack_Signature to handle body-hashing
		if ( is_null( $body ) ) {
			$body_hash = '';

		} else {
			// Allow arrays to be used in passing data.
			$body_to_hash = $body;

			if ( is_array( $body ) ) {
				// We cast this to a new variable, because the array form of $body needs to be
				// maintained so it can be passed into the request later on in the code.
				if ( count( $body ) > 0 ) {
					$body_to_hash = json_encode( self::_stringify_data( $body ) );
				} else {
					$body_to_hash = '';
				}
			}

			if ( ! is_string( $body_to_hash ) ) {
				return new Jetpack_Error( 'invalid_body', 'Body is malformed.' );
			}

			$body_hash = jetpack_sha1_base64( $body_to_hash );
		}

		$auth = array(
			'token' => $token_key,
			'timestamp' => $timestamp,
			'nonce' => $nonce,
			'body-hash' => $body_hash,
		);

		if ( false !== strpos( $args['url'], 'xmlrpc.php' ) ) {
			$url_args = array(
				'for'           => 'jetpack',
				'wpcom_blog_id' => Jetpack_Options::get_option( 'id' ),
			);
		} else {
			$url_args = array();
		}

		if ( 'header' != $args['auth_location'] ) {
			$url_args += $auth;
		}

		$url = add_query_arg( urlencode_deep( $url_args ), $args['url'] );
		$url = Jetpack::fix_url_for_bad_hosts( $url );

		$signature = $jetpack_signature->sign_request( $token_key, $timestamp, $nonce, $body_hash, $method, $url, $body, false );

		if ( !$signature || is_wp_error( $signature ) ) {
			return $signature;
		}

		// Send an Authorization header so various caches/proxies do the right thing
		$auth['signature'] = $signature;
		$auth['version'] = JETPACK__VERSION;
		$header_pieces = array();
		foreach ( $auth as $key => $value ) {
			$header_pieces[] = sprintf( '%s="%s"', $key, $value );
		}
		$request['headers'] = array_merge( $args['headers'], array(
			'Authorization' => "X_JETPACK " . join( ' ', $header_pieces ),
		) );

		$host = parse_url( $url, PHP_URL_HOST );

		// If we have a JETPACK__WPCOM_JSON_API_HOST_HEADER set, then let's use
		// that, otherwise, let's fallback to the standard.
		if ( defined( 'JETPACK__WPCOM_JSON_API_HOST_HEADER' ) && JETPACK__WPCOM_JSON_API_HOST_HEADER ) {
			$request['headers']['Host'] = JETPACK__WPCOM_JSON_API_HOST_HEADER;

		} elseif ( $host === JETPACK__WPCOM_JSON_API_HOST ) {
			$request['headers']['Host'] = 'public-api.wordpress.com';
		}

		if ( 'header' != $args['auth_location'] ) {
			$url = add_query_arg( 'signature', urlencode( $signature ), $url );
		}

		return Jetpack_Client::_wp_remote_request( $url, $request );
	}

	/**
	 * Wrapper for wp_remote_request().  Turns off SSL verification for certain SSL errors.
	 * This is lame, but many, many, many hosts have misconfigured SSL.
	 *
	 * When Jetpack is registered, the jetpack_fallback_no_verify_ssl_certs option is set to the current time if:
	 * 1. a certificate error is found AND
	 * 2. not verifying the certificate works around the problem.
	 *
	 * The option is checked on each request.
	 *
	 * @internal
	 * @see Jetpack::fix_url_for_bad_hosts()
	 *
	 * @return array|WP_Error WP HTTP response on success
	 */
	public static function _wp_remote_request( $url, $args, $set_fallback = false ) {
		/**
		 * SSL verification (`sslverify`) for the JetpackClient remote request
		 * defaults to off, use this filter to force it on.
		 *
		 * Return `true` to ENABLE SSL verification, return `false`
		 * to DISABLE SSL verification.
		 *
		 * @since 3.6.0
		 *
		 * @param bool Whether to force `sslverify` or not.
		 */
		if ( apply_filters( 'jetpack_client_verify_ssl_certs', false ) ) {
			return wp_remote_request( $url, $args );
		}

		$fallback = Jetpack_Options::get_option( 'fallback_no_verify_ssl_certs' );
		if ( false === $fallback ) {
			Jetpack_Options::update_option( 'fallback_no_verify_ssl_certs', 0 );
		}

		if ( (int) $fallback ) {
			// We're flagged to fallback
			$args['sslverify'] = false;
		}

		$response = wp_remote_request( $url, $args );

		if (
			!$set_fallback                                     // We're not allowed to set the flag on this request, so whatever happens happens
		||
			isset( $args['sslverify'] ) && !$args['sslverify'] // No verification - no point in doing it again
		||
			!is_wp_error( $response )                          // Let it ride
		) {
			Jetpack_Client::set_time_diff( $response, $set_fallback );
			return $response;
		}

		// At this point, we're not flagged to fallback and we are allowed to set the flag on this request.

		$message = $response->get_error_message();

		// Is it an SSL Certificate verification error?
		if (
			false === strpos( $message, '14090086' ) // OpenSSL SSL3 certificate error
		&&
			false === strpos( $message, '1407E086' ) // OpenSSL SSL2 certificate error
		&&
			false === strpos( $message, 'error setting certificate verify locations' ) // cURL CA bundle not found
		&&
			false === strpos( $message, 'Peer certificate cannot be authenticated with' ) // cURL CURLE_SSL_CACERT: CA bundle found, but not helpful
			                                                                              // different versions of curl have different error messages
			                                                                              // this string should catch them all
		&&
			false === strpos( $message, 'Problem with the SSL CA cert' ) // cURL CURLE_SSL_CACERT_BADFILE: probably access rights
		) {
			// No, it is not.
			return $response;
		}

		// Redo the request without SSL certificate verification.
		$args['sslverify'] = false;
		$response = wp_remote_request( $url, $args );

		if ( !is_wp_error( $response ) ) {
			// The request went through this time, flag for future fallbacks
			Jetpack_Options::update_option( 'fallback_no_verify_ssl_certs', time() );
			Jetpack_Client::set_time_diff( $response, $set_fallback );
		}

		return $response;
	}

	public static function set_time_diff( &$response, $force_set = false ) {
		$code = wp_remote_retrieve_response_code( $response );

		// Only trust the Date header on some responses
		if ( 200 != $code && 304 != $code && 400 != $code && 401 != $code ) {
			return;
		}

		if ( !$date = wp_remote_retrieve_header( $response, 'date' ) ) {
			return;
		}

		if ( 0 >= $time = (int) strtotime( $date ) ) {
			return;
		}

		$time_diff = $time - time();

		if ( $force_set ) { // during register
			Jetpack_Options::update_option( 'time_diff', $time_diff );
		} else { // otherwise
			$old_diff = Jetpack_Options::get_option( 'time_diff' );
			if ( false === $old_diff || abs( $time_diff - (int) $old_diff ) > 10 ) {
				Jetpack_Options::update_option( 'time_diff', $time_diff );
			}
		}
	}

	/**
	 * Query the WordPress.com REST API using the blog token
	 *
	 * @param string  $path
	 * @param string  $version
	 * @param array   $args
	 * @param string  $body

	 * @param string  $base_api_path
	 * @return array|WP_Error $response Data.
	 */
	static function wpcom_json_api_request_as_blog( $path, $version = self::WPCOM_JSON_API_VERSION, $args = array(), $body = null, $base_api_path = 'rest' ) {
		$filtered_args = array_intersect_key( $args, array(
			'headers'     => 'array',
			'method'      => 'string',
			'timeout'     => 'int',
			'redirection' => 'int',
			'stream'      => 'boolean',
			'filename'    => 'string',
			'sslverify'   => 'boolean',
		) );

		/**
		 * Determines whether Jetpack can send outbound https requests to the WPCOM api.
		 *
		 * @since 3.6.0
		 *
		 * @param bool $proto Defaults to true.
		 */
		$proto = apply_filters( 'jetpack_can_make_outbound_https', true ) ? 'https' : 'http';

		// unprecedingslashit
		$_path = preg_replace( '/^\//', '', $path );

		// Use GET by default whereas `remote_request` uses POST
		$request_method = ( isset( $filtered_args['method'] ) ) ? $filtered_args['method'] : 'GET';

		$url = sprintf( '%s://%s/%s/v%s/%s', $proto, JETPACK__WPCOM_JSON_API_HOST, $base_api_path, $version, $_path );

		$validated_args = array_merge( $filtered_args, array(
			'url'     => $url,
			'blog_id' => (int) Jetpack_Options::get_option( 'id' ),
			'method'  => $request_method,
		) );

		return Jetpack_Client::remote_request( $validated_args, $body );
	}

	/**
	 * Takes an array or similar structure and recursively turns all values into strings. This is used to
	 * make sure that body hashes are made ith the string version, which is what will be seen after a
	 * server pulls up the data in the $_POST array.
	 *
	 * @param array|mixed $data
	 *
	 * @return array|string
	 */
	public static function _stringify_data( $data ) {

		// Booleans are special, lets just makes them and explicit 1/0 instead of the 0 being an empty string.
		if ( is_bool( $data ) ) {
			return $data ? "1" : "0";
		}

		// Cast objects into arrays.
		if ( is_object( $data ) ) {
			$data = (array) $data;
		}

		// Non arrays at this point should be just converted to strings.
		if ( ! is_array( $data ) ) {
			return (string)$data;
		}

		foreach ( $data as $key => &$value ) {
			$value = self::_stringify_data( $value );
		}

		return $data;
	}
}


1			<?php
2
3			class Jetpack_Client {
4			const WPCOM_JSON_API_VERSION = '1.1';
5
6			/**
7			* Makes an authorized remote request using Jetpack_Signature
8			*
9			* @return array\|WP_Error WP HTTP response on success
10			*/
11			public static function remote_request( $args, $body = null ) {
12			$defaults = array(
13			'url' => '',
14			'user_id' => 0,
15			'blog_id' => 0,
16			'auth_location' => JETPACK_CLIENT__AUTH_LOCATION,
17			'method' => 'POST',
18			'timeout' => 10,
19			'redirection' => 0,
20			'headers' => array(),
21			'stream' => false,
22			'filename' => null,
23			'sslverify' => true,
24			);
25
26			$args = wp_parse_args( $args, $defaults );
27
28			$args['blog_id'] = (int) $args['blog_id'];
29
30			if ( 'header' != $args['auth_location'] ) {
31			$args['auth_location'] = 'query_string';
32			}
33
34			$token = Jetpack_Data::get_access_token( $args['user_id'] );
			0 ignored issues – show Documentation introduced 2015-11-20 23:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$args['user_id']` is of type `integer\|string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
35			if ( !$token ) {
36			return new Jetpack_Error( 'missing_token' );
37			}
38
39			$method = strtoupper( $args['method'] );
40
41			$timeout = intval( $args['timeout'] );
42
43			$redirection = $args['redirection'];
44			$stream = $args['stream'];
45			$filename = $args['filename'];
46			$sslverify = $args['sslverify'];
47
48			$request = compact( 'method', 'body', 'timeout', 'redirection', 'stream', 'filename', 'sslverify' );
49
50			@list( $token_key, $secret ) = explode( '.', $token->secret );
			0 ignored issues – show Security Best Practice introduced 2017-04-18 21:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
51			if ( empty( $token ) \|\| empty( $secret ) ) {
52			return new Jetpack_Error( 'malformed_token' );
53			}
54
55			$token_key = sprintf( '%s:%d:%d', $token_key, JETPACK__API_VERSION, $token->external_user_id );
56
57			require_once JETPACK__PLUGIN_DIR . 'class.jetpack-signature.php';
58
59			$time_diff = (int) Jetpack_Options::get_option( 'time_diff' );
60			$jetpack_signature = new Jetpack_Signature( $token->secret, $time_diff );
61
62			$timestamp = time() + $time_diff;
63
64			if( function_exists( 'wp_generate_password' ) ) {
65			$nonce = wp_generate_password( 10, false );
66			} else {
67			$nonce = substr( sha1( rand( 0, 1000000 ) ), 0, 10);
68			}
69
70			// Kind of annoying. Maybe refactor Jetpack_Signature to handle body-hashing
71			if ( is_null( $body ) ) {
72			$body_hash = '';
73
74			} else {
75			// Allow arrays to be used in passing data.
76			$body_to_hash = $body;
77
78			if ( is_array( $body ) ) {
79			// We cast this to a new variable, because the array form of $body needs to be
80			// maintained so it can be passed into the request later on in the code.
81			if ( count( $body ) > 0 ) {
82			$body_to_hash = json_encode( self::_stringify_data( $body ) );
83			} else {
84			$body_to_hash = '';
85			}
86			}
87
88			if ( ! is_string( $body_to_hash ) ) {
89			return new Jetpack_Error( 'invalid_body', 'Body is malformed.' );
90			}
91
92			$body_hash = jetpack_sha1_base64( $body_to_hash );
93			}
94
95			$auth = array(
96			'token' => $token_key,
97			'timestamp' => $timestamp,
98			'nonce' => $nonce,
99			'body-hash' => $body_hash,
100			);
101
102			if ( false !== strpos( $args['url'], 'xmlrpc.php' ) ) {
103			$url_args = array(
104			'for' => 'jetpack',
105			'wpcom_blog_id' => Jetpack_Options::get_option( 'id' ),
106			);
107			} else {
108			$url_args = array();
109			}
110
111			if ( 'header' != $args['auth_location'] ) {
112			$url_args += $auth;
113			}
114
115			$url = add_query_arg( urlencode_deep( $url_args ), $args['url'] );
116			$url = Jetpack::fix_url_for_bad_hosts( $url );
117
118			$signature = $jetpack_signature->sign_request( $token_key, $timestamp, $nonce, $body_hash, $method, $url, $body, false );
119
120			if ( !$signature \|\| is_wp_error( $signature ) ) {
121			return $signature;
122			}
123
124			// Send an Authorization header so various caches/proxies do the right thing
125			$auth['signature'] = $signature;
126			$auth['version'] = JETPACK__VERSION;
127			$header_pieces = array();
128			foreach ( $auth as $key => $value ) {
129			$header_pieces[] = sprintf( '%s="%s"', $key, $value );
130			}
131			$request['headers'] = array_merge( $args['headers'], array(
132			'Authorization' => "X_JETPACK " . join( ' ', $header_pieces ),
133			) );
134
135			$host = parse_url( $url, PHP_URL_HOST );
136
137			// If we have a JETPACK__WPCOM_JSON_API_HOST_HEADER set, then let's use
138			// that, otherwise, let's fallback to the standard.
139			if ( defined( 'JETPACK__WPCOM_JSON_API_HOST_HEADER' ) && JETPACK__WPCOM_JSON_API_HOST_HEADER ) {
140			$request['headers']['Host'] = JETPACK__WPCOM_JSON_API_HOST_HEADER;
141
142			} elseif ( $host === JETPACK__WPCOM_JSON_API_HOST ) {
143			$request['headers']['Host'] = 'public-api.wordpress.com';
144			}
145
146			if ( 'header' != $args['auth_location'] ) {
147			$url = add_query_arg( 'signature', urlencode( $signature ), $url );
148			}
149
150			return Jetpack_Client::_wp_remote_request( $url, $request );
151			}
152
153			/**
154			* Wrapper for wp_remote_request(). Turns off SSL verification for certain SSL errors.
155			* This is lame, but many, many, many hosts have misconfigured SSL.
156			*
157			* When Jetpack is registered, the jetpack_fallback_no_verify_ssl_certs option is set to the current time if:
158			* 1. a certificate error is found AND
159			* 2. not verifying the certificate works around the problem.
160			*
161			* The option is checked on each request.
162			*
163			* @internal
164			* @see Jetpack::fix_url_for_bad_hosts()
165			*
166			* @return array\|WP_Error WP HTTP response on success
167			*/
168			public static function _wp_remote_request( $url, $args, $set_fallback = false ) {
169			/**
170			* SSL verification (`sslverify`) for the JetpackClient remote request
171			* defaults to off, use this filter to force it on.
172			*
173			* Return `true` to ENABLE SSL verification, return `false`
174			* to DISABLE SSL verification.
175			*
176			* @since 3.6.0
177			*
178			* @param bool Whether to force `sslverify` or not.
179			*/
180			if ( apply_filters( 'jetpack_client_verify_ssl_certs', false ) ) {
181			return wp_remote_request( $url, $args );
182			}
183
184			$fallback = Jetpack_Options::get_option( 'fallback_no_verify_ssl_certs' );
185			if ( false === $fallback ) {
186			Jetpack_Options::update_option( 'fallback_no_verify_ssl_certs', 0 );
187			}
188
189			if ( (int) $fallback ) {
190			// We're flagged to fallback
191			$args['sslverify'] = false;
192			}
193
194			$response = wp_remote_request( $url, $args );
195
196			if (
197			!$set_fallback // We're not allowed to set the flag on this request, so whatever happens happens
198			\|\|
199			isset( $args['sslverify'] ) && !$args['sslverify'] // No verification - no point in doing it again
200			\|\|
201			!is_wp_error( $response ) // Let it ride
202			) {
203			Jetpack_Client::set_time_diff( $response, $set_fallback );
204			return $response;
205			}
206
207			// At this point, we're not flagged to fallback and we are allowed to set the flag on this request.
208
209			$message = $response->get_error_message();
210
211			// Is it an SSL Certificate verification error?
212			if (
213			false === strpos( $message, '14090086' ) // OpenSSL SSL3 certificate error
214			&&
215			false === strpos( $message, '1407E086' ) // OpenSSL SSL2 certificate error
216			&&
217			false === strpos( $message, 'error setting certificate verify locations' ) // cURL CA bundle not found
218			&&
219			false === strpos( $message, 'Peer certificate cannot be authenticated with' ) // cURL CURLE_SSL_CACERT: CA bundle found, but not helpful
220			// different versions of curl have different error messages
221			// this string should catch them all
222			&&
223			false === strpos( $message, 'Problem with the SSL CA cert' ) // cURL CURLE_SSL_CACERT_BADFILE: probably access rights
224			) {
225			// No, it is not.
226			return $response;
227			}
228
229			// Redo the request without SSL certificate verification.
230			$args['sslverify'] = false;
231			$response = wp_remote_request( $url, $args );
232
233			if ( !is_wp_error( $response ) ) {
234			// The request went through this time, flag for future fallbacks
235			Jetpack_Options::update_option( 'fallback_no_verify_ssl_certs', time() );
236			Jetpack_Client::set_time_diff( $response, $set_fallback );
237			}
238
239			return $response;
240			}
241
242			public static function set_time_diff( &$response, $force_set = false ) {
243			$code = wp_remote_retrieve_response_code( $response );
244
245			// Only trust the Date header on some responses
246			if ( 200 != $code && 304 != $code && 400 != $code && 401 != $code ) {
247			return;
248			}
249
250			if ( !$date = wp_remote_retrieve_header( $response, 'date' ) ) {
251			return;
252			}
253
254			if ( 0 >= $time = (int) strtotime( $date ) ) {
255			return;
256			}
257
258			$time_diff = $time - time();
259
260			if ( $force_set ) { // during register
261			Jetpack_Options::update_option( 'time_diff', $time_diff );
262			} else { // otherwise
263			$old_diff = Jetpack_Options::get_option( 'time_diff' );
264			if ( false === $old_diff \|\| abs( $time_diff - (int) $old_diff ) > 10 ) {
265			Jetpack_Options::update_option( 'time_diff', $time_diff );
266			}
267			}
268			}
269
270			/**
271			* Query the WordPress.com REST API using the blog token
272			*
273			* @param string $path
274			* @param string $version
275			* @param array $args
276			* @param string $body
			0 ignored issues – show Documentation introduced 2017-06-26 18:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$body` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
277			* @param string $base_api_path
278			* @return array\|WP_Error $response Data.
279			*/
280			static function wpcom_json_api_request_as_blog( $path, $version = self::WPCOM_JSON_API_VERSION, $args = array(), $body = null, $base_api_path = 'rest' ) {
281			$filtered_args = array_intersect_key( $args, array(
282			'headers' => 'array',
283			'method' => 'string',
284			'timeout' => 'int',
285			'redirection' => 'int',
286			'stream' => 'boolean',
287			'filename' => 'string',
288			'sslverify' => 'boolean',
289			) );
290
291			/**
292			* Determines whether Jetpack can send outbound https requests to the WPCOM api.
293			*
294			* @since 3.6.0
295			*
296			* @param bool $proto Defaults to true.
297			*/
298			$proto = apply_filters( 'jetpack_can_make_outbound_https', true ) ? 'https' : 'http';
299
300			// unprecedingslashit
301			$_path = preg_replace( '/^\//', '', $path );
302
303			// Use GET by default whereas `remote_request` uses POST
304			$request_method = ( isset( $filtered_args['method'] ) ) ? $filtered_args['method'] : 'GET';
305
306			$url = sprintf( '%s://%s/%s/v%s/%s', $proto, JETPACK__WPCOM_JSON_API_HOST, $base_api_path, $version, $_path );
307
308			$validated_args = array_merge( $filtered_args, array(
309			'url' => $url,
310			'blog_id' => (int) Jetpack_Options::get_option( 'id' ),
311			'method' => $request_method,
312			) );
313
314			return Jetpack_Client::remote_request( $validated_args, $body );
315			}
316
317			/**
318			* Takes an array or similar structure and recursively turns all values into strings. This is used to
319			* make sure that body hashes are made ith the string version, which is what will be seen after a
320			* server pulls up the data in the $_POST array.
321			*
322			* @param array\|mixed $data
323			*
324			* @return array\|string
325			*/
326			public static function _stringify_data( $data ) {
327
328			// Booleans are special, lets just makes them and explicit 1/0 instead of the 0 being an empty string.
329			if ( is_bool( $data ) ) {
330			return $data ? "1" : "0";
331			}
332
333			// Cast objects into arrays.
334			if ( is_object( $data ) ) {
335			$data = (array) $data;
336			}
337
338			// Non arrays at this point should be just converted to strings.
339			if ( ! is_array( $data ) ) {
340			return (string)$data;
341			}
342
343			foreach ( $data as $key => &$value ) {
344			$value = self::_stringify_data( $value );
345			}
346
347			return $data;
348			}
349			}
350

Automattic / jetpack

Push — fix/vp-request-loop ( ab6ce3...2a194d )

class.jetpack-client.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like