Class_Method_Missing::find_invocation_warnings() - Code Metrics - Inspection of "Finding missing static calls" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — try/code-signature-diff ( 9050e5...a2c3d7 )

unknown

created 2019-06-24 21:49 UTC

Class_Method_Missing::find_invocation_warnings() A

↳ Parent: Class_Method_Missing

Complexity

Conditions	5
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
nc	3
nop	2
dl	0
loc	12
rs	9.5555
c	0
b	0
f	0

<?php

namespace Automattic\Jetpack\Analyzer\Differences;

use Automattic\Jetpack\Analyzer\PersistentList\Item as PersistentListItem;
use Automattic\Jetpack\Analyzer\Invocations\Static_Call;
use Automattic\Jetpack\Analyzer\Warnings\Warning; // TODO - subclasses?

class Class_Method_Missing extends PersistentListItem implements Invocation_Warner {
	public $declaration;

	function __construct( $declaration ) {
		$this->declaration = $declaration;
	}

	function to_csv_array() {
		return array(
			$this->type(),
			$this->declaration->path,
			$this->declaration->line,
			$this->declaration->display_name()
		);
	}

	public function type() {
		return 'method_missing';
	}

	public function display_name() {
		return $this->declaration->display_name();
	}

	public function find_invocation_warnings( $invocation, $warnings ) {
		if ( $invocation instanceof Static_Call ) {
			// check if it's instantiating this missing class
			// echo "Checking " . $invocation->class_name . " matches " . $this->declaration->class_name . "\n";
			// echo "... and " . $invocation->method_name . " matches " . $this->declaration->name . ", and invocation is static\n";
			if ( $invocation->class_name === $this->declaration->class_name
				&& $invocation->method_name === $this->declaration->name
				&& $this->declaration->static ) {
				$warnings->add( new Warning( $invocation->path, $invocation->line, "Class static method" . $this->declaration->display_name() . " is missing") );
			}
		}
	}
}

1			<?php
2
3			namespace Automattic\Jetpack\Analyzer\Differences;
4
5			use Automattic\Jetpack\Analyzer\PersistentList\Item as PersistentListItem;
6			use Automattic\Jetpack\Analyzer\Invocations\Static_Call;
7			use Automattic\Jetpack\Analyzer\Warnings\Warning; // TODO - subclasses?
8
9			class Class_Method_Missing extends PersistentListItem implements Invocation_Warner {
10			public $declaration;
11
12			function __construct( $declaration ) {
13			$this->declaration = $declaration;
14			}
15
16			function to_csv_array() {
17			return array(
18			$this->type(),
19			$this->declaration->path,
20			$this->declaration->line,
21			$this->declaration->display_name()
22			);
23			}
24
25			public function type() {
26			return 'method_missing';
27			}
28
29			public function display_name() {
30			return $this->declaration->display_name();
31			}
32
33			public function find_invocation_warnings( $invocation, $warnings ) {
34			if ( $invocation instanceof Static_Call ) {
35			// check if it's instantiating this missing class
36			// echo "Checking " . $invocation->class_name . " matches " . $this->declaration->class_name . "\n";
37			// echo "... and " . $invocation->method_name . " matches " . $this->declaration->name . ", and invocation is static\n";
38			if ( $invocation->class_name === $this->declaration->class_name
39			&& $invocation->method_name === $this->declaration->name
40			&& $this->declaration->static ) {
41			$warnings->add( new Warning( $invocation->path, $invocation->line, "Class static method" . $this->declaration->display_name() . " is missing") );
42			}
43			}
44			}
45			}

Automattic / jetpack

Push — try/code-signature-diff ( 9050e5...a2c3d7 )

Class_Method_Missing::find_invocation_warnings() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like