shortcodes.php ➔ jetpack_shortcode_get_videopress_id() - Code Metrics - Inspection of "SEO Tools: Fix empty configure URL when Business p..." - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — fix/seo-tools-configure-url ( 9bbb48...1b9e3f )

unknown

created 2016-11-09 20:54 UTC

shortcodes.php ➔ jetpack_shortcode_get_videopress_id() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0

<?php

/**
 * Module Name: Shortcode Embeds
 * Module Description: Embed media from popular sites without any coding.
 * Sort Order: 3
 * First Introduced: 1.1
 * Major Changes In: 1.2
 * Requires Connection: No
 * Auto Activate: Yes
 * Module Tags: Photos and Videos, Social, Writing, Appearance
 * Feature: Writing
 * Additional Search Queries: shortcodes, shortcode, embeds, media, bandcamp, blip.tv, dailymotion, facebook, flickr, google calendars, google maps, google+, polldaddy, recipe, recipes, scribd, slideshare, slideshow, slideshows, soundcloud, ted, twitter, vimeo, vine, youtube
 */

/**
 * Transforms the $atts array into a string that the old functions expected
 *
 * The old way was:
 * [shortcode a=1&b=2&c=3] or [shortcode=1]
 * This is parsed as array( a => '1&b=2&c=3' ) and array( 0 => '=1' ), which is useless
 *
 * @param array $params             Array of old shortcode parameters.
 * @param bool  $old_format_support true if [shortcode=foo] format is possible.
 *
 * @return string $params
 */
function shortcode_new_to_old_params( $params, $old_format_support = false ) {
	$str = '';

	if ( $old_format_support && isset( $params[0] ) ) {
		$str = ltrim( $params[0], '=' );
	} elseif ( is_array( $params ) ) {
		foreach ( array_keys( $params ) as $key ) {
			if ( ! is_numeric( $key ) ) {
				$str = $key . '=' . $params[ $key ];
			}
		}
	}

	return str_replace( array( '&amp;', '&#038;' ), '&', $str );
}

/**
 * Load all available Jetpack shortcode files.
 */
function jetpack_load_shortcodes() {
	$shortcode_includes = array();

	foreach ( Jetpack::glob_php( dirname( __FILE__ ) . '/shortcodes' ) as $file ) {
		$filename = substr( basename( $file ), 0, -4 );

		$shortcode_includes[ $filename ] = $file;
	}

	/**
	 * This filter allows other plugins to override which shortcodes Jetpack loads.
	 *
	 * @module shortcodes
	 *
	 * @since 2.2.1
	 * @since 4.2.0 Added filename without extension as array key.
	 *
	 * @param array $shortcode_includes An array of which shortcodes to include.
	 */
	$shortcode_includes = apply_filters( 'jetpack_shortcodes_to_include', $shortcode_includes );

	foreach ( $shortcode_includes as $include ) {
		include $include;
	}
}

/**
 * Runs preg_replace so that replacements don't happen within open tags.
 * Parameters are the same as preg_replace, with an added optional search param for improved performance
 *
 * @param string $pattern     Pattern to search for.
 * @param string $replacement String to replace.
 * @param string $content     Post content.
 * @param string $search      String to search for.

 *
 * @return string $content    Replaced post content.
 */
function jetpack_preg_replace_outside_tags( $pattern, $replacement, $content, $search = null ) {

	if ( ! function_exists( 'wp_html_split' ) ) {
		return $content;
	}

	if ( $search && false === strpos( $content, $search ) ) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
		return $content;
	}

	$textarr = wp_html_split( $content );
	unset( $content );
	foreach ( $textarr as &$element ) {
		if ( '' === $element || '<' === $element{0} ) {
			continue;
		}
		$element = preg_replace( $pattern, $replacement, $element );
	}

	return join( $textarr );
}

/**
 * Runs preg_replace_callback so that replacements don't happen within open tags.
 * Parameters are the same as preg_replace, with an added optional search param for improved performance.
 *
 * @param string $pattern  Pattern to search for.
 * @param string $callback Callback returning the replacement string.
 * @param string $content  Post content.
 * @param string $search   String to search for.

 *
 * @return string $content Replaced post content.
 */
function jetpack_preg_replace_callback_outside_tags( $pattern, $callback, $content, $search = null ) {

	if ( ! function_exists( 'wp_html_split' ) ) {
		return $content;
	}

	if ( $search && false === strpos( $content, $search ) ) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
		return $content;
	}

	$textarr = wp_html_split( $content );
	unset( $content );
	foreach ( $textarr as &$element ) {
		if ( '' === $element || '<' === $element{0} ) {
			continue;
		}
		$element = preg_replace_callback( $pattern, $callback, $element );
	}

	return join( $textarr );
}

if ( ! function_exists( 'jetpack_shortcode_get_wpvideo_id' ) ) {
	/**
	 * Get VideoPress ID from wpvideo shortcode attributes.
	 *
	 * @param array $atts Shortcode attributes.
	 * @return int  $id   VideoPress ID.
	 */
	function jetpack_shortcode_get_wpvideo_id( $atts ) {
		if ( isset( $atts[0] ) ) {
			return $atts[0];
		} else {
			return 0;
		}
	}
}

if ( ! function_exists( 'jetpack_shortcode_get_videopress_id' ) ) {
	/**
	 * Get VideoPress ID from videopress shortcode attributes.
	 *
	 * @param array $atts Shortcode attributes.
	 * @return int  $id   VideoPress ID.
	 */
	function jetpack_shortcode_get_videopress_id( $atts ) {
		if ( isset( $atts[0] ) ) {
			return $atts[0];
		} else {
			return 0;
		}
	}
}

jetpack_load_shortcodes();


1		<?php
2
3		/**
4		* Module Name: Shortcode Embeds
5		* Module Description: Embed media from popular sites without any coding.
6		* Sort Order: 3
7		* First Introduced: 1.1
8		* Major Changes In: 1.2
9		* Requires Connection: No
10		* Auto Activate: Yes
11		* Module Tags: Photos and Videos, Social, Writing, Appearance
12		* Feature: Writing
13		* Additional Search Queries: shortcodes, shortcode, embeds, media, bandcamp, blip.tv, dailymotion, facebook, flickr, google calendars, google maps, google+, polldaddy, recipe, recipes, scribd, slideshare, slideshow, slideshows, soundcloud, ted, twitter, vimeo, vine, youtube
14		*/
15
16		/**
17		* Transforms the $atts array into a string that the old functions expected
18		*
19		* The old way was:
20		* [shortcode a=1&b=2&c=3] or [shortcode=1]
21		* This is parsed as array( a => '1&b=2&c=3' ) and array( 0 => '=1' ), which is useless
22		*
23		* @param array $params Array of old shortcode parameters.
24		* @param bool $old_format_support true if [shortcode=foo] format is possible.
25		*
26		* @return string $params
27		*/
28		function shortcode_new_to_old_params( $params, $old_format_support = false ) {
29		$str = '';
30
31		if ( $old_format_support && isset( $params[0] ) ) {
32		$str = ltrim( $params[0], '=' );
33		} elseif ( is_array( $params ) ) {
34		foreach ( array_keys( $params ) as $key ) {
35		if ( ! is_numeric( $key ) ) {
36		$str = $key . '=' . $params[ $key ];
37		}
38		}
39		}
40
41		return str_replace( array( '&', '&' ), '&', $str );
42		}
43
44		/**
45		* Load all available Jetpack shortcode files.
46		*/
47		function jetpack_load_shortcodes() {
48		$shortcode_includes = array();
49
50		foreach ( Jetpack::glob_php( dirname( __FILE__ ) . '/shortcodes' ) as $file ) {
51		$filename = substr( basename( $file ), 0, -4 );
52
53		$shortcode_includes[ $filename ] = $file;
54		}
55
56		/**
57		* This filter allows other plugins to override which shortcodes Jetpack loads.
58		*
59		* @module shortcodes
60		*
61		* @since 2.2.1
62		* @since 4.2.0 Added filename without extension as array key.
63		*
64		* @param array $shortcode_includes An array of which shortcodes to include.
65		*/
66		$shortcode_includes = apply_filters( 'jetpack_shortcodes_to_include', $shortcode_includes );
67
68		foreach ( $shortcode_includes as $include ) {
69		include $include;
70		}
71		}
72
73		/**
74		* Runs preg_replace so that replacements don't happen within open tags.
75		* Parameters are the same as preg_replace, with an added optional search param for improved performance
76		*
77		* @param string $pattern Pattern to search for.
78		* @param string $replacement String to replace.
79		* @param string $content Post content.
80		* @param string $search String to search for.
		0 ignored issues – show Documentation introduced 2016-11-09 04:59 UTC by Report Bug Copy Issue Report Should the type for parameter `$search` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
81		*
82		* @return string $content Replaced post content.
83		*/
84	View Code Duplication	function jetpack_preg_replace_outside_tags( $pattern, $replacement, $content, $search = null ) {
		0 ignored issues – show Duplication introduced 2016-05-27 01:47 UTC by Report Bug Copy Issue Report This function seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
85		if ( ! function_exists( 'wp_html_split' ) ) {
86		return $content;
87		}
88
89		if ( $search && false === strpos( $content, $search ) ) {
		0 ignored issues – show Bug Best Practice introduced 2016-06-17 16:21 UTC by Report Bug Copy Issue Report The expression `$search` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
90		return $content;
91		}
92
93		$textarr = wp_html_split( $content );
94		unset( $content );
95		foreach ( $textarr as &$element ) {
96		if ( '' === $element \|\| '<' === $element{0} ) {
97		continue;
98		}
99		$element = preg_replace( $pattern, $replacement, $element );
100		}
101
102		return join( $textarr );
103		}
104
105		/**
106		* Runs preg_replace_callback so that replacements don't happen within open tags.
107		* Parameters are the same as preg_replace, with an added optional search param for improved performance.
108		*
109		* @param string $pattern Pattern to search for.
110		* @param string $callback Callback returning the replacement string.
111		* @param string $content Post content.
112		* @param string $search String to search for.
		0 ignored issues – show Documentation introduced 2016-11-09 04:59 UTC by Report Bug Copy Issue Report Should the type for parameter `$search` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
113		*
114		* @return string $content Replaced post content.
115		*/
116	View Code Duplication	function jetpack_preg_replace_callback_outside_tags( $pattern, $callback, $content, $search = null ) {
		0 ignored issues – show Duplication introduced 2016-05-27 01:47 UTC by Report Bug Copy Issue Report This function seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
117		if ( ! function_exists( 'wp_html_split' ) ) {
118		return $content;
119		}
120
121		if ( $search && false === strpos( $content, $search ) ) {
		0 ignored issues – show Bug Best Practice introduced 2016-06-17 16:21 UTC by Report Bug Copy Issue Report The expression `$search` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
122		return $content;
123		}
124
125		$textarr = wp_html_split( $content );
126		unset( $content );
127		foreach ( $textarr as &$element ) {
128		if ( '' === $element \|\| '<' === $element{0} ) {
129		continue;
130		}
131		$element = preg_replace_callback( $pattern, $callback, $element );
132		}
133
134		return join( $textarr );
135		}
136
137		if ( ! function_exists( 'jetpack_shortcode_get_wpvideo_id' ) ) {
138		/**
139		* Get VideoPress ID from wpvideo shortcode attributes.
140		*
141		* @param array $atts Shortcode attributes.
142		* @return int $id VideoPress ID.
143		*/
144		function jetpack_shortcode_get_wpvideo_id( $atts ) {
145		if ( isset( $atts[0] ) ) {
146		return $atts[0];
147		} else {
148		return 0;
149		}
150		}
151		}
152
153		if ( ! function_exists( 'jetpack_shortcode_get_videopress_id' ) ) {
154		/**
155		* Get VideoPress ID from videopress shortcode attributes.
156		*
157		* @param array $atts Shortcode attributes.
158		* @return int $id VideoPress ID.
159		*/
160		function jetpack_shortcode_get_videopress_id( $atts ) {
161		if ( isset( $atts[0] ) ) {
162		return $atts[0];
163		} else {
164		return 0;
165		}
166		}
167		}
168
169		jetpack_load_shortcodes();
170

Automattic / jetpack

Push — fix/seo-tools-configure-url ( 9bbb48...1b9e3f )

shortcodes.php ➔ jetpack_shortcode_get_videopress_id() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like