Jetpack_Sync_Options::read_option() - Code Metrics - Inspection of "Move options read/write into separate file" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — fix/bypass-option-caching-full... ( 643d8f )

unknown

created 2016-11-23 01:09 UTC

Jetpack_Sync_Options::read_option() A

↳ Parent: Jetpack_Sync_Options

Complexity

Conditions	3
Paths	2

Size

Total Lines	16
Code Lines	10

Duplication

Lines	16
Ratio	100 %

Importance

Changes

Metric	Value
cc	3
eloc	10
nc	2
nop	2
dl	16
loc	16
rs	9.4285
c	0
b	0
f	0

<?php

/**
 * Simple class to read/write to the options table, bypassing 
 * problematic caching with get_option/set_option
 **/

class Jetpack_Sync_Options {

	static function write_option( $name, $value, $autoload = false ) {

		$autoload_value = $autoload ? 'yes' : 'no';

		// we write our own option updating code to bypass filters/caching/etc on set_option/get_option
		global $wpdb;
		$serialized_value = maybe_serialize( $value );
		// try updating, if no update then insert
		// TODO: try to deal with the fact that unchanged values can return updated_num = 0

		// below we used "insert ignore" to at least suppress the resulting error
		$updated_num = $wpdb->query(
			$wpdb->prepare(
				"UPDATE $wpdb->options SET option_value = %s WHERE option_name = %s", 
				$serialized_value,
				$name
			)
		);

		if ( ! $updated_num ) {
			$updated_num = $wpdb->query(
				$wpdb->prepare(
					"INSERT IGNORE INTO $wpdb->options ( option_name, option_value, autoload ) VALUES ( %s, %s, '$autoload_value' )", 
					$name,
					$serialized_value
				)
			);
		}
		return $updated_num;
	}

	static function read_option( $name, $default = null ) {
		global $wpdb;
		$value = $wpdb->get_var( 
			$wpdb->prepare(
				"SELECT option_value FROM $wpdb->options WHERE option_name = %s LIMIT 1", 
				$name
			)
		);
		$value = maybe_unserialize( $value );

		if ( $value === null && $default !== null ) {
			return $default;
		}

		return $value;
	}
	
}

1		<?php
2
3		/**
4		* Simple class to read/write to the options table, bypassing
5		* problematic caching with get_option/set_option
6		**/
7
8		class Jetpack_Sync_Options {
9
10		static function write_option( $name, $value, $autoload = false ) {
11
12		$autoload_value = $autoload ? 'yes' : 'no';
13
14		// we write our own option updating code to bypass filters/caching/etc on set_option/get_option
15		global $wpdb;
16		$serialized_value = maybe_serialize( $value );
17		// try updating, if no update then insert
18		// TODO: try to deal with the fact that unchanged values can return updated_num = 0
		0 ignored issues – show Coding Style Best Practice introduced 2016-11-23 01:16 UTC by Report Bug Copy Issue Report Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker. Loading history...
19		// below we used "insert ignore" to at least suppress the resulting error
20		$updated_num = $wpdb->query(
21		$wpdb->prepare(
22		"UPDATE $wpdb->options SET option_value = %s WHERE option_name = %s",
23		$serialized_value,
24		$name
25		)
26		);
27
28		if ( ! $updated_num ) {
29		$updated_num = $wpdb->query(
30		$wpdb->prepare(
31		"INSERT IGNORE INTO $wpdb->options ( option_name, option_value, autoload ) VALUES ( %s, %s, '$autoload_value' )",
32		$name,
33		$serialized_value
34		)
35		);
36		}
37		return $updated_num;
38		}
39
40	View Code Duplication	static function read_option( $name, $default = null ) {
41		global $wpdb;
42		$value = $wpdb->get_var(
43		$wpdb->prepare(
44		"SELECT option_value FROM $wpdb->options WHERE option_name = %s LIMIT 1",
45		$name
46		)
47		);
48		$value = maybe_unserialize( $value );
49
50		if ( $value === null && $default !== null ) {
51		return $default;
52		}
53
54		return $value;
55		}
56
57		}

Automattic / jetpack

Push — fix/bypass-option-caching-full... ( 643d8f )

Jetpack_Sync_Options::read_option() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like