Automattic /
jetpack
These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
| 1 | <?php |
||
| 2 | |||
| 3 | namespace Automattic\Jetpack\Analyzer\Differences; |
||
| 4 | |||
| 5 | use Automattic\Jetpack\Analyzer\PersistentList\Item as PersistentListItem; |
||
| 6 | use Automattic\Jetpack\Analyzer\Invocations\New_; |
||
| 7 | use Automattic\Jetpack\Analyzer\Warnings\Warning; // TODO - subclasses? |
||
| 8 | |||
| 9 | View Code Duplication | class Class_Moved extends PersistentListItem implements Invocation_Warner { |
|
|
0 ignored issues
–
show
|
|||
| 10 | public $old_declaration; |
||
| 11 | public $new_declaration; |
||
| 12 | |||
| 13 | function __construct( $old_declaration, $new_declaration ) { |
||
| 14 | $this->old_declaration = $old_declaration; |
||
| 15 | $this->new_declaration = $new_declaration; |
||
| 16 | } |
||
| 17 | |||
| 18 | function to_csv_array() { |
||
| 19 | return array( |
||
| 20 | $this->type(), |
||
| 21 | $this->old_declaration->path, |
||
| 22 | $this->old_declaration->line, |
||
| 23 | $this->old_declaration->display_name(), |
||
| 24 | ); |
||
| 25 | } |
||
| 26 | |||
| 27 | public function type() { |
||
| 28 | return 'class_moved'; |
||
| 29 | } |
||
| 30 | |||
| 31 | public function find_invocation_warnings( $invocation, $warnings ) { |
||
| 32 | if ( $invocation->depends_on( $this->old_declaration ) ) { |
||
| 33 | $warnings->add( |
||
| 34 | new Warning( $this->type(), $invocation->path, $invocation->line, 'Class ' . $this->old_declaration->display_name() . ' was moved from ' . $this->old_declaration->path . ' to ' . $this->new_declaration->path, $this->old_declaration ) |
||
| 35 | ); |
||
| 36 | } |
||
| 37 | } |
||
| 38 | } |
||
| 39 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.