Issues in functions.gallery.php - All Issues - Inspection of "New build" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — branch-4.4-built ( 3fd0f8...ac6bb8 )

unknown

created 2016-12-06 16:52 UTC

functions.gallery.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Renders extra controls in the Gallery Settings section of the new media UI.
 */
class Jetpack_Gallery_Settings {
	function __construct() {
		add_action( 'admin_init', array( $this, 'admin_init' ) );
	}

	function admin_init() {
		/**
		 * Filter the available gallery types.
		 *
		 * @module shortcodes, tiled-gallery
		 *
		 * @since 2.5.1
		 *
		 * @param array $value Array of the default thumbnail grid gallery type. Default array contains one key, ‘default’.
		 *
		 */
		$this->gallery_types = apply_filters( 'jetpack_gallery_types', array( 'default' => __( 'Thumbnail Grid', 'jetpack' ) ) );
class MyClass { }

$x = new MyClass();
$x->foo = true;

		// Enqueue the media UI only if needed.
		if ( count( $this->gallery_types ) > 1 ) {
			add_action( 'wp_enqueue_media', array( $this, 'wp_enqueue_media' ) );
			add_action( 'print_media_templates', array( $this, 'print_media_templates' ) );
		}
	}

	/**
	 * Registers/enqueues the gallery settings admin js.
	 */
	function wp_enqueue_media() {
		if ( ! wp_script_is( 'jetpack-gallery-settings', 'registered' ) ) {
			/**
			 * This only happens if we're not in Jetpack, but on WPCOM instead.
			 * This is the correct path for WPCOM.
			 */
			wp_register_script( 'jetpack-gallery-settings', plugins_url( 'gallery-settings/gallery-settings.js', __FILE__ ), array( 'media-views' ), '20121225' );
		}

		wp_enqueue_script( 'jetpack-gallery-settings' );
	}

	/**
	 * Outputs a view template which can be used with wp.media.template
	 */
	function print_media_templates() {
		/**
		 * Filter the default gallery type.
		 *
		 * @module tiled-gallery
		 *
		 * @since 2.5.1
		 *
		 * @param string $value A string of the gallery type. Default is ‘default’.
		 *
		 */
		$default_gallery_type = apply_filters( 'jetpack_default_gallery_type', 'default' );

		?>
		<script type="text/html" id="tmpl-jetpack-gallery-settings">
			<label class="setting">
				<span><?php _e( 'Type', 'jetpack' ); ?></span>
				<select class="type" name="type" data-setting="type">
					<?php foreach ( $this->gallery_types as $value => $caption ) : ?>
						<option value="<?php echo esc_attr( $value ); ?>" <?php selected( $value, $default_gallery_type ); ?>><?php echo esc_html( $caption ); ?></option>
					<?php endforeach; ?>
				</select>
			</label>
		</script>
		<?php
	}
}
new Jetpack_Gallery_Settings;


1		<?php
2
3		/**
4		* Renders extra controls in the Gallery Settings section of the new media UI.
5		*/
6		class Jetpack_Gallery_Settings {
7		function __construct() {
8		add_action( 'admin_init', array( $this, 'admin_init' ) );
9		}
10
11		function admin_init() {
12		/**
13		* Filter the available gallery types.
14		*
15		* @module shortcodes, tiled-gallery
16		*
17		* @since 2.5.1
18		*
19		* @param array $value Array of the default thumbnail grid gallery type. Default array contains one key, ‘default’.
20		*
21		*/
22		$this->gallery_types = apply_filters( 'jetpack_gallery_types', array( 'default' => __( 'Thumbnail Grid', 'jetpack' ) ) );
		0 ignored issues – show Bug introduced 2015-11-20 23:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `gallery_types` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23
24		// Enqueue the media UI only if needed.
25		if ( count( $this->gallery_types ) > 1 ) {
26		add_action( 'wp_enqueue_media', array( $this, 'wp_enqueue_media' ) );
27		add_action( 'print_media_templates', array( $this, 'print_media_templates' ) );
28		}
29		}
30
31		/**
32		* Registers/enqueues the gallery settings admin js.
33		*/
34		function wp_enqueue_media() {
35	View Code Duplication	if ( ! wp_script_is( 'jetpack-gallery-settings', 'registered' ) ) {
36		/**
37		* This only happens if we're not in Jetpack, but on WPCOM instead.
38		* This is the correct path for WPCOM.
39		*/
40		wp_register_script( 'jetpack-gallery-settings', plugins_url( 'gallery-settings/gallery-settings.js', __FILE__ ), array( 'media-views' ), '20121225' );
41		}
42
43		wp_enqueue_script( 'jetpack-gallery-settings' );
44		}
45
46		/**
47		* Outputs a view template which can be used with wp.media.template
48		*/
49		function print_media_templates() {
50		/**
51		* Filter the default gallery type.
52		*
53		* @module tiled-gallery
54		*
55		* @since 2.5.1
56		*
57		* @param string $value A string of the gallery type. Default is ‘default’.
58		*
59		*/
60		$default_gallery_type = apply_filters( 'jetpack_default_gallery_type', 'default' );
61
62		?>
63		<script type="text/html" id="tmpl-jetpack-gallery-settings">
64		<label class="setting">
65		<span><?php _e( 'Type', 'jetpack' ); ?></span>
66		<select class="type" name="type" data-setting="type">
67		<?php foreach ( $this->gallery_types as $value => $caption ) : ?>
68		<option value="<?php echo esc_attr( $value ); ?>" <?php selected( $value, $default_gallery_type ); ?>><?php echo esc_html( $caption ); ?></option>
69		<?php endforeach; ?>
70		</select>
71		</label>
72		</script>
73		<?php
74		}
75		}
76		new Jetpack_Gallery_Settings;
77

Automattic / jetpack

Push — branch-4.4-built ( 3fd0f8...ac6bb8 )

functions.gallery.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like