Compatibility - Code Metrics - Inspection of "Backward Compatibility Package: Proof of Concept." - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — add/going-backwards ( 3440c3 )

unknown

created 2020-12-08 18:59 UTC

Compatibility A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	54
Duplicated Lines	11.11 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
dl	6
loc	54
rs	10
c	0
b	0
f	0
wmc	10
lcom	1
cbo	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	add_feature()	3	9	4
A	can_use()	0	9	3
A	add_plugin()	3	5	3

How to fix Duplicated Code

<?php
/**
 * The Backward Compatibility class.
 *
 * @package automattic/jetpack-back
 */

namespace Automattic\Jetpack\Back;

/**
 * The class manages the features supported by the plugins.
 */
class Compatibility {

	/**
	 * Supported features are stored here on per-plugin basis.
	 *
	 * @var array
	 */
	private static $features = array();

	/**
	 * Mark a feature as supported by the plugin.
	 *
	 * @param string $plugin The plugin slug.
	 * @param string $feature The feature label.
	 */
	public static function add_feature( $plugin, $feature ) {
		if ( ! array_key_exists( $plugin, static::$features ) || ! is_array( static::$features[ $plugin ] ) ) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
			static::$features[ $plugin ] = array();
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
		}

		if ( ! in_array( $feature, static::$features[ $plugin ], true ) ) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
			static::$features[ $plugin ][] = $feature;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
		}
	}

	/**
	 * Check if all the plugins support a feature.
	 *
	 * @param string $feature The feature label.
	 *
	 * @return bool True if the feature is supported, false otherwise.
	 */
	public static function can_use( $feature ) {
		foreach ( static::$features as $features ) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
			if ( ! in_array( $feature, $features, true ) ) {
				return false;
			}
		}

		return true;
	}

	/**
	 * Let the package know that the plugin exists and needs to be checked for compatibility.
	 *
	 * @param string $plugin The plugin slug.
	 */
	public static function add_plugin( $plugin ) {
		if ( empty( static::$features[ $plugin ] ) || ! is_array( static::$features[ $plugin ] ) ) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
			static::$features[ $plugin ] = array();
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
		}
	}

}


1		<?php
2		/**
3		* The Backward Compatibility class.
4		*
5		* @package automattic/jetpack-back
6		*/
7
8		namespace Automattic\Jetpack\Back;
9
10		/**
11		* The class manages the features supported by the plugins.
12		*/
13		class Compatibility {
14
15		/**
16		* Supported features are stored here on per-plugin basis.
17		*
18		* @var array
19		*/
20		private static $features = array();
21
22		/**
23		* Mark a feature as supported by the plugin.
24		*
25		* @param string $plugin The plugin slug.
26		* @param string $feature The feature label.
27		*/
28		public static function add_feature( $plugin, $feature ) {
29	View Code Duplication	if ( ! array_key_exists( $plugin, static::$features ) \|\| ! is_array( static::$features[ $plugin ] ) ) {
		0 ignored issues – show Bug introduced 2020-12-09 02:26 UTC by Report Bug Copy Issue Report Since `$features` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$features` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
30		static::$features[ $plugin ] = array();
		0 ignored issues – show Bug introduced 2020-12-09 02:26 UTC by Report Bug Copy Issue Report Since `$features` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$features` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
31		}
32
33		if ( ! in_array( $feature, static::$features[ $plugin ], true ) ) {
		0 ignored issues – show Bug introduced 2020-12-09 02:26 UTC by Report Bug Copy Issue Report Since `$features` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$features` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
34		static::$features[ $plugin ][] = $feature;
		0 ignored issues – show Bug introduced 2020-12-09 02:26 UTC by Report Bug Copy Issue Report Since `$features` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$features` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
35		}
36		}
37
38		/**
39		* Check if all the plugins support a feature.
40		*
41		* @param string $feature The feature label.
42		*
43		* @return bool True if the feature is supported, false otherwise.
44		*/
45		public static function can_use( $feature ) {
46		foreach ( static::$features as $features ) {
		0 ignored issues – show Bug introduced 2020-12-09 02:26 UTC by Report Bug Copy Issue Report Since `$features` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$features` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
47		if ( ! in_array( $feature, $features, true ) ) {
48		return false;
49		}
50		}
51
52		return true;
53		}
54
55		/**
56		* Let the package know that the plugin exists and needs to be checked for compatibility.
57		*
58		* @param string $plugin The plugin slug.
59		*/
60		public static function add_plugin( $plugin ) {
61	View Code Duplication	if ( empty( static::$features[ $plugin ] ) \|\| ! is_array( static::$features[ $plugin ] ) ) {
		0 ignored issues – show Bug introduced 2020-12-09 02:26 UTC by Report Bug Copy Issue Report Since `$features` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$features` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
62		static::$features[ $plugin ] = array();
		0 ignored issues – show Bug introduced 2020-12-09 02:26 UTC by Report Bug Copy Issue Report Since `$features` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$features` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
63		}
64		}
65
66		}
67

Automattic / jetpack

Push — add/going-backwards ( 3440c3 )

Compatibility A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like