Jetpack_Sync_Module_Constants::get_all_constants() - Code Metrics - Inspection of "Added a npm task to run a production build." - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — fix/gulp-env ( ec4107...cf0b47 )

unknown

created 2016-07-13 20:16 UTC

Jetpack_Sync_Module_Constants::get_all_constants() A

↳ Parent: Jetpack_Sync_Module_Constants

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	0
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php

class Jetpack_Sync_Module_Constants extends Jetpack_Sync_Module {
	const CONSTANTS_CHECKSUM_OPTION_NAME = 'jetpack_constants_sync_checksum';
	const CONSTANTS_AWAIT_TRANSIENT_NAME = 'jetpack_sync_constants_await';

	public function name() {
		return 'constants';
	}

	private $constants_whitelist;

	public function set_defaults() {
		$this->constants_whitelist       = Jetpack_Sync_Defaults::$default_constants_whitelist;
$a = "a";
$ab = "ab";
$abc = "abc";
	}

	public function init_listeners( $callable ) {
		add_action( 'jetpack_sync_constant', $callable, 10, 2 );

		// full sync
		add_action( 'jetpack_full_sync_constants', $callable );
	}

	public function init_before_send() {
		add_action( 'jetpack_sync_before_send', array( $this, 'maybe_sync_constants' ) );

		// full sync
		add_filter( 'jetpack_sync_before_send_jetpack_full_sync_constants', array( $this, 'expand_constants' ) );
	}

	public function reset_data() {
		delete_option( self::CONSTANTS_CHECKSUM_OPTION_NAME );
		delete_transient( self::CONSTANTS_AWAIT_TRANSIENT_NAME );
	}

	function set_constants_whitelist( $constants ) {
		$this->constants_whitelist = $constants;
	}

	function get_constants_whitelist() {
		return $this->constants_whitelist;
	}

	function force_sync_constants() {
		delete_option( self::CONSTANTS_CHECKSUM_OPTION_NAME );
		delete_transient( self::CONSTANTS_AWAIT_TRANSIENT_NAME );
		$this->maybe_sync_constants();
	}

	function enqueue_full_sync_actions() {
		/**
		 * Tells the client to sync all constants to the server
		 *
		 * @since 4.2.0
		 *
		 * @param boolean Whether to expand constants (should always be true)
		 */
		do_action( 'jetpack_full_sync_constants', true );
		return 1;
	}

	function get_full_sync_actions() {
		return array( 'jetpack_full_sync_constants' );
	}

	function maybe_sync_constants() {
		if ( get_transient( self::CONSTANTS_AWAIT_TRANSIENT_NAME ) ) {
			return;
		}

		$constants = $this->get_all_constants();
		if ( empty( $constants ) ) {
			return;
		}

		set_transient( self::CONSTANTS_AWAIT_TRANSIENT_NAME, microtime( true ), Jetpack_Sync_Defaults::$default_sync_constants_wait_time );

		$constants_checksums = (array) get_option( self::CONSTANTS_CHECKSUM_OPTION_NAME, array() );

		foreach ( $constants as $name => $value ) {
			$checksum = $this->get_check_sum( $value );
			// explicitly not using Identical comparison as get_option returns a string
			if ( ! $this->still_valid_checksum( $constants_checksums, $name, $checksum )  && ! is_null( $value ) ) {
				/**
				 * Tells the client to sync a constant to the server
				 *
				 * @since 4.2.0
				 *
				 * @param string The name of the constant
				 * @param mixed The value of the constant
				 */
				do_action( 'jetpack_sync_constant', $name, $value );
				$constants_checksums[ $name ] = $checksum;
			} else {
				$constants_checksums[ $name ] = $checksum;
			}
		}
		update_option( self::CONSTANTS_CHECKSUM_OPTION_NAME, $constants_checksums );
	}

	// public so that we don't have to store an option for each constant
	function get_all_constants() {
		return array_combine(
			$this->constants_whitelist,
			array_map( array( $this, 'get_constant' ), $this->constants_whitelist )
		);
	}

	private function get_constant( $constant ) {
		return ( defined( $constant ) ) ?
			constant( $constant )
			: null;
	}

	public function expand_constants( $args ) {
		if ( $args[0] ) {
			return $this->get_all_constants();
		}
		return $args;
	}
}


1		<?php
2
3		class Jetpack_Sync_Module_Constants extends Jetpack_Sync_Module {
4		const CONSTANTS_CHECKSUM_OPTION_NAME = 'jetpack_constants_sync_checksum';
5		const CONSTANTS_AWAIT_TRANSIENT_NAME = 'jetpack_sync_constants_await';
6
7		public function name() {
8		return 'constants';
9		}
10
11		private $constants_whitelist;
12
13		public function set_defaults() {
14		$this->constants_whitelist = Jetpack_Sync_Defaults::$default_constants_whitelist;
		0 ignored issues – show Bug introduced 2016-06-29 22:35 UTC by Report Bug Copy Issue Report The property `default_constants_whitelist` cannot be accessed from this context as it is declared `private` in class `Jetpack_Sync_Defaults`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history... Coding Style introduced 2016-06-29 22:35 UTC by Report Bug Copy Issue Report Equals sign not aligned correctly; expected 1 space but found 7 spaces This check looks for improperly formatted assignments. Every assignment must have exactly one space before and one space after the equals operator. To illustrate: $a = "a"; $ab = "ab"; $abc = "abc"; will have no issues, while $a = "a"; $ab = "ab"; $abc = "abc"; will report issues in lines 1 and 2. Loading history...
15		}
16
17		public function init_listeners( $callable ) {
18		add_action( 'jetpack_sync_constant', $callable, 10, 2 );
19
20		// full sync
21		add_action( 'jetpack_full_sync_constants', $callable );
22		}
23
24		public function init_before_send() {
25		add_action( 'jetpack_sync_before_send', array( $this, 'maybe_sync_constants' ) );
26
27		// full sync
28		add_filter( 'jetpack_sync_before_send_jetpack_full_sync_constants', array( $this, 'expand_constants' ) );
29		}
30
31		public function reset_data() {
32		delete_option( self::CONSTANTS_CHECKSUM_OPTION_NAME );
33		delete_transient( self::CONSTANTS_AWAIT_TRANSIENT_NAME );
34		}
35
36		function set_constants_whitelist( $constants ) {
37		$this->constants_whitelist = $constants;
38		}
39
40		function get_constants_whitelist() {
41		return $this->constants_whitelist;
42		}
43
44		function force_sync_constants() {
45		delete_option( self::CONSTANTS_CHECKSUM_OPTION_NAME );
46		delete_transient( self::CONSTANTS_AWAIT_TRANSIENT_NAME );
47		$this->maybe_sync_constants();
48		}
49
50		function enqueue_full_sync_actions() {
51		/**
52		* Tells the client to sync all constants to the server
53		*
54		* @since 4.2.0
55		*
56		* @param boolean Whether to expand constants (should always be true)
57		*/
58		do_action( 'jetpack_full_sync_constants', true );
59		return 1;
60		}
61
62		function get_full_sync_actions() {
63		return array( 'jetpack_full_sync_constants' );
64		}
65
66	View Code Duplication	function maybe_sync_constants() {
67		if ( get_transient( self::CONSTANTS_AWAIT_TRANSIENT_NAME ) ) {
68		return;
69		}
70
71		$constants = $this->get_all_constants();
72		if ( empty( $constants ) ) {
73		return;
74		}
75
76		set_transient( self::CONSTANTS_AWAIT_TRANSIENT_NAME, microtime( true ), Jetpack_Sync_Defaults::$default_sync_constants_wait_time );
		0 ignored issues – show Bug introduced 2016-06-29 22:35 UTC by Report Bug Copy Issue Report The property `default_sync_constants_wait_time` cannot be accessed from this context as it is declared `private` in class `Jetpack_Sync_Defaults`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
77		$constants_checksums = (array) get_option( self::CONSTANTS_CHECKSUM_OPTION_NAME, array() );
78
79		foreach ( $constants as $name => $value ) {
80		$checksum = $this->get_check_sum( $value );
81		// explicitly not using Identical comparison as get_option returns a string
82		if ( ! $this->still_valid_checksum( $constants_checksums, $name, $checksum ) && ! is_null( $value ) ) {
83		/**
84		* Tells the client to sync a constant to the server
85		*
86		* @since 4.2.0
87		*
88		* @param string The name of the constant
89		* @param mixed The value of the constant
90		*/
91		do_action( 'jetpack_sync_constant', $name, $value );
92		$constants_checksums[ $name ] = $checksum;
93		} else {
94		$constants_checksums[ $name ] = $checksum;
95		}
96		}
97		update_option( self::CONSTANTS_CHECKSUM_OPTION_NAME, $constants_checksums );
98		}
99
100		// public so that we don't have to store an option for each constant
101		function get_all_constants() {
102		return array_combine(
103		$this->constants_whitelist,
104		array_map( array( $this, 'get_constant' ), $this->constants_whitelist )
105		);
106		}
107
108		private function get_constant( $constant ) {
109		return ( defined( $constant ) ) ?
110		constant( $constant )
111		: null;
112		}
113
114		public function expand_constants( $args ) {
115		if ( $args[0] ) {
116		return $this->get_all_constants();
117		}
118		return $args;
119		}
120		}
121

Automattic / jetpack

Push — fix/gulp-env ( ec4107...cf0b47 )

Jetpack_Sync_Module_Constants::get_all_constants() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like