Conditions | 13 |
Paths | 432 |
Total Lines | 49 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
104 | public static function generate_stats_array( $prefix = '' ) { |
||
105 | $return = array(); |
||
106 | |||
107 | $return["{$prefix}version"] = JETPACK__VERSION; |
||
108 | $return["{$prefix}wp-version"] = get_bloginfo( 'version' ); |
||
109 | $return["{$prefix}php-version"] = PHP_VERSION; |
||
110 | $return["{$prefix}branch"] = floatval( JETPACK__VERSION ); |
||
111 | $return["{$prefix}wp-branch"] = floatval( get_bloginfo( 'version' ) ); |
||
112 | $return["{$prefix}php-branch"] = floatval( PHP_VERSION ); |
||
113 | $return["{$prefix}public"] = Jetpack_Options::get_option( 'public' ); |
||
114 | $return["{$prefix}ssl"] = Jetpack::permit_ssl(); |
||
115 | $return["{$prefix}is-https"] = is_ssl() ? 'https' : 'http'; |
||
116 | $return["{$prefix}language"] = get_bloginfo( 'language' ); |
||
117 | $return["{$prefix}charset"] = get_bloginfo( 'charset' ); |
||
118 | $return["{$prefix}is-multisite"] = is_multisite() ? 'multisite' : 'singlesite'; |
||
119 | $return["{$prefix}identitycrisis"] = Jetpack::check_identity_crisis() ? 'yes' : 'no'; |
||
120 | $return["{$prefix}plugins"] = implode( ',', Jetpack::get_active_plugins() ); |
||
121 | $return["{$prefix}manage-enabled"] = true; |
||
122 | |||
123 | $xmlrpc_errors = Jetpack_Options::get_option( 'xmlrpc_errors', array() ); |
||
124 | if ( $xmlrpc_errors ) { |
||
125 | $return["{$prefix}xmlrpc-errors"] = implode( ',', array_keys( $xmlrpc_errors ) ); |
||
126 | Jetpack_Options::delete_option( 'xmlrpc_errors' ); |
||
127 | } |
||
128 | |||
129 | // Missing the connection owner? |
||
130 | $connection_manager = new Manager(); |
||
131 | $return["{$prefix}missing-owner"] = $connection_manager->is_missing_connection_owner(); |
||
132 | |||
133 | // is-multi-network can have three values, `single-site`, `single-network`, and `multi-network` |
||
134 | $return["{$prefix}is-multi-network"] = 'single-site'; |
||
135 | if ( is_multisite() ) { |
||
136 | $return["{$prefix}is-multi-network"] = Jetpack::is_multi_network() ? 'multi-network' : 'single-network'; |
||
137 | } |
||
138 | |||
139 | if ( ! empty( $_SERVER['SERVER_ADDR'] ) || ! empty( $_SERVER['LOCAL_ADDR'] ) ) { |
||
140 | $ip = ! empty( $_SERVER['SERVER_ADDR'] ) ? $_SERVER['SERVER_ADDR'] : $_SERVER['LOCAL_ADDR']; |
||
141 | $ip_arr = array_map( 'intval', explode( '.', $ip ) ); |
||
142 | if ( 4 == count( $ip_arr ) ) { |
||
143 | $return["{$prefix}ip-2-octets"] = implode( '.', array_slice( $ip_arr, 0, 2 ) ); |
||
144 | } |
||
145 | } |
||
146 | |||
147 | foreach ( Jetpack::get_available_modules() as $slug ) { |
||
148 | $return["{$prefix}module-{$slug}"] = Jetpack::is_module_active( $slug ) ? 'on' : 'off'; |
||
149 | } |
||
150 | |||
151 | return $return; |
||
152 | } |
||
153 | |||
178 |
Adding a
@return
annotation to a constructor is not recommended, since a constructor does not have a meaningful return value.Please refer to the PHP core documentation on constructors.