Completed
Pull Request — master (#12933)
by Bernhard
11:03 queued 01:30
created
_inc/class.jetpack-provision.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -249,6 +249,9 @@
 block discarded – undo
249 249
 		}
250 250
 	}
251 251
 
252
+	/**
253
+	 * @param string $access_token
254
+	 */
252 255
 	private static function verify_token( $access_token ) {
253 256
 		$request = array(
254 257
 			'headers' => array(
Please login to merge, or discard this patch.
json-endpoints/class.wpcom-json-api-list-post-type-taxonomies-endpoint.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -75,6 +75,9 @@
 block discarded – undo
75 75
 		);
76 76
 	}
77 77
 
78
+	/**
79
+	 * @param string $post_type
80
+	 */
78 81
 	protected function localize_initial_taxonomies( $post_type ) {
79 82
 		/** This filter is documented in jetpack/json-endpoints/class.wpcom-json-api-list-post-types-endpoint.php */
80 83
 		if ( ! apply_filters( 'rest_api_localize_response', false ) ) {
Please login to merge, or discard this patch.
json-endpoints/class.wpcom-json-api-edit-media-v1-2-endpoint.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 	 * Update the media post grabbing the post values from
102 102
 	 * the `attrs` parameter
103 103
 	 *
104
-	 * @param  {Number} $media_id - post media ID
104
+	 * @param  integer $media_id - post media ID
105 105
 	 * @param  {Object} $attrs - `attrs` parameter sent from the client in the request body
106 106
 	 * @return
107 107
 	 */
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
 	 * Save the given temporal file in a local folder.
203 203
 	 *
204 204
 	 * @param  {Array} $file_array
205
-	 * @param  {Number} $media_id
205
+	 * @param  integer $media_id
206 206
 	 * @return {Array|WP_Error} An array with information about the new file saved or a WP_Error is something went wrong.
207 207
 	 */
208 208
 	private function save_temporary_file( $file_array, $media_id ) {
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
 	/**
278 278
 	 * Get the image from a remote url and then save it locally.
279 279
 	 *
280
-	 * @param  {Number} $media_id - media post ID
280
+	 * @param  integer $media_id - media post ID
281 281
 	 * @param  {String} $url - image URL to save locally
282 282
 	 * @return {Array|WP_Error} An array with information about the new file saved or a WP_Error is something went wrong.
283 283
 	 */
Please login to merge, or discard this patch.
_inc/lib/class.media.php 1 patch
Doc Comments   +7 added lines, -3 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 	/**
87 87
 	 * Return an array of allowed mime_type items used to upload a media file.
88 88
 	 * 	
89
-	 * @return array mime_type array
89
+	 * @return string[] mime_type array
90 90
 	 */
91 91
 	static function get_allowed_mime_types( $default_mime_types ) {
92 92
 		return array_unique( array_merge( $default_mime_types, array(
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
 	 * @param  object $media_item - media post object
254 254
 	 * @param  file $file - file recently added
255 255
 	 * @param  bool $has_original_media - condition is the original media has been already added
256
-	 * @return bool `true` if the item has been added. Otherwise `false`.
256
+	 * @return false|null `true` if the item has been added. Otherwise `false`.
257 257
 	 */
258 258
 	public static function register_revision( $media_item, $file, $has_original_media ) {
259 259
 		if ( is_wp_error( $file ) || ! $has_original_media ) {
@@ -281,6 +281,9 @@  discard block
 block discarded – undo
281 281
 		return $original;
282 282
 	}
283 283
 
284
+	/**
285
+	 * @param string $pathname
286
+	 */
284 287
 	public static function delete_file( $pathname ) {
285 288
 		if ( ! file_exists( $pathname ) || ! is_file( $pathname ) ) {
286 289
 			// let's touch a fake file to try to `really` remove the media file
@@ -296,7 +299,7 @@  discard block
 block discarded – undo
296 299
 	 * 
297 300
 	 * @param  number $media_id - media post ID
298 301
 	 * @param  string $filename - basename of the file ( name-of-file.ext )
299
-	 * @return bool `true` is the file has been removed, `false` if not.
302
+	 * @return boolean|null `true` is the file has been removed, `false` if not.
300 303
 	 */
301 304
 	private static function delete_media_history_file( $media_id, $filename ) {
302 305
 		$attached_path = get_attached_file( $media_id );
@@ -366,6 +369,7 @@  discard block
 block discarded – undo
366 369
 	 * 
367 370
 	 * @param  number $media_id - media post ID
368 371
 	 * @param  number [$limit] - maximun amount of items. 20 as default.
372
+	 * @param integer $limit
369 373
 	 * @return array items removed from `revision_history`
370 374
 	 */
371 375
 	public static function limit_revision_history( $media_id, $limit = null) {
Please login to merge, or discard this patch.
_inc/lib/tonesque.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
 	 * Construct object from image.
88 88
 	 *
89 89
 	 * @param optional $type (hex, rgb, hsv)
90
-	 * @return color as a string formatted as $type
90
+	 * @return false|string as a string formatted as $type
91 91
 	 *
92 92
  	 */
93 93
 	function color( $type = 'hex' ) {
Please login to merge, or discard this patch.
_inc/lib/class.jetpack-keyring-service-helper.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -100,6 +100,10 @@  discard block
 block discarded – undo
100 100
 		), menu_page_url( 'sharing', false ) );
101 101
 	}
102 102
 
103
+	/**
104
+	 * @param string $service_name
105
+	 * @param string $for
106
+	 */
103 107
 	static function refresh_url( $service_name, $for ) {
104 108
 		return add_query_arg( array(
105 109
 			'action'   => 'request',
@@ -111,6 +115,10 @@  discard block
 block discarded – undo
111 115
 		), admin_url( 'options-general.php?page=sharing' ) );
112 116
 	}
113 117
 
118
+	/**
119
+	 * @param string $service_name
120
+	 * @param string $id
121
+	 */
114 122
 	static function disconnect_url( $service_name, $id ) {
115 123
 		return add_query_arg( array(
116 124
 			'action'   => 'delete',
Please login to merge, or discard this patch.
class.json-api.php 1 patch
Doc Comments   +18 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,6 +33,9 @@  discard block
 block discarded – undo
33 33
 	public $extra_headers = array();
34 34
 
35 35
 	/**
36
+	 * @param string $method
37
+	 * @param string $url
38
+	 * @param string $post_body
36 39
 	 * @return WPCOM_JSON_API instance
37 40
 	 */
38 41
 	static function init( $method = null, $url = null, $post_body = null ) {
@@ -335,6 +338,9 @@  discard block
 block discarded – undo
335 338
 		return call_user_func_array( array( $endpoint, 'callback' ), $path_pieces );
336 339
 	}
337 340
 
341
+	/**
342
+	 * @param integer $status_code
343
+	 */
338 344
 	function output_early( $status_code, $response = null, $content_type = 'application/json' ) {
339 345
 		$exit = $this->exit;
340 346
 		$this->exit = false;
@@ -543,11 +549,18 @@  discard block
 block discarded – undo
543 549
 		return json_encode( $data );
544 550
 	}
545 551
 
552
+	/**
553
+	 * @param string $needle
554
+	 */
546 555
 	function ends_with( $haystack, $needle ) {
547 556
 		return $needle === substr( $haystack, -strlen( $needle ) );
548 557
 	}
549 558
 
550 559
 	// Returns the site's blog_id in the WP.com ecosystem
560
+
561
+	/**
562
+	 * @return integer
563
+	 */
551 564
 	function get_blog_id_for_output() {
552 565
 		return $this->token_details['blog_id'];
553 566
 	}
@@ -570,6 +583,10 @@  discard block
 block discarded – undo
570 583
 	}
571 584
 
572 585
 	// Returns true if the specified blog ID is a restricted blog
586
+
587
+	/**
588
+	 * @param integer $blog_id
589
+	 */
573 590
 	function is_restricted_blog( $blog_id ) {
574 591
 		/**
575 592
 		 * Filters all REST API access and return a 403 unauthorized response for all Restricted blog IDs.
@@ -619,7 +636,7 @@  discard block
 block discarded – undo
619 636
 	/**
620 637
 	 * Counts the number of comments on a site, excluding certain comment types.
621 638
 	 *
622
-	 * @param $post_id int Post ID.
639
+	 * @param integer $post_id int Post ID.
623 640
 	 * @return array Array of counts, matching the output of https://developer.wordpress.org/reference/functions/get_comment_count/.
624 641
 	 */
625 642
 	public function wp_count_comments( $post_id ) {
Please login to merge, or discard this patch.
modules/contact-form/grunion-contact-form.php 1 patch
Doc Comments   +44 added lines, -2 removed lines patch added patch discarded remove patch
@@ -300,6 +300,9 @@  discard block
 block discarded – undo
300 300
 		return Grunion_Contact_Form::parse( $atts, do_blocks( $content ) );
301 301
 	}
302 302
 
303
+	/**
304
+	 * @param string $type
305
+	 */
303 306
 	public static function block_attributes_to_shortcode_attributes( $atts, $type ) {
304 307
 		$atts['type'] = $type;
305 308
 		if ( isset( $atts['className'] ) ) {
@@ -1918,7 +1921,6 @@  discard block
 block discarded – undo
1918 1921
 	 *
1919 1922
 	 * @see ::style()
1920 1923
 	 * @internal
1921
-	 * @param bool $style
1922 1924
 	 */
1923 1925
 	static function _style_on() {
1924 1926
 		return self::style( true );
@@ -2086,6 +2088,7 @@  discard block
 block discarded – undo
2086 2088
 	 *
2087 2089
 	 * @param int                         $feedback_id
2088 2090
 	 * @param object Grunion_Contact_Form $form
2091
+	 * @param Grunion_Contact_Form $form
2089 2092
 	 *
2090 2093
 	 * @return string $message
2091 2094
 	 */
@@ -2210,7 +2213,7 @@  discard block
 block discarded – undo
2210 2213
 	 *
2211 2214
 	 * @param array       $attributes Key => Value pairs as parsed by shortcode_parse_atts()
2212 2215
 	 * @param string|null $content The shortcode's inner content: [contact-field]$content[/contact-field]
2213
-	 * @return HTML for the contact form field
2216
+	 * @return string for the contact form field
2214 2217
 	 */
2215 2218
 	static function parse_contact_field( $attributes, $content ) {
2216 2219
 		// Don't try to parse contact form fields if not inside a contact form
@@ -3233,6 +3236,9 @@  discard block
 block discarded – undo
3233 3236
 
3234 3237
 	}
3235 3238
 
3239
+	/**
3240
+	 * @param string $type
3241
+	 */
3236 3242
 	function render_input_field( $type, $id, $value, $class, $placeholder, $required ) {
3237 3243
 		return "<input
3238 3244
 					type='". esc_attr( $type ) ."'
@@ -3244,24 +3250,40 @@  discard block
 block discarded – undo
3244 3250
 				/>\n";
3245 3251
 	}
3246 3252
 
3253
+	/**
3254
+	 * @param string $class
3255
+	 * @param string $placeholder
3256
+	 */
3247 3257
 	function render_email_field( $id, $label, $value, $class, $required, $required_field_text, $placeholder ) {
3248 3258
 		$field = $this->render_label( 'email', $id, $label, $required, $required_field_text );
3249 3259
 		$field .= $this->render_input_field( 'email', $id, $value, $class, $placeholder, $required );
3250 3260
 		return $field;
3251 3261
 	}
3252 3262
 
3263
+	/**
3264
+	 * @param string $class
3265
+	 * @param string $placeholder
3266
+	 */
3253 3267
 	function render_telephone_field( $id, $label, $value, $class, $required, $required_field_text, $placeholder ) {
3254 3268
 		$field = $this->render_label( 'telephone', $id, $label, $required, $required_field_text );
3255 3269
 		$field .= $this->render_input_field( 'tel', $id, $value, $class, $placeholder, $required );
3256 3270
 		return $field;
3257 3271
 	}
3258 3272
 
3273
+	/**
3274
+	 * @param string $class
3275
+	 * @param string $placeholder
3276
+	 */
3259 3277
 	function render_url_field( $id, $label, $value, $class, $required, $required_field_text, $placeholder ) {
3260 3278
 		$field = $this->render_label( 'url', $id, $label, $required, $required_field_text );
3261 3279
 		$field .= $this->render_input_field( 'url', $id, $value, $class, $placeholder, $required );
3262 3280
 		return $field;
3263 3281
 	}
3264 3282
 
3283
+	/**
3284
+	 * @param string $class
3285
+	 * @param string $placeholder
3286
+	 */
3265 3287
 	function render_textarea_field( $id, $label, $value, $class, $required, $required_field_text, $placeholder ) {
3266 3288
 		$field = $this->render_label( 'textarea', 'contact-form-comment-' . $id, $label, $required, $required_field_text );
3267 3289
 		$field .= "<textarea
@@ -3276,6 +3298,9 @@  discard block
 block discarded – undo
3276 3298
 		return $field;
3277 3299
 	}
3278 3300
 
3301
+	/**
3302
+	 * @param string $class
3303
+	 */
3279 3304
 	function render_radio_field( $id, $label, $value, $class, $required, $required_field_text ) {
3280 3305
 		$field = $this->render_label( '', $id, $label, $required, $required_field_text );
3281 3306
 		foreach ( (array) $this->get_attribute( 'options' ) as $optionIndex => $option ) {
@@ -3297,6 +3322,9 @@  discard block
 block discarded – undo
3297 3322
 		return $field;
3298 3323
 	}
3299 3324
 
3325
+	/**
3326
+	 * @param string $class
3327
+	 */
3300 3328
 	function render_checkbox_field( $id, $label, $value, $class, $required, $required_field_text ) {
3301 3329
 		$field = "<label class='grunion-field-label checkbox" . ( $this->is_error() ? ' form-error' : '' ) . "'>";
3302 3330
 			$field .= "\t\t<input type='checkbox' name='" . esc_attr( $id ) . "' value='" . esc_attr__( 'Yes', 'jetpack' ) . "' " . $class . checked( (bool) $value, true, false ) . ' ' . ( $required ? "required aria-required='true'" : '' ) . "/> \n";
@@ -3306,6 +3334,9 @@  discard block
 block discarded – undo
3306 3334
 		return $field;
3307 3335
 	}
3308 3336
 
3337
+	/**
3338
+	 * @param string $class
3339
+	 */
3309 3340
 	function render_checkbox_multiple_field( $id, $label, $value, $class, $required, $required_field_text  ) {
3310 3341
 		$field = $this->render_label( '', $id, $label, $required, $required_field_text );
3311 3342
 		foreach ( (array) $this->get_attribute( 'options' ) as $optionIndex => $option ) {
@@ -3321,6 +3352,9 @@  discard block
 block discarded – undo
3321 3352
 		return $field;
3322 3353
 	}
3323 3354
 
3355
+	/**
3356
+	 * @param string $class
3357
+	 */
3324 3358
 	function render_select_field( $id, $label, $value, $class, $required, $required_field_text ) {
3325 3359
 		$field = $this->render_label( 'select', $id, $label, $required, $required_field_text );
3326 3360
 		$field  .= "\t<select name='" . esc_attr( $id ) . "' id='" . esc_attr( $id ) . "' " . $class . ( $required ? "required aria-required='true'" : '' ) . ">\n";
@@ -3338,6 +3372,10 @@  discard block
 block discarded – undo
3338 3372
 		return $field;
3339 3373
 	}
3340 3374
 
3375
+	/**
3376
+	 * @param string $class
3377
+	 * @param string $placeholder
3378
+	 */
3341 3379
 	function render_date_field( $id, $label, $value, $class, $required, $required_field_text, $placeholder ) {
3342 3380
 		$field = $this->render_label( 'date', $id, $label, $required, $required_field_text );
3343 3381
 		$field .= $this->render_input_field( 'text', $id, $value, $class, $placeholder, $required );
@@ -3357,6 +3395,10 @@  discard block
 block discarded – undo
3357 3395
 		return $field;
3358 3396
 	}
3359 3397
 
3398
+	/**
3399
+	 * @param string $class
3400
+	 * @param string $placeholder
3401
+	 */
3360 3402
 	function render_default_field( $id, $label, $value, $class, $required, $required_field_text, $placeholder, $type ) {
3361 3403
 		$field = $this->render_label( $type, $id, $label, $required, $required_field_text );
3362 3404
 		$field .= $this->render_input_field( 'text', $id, $value, $class, $placeholder, $required );
Please login to merge, or discard this patch.
class.photon.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -213,7 +213,6 @@  discard block
 block discarded – undo
213 213
 	/**
214 214
 	 * Inject image sizes to Jetpack REST API responses. This wraps the filter_photon_norezise_maybe_inject_sizes function.
215 215
 	 *
216
-	 * @param array $data          Attachment sizes data.
217 216
 	 * @param int   $attachment_id Attachment's post ID.
218 217
 	 *
219 218
 	 * @return array Attachment sizes array.
@@ -1257,7 +1256,7 @@  discard block
 block discarded – undo
1257 1256
 	 * after ourselves without breaking anyone else's filters.
1258 1257
 	 *
1259 1258
 	 * @internal
1260
-	 * @return true
1259
+	 * @return boolean
1261 1260
 	 */
1262 1261
 	public function _override_image_downsize_in_rest_edit_context() {
1263 1262
 		return true;
Please login to merge, or discard this patch.