Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 15 | class Atomic_Admin_Menu extends Admin_Menu { |
||
| 16 | |||
| 17 | /** |
||
| 18 | * Atomic_Admin_Menu constructor. |
||
| 19 | */ |
||
| 20 | protected function __construct() { |
||
| 34 | |||
| 35 | /** |
||
| 36 | * Dequeues unnecessary scripts. |
||
| 37 | */ |
||
| 38 | public function dequeue_scripts() { |
||
| 41 | |||
| 42 | /** |
||
| 43 | * Create the desired menu output. |
||
| 44 | */ |
||
| 45 | View Code Duplication | public function reregister_menu_items() { |
|
| 59 | |||
| 60 | /** |
||
| 61 | * Forces Posts menu to WPAdmin for Atomic sites only. |
||
| 62 | * Overloads `add_posts_menu` in parent class. |
||
| 63 | * |
||
| 64 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 65 | */ |
||
| 66 | public function add_posts_menu( $wp_admin = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
| 69 | |||
| 70 | /** |
||
| 71 | * Forces Pages menu to WPAdmin for Atomic sites only. |
||
| 72 | * Overloads `add_page_menu` in parent class. |
||
| 73 | * |
||
| 74 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 75 | */ |
||
| 76 | public function add_page_menu( $wp_admin = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
| 79 | |||
| 80 | /** |
||
| 81 | * Adds Plugins menu. |
||
| 82 | * |
||
| 83 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 84 | */ |
||
| 85 | public function add_plugins_menu( $wp_admin = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
| 89 | |||
| 90 | /** |
||
| 91 | * Adds the site switcher link if user has more than one site. |
||
| 92 | */ |
||
| 93 | public function add_browse_sites_link() { |
||
| 103 | |||
| 104 | /** |
||
| 105 | * Adds a custom element class for Site Switcher menu item. |
||
| 106 | * |
||
| 107 | * @param array $menu Associative array of administration menu items. |
||
| 108 | * |
||
| 109 | * @return array |
||
| 110 | */ |
||
| 111 | View Code Duplication | public function set_browse_sites_link_class( array $menu ) { |
|
| 123 | |||
| 124 | /** |
||
| 125 | * Adds a link to the menu to create a new site. |
||
| 126 | */ |
||
| 127 | public function add_new_site_link() { |
||
| 144 | |||
| 145 | /** |
||
| 146 | * Adds site card component. |
||
| 147 | */ |
||
| 148 | public function add_site_card_menu() { |
||
| 178 | |||
| 179 | /** |
||
| 180 | * Adds a custom element class and id for Site Card's menu item. |
||
| 181 | * |
||
| 182 | * @param array $menu Associative array of administration menu items. |
||
| 183 | * |
||
| 184 | * @return array |
||
| 185 | */ |
||
| 186 | public function set_site_card_menu_class( array $menu ) { |
||
| 206 | |||
| 207 | /** |
||
| 208 | * Adds Upgrades menu. |
||
| 209 | */ |
||
| 210 | public function add_upgrades_menu() { |
||
| 215 | |||
| 216 | /** |
||
| 217 | * Adds Tools menu. |
||
| 218 | * |
||
| 219 | * @param bool $wp_admin_import Optional. Whether Import link should point to Calypso or wp-admin. Default false (Calypso). |
||
| 220 | * @param bool $wp_admin_export Optional. Whether Export link should point to Calypso or wp-admin. Default false (Calypso). |
||
| 221 | */ |
||
| 222 | public function add_tools_menu( $wp_admin_import = false, $wp_admin_export = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
| 226 | |||
| 227 | /** |
||
| 228 | * Adds Settings menu. |
||
| 229 | * |
||
| 230 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 231 | */ |
||
| 232 | public function add_options_menu( $wp_admin = false ) { |
||
| 243 | |||
| 244 | /** |
||
| 245 | * Adds Appearance menu. |
||
| 246 | * |
||
| 247 | * @param bool $wp_admin_themes Optional. Whether Themes link should point to Calypso or wp-admin. Default false (Calypso). |
||
| 248 | * @param bool $wp_admin_customize Optional. Whether Customize link should point to Calypso or wp-admin. Default false (Calypso). |
||
| 249 | */ |
||
| 250 | public function add_appearance_menu( $wp_admin_themes = false, $wp_admin_customize = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
| 256 | |||
| 257 | /** |
||
| 258 | * Adds Users menu. |
||
| 259 | * |
||
| 260 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 261 | */ |
||
| 262 | public function add_users_menu( $wp_admin = false ) { |
||
| 267 | |||
| 268 | /** |
||
| 269 | * Also remove the Gutenberg plugin menu. |
||
| 270 | * |
||
| 271 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 272 | */ |
||
| 273 | public function add_gutenberg_menus( $wp_admin = false ) { |
||
| 278 | } |
||
| 279 |