Automattic /
jetpack
| Conditions | 3 |
| Paths | 4 |
| Total Lines | 56 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 57 | function parse_shortcode( $attrs, $content = false ) { |
||
| 58 | // We allow for overriding the presentation labels |
||
| 59 | $data = shortcode_atts( array( |
||
| 60 | 'blog_id' => $this->get_blog_id(), |
||
| 61 | 'title' => __( 'Join my email list', 'jetpack' ), |
||
| 62 | 'email_placeholder' => __( 'Enter your email', 'jetpack' ), |
||
| 63 | 'submit_label' => __( 'Join My Email List', 'jetpack' ), |
||
| 64 | 'consent_text' => __( 'By clicking submit, you agree to share your email address with the site owner and MailChimp to receive marketing, updates, and other emails from the site owner. Use the unsubscribe link in those emails to opt out at any time.', 'jetpack' ), |
||
| 65 | 'processing_label' => __( 'Processing...', 'jetpack' ), |
||
| 66 | 'success_label' => __( 'Success! You\'ve been added to the list.', 'jetpack' ), |
||
| 67 | 'error_label' => __( "Oh no! Unfortunately there was an error.\nPlease try reloading this page and adding your email once more.", 'jetpack' ), |
||
| 68 | 'classname' => self::$css_classname_prefix, |
||
| 69 | 'dom_id' => uniqid( self::$css_classname_prefix . '_', false ), |
||
| 70 | ), $attrs ); |
||
| 71 | |||
| 72 | |||
| 73 | if ( ! wp_script_is( 'jetpack-email-subscribe', 'enqueued' ) ) { |
||
| 74 | wp_enqueue_script( 'jetpack-email-subscribe' ); |
||
| 75 | } |
||
| 76 | |||
| 77 | if( ! wp_style_is( 'jetpack-email-subscribe', 'enqueue' ) ) { |
||
| 78 | wp_enqueue_style( 'jetpack-email-subscribe' ); |
||
| 79 | } |
||
| 80 | |||
| 81 | wp_add_inline_script( 'jetpack-email-subscribe', sprintf( |
||
| 82 | "try{JetpackEmailSubscribe.activate( '%s', '%s', '%s' );}catch(e){}", |
||
| 83 | esc_js( $data['blog_id'] ), |
||
| 84 | esc_js( $data['dom_id'] ), |
||
| 85 | esc_js( $data['classname'] ) |
||
| 86 | ) ); |
||
| 87 | |||
| 88 | return sprintf( |
||
| 89 | '<div class="%1$s" id="%2$s"> |
||
| 90 | <h2>%3$s</h2> |
||
| 91 | <form> |
||
| 92 | <input type="email" class="%1$s-email" required placeholder="%4$s"> |
||
| 93 | <button type="submit" class="%1$s-submit">%6$s</button> |
||
| 94 | <label class="%1$s-consent-label"> |
||
| 95 | <small>%5$s</small> |
||
| 96 | </label> |
||
| 97 | </form> |
||
| 98 | <div class="%1$s-processing">%7$s</div> |
||
| 99 | <div class="%1$s-success">%8$s</div> |
||
| 100 | <div class="%1$s-error">%9$s</div> |
||
| 101 | </div>', |
||
| 102 | esc_attr( $data['classname'] ), |
||
| 103 | esc_attr( $data['dom_id'] ), |
||
| 104 | esc_html( $data['title'] ), |
||
| 105 | esc_html( $data['email_placeholder'] ), |
||
| 106 | esc_html( $data['consent_text'] ), |
||
| 107 | esc_html( $data['submit_label'] ), |
||
| 108 | nl2br( esc_html( $data['processing_label'] ) ), |
||
| 109 | nl2br( esc_html( $data['success_label'] ) ), |
||
| 110 | nl2br( esc_html( $data['error_label'] ) ) |
||
| 111 | ); |
||
| 112 | } |
||
| 113 | |||
| 116 |
