WPCOM_JSON_API_Date - Code Metrics - Inspection of "Add back in wrap_post function" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — add/sal-post ( 4a4572 )

unknown

created 2016-04-08 17:12 UTC

WPCOM_JSON_API_Date A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	53
Duplicated Lines	81.13 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	8
c	1
b	0
f	0
lcom	0
cbo	0
dl	43
loc	53
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
C	format_date()	43	43	8

How to fix Duplicated Code

<?php

class WPCOM_JSON_API_Date {
	/**
	 * Returns ISO 8601 formatted datetime: 2011-12-08T01:15:36-08:00
	 *
	 * @param $date_gmt (string) GMT datetime string.
	 * @param $date (string) Optional.  Used to calculate the offset from GMT.
	 *
	 * @return string
	 */
	static function format_date( $date_gmt, $date = null ) {
		$timestamp_gmt = strtotime( "$date_gmt+0000" );

		if ( null === $date ) {
			$timestamp = $timestamp_gmt;
			$hours     = $minutes = $west = 0;
		} else {
			$date_time = date_create( "$date+0000" );
			if ( $date_time ) {
				$timestamp = date_format( $date_time, 'U' );
			} else {
				$timestamp = 0;
			}

			// "0000-00-00 00:00:00" == -62169984000
			if ( - 62169984000 == $timestamp_gmt ) {
				// WordPress sets post_date=now, post_date_gmt="0000-00-00 00:00:00" for all drafts
				// WordPress sets post_modified=now, post_modified_gmt="0000-00-00 00:00:00" for new drafts

				// Try to guess the correct offset from the blog's options.
				$timezone_string = get_option( 'timezone_string' );

				if ( $timezone_string && $date_time ) {
					$timezone = timezone_open( $timezone_string );
					if ( $timezone ) {
						$offset = $timezone->getOffset( $date_time );
					}
				} else {
					$offset = 3600 * get_option( 'gmt_offset' );
				}
			} else {
				$offset = $timestamp - $timestamp_gmt;
			}

			$west   = $offset < 0;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			$offset = abs( $offset );
			$hours  = (int) floor( $offset / 3600 );
			$offset -= $hours * 3600;
			$minutes = (int) floor( $offset / 60 );
		}

		return (string) gmdate( 'Y-m-d\\TH:i:s', $timestamp ) . sprintf( '%s%02d:%02d', $west ? '-' : '+', $hours, $minutes );
	}
}

1		<?php
2
3		class WPCOM_JSON_API_Date {
4		/**
5		* Returns ISO 8601 formatted datetime: 2011-12-08T01:15:36-08:00
6		*
7		* @param $date_gmt (string) GMT datetime string.
8		* @param $date (string) Optional. Used to calculate the offset from GMT.
9		*
10		* @return string
11		*/
12	View Code Duplication	static function format_date( $date_gmt, $date = null ) {
13		$timestamp_gmt = strtotime( "$date_gmt+0000" );
14
15		if ( null === $date ) {
16		$timestamp = $timestamp_gmt;
17		$hours = $minutes = $west = 0;
18		} else {
19		$date_time = date_create( "$date+0000" );
20		if ( $date_time ) {
21		$timestamp = date_format( $date_time, 'U' );
22		} else {
23		$timestamp = 0;
24		}
25
26		// "0000-00-00 00:00:00" == -62169984000
27		if ( - 62169984000 == $timestamp_gmt ) {
28		// WordPress sets post_date=now, post_date_gmt="0000-00-00 00:00:00" for all drafts
29		// WordPress sets post_modified=now, post_modified_gmt="0000-00-00 00:00:00" for new drafts
30
31		// Try to guess the correct offset from the blog's options.
32		$timezone_string = get_option( 'timezone_string' );
33
34		if ( $timezone_string && $date_time ) {
35		$timezone = timezone_open( $timezone_string );
36		if ( $timezone ) {
37		$offset = $timezone->getOffset( $date_time );
38		}
39		} else {
40		$offset = 3600 * get_option( 'gmt_offset' );
41		}
42		} else {
43		$offset = $timestamp - $timestamp_gmt;
44		}
45
46		$west = $offset < 0;
		0 ignored issues – show Bug introduced 2016-04-08 16:10 UTC by Report Bug Copy Issue Report The variable `$offset` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
47		$offset = abs( $offset );
48		$hours = (int) floor( $offset / 3600 );
49		$offset -= $hours * 3600;
50		$minutes = (int) floor( $offset / 60 );
51		}
52
53		return (string) gmdate( 'Y-m-d\\TH:i:s', $timestamp ) . sprintf( '%s%02d:%02d', $west ? '-' : '+', $hours, $minutes );
54		}
55		}

Automattic / jetpack

Push — add/sal-post ( 4a4572 )

WPCOM_JSON_API_Date A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like