Automattic /
jetpack
| Conditions | 64 |
| Paths | > 20000 |
| Total Lines | 193 |
| Lines | 14 |
| Ratio | 7.25 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 174 | function youtube_id( $url ) { |
||
| 175 | $id = jetpack_get_youtube_id( $url ); |
||
| 176 | |||
| 177 | if ( ! $id ) { |
||
| 178 | return '<!--YouTube Error: bad URL entered-->'; |
||
| 179 | } |
||
| 180 | |||
| 181 | $url = youtube_sanitize_url( $url ); |
||
| 182 | $url = wp_parse_url( $url ); |
||
| 183 | |||
| 184 | $qargs = array(); |
||
| 185 | if ( ! empty( $url['query'] ) ) { |
||
| 186 | wp_parse_str( $url['query'], $qargs ); |
||
| 187 | } else { |
||
| 188 | return false; |
||
| 189 | } |
||
| 190 | |||
| 191 | $fargs = array(); |
||
| 192 | if ( ! empty( $url['fragment'] ) ) { |
||
| 193 | wp_parse_str( $url['fragment'], $fargs ); |
||
| 194 | } |
||
| 195 | |||
| 196 | $qargs = array_merge( $fargs, $qargs ); |
||
| 197 | |||
| 198 | // calculate the width and height, taking content_width into consideration. |
||
| 199 | global $content_width; |
||
| 200 | |||
| 201 | $input_w = ( isset( $qargs['w'] ) && intval( $qargs['w'] ) ) ? intval( $qargs['w'] ) : 0; |
||
| 202 | $input_h = ( isset( $qargs['h'] ) && intval( $qargs['h'] ) ) ? intval( $qargs['h'] ) : 0; |
||
| 203 | |||
| 204 | // If we have $content_width, use it. |
||
| 205 | if ( ! empty( $content_width ) ) { |
||
| 206 | $default_width = $content_width; |
||
| 207 | } else { |
||
| 208 | // Otherwise get default width from the old, now deprecated embed_size_w option. |
||
| 209 | $default_width = get_option( 'embed_size_w' ); |
||
| 210 | } |
||
| 211 | |||
| 212 | // If we don't know those 2 values use a hardcoded width. |
||
| 213 | if ( empty( $default_width ) ) { |
||
| 214 | $default_width = 640; |
||
| 215 | } |
||
| 216 | |||
| 217 | if ( $input_w > 0 && $input_h > 0 ) { |
||
| 218 | $w = $input_w; |
||
| 219 | $h = $input_h; |
||
| 220 | } elseif ( 0 === $input_w && 0 === $input_h ) { |
||
| 221 | View Code Duplication | if ( isset( $qargs['fmt'] ) && intval( $qargs['fmt'] ) ) { |
|
| 222 | $w = ( ! empty( $content_width ) ? min( $content_width, 480 ) : 480 ); |
||
| 223 | } else { |
||
| 224 | $w = ( ! empty( $content_width ) ? min( $content_width, $default_width ) : $default_width ); |
||
| 225 | $h = ceil( ( $w / 16 ) * 9 ); |
||
| 226 | } |
||
| 227 | } elseif ( $input_w > 0 ) { |
||
| 228 | $w = $input_w; |
||
| 229 | $h = ceil( ( $w / 16 ) * 9 ); |
||
| 230 | View Code Duplication | } else { |
|
| 231 | if ( isset( $qargs['fmt'] ) && intval( $qargs['fmt'] ) ) { |
||
| 232 | $w = ( ! empty( $content_width ) ? min( $content_width, 480 ) : 480 ); |
||
| 233 | } else { |
||
| 234 | $w = ( ! empty( $content_width ) ? min( $content_width, $default_width ) : $default_width ); |
||
| 235 | $h = $input_h; |
||
| 236 | } |
||
| 237 | } |
||
| 238 | |||
| 239 | /** |
||
| 240 | * Filter the YouTube player width. |
||
| 241 | * |
||
| 242 | * @module shortcodes |
||
| 243 | * |
||
| 244 | * @since 1.1.0 |
||
| 245 | * |
||
| 246 | * @param int $w Width of the YouTube player in pixels. |
||
| 247 | */ |
||
| 248 | $w = (int) apply_filters( 'youtube_width', $w ); |
||
| 249 | |||
| 250 | /** |
||
| 251 | * Filter the YouTube player height. |
||
| 252 | * |
||
| 253 | * @module shortcodes |
||
| 254 | * |
||
| 255 | * @since 1.1.0 |
||
| 256 | * |
||
| 257 | * @param int $h Height of the YouTube player in pixels. |
||
| 258 | */ |
||
| 259 | $h = (int) apply_filters( 'youtube_height', $h ); |
||
| 260 | |||
| 261 | $rel = ( isset( $qargs['rel'] ) && '0' === $qargs['rel'] ) ? 0 : 1; |
||
| 262 | $search = ( isset( $qargs['showsearch'] ) && '1' === $qargs['showsearch'] ) ? 1 : 0; |
||
| 263 | $info = ( isset( $qargs['showinfo'] ) && '0' === $qargs['showinfo'] ) ? 0 : 1; |
||
| 264 | $iv = ( isset( $qargs['iv_load_policy'] ) && '3' === $qargs['iv_load_policy'] ) ? 3 : 1; |
||
| 265 | |||
| 266 | $fmt = ( isset( $qargs['fmt'] ) && intval( $qargs['fmt'] ) ) ? '&fmt=' . (int) $qargs['fmt'] : ''; |
||
| 267 | |||
| 268 | if ( ! isset( $qargs['autohide'] ) || ( $qargs['autohide'] < 0 || 2 < $qargs['autohide'] ) ) { |
||
| 269 | $autohide = '&autohide=2'; |
||
| 270 | } else { |
||
| 271 | $autohide = '&autohide=' . absint( $qargs['autohide'] ); |
||
| 272 | } |
||
| 273 | |||
| 274 | $start = 0; |
||
| 275 | if ( isset( $qargs['start'] ) ) { |
||
| 276 | $start = intval( $qargs['start'] ); |
||
| 277 | } elseif ( isset( $qargs['t'] ) ) { |
||
| 278 | $time_pieces = preg_split( '/(?<=\D)(?=\d+)/', $qargs['t'] ); |
||
| 279 | |||
| 280 | foreach ( $time_pieces as $time_piece ) { |
||
| 281 | $int = (int) $time_piece; |
||
| 282 | switch ( substr( $time_piece, -1 ) ) { |
||
| 283 | case 'h': |
||
| 284 | $start += $int * 3600; |
||
| 285 | break; |
||
| 286 | case 'm': |
||
| 287 | $start += $int * 60; |
||
| 288 | break; |
||
| 289 | case 's': |
||
| 290 | $start += $int; |
||
| 291 | break; |
||
| 292 | } |
||
| 293 | } |
||
| 294 | } |
||
| 295 | |||
| 296 | $start = $start ? '&start=' . $start : ''; |
||
| 297 | $end = ( isset( $qargs['end'] ) && intval( $qargs['end'] ) ) ? '&end=' . (int) $qargs['end'] : ''; |
||
| 298 | $hd = ( isset( $qargs['hd'] ) && intval( $qargs['hd'] ) ) ? '&hd=' . (int) $qargs['hd'] : ''; |
||
| 299 | |||
| 300 | $vq = ( isset( $qargs['vq'] ) && in_array( $qargs['vq'], array( 'hd720', 'hd1080' ), true ) ) ? '&vq=' . $qargs['vq'] : ''; |
||
| 301 | |||
| 302 | $cc = ( isset( $qargs['cc_load_policy'] ) ) ? '&cc_load_policy=1' : ''; |
||
| 303 | $cc_lang = ( isset( $qargs['cc_lang_pref'] ) ) ? '&cc_lang_pref=' . preg_replace( '/[^_a-z0-9-]/i', '', $qargs['cc_lang_pref'] ) : ''; |
||
| 304 | |||
| 305 | $wmode = ( isset( $qargs['wmode'] ) && in_array( strtolower( $qargs['wmode'] ), array( 'opaque', 'window', 'transparent' ), true ) ) ? $qargs['wmode'] : 'transparent'; |
||
| 306 | |||
| 307 | $theme = ( isset( $qargs['theme'] ) && in_array( strtolower( $qargs['theme'] ), array( 'dark', 'light' ), true ) ) ? '&theme=' . $qargs['theme'] : ''; |
||
| 308 | |||
| 309 | $autoplay = ''; |
||
| 310 | /** |
||
| 311 | * Allow YouTube videos to start playing automatically. |
||
| 312 | * |
||
| 313 | * @module shortcodes |
||
| 314 | * |
||
| 315 | * @since 2.2.2 |
||
| 316 | * |
||
| 317 | * @param bool false Enable autoplay for YouTube videos. |
||
| 318 | */ |
||
| 319 | if ( apply_filters( 'jetpack_youtube_allow_autoplay', false ) && isset( $qargs['autoplay'] ) ) { |
||
| 320 | $autoplay = '&autoplay=' . (int) $qargs['autoplay']; |
||
| 321 | } |
||
| 322 | |||
| 323 | if ( |
||
| 324 | ( isset( $url['path'] ) && '/videoseries' === $url['path'] ) |
||
| 325 | || isset( $qargs['list'] ) |
||
| 326 | ) { |
||
| 327 | $html = "<iframe class='youtube-player' type='text/html' width='$w' height='$h' src='" . esc_url( "https://www.youtube.com/embed/videoseries?list=$id&hl=en_US" ) . "' allowfullscreen='true' style='border:0;'></iframe>"; |
||
| 328 | } else { |
||
| 329 | $html = "<iframe class='youtube-player' type='text/html' width='$w' height='$h' src='" . esc_url( "https://www.youtube.com/embed/$id?version=3&rel=$rel&fs=1$fmt$autohide&showsearch=$search&showinfo=$info&iv_load_policy=$iv$start$end$hd&wmode=$wmode$theme$autoplay$vq{$cc}{$cc_lang}" ) . "' allowfullscreen='true' style='border:0;'></iframe>"; |
||
| 330 | } |
||
| 331 | |||
| 332 | // Let's do some alignment wonder in a span, unless we're producing a feed. |
||
| 333 | if ( ! is_feed() ) { |
||
| 334 | $alignmentcss = 'text-align:center;'; |
||
| 335 | if ( isset( $qargs['align'] ) ) { |
||
| 336 | switch ( $qargs['align'] ) { |
||
| 337 | case 'left': |
||
| 338 | $alignmentcss = "float:left; width:{$w}px; height:{$h}px; margin-right:10px; margin-bottom: 10px;"; |
||
| 339 | break; |
||
| 340 | case 'right': |
||
| 341 | $alignmentcss = "float:right; width:{$w}px; height:{$h}px; margin-left:10px; margin-bottom: 10px;"; |
||
| 342 | break; |
||
| 343 | } |
||
| 344 | } |
||
| 345 | |||
| 346 | $html = sprintf( |
||
| 347 | '<span class="embed-youtube" style="%s display: block;">%s</span>', |
||
| 348 | esc_attr( $alignmentcss ), |
||
| 349 | $html |
||
| 350 | ); |
||
| 351 | |||
| 352 | } |
||
| 353 | |||
| 354 | /** |
||
| 355 | * Filter the YouTube video HTML output. |
||
| 356 | * |
||
| 357 | * @module shortcodes |
||
| 358 | * |
||
| 359 | * @since 1.2.3 |
||
| 360 | * |
||
| 361 | * @param string $html YouTube video HTML output. |
||
| 362 | */ |
||
| 363 | $html = apply_filters( 'video_embed_html', $html ); |
||
| 364 | |||
| 365 | return $html; |
||
| 366 | } |
||
| 367 | |||
| 434 |
Loading history...
This check looks for functions that have already been defined in other files.
Some Codebases, like WordPress, make a practice of defining functions multiple times. This may lead to problems with the detection of function parameters and types. If you really need to do this, you can mark the duplicate definition with the
@ignoreannotation.See also the PhpDoc documentation for @ignore.