Jetpack_Sync_Settings::get_setting() - Code Metrics - Inspection of "Updated tests and sync-setting fixes" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — add/whitelist-post_meta_and_co... ( 684fcf...dca051 )

unknown

created 2016-10-10 21:57 UTC

Jetpack_Sync_Settings::get_setting() D

↳ Parent: Jetpack_Sync_Settings

Complexity

Conditions	10
Paths	50

Size

Total Lines	45
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	10
eloc	30
nc	50
nop	1
dl	0
loc	45
rs	4.8196
c	0
b	0
f	0

How to fix Complexity

<?php

require_once dirname( __FILE__ ) . '/class.jetpack-sync-defaults.php';

class Jetpack_Sync_Settings {
	const SETTINGS_OPTION_PREFIX = 'jetpack_sync_settings_';

	static $valid_settings = array(
class A {
    var $property;
}
		'dequeue_max_bytes'    => true,
		'upload_max_bytes'     => true,
		'upload_max_rows'      => true,
		'sync_wait_time'       => true,
		'sync_wait_threshold'  => true,
		'max_queue_size'       => true,
		'max_queue_lag'        => true,
		'queue_max_writes_sec' => true,
		'post_types_blacklist' => true,
		'disable'              => true,
		'render_filtered_content' => true,
		'post_meta_whitelist' => true,
		'comment_meta_whitelist' => true,
	);

	static $is_importing;
class A {
    var $property;
}
	static $is_doing_cron;
class A {
    var $property;
}
	static $is_syncing;
class A {
    var $property;
}
	static $is_sending;
class A {
    var $property;
}

	static $settings_cache = array(); // some settings can be expensive to compute - let's cache them
class A {
    var $property;
}

	static function get_settings() {
		$settings = array();
		foreach ( array_keys( self::$valid_settings ) as $setting ) {
			$settings[ $setting ] = self::get_setting( $setting );
		}

		return $settings;
	}

	// Fetches the setting. It saves it if the setting doesn't exist, so that it gets
	// autoloaded on page load rather than re-queried every time.
	static function get_setting( $setting ) {
		if ( ! isset( self::$valid_settings[ $setting ] ) ) {
			return false;
		}

		if ( isset( self::$settings_cache[ $setting ] ) ) {
			return self::$settings_cache[ $setting ];
		}

		$value = get_option( self::SETTINGS_OPTION_PREFIX . $setting );

		if ( false === $value ) {
			$default_name = "default_$setting"; // e.g. default_dequeue_max_bytes
			$value        = Jetpack_Sync_Defaults::$$default_name;
			update_option( self::SETTINGS_OPTION_PREFIX . $setting, $value, true );
		}

		if ( is_numeric( $value ) ) {
			$value = intval( $value );
		}
		$default_array_value = null;
		switch( $setting ) {
			case 'post_types_blacklist':
				$default_array_value = Jetpack_Sync_Defaults::$blacklisted_post_types;

				break;
			case 'post_meta_whitelist':
				$default_array_value = Jetpack_Sync_Defaults::$post_meta_whitelist;

				break;
			case 'comment_meta_whitelist':
				$default_array_value = Jetpack_Sync_Defaults::$comment_meta_whitelist;

				break;
		}

		if ( $default_array_value ) {
			if ( is_array( $value ) ) {
				$value = array_unique( array_merge( $value, $default_array_value ) );
			} else {
				$value = $default_array_value;
			}
		}

		self::$settings_cache[ $setting ] = $value;

		return $value;
	}

	static function update_settings( $new_settings ) {
		$validated_settings = array_intersect_key( $new_settings, self::$valid_settings );
		foreach ( $validated_settings as $setting => $value ) {
			update_option( self::SETTINGS_OPTION_PREFIX . $setting, $value, true );
			unset( self::$settings_cache[ $setting ] );

			// if we set the disabled option to true, clear the queues
			if ( 'disable' === $setting && !! $value ) {
				require_once dirname( __FILE__ ) . '/class.jetpack-sync-listener.php';
				$listener = Jetpack_Sync_Listener::get_instance();
				$listener->get_sync_queue()->reset();
				$listener->get_full_sync_queue()->reset();
			}
		}
	}

	// returns escapted SQL that can be injected into a WHERE clause
	static function get_blacklisted_post_types_sql() {
		return 'post_type NOT IN (\'' . join( '\', \'', array_map( 'esc_sql', self::get_setting( 'post_types_blacklist' ) ) ) . '\')';
	}

	static function reset_data() {
		$valid_settings       = self::$valid_settings;
		self::$settings_cache = array();
		foreach ( $valid_settings as $option => $value ) {
			delete_option( self::SETTINGS_OPTION_PREFIX . $option );
		}
		self::set_importing( null );
		self::set_doing_cron( null );
		self::set_is_syncing( null );
		self::set_is_sending( null );
	}

	static function set_importing( $is_importing ) {
		// set to NULL to revert to WP_IMPORTING, the standard behaviour
		self::$is_importing = $is_importing;
	}

	static function is_importing() {
		if ( ! is_null( self::$is_importing ) ) {
			return self::$is_importing;
		}

		return defined( 'WP_IMPORTING' ) && WP_IMPORTING;
	}

	static function set_doing_cron( $is_doing_cron ) {
		// set to NULL to revert to WP_IMPORTING, the standard behaviour
		self::$is_doing_cron = $is_doing_cron;
	}

	static function is_doing_cron() {
		if ( ! is_null( self::$is_doing_cron ) ) {
			return self::$is_doing_cron;
		}

		return defined( 'DOING_CRON' ) && DOING_CRON;
	}

	static function is_syncing() {
		return (bool) self::$is_syncing;
	}

	static function set_is_syncing( $is_syncing ) {
		self::$is_syncing = $is_syncing;
	}

	static function is_sending() {
		return (bool) self::$is_sending;
	}

	static function set_is_sending( $is_sending ) {
		self::$is_sending = $is_sending;
	}
}


1			<?php
2
3			require_once dirname( __FILE__ ) . '/class.jetpack-sync-defaults.php';
4
5			class Jetpack_Sync_Settings {
6			const SETTINGS_OPTION_PREFIX = 'jetpack_sync_settings_';
7
8			static $valid_settings = array(
			0 ignored issues – show Coding Style introduced 2016-06-30 21:02 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$valid_settings`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
9			'dequeue_max_bytes' => true,
10			'upload_max_bytes' => true,
11			'upload_max_rows' => true,
12			'sync_wait_time' => true,
13			'sync_wait_threshold' => true,
14			'max_queue_size' => true,
15			'max_queue_lag' => true,
16			'queue_max_writes_sec' => true,
17			'post_types_blacklist' => true,
18			'disable' => true,
19			'render_filtered_content' => true,
20			'post_meta_whitelist' => true,
21			'comment_meta_whitelist' => true,
22			);
23
24			static $is_importing;
			0 ignored issues – show Coding Style introduced 2016-08-01 20:51 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$is_importing`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
25			static $is_doing_cron;
			0 ignored issues – show Coding Style introduced 2016-08-10 03:00 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$is_doing_cron`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
26			static $is_syncing;
			0 ignored issues – show Coding Style introduced 2016-10-04 18:38 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$is_syncing`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
27			static $is_sending;
			0 ignored issues – show Coding Style introduced 2016-10-05 21:54 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$is_sending`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
28
29			static $settings_cache = array(); // some settings can be expensive to compute - let's cache them
			0 ignored issues – show Coding Style introduced 2016-08-12 18:29 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$settings_cache`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
30
31			static function get_settings() {
32			$settings = array();
33			foreach ( array_keys( self::$valid_settings ) as $setting ) {
34			$settings[ $setting ] = self::get_setting( $setting );
35			}
36
37			return $settings;
38			}
39
40			// Fetches the setting. It saves it if the setting doesn't exist, so that it gets
41			// autoloaded on page load rather than re-queried every time.
42			static function get_setting( $setting ) {
43			if ( ! isset( self::$valid_settings[ $setting ] ) ) {
44			return false;
45			}
46
47			if ( isset( self::$settings_cache[ $setting ] ) ) {
48			return self::$settings_cache[ $setting ];
49			}
50
51			$value = get_option( self::SETTINGS_OPTION_PREFIX . $setting );
52
53			if ( false === $value ) {
54			$default_name = "default_$setting"; // e.g. default_dequeue_max_bytes
55			$value = Jetpack_Sync_Defaults::$$default_name;
56			update_option( self::SETTINGS_OPTION_PREFIX . $setting, $value, true );
57			}
58
59			if ( is_numeric( $value ) ) {
60			$value = intval( $value );
61			}
62			$default_array_value = null;
63			switch( $setting ) {
64			case 'post_types_blacklist':
65			$default_array_value = Jetpack_Sync_Defaults::$blacklisted_post_types;
			0 ignored issues – show Bug introduced 2016-08-12 17:30 UTC by Report Bug Copy Issue Report The property `blacklisted_post_types` cannot be accessed from this context as it is declared `private` in class `Jetpack_Sync_Defaults`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
66			break;
67			case 'post_meta_whitelist':
68			$default_array_value = Jetpack_Sync_Defaults::$post_meta_whitelist;
			0 ignored issues – show Bug introduced 2016-10-10 22:06 UTC by Report Bug Copy Issue Report The property `post_meta_whitelist` cannot be accessed from this context as it is declared `private` in class `Jetpack_Sync_Defaults`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
69			break;
70			case 'comment_meta_whitelist':
71			$default_array_value = Jetpack_Sync_Defaults::$comment_meta_whitelist;
			0 ignored issues – show Bug introduced 2016-10-10 22:06 UTC by Report Bug Copy Issue Report The property `comment_meta_whitelist` cannot be accessed from this context as it is declared `private` in class `Jetpack_Sync_Defaults`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
72			break;
73			}
74
75			if ( $default_array_value ) {
76			if ( is_array( $value ) ) {
77			$value = array_unique( array_merge( $value, $default_array_value ) );
78			} else {
79			$value = $default_array_value;
80			}
81			}
82
83			self::$settings_cache[ $setting ] = $value;
84
85			return $value;
86			}
87
88			static function update_settings( $new_settings ) {
89			$validated_settings = array_intersect_key( $new_settings, self::$valid_settings );
90			foreach ( $validated_settings as $setting => $value ) {
91			update_option( self::SETTINGS_OPTION_PREFIX . $setting, $value, true );
92			unset( self::$settings_cache[ $setting ] );
93
94			// if we set the disabled option to true, clear the queues
95			if ( 'disable' === $setting && !! $value ) {
96			require_once dirname( __FILE__ ) . '/class.jetpack-sync-listener.php';
97			$listener = Jetpack_Sync_Listener::get_instance();
98			$listener->get_sync_queue()->reset();
99			$listener->get_full_sync_queue()->reset();
100			}
101			}
102			}
103
104			// returns escapted SQL that can be injected into a WHERE clause
105			static function get_blacklisted_post_types_sql() {
106			return 'post_type NOT IN (\'' . join( '\', \'', array_map( 'esc_sql', self::get_setting( 'post_types_blacklist' ) ) ) . '\')';
107			}
108
109			static function reset_data() {
110			$valid_settings = self::$valid_settings;
111			self::$settings_cache = array();
112			foreach ( $valid_settings as $option => $value ) {
113			delete_option( self::SETTINGS_OPTION_PREFIX . $option );
114			}
115			self::set_importing( null );
116			self::set_doing_cron( null );
117			self::set_is_syncing( null );
118			self::set_is_sending( null );
119			}
120
121			static function set_importing( $is_importing ) {
122			// set to NULL to revert to WP_IMPORTING, the standard behaviour
123			self::$is_importing = $is_importing;
124			}
125
126			static function is_importing() {
127			if ( ! is_null( self::$is_importing ) ) {
128			return self::$is_importing;
129			}
130
131			return defined( 'WP_IMPORTING' ) && WP_IMPORTING;
132			}
133
134			static function set_doing_cron( $is_doing_cron ) {
135			// set to NULL to revert to WP_IMPORTING, the standard behaviour
136			self::$is_doing_cron = $is_doing_cron;
137			}
138
139			static function is_doing_cron() {
140			if ( ! is_null( self::$is_doing_cron ) ) {
141			return self::$is_doing_cron;
142			}
143
144			return defined( 'DOING_CRON' ) && DOING_CRON;
145			}
146
147			static function is_syncing() {
148			return (bool) self::$is_syncing;
149			}
150
151			static function set_is_syncing( $is_syncing ) {
152			self::$is_syncing = $is_syncing;
153			}
154
155			static function is_sending() {
156			return (bool) self::$is_sending;
157			}
158
159			static function set_is_sending( $is_sending ) {
160			self::$is_sending = $is_sending;
161			}
162			}
163

Automattic / jetpack

Push — add/whitelist-post_meta_and_co... ( 684fcf...dca051 )

Jetpack_Sync_Settings::get_setting() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like