shortcodes.php ➔ jetpack_shortcode_get_videopress_id() - Code Metrics - Inspection of "Fix to allow videopress shortcode, as well as wpvi..." - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — better/video-og ( 32617c...ceeb43 )

unknown

created 2016-11-04 01:21 UTC

shortcodes.php ➔ jetpack_shortcode_get_videopress_id() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php

/**
 * Module Name: Shortcode Embeds
 * Module Description: Embed media from popular sites without any coding.
 * Sort Order: 3
 * First Introduced: 1.1
 * Major Changes In: 1.2
 * Requires Connection: No
 * Auto Activate: Yes
 * Module Tags: Photos and Videos, Social, Writing, Appearance
 * Feature: Writing
 * Additional Search Queries: shortcodes, shortcode, embeds, media, bandcamp, blip.tv, dailymotion, facebook, flickr, google calendars, google maps, google+, polldaddy, recipe, recipes, scribd, slideshare, slideshow, slideshows, soundcloud, ted, twitter, vimeo, vine, youtube
 */

/**
 * Transforms the $atts array into a string that the old functions expected
 *
 * The old way was:
 * [shortcode a=1&b=2&c=3] or [shortcode=1]
 * This is parsed as array( a => '1&b=2&c=3' ) and array( 0 => '=1' ), which is useless
 *
 * @param Array $params
 * @param Bool $old_format_support true if [shortcode=foo] format is possible.
 * @return String $params
 */
function shortcode_new_to_old_params( $params, $old_format_support = false ) {
	$str = '';

	if ( $old_format_support && isset( $params[0] ) ) {
		$str = ltrim( $params[0], '=' );
	} elseif ( is_array( $params ) ) {
		foreach ( array_keys( $params ) as $key ) {
			if ( ! is_numeric( $key ) )
				$str = $key . '=' . $params[$key];
		}
	}

	return str_replace( array( '&amp;', '&#038;' ), '&', $str );
}

function jetpack_load_shortcodes() {
	$shortcode_includes = array();

	foreach ( Jetpack::glob_php( dirname( __FILE__ ) . '/shortcodes' ) as $file ) {
		$filename = substr( basename( $file ), 0, -4 );

		$shortcode_includes[ $filename ] = $file;
	}

/**
 * This filter allows other plugins to override which shortcodes Jetpack loads.
 *
 * @module shortcodes
 *
 * @since 2.2.1
 * @since 4.2.0 Added filename without extension as array key.
 *
 * @param array $shortcode_includes An array of which shortcodes to include.
 */
	$shortcode_includes = apply_filters( 'jetpack_shortcodes_to_include', $shortcode_includes );

	foreach ( $shortcode_includes as $include ) {
		include $include;
	}
}

/**
 * Runs preg_replace so that replacements don't happen within open tags.
 * Parameters are the same as preg_replace, with an added optional search param for improved performance
 *
 * @param String $pattern
 * @param String $replacement
 * @param String $content
 * @param String $search

 * @return String $content
 */
function jetpack_preg_replace_outside_tags( $pattern, $replacement, $content, $search = null ) {

	if( ! function_exists( 'wp_html_split' ) ) {
		return $content;
	}

	if ( $search && false === strpos( $content, $search ) ) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
		return $content;
	}

	$textarr = wp_html_split( $content );
	unset( $content );
	foreach( $textarr as &$element ) {
	    if ( '' === $element || '<' === $element{0} )
	        continue;
	    $element = preg_replace( $pattern, $replacement, $element );
	}

	return join( $textarr );
}

/**
 * Runs preg_replace_callback so that replacements don't happen within open tags.
 * Parameters are the same as preg_replace, with an added optional search param for improved performance
 *
 * @param String $pattern
 * @param String $replacement
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
 * @param String $content
 * @param String $search

 * @return String $content
 */
function jetpack_preg_replace_callback_outside_tags( $pattern, $callback, $content, $search = null ) {

	if( ! function_exists( 'wp_html_split' ) ) {
		return $content;
	}

	if ( $search && false === strpos( $content, $search ) ) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
		return $content;
	}

	$textarr = wp_html_split( $content );
	unset( $content );
	foreach( $textarr as &$element ) {
	    if ( '' === $element || '<' === $element{0} )
	        continue;
	    $element = preg_replace_callback( $pattern, $callback, $element );
	}

	return join( $textarr );
}

if ( ! function_exists( 'jetpack_shortcode_get_wpvideo_id' ) ) {
	function jetpack_shortcode_get_wpvideo_id( $atts ) {
		if ( isset( $atts[ 0 ] ) )
			return $atts[ 0 ];
		else
			return 0;
	}
}

if ( ! function_exists( 'jetpack_shortcode_get_videopress_id' ) ) {
	function jetpack_shortcode_get_videopress_id( $atts ) {
		if ( isset( $atts[ 0 ] ) )
			return $atts[ 0 ];
		else
			return 0;
	}
}

jetpack_load_shortcodes();


1		<?php
2
3		/**
4		* Module Name: Shortcode Embeds
5		* Module Description: Embed media from popular sites without any coding.
6		* Sort Order: 3
7		* First Introduced: 1.1
8		* Major Changes In: 1.2
9		* Requires Connection: No
10		* Auto Activate: Yes
11		* Module Tags: Photos and Videos, Social, Writing, Appearance
12		* Feature: Writing
13		* Additional Search Queries: shortcodes, shortcode, embeds, media, bandcamp, blip.tv, dailymotion, facebook, flickr, google calendars, google maps, google+, polldaddy, recipe, recipes, scribd, slideshare, slideshow, slideshows, soundcloud, ted, twitter, vimeo, vine, youtube
14		*/
15
16		/**
17		* Transforms the $atts array into a string that the old functions expected
18		*
19		* The old way was:
20		* [shortcode a=1&b=2&c=3] or [shortcode=1]
21		* This is parsed as array( a => '1&b=2&c=3' ) and array( 0 => '=1' ), which is useless
22		*
23		* @param Array $params
24		* @param Bool $old_format_support true if [shortcode=foo] format is possible.
25		* @return String $params
26		*/
27		function shortcode_new_to_old_params( $params, $old_format_support = false ) {
28		$str = '';
29
30		if ( $old_format_support && isset( $params[0] ) ) {
31		$str = ltrim( $params[0], '=' );
32		} elseif ( is_array( $params ) ) {
33		foreach ( array_keys( $params ) as $key ) {
34		if ( ! is_numeric( $key ) )
35		$str = $key . '=' . $params[$key];
36		}
37		}
38
39		return str_replace( array( '&', '&' ), '&', $str );
40		}
41
42		function jetpack_load_shortcodes() {
43		$shortcode_includes = array();
44
45		foreach ( Jetpack::glob_php( dirname( __FILE__ ) . '/shortcodes' ) as $file ) {
46		$filename = substr( basename( $file ), 0, -4 );
47
48		$shortcode_includes[ $filename ] = $file;
49		}
50
51		/**
52		* This filter allows other plugins to override which shortcodes Jetpack loads.
53		*
54		* @module shortcodes
55		*
56		* @since 2.2.1
57		* @since 4.2.0 Added filename without extension as array key.
58		*
59		* @param array $shortcode_includes An array of which shortcodes to include.
60		*/
61		$shortcode_includes = apply_filters( 'jetpack_shortcodes_to_include', $shortcode_includes );
62
63		foreach ( $shortcode_includes as $include ) {
64		include $include;
65		}
66		}
67
68		/**
69		* Runs preg_replace so that replacements don't happen within open tags.
70		* Parameters are the same as preg_replace, with an added optional search param for improved performance
71		*
72		* @param String $pattern
73		* @param String $replacement
74		* @param String $content
75		* @param String $search
		0 ignored issues – show Documentation introduced 2016-06-17 16:21 UTC by Report Bug Copy Issue Report Should the type for parameter `$search` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
76		* @return String $content
77		*/
78	View Code Duplication	function jetpack_preg_replace_outside_tags( $pattern, $replacement, $content, $search = null ) {
		0 ignored issues – show Duplication introduced 2016-05-27 01:47 UTC by Report Bug Copy Issue Report This function seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
79		if( ! function_exists( 'wp_html_split' ) ) {
80		return $content;
81		}
82
83		if ( $search && false === strpos( $content, $search ) ) {
		0 ignored issues – show Bug Best Practice introduced 2016-06-17 16:21 UTC by Report Bug Copy Issue Report The expression `$search` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
84		return $content;
85		}
86
87		$textarr = wp_html_split( $content );
88		unset( $content );
89		foreach( $textarr as &$element ) {
90		if ( '' === $element \|\| '<' === $element{0} )
91		continue;
92		$element = preg_replace( $pattern, $replacement, $element );
93		}
94
95		return join( $textarr );
96		}
97
98		/**
99		* Runs preg_replace_callback so that replacements don't happen within open tags.
100		* Parameters are the same as preg_replace, with an added optional search param for improved performance
101		*
102		* @param String $pattern
103		* @param String $replacement
		0 ignored issues – show Bug introduced 2016-05-27 01:47 UTC by Report Bug Copy Issue Report There is no parameter named `$replacement`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
104		* @param String $content
105		* @param String $search
		0 ignored issues – show Documentation introduced 2016-06-17 16:21 UTC by Report Bug Copy Issue Report Should the type for parameter `$search` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
106		* @return String $content
107		*/
108	View Code Duplication	function jetpack_preg_replace_callback_outside_tags( $pattern, $callback, $content, $search = null ) {
		0 ignored issues – show Duplication introduced 2016-05-27 01:47 UTC by Report Bug Copy Issue Report This function seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
109		if( ! function_exists( 'wp_html_split' ) ) {
110		return $content;
111		}
112
113		if ( $search && false === strpos( $content, $search ) ) {
		0 ignored issues – show Bug Best Practice introduced 2016-06-17 16:21 UTC by Report Bug Copy Issue Report The expression `$search` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
114		return $content;
115		}
116
117		$textarr = wp_html_split( $content );
118		unset( $content );
119		foreach( $textarr as &$element ) {
120		if ( '' === $element \|\| '<' === $element{0} )
121		continue;
122		$element = preg_replace_callback( $pattern, $callback, $element );
123		}
124
125		return join( $textarr );
126		}
127
128		if ( ! function_exists( 'jetpack_shortcode_get_wpvideo_id' ) ) {
129		function jetpack_shortcode_get_wpvideo_id( $atts ) {
130		if ( isset( $atts[ 0 ] ) )
131		return $atts[ 0 ];
132		else
133		return 0;
134		}
135		}
136
137		if ( ! function_exists( 'jetpack_shortcode_get_videopress_id' ) ) {
138		function jetpack_shortcode_get_videopress_id( $atts ) {
139		if ( isset( $atts[ 0 ] ) )
140		return $atts[ 0 ];
141		else
142		return 0;
143		}
144		}
145
146		jetpack_load_shortcodes();
147

Automattic / jetpack

Push — better/video-og ( 32617c...ceeb43 )

shortcodes.php ➔ jetpack_shortcode_get_videopress_id() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like