| Conditions | 19 |
| Paths | 114 |
| Total Lines | 101 |
| Lines | 7 |
| Ratio | 6.93 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 111 | function github_gist_shortcode( $atts, $content = '' ) { |
||
| 112 | |||
| 113 | View Code Duplication | if ( empty( $atts[0] ) && empty( $content ) ) { |
|
| 114 | if ( current_user_can( 'edit_posts' ) ) { |
||
| 115 | return esc_html__( 'Please specify a Gist URL or ID.', 'jetpack' ); |
||
| 116 | } else { |
||
| 117 | return '<!-- Missing Gist ID -->'; |
||
| 118 | } |
||
| 119 | } |
||
| 120 | |||
| 121 | $id = ( ! empty( $content ) ) ? $content : $atts[0]; |
||
| 122 | |||
| 123 | // Parse a URL to get an ID we can use. |
||
| 124 | $gist_info = jetpack_gist_get_shortcode_id( $id ); |
||
| 125 | if ( empty( $gist_info['id'] ) ) { |
||
| 126 | if ( current_user_can( 'edit_posts' ) ) { |
||
| 127 | return esc_html__( 'The Gist ID you provided is not valid. Please try a different one.', 'jetpack' ); |
||
| 128 | } else { |
||
| 129 | return '<!-- Invalid Gist ID -->'; |
||
| 130 | } |
||
| 131 | } else { |
||
| 132 | // Add trailing .json to all unique gist identifiers. |
||
| 133 | $id = $gist_info['id'] . '.json'; |
||
| 134 | } |
||
| 135 | |||
| 136 | // The file name can come from the URL passed, or from a shortcode attribute. |
||
| 137 | if ( ! empty( $gist_info['file'] ) ) { |
||
| 138 | $file = $gist_info['file']; |
||
| 139 | } elseif ( ! empty( $atts['file'] ) ) { |
||
| 140 | $file = $atts['file']; |
||
| 141 | } else { |
||
| 142 | $file = ''; |
||
| 143 | } |
||
| 144 | |||
| 145 | // Replace - by . to get a real file name from slug. |
||
| 146 | if ( ! empty( $file ) ) { |
||
| 147 | // Find the last -. |
||
| 148 | $dash_position = strrpos( $file, '-' ); |
||
| 149 | if ( false !== $dash_position ) { |
||
| 150 | // Replace the - by a period. |
||
| 151 | $file = substr_replace( $file, '.', $dash_position, 1 ); |
||
| 152 | } |
||
| 153 | |||
| 154 | $file = rawurlencode( $file ); |
||
| 155 | } |
||
| 156 | |||
| 157 | if ( |
||
| 158 | class_exists( 'Jetpack_AMP_Support' ) |
||
| 159 | && Jetpack_AMP_Support::is_amp_request() |
||
| 160 | ) { |
||
| 161 | /* |
||
| 162 | * According to <https://www.ampproject.org/docs/reference/components/amp-gist#height-(required)>: |
||
| 163 | * |
||
| 164 | * > Note: You must find the height of the gist by inspecting it with your browser (e.g., Chrome Developer Tools). |
||
| 165 | * |
||
| 166 | * However, this does not seem to be the case any longer. The actual height of the content does get set in the |
||
| 167 | * page after loading. So this is just the initial height. |
||
| 168 | * See <https://github.com/ampproject/amphtml/pull/17738>. |
||
| 169 | */ |
||
| 170 | $height = 240; |
||
| 171 | |||
| 172 | $amp_tag = sprintf( |
||
| 173 | '<amp-gist layout="fixed-height" data-gistid="%s" height="%s"', |
||
| 174 | esc_attr( basename( $id, '.json' ) ), |
||
| 175 | esc_attr( $height ) |
||
| 176 | ); |
||
| 177 | if ( ! empty( $file ) ) { |
||
| 178 | $amp_tag .= sprintf( ' data-file="%s"', esc_attr( $file ) ); |
||
| 179 | } |
||
| 180 | $amp_tag .= '></amp-gist>'; |
||
| 181 | return $amp_tag; |
||
| 182 | } |
||
| 183 | |||
| 184 | // URL points to the entire gist, including the file name if there was one. |
||
| 185 | $id = ( ! empty( $file ) ? $id . '?file=' . $file : $id ); |
||
| 186 | |||
| 187 | wp_enqueue_script( |
||
| 188 | 'jetpack-gist-embed', |
||
| 189 | Jetpack::get_file_url_for_environment( '_inc/build/shortcodes/js/gist.min.js', 'modules/shortcodes/js/gist.js' ), |
||
| 190 | array( 'jquery' ), |
||
| 191 | JETPACK__VERSION, |
||
| 192 | true |
||
| 193 | ); |
||
| 194 | |||
| 195 | // inline style to prevent the bottom margin to the embed that themes like TwentyTen, et al., add to tables. |
||
| 196 | $return = '<style>.gist table { margin-bottom: 0; }</style><div class="gist-oembed" data-gist="' . esc_attr( $id ) . '"></div>'; |
||
| 197 | |||
| 198 | if ( |
||
| 199 | // No need to check for a nonce here, that's already handled by Core further up. |
||
| 200 | // phpcs:disable WordPress.Security.NonceVerification.Missing |
||
| 201 | isset( $_POST['type'] ) |
||
| 202 | && 'embed' === $_POST['type'] |
||
| 203 | && isset( $_POST['action'] ) |
||
| 204 | && 'parse-embed' === $_POST['action'] |
||
| 205 | // phpcs:enable WordPress.Security.NonceVerification.Missing |
||
| 206 | ) { |
||
| 207 | return github_gist_simple_embed( $id ); |
||
| 208 | } |
||
| 209 | |||
| 210 | return $return; |
||
| 211 | } |
||
| 212 | |||
| 225 |