Connection_Error::__construct() - Code Metrics - Inspection of "Exploration of connection errors handling" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — add/connection-error-handling ( a8d1fc )

unknown

created 2020-06-05 18:58 UTC

Connection_Error::__construct() A

↳ Parent: Connection_Error

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	2
dl	0
loc	17
rs	9.7
c	0
b	0
f	0

<?php
/**
 * The Jetpack Connection error class file.
 *
 * @package automattic/jetpack-connection
 */

namespace Automattic\Jetpack\Connection;

/**
 * The Jetpack Connection Error class represents one Connection Error
 */
class Connection_Error extends \WP_Error {

	/**
	 * Stores the list of data for error codes.
	 *
	 * @var array
	 */
	public $error_info = array();

	public function __construct( $error_code, $data ) {

		$this->errors_handler = new Errors();
class MyClass { }

$x = new MyClass();
$x->foo = true;

		$error = $this->errors_handler->get_error( $error_code );

		parent::__construct(
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
			$error_code,
			$error['title'],
			$data
		);

		$this->error_info[ $error_code ] = $error;

		$this->errors_handler->report_error( $this );

	}

}


1			<?php
2			/**
3			* The Jetpack Connection error class file.
4			*
5			* @package automattic/jetpack-connection
6			*/
7
8			namespace Automattic\Jetpack\Connection;
9
10			/**
11			* The Jetpack Connection Error class represents one Connection Error
12			*/
13			class Connection_Error extends \WP_Error {
14
15			/**
16			* Stores the list of data for error codes.
17			*
18			* @var array
19			*/
20			public $error_info = array();
21
22			public function __construct( $error_code, $data ) {
23
24			$this->errors_handler = new Errors();
			0 ignored issues – show Bug introduced 2020-06-05 19:05 UTC by Report Bug Copy Issue Report The property `errors_handler` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25
26			$error = $this->errors_handler->get_error( $error_code );
27
28			parent::__construct(
			0 ignored issues – show Bug introduced 2020-06-05 19:05 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `WP_Error` as the method `__construct()` does only exist in the following sub-classes of `WP_Error`: `Automattic\Jetpack\Connection\Connection_Error`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
29			$error_code,
30			$error['title'],
31			$data
32			);
33
34			$this->error_info[ $error_code ] = $error;
35
36			$this->errors_handler->report_error( $this );
37
38			}
39
40			}
41

Automattic / jetpack

Push — add/connection-error-handling ( a8d1fc )

Connection_Error::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like