Urls::normalize_www_in_url() - Code Metrics - Inspection of "Verify window is defined before accessing it" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — try/add-jetpack-purchase-token ( 0a4d98...ef8438 )

unknown

created 2021-05-27 19:46 UTC

Urls::normalize_www_in_url() B

↳ Parent: Urls

Complexity

Conditions	7
Paths	17

Size

Total Lines

Duplication

Lines	8
Ratio	28.57 %

Importance

Changes

Metric	Value
cc	7
nc	17
nop	2
dl	8
loc	28
rs	8.5386
c	0
b	0
f	0

<?php
/**
 * The Jetpack Connection package Urls class file.
 *
 * @package automattic/jetpack-connection
 */

namespace Automattic\Jetpack\Connection;

use Automattic\Jetpack\Constants;

/**
 * Provides Url methods for the Connection package.
 */
class Urls {

	const HTTPS_CHECK_OPTION_PREFIX = 'jetpack_sync_https_history_';
	const HTTPS_CHECK_HISTORY       = 5;

	/**
	 * Return URL from option or PHP constant.
	 *
	 * @param string $option_name (e.g. 'home').
	 *
	 * @return mixed|null URL.
	 */
	public static function get_raw_url( $option_name ) {
		$value    = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$constant = ( 'home' === $option_name )
			? 'WP_HOME'
			: 'WP_SITEURL';

		// Since we disregard the constant for multisites in ms-default-filters.php,
		// let's also use the db value if this is a multisite.
		if ( ! is_multisite() && Constants::is_defined( $constant ) ) {
			$value = Constants::get_constant( $constant );
		} else {
			// Let's get the option from the database so that we can bypass filters. This will help
			// ensure that we get more uniform values.
			$value = \Jetpack_Options::get_raw_option( $option_name );
		}

		return $value;
	}

	/**
	 * Normalize domains by removing www unless declared in the site's option.
	 *
	 * @param string   $option Option value from the site.
	 * @param callable $url_function Function retrieving the URL to normalize.
	 * @return mixed|string URL.
	 */
	public static function normalize_www_in_url( $option, $url_function ) {
		$url        = wp_parse_url( call_user_func( $url_function ) );
		$option_url = wp_parse_url( get_option( $option ) );

		if ( ! $option_url || ! $url ) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			return $url;
		}

		if ( "www.{$option_url[ 'host' ]}" === $url['host'] ) {
			// remove www if not present in option URL.
			$url['host'] = $option_url['host'];
		}
		if ( "www.{$url[ 'host' ]}" === $option_url['host'] ) {
			// add www if present in option URL.
			$url['host'] = $option_url['host'];
		}

		$normalized_url = "{$url['scheme']}://{$url['host']}";
		if ( isset( $url['path'] ) ) {
			$normalized_url .= "{$url['path']}";
		}

		if ( isset( $url['query'] ) ) {
			$normalized_url .= "?{$url['query']}";
		}

		return $normalized_url;
	}

	/**
	 * Return URL with a normalized protocol.
	 *
	 * @param callable $callable Function to retrieve URL option.
	 * @param string   $new_value URL Protocol to set URLs to.
	 * @return string Normalized URL.
	 */
	public static function get_protocol_normalized_url( $callable, $new_value ) {
		$option_key = self::HTTPS_CHECK_OPTION_PREFIX . $callable;

		$parsed_url = wp_parse_url( $new_value );
		if ( ! $parsed_url ) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			return $new_value;
		}
		if ( array_key_exists( 'scheme', $parsed_url ) ) {
			$scheme = $parsed_url['scheme'];
		} else {
			$scheme = '';
		}
		$scheme_history   = get_option( $option_key, array() );
		$scheme_history[] = $scheme;

		// Limit length to self::HTTPS_CHECK_HISTORY.
		$scheme_history = array_slice( $scheme_history, ( self::HTTPS_CHECK_HISTORY * -1 ) );

		update_option( $option_key, $scheme_history );

		$forced_scheme = in_array( 'https', $scheme_history, true ) ? 'https' : 'http';

		return set_url_scheme( $new_value, $forced_scheme );
	}

	/**
	 * Helper function that is used when getting home or siteurl values. Decides
	 * whether to get the raw or filtered value.
	 *
	 * @param string $url_type URL to get, home or siteurl.
	 * @return string
	 */
	public static function get_raw_or_filtered_url( $url_type ) {
		$url_function = ( 'home' === $url_type )
			? 'home_url'
			: 'site_url';

		if (
			! Constants::is_defined( 'JETPACK_SYNC_USE_RAW_URL' ) ||
			Constants::get_constant( 'JETPACK_SYNC_USE_RAW_URL' )
		) {
			$scheme = is_ssl() ? 'https' : 'http';
			$url    = self::get_raw_url( $url_type );
			$url    = set_url_scheme( $url, $scheme );
		} else {
			$url = self::normalize_www_in_url( $url_type, $url_function );
		}

		return self::get_protocol_normalized_url( $url_function, $url );
	}

	/**
	 * Return the escaped home_url.
	 *
	 * @return string
	 */
	public static function home_url() {
		$url = self::get_raw_or_filtered_url( 'home' );

		/**
		 * Allows overriding of the home_url value that is synced back to WordPress.com.
		 *
		 * @since 5.2.0
		 *
		 * @param string $home_url
		 */
		return esc_url_raw( apply_filters( 'jetpack_sync_home_url', $url ) );
	}

	/**
	 * Return the escaped siteurl.
	 *
	 * @return string
	 */
	public static function site_url() {
		$url = self::get_raw_or_filtered_url( 'siteurl' );

		/**
		 * Allows overriding of the site_url value that is synced back to WordPress.com.
		 *
		 * @since 5.2.0
		 *
		 * @param string $site_url
		 */
		return esc_url_raw( apply_filters( 'jetpack_sync_site_url', $url ) );
	}

	/**
	 * Return main site URL with a normalized protocol.
	 *
	 * @return string
	 */
	public static function main_network_site_url() {
		return self::get_protocol_normalized_url( 'main_network_site_url', network_site_url() );
	}

}


1		<?php
2		/**
3		* The Jetpack Connection package Urls class file.
4		*
5		* @package automattic/jetpack-connection
6		*/
7
8		namespace Automattic\Jetpack\Connection;
9
10		use Automattic\Jetpack\Constants;
11
12		/**
13		* Provides Url methods for the Connection package.
14		*/
15		class Urls {
16
17		const HTTPS_CHECK_OPTION_PREFIX = 'jetpack_sync_https_history_';
18		const HTTPS_CHECK_HISTORY = 5;
19
20		/**
21		* Return URL from option or PHP constant.
22		*
23		* @param string $option_name (e.g. 'home').
24		*
25		* @return mixed\|null URL.
26		*/
27		public static function get_raw_url( $option_name ) {
28		$value = null;
		0 ignored issues – show Unused Code introduced 2017-07-25 00:48 UTC by Report Bug Copy Issue Report `$value` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
29		$constant = ( 'home' === $option_name )
30		? 'WP_HOME'
31		: 'WP_SITEURL';
32
33		// Since we disregard the constant for multisites in ms-default-filters.php,
34		// let's also use the db value if this is a multisite.
35		if ( ! is_multisite() && Constants::is_defined( $constant ) ) {
36		$value = Constants::get_constant( $constant );
37		} else {
38		// Let's get the option from the database so that we can bypass filters. This will help
39		// ensure that we get more uniform values.
40		$value = \Jetpack_Options::get_raw_option( $option_name );
41		}
42
43		return $value;
44		}
45
46		/**
47		* Normalize domains by removing www unless declared in the site's option.
48		*
49		* @param string $option Option value from the site.
50		* @param callable $url_function Function retrieving the URL to normalize.
51		* @return mixed\|string URL.
52		*/
53		public static function normalize_www_in_url( $option, $url_function ) {
54		$url = wp_parse_url( call_user_func( $url_function ) );
55		$option_url = wp_parse_url( get_option( $option ) );
56
57		if ( ! $option_url \|\| ! $url ) {
		0 ignored issues – show Bug Best Practice introduced 2020-10-23 20:30 UTC by Report Bug Copy Issue Report The expression `$option_url` of type `string\|false` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Bug Best Practice introduced 2020-10-23 20:30 UTC by Report Bug Copy Issue Report The expression `$url` of type `string\|false` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
58		return $url;
59		}
60
61	View Code Duplication	if ( "www.{$option_url[ 'host' ]}" === $url['host'] ) {
62		// remove www if not present in option URL.
63		$url['host'] = $option_url['host'];
64		}
65	View Code Duplication	if ( "www.{$url[ 'host' ]}" === $option_url['host'] ) {
66		// add www if present in option URL.
67		$url['host'] = $option_url['host'];
68		}
69
70		$normalized_url = "{$url['scheme']}://{$url['host']}";
71		if ( isset( $url['path'] ) ) {
72		$normalized_url .= "{$url['path']}";
73		}
74
75		if ( isset( $url['query'] ) ) {
76		$normalized_url .= "?{$url['query']}";
77		}
78
79		return $normalized_url;
80		}
81
82		/**
83		* Return URL with a normalized protocol.
84		*
85		* @param callable $callable Function to retrieve URL option.
86		* @param string $new_value URL Protocol to set URLs to.
87		* @return string Normalized URL.
88		*/
89		public static function get_protocol_normalized_url( $callable, $new_value ) {
90		$option_key = self::HTTPS_CHECK_OPTION_PREFIX . $callable;
91
92		$parsed_url = wp_parse_url( $new_value );
93		if ( ! $parsed_url ) {
		0 ignored issues – show Bug Best Practice introduced 2020-10-23 20:30 UTC by Report Bug Copy Issue Report The expression `$parsed_url` of type `string\|false` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
94		return $new_value;
95		}
96		if ( array_key_exists( 'scheme', $parsed_url ) ) {
97		$scheme = $parsed_url['scheme'];
98		} else {
99		$scheme = '';
100		}
101		$scheme_history = get_option( $option_key, array() );
102		$scheme_history[] = $scheme;
103
104		// Limit length to self::HTTPS_CHECK_HISTORY.
105		$scheme_history = array_slice( $scheme_history, ( self::HTTPS_CHECK_HISTORY * -1 ) );
106
107		update_option( $option_key, $scheme_history );
108
109		$forced_scheme = in_array( 'https', $scheme_history, true ) ? 'https' : 'http';
110
111		return set_url_scheme( $new_value, $forced_scheme );
112		}
113
114		/**
115		* Helper function that is used when getting home or siteurl values. Decides
116		* whether to get the raw or filtered value.
117		*
118		* @param string $url_type URL to get, home or siteurl.
119		* @return string
120		*/
121		public static function get_raw_or_filtered_url( $url_type ) {
122		$url_function = ( 'home' === $url_type )
123		? 'home_url'
124		: 'site_url';
125
126		if (
127		! Constants::is_defined( 'JETPACK_SYNC_USE_RAW_URL' ) \|\|
128		Constants::get_constant( 'JETPACK_SYNC_USE_RAW_URL' )
129		) {
130		$scheme = is_ssl() ? 'https' : 'http';
131		$url = self::get_raw_url( $url_type );
132		$url = set_url_scheme( $url, $scheme );
133		} else {
134		$url = self::normalize_www_in_url( $url_type, $url_function );
135		}
136
137		return self::get_protocol_normalized_url( $url_function, $url );
138		}
139
140		/**
141		* Return the escaped home_url.
142		*
143		* @return string
144		*/
145		public static function home_url() {
146		$url = self::get_raw_or_filtered_url( 'home' );
147
148		/**
149		* Allows overriding of the home_url value that is synced back to WordPress.com.
150		*
151		* @since 5.2.0
152		*
153		* @param string $home_url
154		*/
155		return esc_url_raw( apply_filters( 'jetpack_sync_home_url', $url ) );
156		}
157
158		/**
159		* Return the escaped siteurl.
160		*
161		* @return string
162		*/
163		public static function site_url() {
164		$url = self::get_raw_or_filtered_url( 'siteurl' );
165
166		/**
167		* Allows overriding of the site_url value that is synced back to WordPress.com.
168		*
169		* @since 5.2.0
170		*
171		* @param string $site_url
172		*/
173		return esc_url_raw( apply_filters( 'jetpack_sync_site_url', $url ) );
174		}
175
176		/**
177		* Return main site URL with a normalized protocol.
178		*
179		* @return string
180		*/
181		public static function main_network_site_url() {
182		return self::get_protocol_normalized_url( 'main_network_site_url', network_site_url() );
183		}
184
185		}
186

Automattic / jetpack

Push — try/add-jetpack-purchase-token ( 0a4d98...ef8438 )

Urls::normalize_www_in_url() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like