Jetpack_React_Page - Code Metrics - Inspection of "Add masterbar module to pre-commit hook" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — update/masterbar-rm-left-nav ( 7930b3...ec0ec1 )

by Jeremy

created 2019-04-15 12:00 UTC

Jetpack_React_Page B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	307
Duplicated Lines	7.49 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

Metric	Value
dl	23
loc	307
rs	8.64
c	0
b	0
f	0
wmc	47
lcom	1
cbo	8

14 Methods

Rating	Name	Duplication	Size	Complexity
A	get_page_hook()	0	4	1
A	get_external_services_connect_urls()	0	8	2
A	get_flattened_settings()	0	5	1
A	jetpack_add_dashboard_sub_nav_item()	6	8	4
A	jetpack_add_settings_sub_nav_item()	4	6	5
A	add_fallback_head_meta()	0	3	1
A	add_noscript_head_meta()	0	5	1
A	jetpack_menu_order()	13	13	4
A	add_page_actions()	0	21	4
A	page_render()	0	20	2
A	get_dismissed_jetpack_notices()	0	12	1
A	additional_styles()	0	3	1
A	page_admin_scripts()	0	23	4
F	get_initial_state()	0	131	16

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Jetpack_React_Page often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Jetpack_React_Page, and based on these observations, apply Extract Interface, too.

<?php
include_once( 'class.jetpack-admin-page.php' );

// Builds the landing page and its menu
class Jetpack_React_Page extends Jetpack_Admin_Page {

	protected $dont_show_if_not_active = false;

	protected $is_redirecting = false;

	function get_page_hook() {
		// Add the main admin Jetpack menu
		return add_menu_page( 'Jetpack', 'Jetpack', 'jetpack_admin_page', 'jetpack', array( $this, 'render' ), 'div' );
	}

	function add_page_actions( $hook ) {
		/** This action is documented in class.jetpack.php */
		do_action( 'jetpack_admin_menu', $hook );

		// Place the Jetpack menu item on top and others in the order they appear
		add_filter( 'custom_menu_order',         '__return_true' );
		add_filter( 'menu_order',                array( $this, 'jetpack_menu_order' ) );

		if ( ! isset( $_GET['page'] ) || 'jetpack' !== $_GET['page'] ) {
			return; // No need to handle the fallback redirection if we are not on the Jetpack page
		}

		// Adding a redirect meta tag if the REST API is disabled
		if ( ! $this->is_rest_api_enabled() ) {
			$this->is_redirecting = true;
			add_action( 'admin_head', array( $this, 'add_fallback_head_meta' ) );
		}

		// Adding a redirect meta tag wrapped in noscript tags for all browsers in case they have JavaScript disabled
		add_action( 'admin_head', array( $this, 'add_noscript_head_meta' ) );
	}

	/**
	 * Add Jetpack Dashboard sub-link and point it to AAG if the user can view stats, manage modules or if Protect is active.
	 *
	 * Works in Dev Mode or when user is connected.
	 *
	 * @since 4.3.0
	 */
	function jetpack_add_dashboard_sub_nav_item() {
		if ( Jetpack::is_development_mode() || Jetpack::is_active() ) {
			global $submenu;
			if ( current_user_can( 'jetpack_admin_page' ) ) {
				$submenu['jetpack'][] = array( __( 'Dashboard', 'jetpack' ), 'jetpack_admin_page', 'admin.php?page=jetpack#/dashboard' );
			}
		}
	}

	/**
	 * If user is allowed to see the Jetpack Admin, add Settings sub-link.
	 *
	 * @since 4.3.0
	 */
	function jetpack_add_settings_sub_nav_item() {
		if ( ( Jetpack::is_development_mode() || Jetpack::is_active() ) && current_user_can( 'jetpack_admin_page' ) && current_user_can( 'edit_posts' ) ) {
			global $submenu;
			$submenu['jetpack'][] = array( __( 'Settings', 'jetpack' ), 'jetpack_admin_page', 'admin.php?page=jetpack#/settings' );
		}
	}

	function add_fallback_head_meta() {
		echo '<meta http-equiv="refresh" content="0; url=?page=jetpack_modules">';
	}

	function add_noscript_head_meta() {
		echo '<noscript>';
		$this->add_fallback_head_meta();
		echo '</noscript>';
	}

	function jetpack_menu_order( $menu_order ) {
		$jp_menu_order = array();

		foreach ( $menu_order as $index => $item ) {
			if ( $item != 'jetpack' )
				$jp_menu_order[] = $item;

			if ( $index == 0 )
				$jp_menu_order[] = 'jetpack';
		}

		return $jp_menu_order;
	}

	function page_render() {
		/** This action is already documented in views/admin/admin-page.php */
		do_action( 'jetpack_notices' );

		// Try fetching by patch
		$static_html = @file_get_contents( JETPACK__PLUGIN_DIR . '_inc/build/static.html' );

		if ( false === $static_html ) {

			// If we still have nothing, display an error
			echo '<p>';
			esc_html_e( 'Error fetching static.html. Try running: ', 'jetpack' );
			echo '<code>yarn distclean && yarn build</code>';
			echo '</p>';
		} else {

			// We got the static.html so let's display it
			echo $static_html;
		}
	}

	/**
	 * Gets array of any Jetpack notices that have been dismissed.
	 *
	 * @since 4.0.1
	 * @return mixed|void
	 */
	function get_dismissed_jetpack_notices() {
		$jetpack_dismissed_notices = get_option( 'jetpack_dismissed_notices', array() );
		/**
		 * Array of notices that have been dismissed.
		 *
		 * @since 4.0.1
		 *
		 * @param array $jetpack_dismissed_notices If empty, will not show any Jetpack notices.
		 */
		$dismissed_notices = apply_filters( 'jetpack_dismissed_notices', $jetpack_dismissed_notices );
		return $dismissed_notices;
	}

	function additional_styles() {
		Jetpack_Admin_Page::load_wrapper_styles();
	}

	function page_admin_scripts() {
		if ( $this->is_redirecting ) {
			return; // No need for scripts on a fallback page
		}

		wp_enqueue_script(
			'react-plugin',
			plugins_url( '_inc/build/admin.js', JETPACK__PLUGIN_FILE ),
			array( 'wp-i18n', 'wp-polyfill' ),
			JETPACK__VERSION,
			true
		);

		wp_set_script_translations( 'react-plugin', 'jetpack', JETPACK__PLUGIN_DIR . 'languages/json' );

		if ( ! Jetpack::is_development_mode() && Jetpack::is_active() ) {
			// Required for Analytics.
			wp_enqueue_script( 'jp-tracks', '//stats.wp.com/w.js', array(), gmdate( 'YW' ), true );
		}

		// Add objects to be passed to the initial state of the app.
		wp_localize_script( 'react-plugin', 'Initial_State', $this->get_initial_state() );
	}

	function get_initial_state() {
		// Load API endpoint base classes and endpoints for getting the module list fed into the JS Admin Page
		require_once JETPACK__PLUGIN_DIR . '_inc/lib/core-api/class.jetpack-core-api-xmlrpc-consumer-endpoint.php';
		require_once JETPACK__PLUGIN_DIR . '_inc/lib/core-api/class.jetpack-core-api-module-endpoints.php';
		$moduleListEndpoint = new Jetpack_Core_API_Module_List_Endpoint();
		$modules = $moduleListEndpoint->get_modules();

		// Preparing translated fields for JSON encoding by transforming all HTML entities to
		// respective characters.
		foreach( $modules as $slug => $data ) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
			$modules[ $slug ]['name'] = html_entity_decode( $data['name'] );
			$modules[ $slug ]['description'] = html_entity_decode( $data['description'] );
			$modules[ $slug ]['short_description'] = html_entity_decode( $data['short_description'] );
			$modules[ $slug ]['long_description'] = html_entity_decode( $data['long_description'] );
		}

		// Collecting roles that can view site stats.
		$stats_roles = array();
		$enabled_roles = function_exists( 'stats_get_option' ) ? stats_get_option( 'roles' ) : array( 'administrator' );

		if ( ! function_exists( 'get_editable_roles' ) ) {
			require_once ABSPATH . 'wp-admin/includes/user.php';
		}
		foreach ( get_editable_roles() as $slug => $role ) {
			$stats_roles[ $slug ] = array(
				'name' => translate_user_role( $role['name'] ),
				'canView' => is_array( $enabled_roles ) ? in_array( $slug, $enabled_roles, true ) : false,
			);
		}

		// Get information about current theme.
		$current_theme = wp_get_theme();

		// Get all themes that Infinite Scroll provides support for natively.
		$inf_scr_support_themes = array();
		foreach ( Jetpack::glob_php( JETPACK__PLUGIN_DIR . 'modules/infinite-scroll/themes' ) as $path ) {
			if ( is_readable( $path ) ) {
				$inf_scr_support_themes[] = basename( $path, '.php' );
			}
		}

		// Get last post, to build the link to Customizer in the Related Posts module.
		$last_post = get_posts( array( 'posts_per_page' => 1 ) );
		$last_post = isset( $last_post[0] ) && $last_post[0] instanceof WP_Post
if ($x instanceof DoesNotExist) {
    // Do something.
}
			? get_permalink( $last_post[0]->ID )
			: get_home_url();

		// Ensure that class to get the affiliate code is loaded
		if ( ! class_exists( 'Jetpack_Affiliate' ) ) {
			require_once JETPACK__PLUGIN_DIR . 'class.jetpack-affiliate.php';
		}

		return array(
			'WP_API_root' => esc_url_raw( rest_url() ),
			'WP_API_nonce' => wp_create_nonce( 'wp_rest' ),
			'pluginBaseUrl' => plugins_url( '', JETPACK__PLUGIN_FILE ),
			'connectionStatus' => array(
				'isActive'  => Jetpack::is_active(),
				'isStaging' => Jetpack::is_staging_site(),
				'devMode'   => array(
					'isActive' => Jetpack::is_development_mode(),
					'constant' => defined( 'JETPACK_DEV_DEBUG' ) && JETPACK_DEV_DEBUG,
					'url'      => site_url() && false === strpos( site_url(), '.' ),
					'filter'   => apply_filters( 'jetpack_development_mode', false ),
				),
				'isPublic'	=> '1' == get_option( 'blog_public' ),
				'isInIdentityCrisis' => Jetpack::validate_sync_error_idc_option(),
				'sandboxDomain' => JETPACK__SANDBOX_DOMAIN,
			),
			'connectUrl' => Jetpack::init()->build_connect_url( true, false, false ),
			'dismissedNotices' => $this->get_dismissed_jetpack_notices(),
			'isDevVersion' => Jetpack::is_development_version(),
			'currentVersion' => JETPACK__VERSION,
			'is_gutenberg_available' => true,
			'getModules' => $modules,
			'showJumpstart' => jetpack_show_jumpstart(),
			'rawUrl' => Jetpack::build_raw_urls( get_home_url() ),
			'adminUrl' => esc_url( admin_url() ),
			'stats' => array(
				// data is populated asynchronously on page load
				'data'  => array(
					'general' => false,
					'day'     => false,
					'week'    => false,
					'month'   => false,
				),
				'roles' => $stats_roles,
			),
			'aff' => Jetpack_Affiliate::init()->get_affiliate_code(),
			'settings' => $this->get_flattened_settings( $modules ),
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			'userData' => array(
//				'othersLinked' => Jetpack::get_other_linked_admins(),
				'currentUser'  => jetpack_current_user_data(),
			),
			'siteData' => array(
				'icon' => has_site_icon()
					? apply_filters( 'jetpack_photon_url', get_site_icon_url(), array( 'w' => 64 ) )
					: '',
				'siteVisibleToSearchEngines' => '1' == get_option( 'blog_public' ),
				/**
				 * Whether promotions are visible or not.
				 *
				 * @since 4.8.0
				 *
				 * @param bool $are_promotions_active Status of promotions visibility. True by default.
				 */
				'showPromotions' => apply_filters( 'jetpack_show_promotions', true ),
				'isAtomicSite' => jetpack_is_atomic_site(),
				'plan' => Jetpack_Plan::get(),
				'showBackups' => Jetpack::show_backups_ui(),
			),
			'themeData' => array(
				'name'      => $current_theme->get( 'Name' ),
				'hasUpdate' => (bool) get_theme_update_available( $current_theme ),
				'support'   => array(
					'infinite-scroll' => current_theme_supports( 'infinite-scroll' ) || in_array( $current_theme->get_stylesheet(), $inf_scr_support_themes ),
				),
			),
			'locale' => Jetpack::get_i18n_data_json(),
			'localeSlug' => join( '-', explode( '_', get_user_locale() ) ),
			'jetpackStateNotices' => array(
				'messageCode' => Jetpack::state( 'message' ),
				'errorCode' => Jetpack::state( 'error' ),
				'errorDescription' => Jetpack::state( 'error_description' ),
			),
			'tracksUserData' => Jetpack_Tracks_Client::get_connected_user_tracks_identity(),
			'currentIp' => function_exists( 'jetpack_protect_get_ip' ) ? jetpack_protect_get_ip() : false,
			'lastPostUrl' => esc_url( $last_post ),
			'externalServicesConnectUrls' => $this->get_external_services_connect_urls()
		);
	}

	function get_external_services_connect_urls() {
		$connect_urls = array();
		jetpack_require_lib( 'class.jetpack-keyring-service-helper' );
		foreach ( Jetpack_Keyring_Service_Helper::$SERVICES as $service_name => $service_info ) {
			$connect_urls[ $service_name ] = Jetpack_Keyring_Service_Helper::connect_url( $service_name, $service_info[ 'for' ] );
		}
		return $connect_urls;
	}

	/**
	 * Returns an array of modules and settings both as first class members of the object.
	 *
	 * @param array $modules the result of an API request to get all modules.
	 *
	 * @return array flattened settings with modules.
	 */
	function get_flattened_settings( $modules ) {
		$core_api_endpoint = new Jetpack_Core_API_Data();
		$settings = $core_api_endpoint->get_all_options();
		return $settings->data;
	}
}

/*
 * Only show Jump Start on first activation.
 * Any option 'jumpstart' other than 'new connection' will hide it.
 *
 * The option can be of 4 things, and will be stored as such:
 * new_connection      : Brand new connection - Show
 * jumpstart_activated : Jump Start has been activated - dismiss
 * jetpack_action_taken: Manual activation of a module already happened - dismiss
 * jumpstart_dismissed : Manual dismissal of Jump Start - dismiss
 *
 * @todo move to functions.global.php when available
 * @since 3.6
 * @return bool | show or hide
 */
function jetpack_show_jumpstart() {
	if ( ! Jetpack::is_active() ) {
		return false;
	}
	$jumpstart_option = Jetpack_Options::get_option( 'jumpstart' );

	$hide_options = array(
		'jumpstart_activated',
		'jetpack_action_taken',
		'jumpstart_dismissed'
	);

	if ( ! $jumpstart_option || in_array( $jumpstart_option, $hide_options ) ) {
		return false;
	}

	return true;
}

/**
 * Gather data about the current user.
 *
 * @since 4.1.0
 *
 * @return array
 */
function jetpack_current_user_data() {
	$current_user = wp_get_current_user();
	$is_master_user = $current_user->ID == Jetpack_Options::get_option( 'master_user' );
	$dotcom_data    = Jetpack::get_connected_user_data();
	// Add connected user gravatar to the returned dotcom_data.
	$dotcom_data['avatar'] = get_avatar_url( $dotcom_data['email'], array( 'size' => 64, 'default' => 'mysteryman' ) );

	$current_user_data = array(
		'isConnected' => Jetpack::is_user_connected( $current_user->ID ),
		'isMaster'    => $is_master_user,
		'username'    => $current_user->user_login,
		'id'          => $current_user->ID,
		'wpcomUser'   => $dotcom_data,
		'gravatar'    => get_avatar( $current_user->ID, 40, 'mm', '', array( 'force_display' => true ) ),
		'permissions' => array(
			'admin_page'         => current_user_can( 'jetpack_admin_page' ),
			'connect'            => current_user_can( 'jetpack_connect' ),
			'disconnect'         => current_user_can( 'jetpack_disconnect' ),
			'manage_modules'     => current_user_can( 'jetpack_manage_modules' ),
			'network_admin'      => current_user_can( 'jetpack_network_admin_page' ),
			'network_sites_page' => current_user_can( 'jetpack_network_sites_page' ),
			'edit_posts'         => current_user_can( 'edit_posts' ),
			'publish_posts'      => current_user_can( 'publish_posts' ),
			'manage_options'     => current_user_can( 'manage_options' ),
			'view_stats'		 => current_user_can( 'view_stats' ),
			'manage_plugins'	 => current_user_can( 'install_plugins' )
									&& current_user_can( 'activate_plugins' )
									&& current_user_can( 'update_plugins' )
									&& current_user_can( 'delete_plugins' ),
		),
	);

	return $current_user_data;
}


Push — update/masterbar-rm-left-nav ( 7930b3...ec0ec1 )

Jetpack_React_Page B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

1. Missing dependencies

2. Missing use statement

1		<?php
2		include_once( 'class.jetpack-admin-page.php' );
3
4		// Builds the landing page and its menu
5		class Jetpack_React_Page extends Jetpack_Admin_Page {
6
7		protected $dont_show_if_not_active = false;
8
9		protected $is_redirecting = false;
10
11		function get_page_hook() {
12		// Add the main admin Jetpack menu
13		return add_menu_page( 'Jetpack', 'Jetpack', 'jetpack_admin_page', 'jetpack', array( $this, 'render' ), 'div' );
14		}
15
16		function add_page_actions( $hook ) {
17		/** This action is documented in class.jetpack.php */
18		do_action( 'jetpack_admin_menu', $hook );
19
20		// Place the Jetpack menu item on top and others in the order they appear
21		add_filter( 'custom_menu_order', '__return_true' );
22		add_filter( 'menu_order', array( $this, 'jetpack_menu_order' ) );
23
24		if ( ! isset( $_GET['page'] ) \|\| 'jetpack' !== $_GET['page'] ) {
25		return; // No need to handle the fallback redirection if we are not on the Jetpack page
26		}
27
28		// Adding a redirect meta tag if the REST API is disabled
29		if ( ! $this->is_rest_api_enabled() ) {
30		$this->is_redirecting = true;
31		add_action( 'admin_head', array( $this, 'add_fallback_head_meta' ) );
32		}
33
34		// Adding a redirect meta tag wrapped in noscript tags for all browsers in case they have JavaScript disabled
35		add_action( 'admin_head', array( $this, 'add_noscript_head_meta' ) );
36		}
37
38		/**
39		* Add Jetpack Dashboard sub-link and point it to AAG if the user can view stats, manage modules or if Protect is active.
40		*
41		* Works in Dev Mode or when user is connected.
42		*
43		* @since 4.3.0
44		*/
45		function jetpack_add_dashboard_sub_nav_item() {
46	View Code Duplication	if ( Jetpack::is_development_mode() \|\| Jetpack::is_active() ) {
47		global $submenu;
48		if ( current_user_can( 'jetpack_admin_page' ) ) {
49		$submenu['jetpack'][] = array( __( 'Dashboard', 'jetpack' ), 'jetpack_admin_page', 'admin.php?page=jetpack#/dashboard' );
50		}
51		}
52		}
53
54		/**
55		* If user is allowed to see the Jetpack Admin, add Settings sub-link.
56		*
57		* @since 4.3.0
58		*/
59		function jetpack_add_settings_sub_nav_item() {
60	View Code Duplication	if ( ( Jetpack::is_development_mode() \|\| Jetpack::is_active() ) && current_user_can( 'jetpack_admin_page' ) && current_user_can( 'edit_posts' ) ) {
61		global $submenu;
62		$submenu['jetpack'][] = array( __( 'Settings', 'jetpack' ), 'jetpack_admin_page', 'admin.php?page=jetpack#/settings' );
63		}
64		}
65
66		function add_fallback_head_meta() {
67		echo '<meta http-equiv="refresh" content="0; url=?page=jetpack_modules">';
68		}
69
70		function add_noscript_head_meta() {
71		echo '<noscript>';
72		$this->add_fallback_head_meta();
73		echo '</noscript>';
74		}
75
76	View Code Duplication	function jetpack_menu_order( $menu_order ) {
77		$jp_menu_order = array();
78
79		foreach ( $menu_order as $index => $item ) {
80		if ( $item != 'jetpack' )
81		$jp_menu_order[] = $item;
82
83		if ( $index == 0 )
84		$jp_menu_order[] = 'jetpack';
85		}
86
87		return $jp_menu_order;
88		}
89
90		function page_render() {
91		/** This action is already documented in views/admin/admin-page.php */
92		do_action( 'jetpack_notices' );
93
94		// Try fetching by patch
95		$static_html = @file_get_contents( JETPACK__PLUGIN_DIR . '_inc/build/static.html' );
96
97		if ( false === $static_html ) {
98
99		// If we still have nothing, display an error
100		echo '<p>';
101		esc_html_e( 'Error fetching static.html. Try running: ', 'jetpack' );
102		echo '<code>yarn distclean && yarn build</code>';
103		echo '</p>';
104		} else {
105
106		// We got the static.html so let's display it
107		echo $static_html;
108		}
109		}
110
111		/**
112		* Gets array of any Jetpack notices that have been dismissed.
113		*
114		* @since 4.0.1
115		* @return mixed\|void
116		*/
117		function get_dismissed_jetpack_notices() {
118		$jetpack_dismissed_notices = get_option( 'jetpack_dismissed_notices', array() );
119		/**
120		* Array of notices that have been dismissed.
121		*
122		* @since 4.0.1
123		*
124		* @param array $jetpack_dismissed_notices If empty, will not show any Jetpack notices.
125		*/
126		$dismissed_notices = apply_filters( 'jetpack_dismissed_notices', $jetpack_dismissed_notices );
127		return $dismissed_notices;
128		}
129
130		function additional_styles() {
131		Jetpack_Admin_Page::load_wrapper_styles();
132		}
133
134		function page_admin_scripts() {
135		if ( $this->is_redirecting ) {
136		return; // No need for scripts on a fallback page
137		}
138
139		wp_enqueue_script(
140		'react-plugin',
141		plugins_url( '_inc/build/admin.js', JETPACK__PLUGIN_FILE ),
142		array( 'wp-i18n', 'wp-polyfill' ),
143		JETPACK__VERSION,
144		true
145		);
146
147		wp_set_script_translations( 'react-plugin', 'jetpack', JETPACK__PLUGIN_DIR . 'languages/json' );
148
149		if ( ! Jetpack::is_development_mode() && Jetpack::is_active() ) {
150		// Required for Analytics.
151		wp_enqueue_script( 'jp-tracks', '//stats.wp.com/w.js', array(), gmdate( 'YW' ), true );
152		}
153
154		// Add objects to be passed to the initial state of the app.
155		wp_localize_script( 'react-plugin', 'Initial_State', $this->get_initial_state() );
156		}
157
158		function get_initial_state() {
159		// Load API endpoint base classes and endpoints for getting the module list fed into the JS Admin Page
160		require_once JETPACK__PLUGIN_DIR . '_inc/lib/core-api/class.jetpack-core-api-xmlrpc-consumer-endpoint.php';
161		require_once JETPACK__PLUGIN_DIR . '_inc/lib/core-api/class.jetpack-core-api-module-endpoints.php';
162		$moduleListEndpoint = new Jetpack_Core_API_Module_List_Endpoint();
163		$modules = $moduleListEndpoint->get_modules();
164
165		// Preparing translated fields for JSON encoding by transforming all HTML entities to
166		// respective characters.
167		foreach( $modules as $slug => $data ) {
		0 ignored issues – show Bug introduced 2017-10-06 18:49 UTC by Report Bug Copy Issue Report The expression `$modules` of type `string\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
168		$modules[ $slug ]['name'] = html_entity_decode( $data['name'] );
169		$modules[ $slug ]['description'] = html_entity_decode( $data['description'] );
170		$modules[ $slug ]['short_description'] = html_entity_decode( $data['short_description'] );
171		$modules[ $slug ]['long_description'] = html_entity_decode( $data['long_description'] );
172		}
173
174		// Collecting roles that can view site stats.
175		$stats_roles = array();
176		$enabled_roles = function_exists( 'stats_get_option' ) ? stats_get_option( 'roles' ) : array( 'administrator' );
177
178		if ( ! function_exists( 'get_editable_roles' ) ) {
179		require_once ABSPATH . 'wp-admin/includes/user.php';
180		}
181		foreach ( get_editable_roles() as $slug => $role ) {
182		$stats_roles[ $slug ] = array(
183		'name' => translate_user_role( $role['name'] ),
184		'canView' => is_array( $enabled_roles ) ? in_array( $slug, $enabled_roles, true ) : false,
185		);
186		}
187
188		// Get information about current theme.
189		$current_theme = wp_get_theme();
190
191		// Get all themes that Infinite Scroll provides support for natively.
192		$inf_scr_support_themes = array();
193		foreach ( Jetpack::glob_php( JETPACK__PLUGIN_DIR . 'modules/infinite-scroll/themes' ) as $path ) {
194		if ( is_readable( $path ) ) {
195		$inf_scr_support_themes[] = basename( $path, '.php' );
196		}
197		}
198
199		// Get last post, to build the link to Customizer in the Related Posts module.
200		$last_post = get_posts( array( 'posts_per_page' => 1 ) );
201		$last_post = isset( $last_post[0] ) && $last_post[0] instanceof WP_Post
		0 ignored issues – show Bug introduced 2016-09-19 18:57 UTC by Report Bug Copy Issue Report The class `WP_Post` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
202		? get_permalink( $last_post[0]->ID )
203		: get_home_url();
204
205		// Ensure that class to get the affiliate code is loaded
206		if ( ! class_exists( 'Jetpack_Affiliate' ) ) {
207		require_once JETPACK__PLUGIN_DIR . 'class.jetpack-affiliate.php';
208		}
209
210		return array(
211		'WP_API_root' => esc_url_raw( rest_url() ),
212		'WP_API_nonce' => wp_create_nonce( 'wp_rest' ),
213		'pluginBaseUrl' => plugins_url( '', JETPACK__PLUGIN_FILE ),
214		'connectionStatus' => array(
215		'isActive' => Jetpack::is_active(),
216		'isStaging' => Jetpack::is_staging_site(),
217		'devMode' => array(
218		'isActive' => Jetpack::is_development_mode(),
219		'constant' => defined( 'JETPACK_DEV_DEBUG' ) && JETPACK_DEV_DEBUG,
220		'url' => site_url() && false === strpos( site_url(), '.' ),
221		'filter' => apply_filters( 'jetpack_development_mode', false ),
222		),
223		'isPublic' => '1' == get_option( 'blog_public' ),
224		'isInIdentityCrisis' => Jetpack::validate_sync_error_idc_option(),
225		'sandboxDomain' => JETPACK__SANDBOX_DOMAIN,
226		),
227		'connectUrl' => Jetpack::init()->build_connect_url( true, false, false ),
228		'dismissedNotices' => $this->get_dismissed_jetpack_notices(),
229		'isDevVersion' => Jetpack::is_development_version(),
230		'currentVersion' => JETPACK__VERSION,
231		'is_gutenberg_available' => true,
232		'getModules' => $modules,
233		'showJumpstart' => jetpack_show_jumpstart(),
234		'rawUrl' => Jetpack::build_raw_urls( get_home_url() ),
235		'adminUrl' => esc_url( admin_url() ),
236		'stats' => array(
237		// data is populated asynchronously on page load
238		'data' => array(
239		'general' => false,
240		'day' => false,
241		'week' => false,
242		'month' => false,
243		),
244		'roles' => $stats_roles,
245		),
246		'aff' => Jetpack_Affiliate::init()->get_affiliate_code(),
247		'settings' => $this->get_flattened_settings( $modules ),
		0 ignored issues – show Bug introduced 2017-10-06 18:49 UTC by Report Bug Copy Issue Report It seems like `$modules` defined by `$moduleListEndpoint->get_modules()` on line `163` can also be of type `string`; however, `Jetpack_React_Page::get_flattened_settings()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
248		'userData' => array(
249		// 'othersLinked' => Jetpack::get_other_linked_admins(),
250		'currentUser' => jetpack_current_user_data(),
251		),
252		'siteData' => array(
253		'icon' => has_site_icon()
254		? apply_filters( 'jetpack_photon_url', get_site_icon_url(), array( 'w' => 64 ) )
255		: '',
256		'siteVisibleToSearchEngines' => '1' == get_option( 'blog_public' ),
257		/**
258		* Whether promotions are visible or not.
259		*
260		* @since 4.8.0
261		*
262		* @param bool $are_promotions_active Status of promotions visibility. True by default.
263		*/
264		'showPromotions' => apply_filters( 'jetpack_show_promotions', true ),
265		'isAtomicSite' => jetpack_is_atomic_site(),
266		'plan' => Jetpack_Plan::get(),
267		'showBackups' => Jetpack::show_backups_ui(),
268		),
269		'themeData' => array(
270		'name' => $current_theme->get( 'Name' ),
271		'hasUpdate' => (bool) get_theme_update_available( $current_theme ),
272		'support' => array(
273		'infinite-scroll' => current_theme_supports( 'infinite-scroll' ) \|\| in_array( $current_theme->get_stylesheet(), $inf_scr_support_themes ),
274		),
275		),
276		'locale' => Jetpack::get_i18n_data_json(),
277		'localeSlug' => join( '-', explode( '_', get_user_locale() ) ),
278		'jetpackStateNotices' => array(
279		'messageCode' => Jetpack::state( 'message' ),
280		'errorCode' => Jetpack::state( 'error' ),
281		'errorDescription' => Jetpack::state( 'error_description' ),
282		),
283		'tracksUserData' => Jetpack_Tracks_Client::get_connected_user_tracks_identity(),
284		'currentIp' => function_exists( 'jetpack_protect_get_ip' ) ? jetpack_protect_get_ip() : false,
285		'lastPostUrl' => esc_url( $last_post ),
286		'externalServicesConnectUrls' => $this->get_external_services_connect_urls()
287		);
288		}
289
290		function get_external_services_connect_urls() {
291		$connect_urls = array();
292		jetpack_require_lib( 'class.jetpack-keyring-service-helper' );
293		foreach ( Jetpack_Keyring_Service_Helper::$SERVICES as $service_name => $service_info ) {
294		$connect_urls[ $service_name ] = Jetpack_Keyring_Service_Helper::connect_url( $service_name, $service_info[ 'for' ] );
295		}
296		return $connect_urls;
297		}
298
299		/**
300		* Returns an array of modules and settings both as first class members of the object.
301		*
302		* @param array $modules the result of an API request to get all modules.
303		*
304		* @return array flattened settings with modules.
305		*/
306		function get_flattened_settings( $modules ) {
307		$core_api_endpoint = new Jetpack_Core_API_Data();
308		$settings = $core_api_endpoint->get_all_options();
309		return $settings->data;
310		}
311		}
312
313		/*
314		* Only show Jump Start on first activation.
315		* Any option 'jumpstart' other than 'new connection' will hide it.
316		*
317		* The option can be of 4 things, and will be stored as such:
318		* new_connection : Brand new connection - Show
319		* jumpstart_activated : Jump Start has been activated - dismiss
320		* jetpack_action_taken: Manual activation of a module already happened - dismiss
321		* jumpstart_dismissed : Manual dismissal of Jump Start - dismiss
322		*
323		* @todo move to functions.global.php when available
324		* @since 3.6
325		* @return bool \| show or hide
326		*/
327		function jetpack_show_jumpstart() {
328		if ( ! Jetpack::is_active() ) {
329		return false;
330		}
331		$jumpstart_option = Jetpack_Options::get_option( 'jumpstart' );
332
333		$hide_options = array(
334		'jumpstart_activated',
335		'jetpack_action_taken',
336		'jumpstart_dismissed'
337		);
338
339		if ( ! $jumpstart_option \|\| in_array( $jumpstart_option, $hide_options ) ) {
340		return false;
341		}
342
343		return true;
344		}
345
346		/**
347		* Gather data about the current user.
348		*
349		* @since 4.1.0
350		*
351		* @return array
352		*/
353		function jetpack_current_user_data() {
354		$current_user = wp_get_current_user();
355		$is_master_user = $current_user->ID == Jetpack_Options::get_option( 'master_user' );
356		$dotcom_data = Jetpack::get_connected_user_data();
357		// Add connected user gravatar to the returned dotcom_data.
358		$dotcom_data['avatar'] = get_avatar_url( $dotcom_data['email'], array( 'size' => 64, 'default' => 'mysteryman' ) );
359
360		$current_user_data = array(
361		'isConnected' => Jetpack::is_user_connected( $current_user->ID ),
362		'isMaster' => $is_master_user,
363		'username' => $current_user->user_login,
364		'id' => $current_user->ID,
365		'wpcomUser' => $dotcom_data,
366		'gravatar' => get_avatar( $current_user->ID, 40, 'mm', '', array( 'force_display' => true ) ),
367		'permissions' => array(
368		'admin_page' => current_user_can( 'jetpack_admin_page' ),
369		'connect' => current_user_can( 'jetpack_connect' ),
370		'disconnect' => current_user_can( 'jetpack_disconnect' ),
371		'manage_modules' => current_user_can( 'jetpack_manage_modules' ),
372		'network_admin' => current_user_can( 'jetpack_network_admin_page' ),
373		'network_sites_page' => current_user_can( 'jetpack_network_sites_page' ),
374		'edit_posts' => current_user_can( 'edit_posts' ),
375		'publish_posts' => current_user_can( 'publish_posts' ),
376		'manage_options' => current_user_can( 'manage_options' ),
377		'view_stats' => current_user_can( 'view_stats' ),
378		'manage_plugins' => current_user_can( 'install_plugins' )
379		&& current_user_can( 'activate_plugins' )
380		&& current_user_can( 'update_plugins' )
381		&& current_user_can( 'delete_plugins' ),
382		),
383		);
384
385		return $current_user_data;
386		}
387

Automattic / jetpack

Push — update/masterbar-rm-left-nav ( 7930b3...ec0ec1 )

Jetpack_React_Page B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like