Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 13 | class Health { |
||
| 14 | |||
| 15 | /** |
||
| 16 | * Prefix of the blog lock transient. |
||
| 17 | * |
||
| 18 | * @access public |
||
| 19 | * |
||
| 20 | * @var string |
||
| 21 | */ |
||
| 22 | const STATUS_OPTION = 'sync_health_status'; |
||
| 23 | |||
| 24 | /** |
||
| 25 | * Status key in option array. |
||
| 26 | * |
||
| 27 | * @access public |
||
| 28 | * |
||
| 29 | * @var string |
||
| 30 | */ |
||
| 31 | const OPTION_STATUS_KEY = 'status'; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * Timestamp key in option array. |
||
| 35 | * |
||
| 36 | * @access public |
||
| 37 | * |
||
| 38 | * @var string |
||
| 39 | */ |
||
| 40 | const OPTION_TIMESTAMP_KEY = 'timestamp'; |
||
| 41 | |||
| 42 | /** |
||
| 43 | * Unknown status code. |
||
| 44 | * |
||
| 45 | * @access public |
||
| 46 | * |
||
| 47 | * @var string |
||
| 48 | */ |
||
| 49 | const STATUS_UNKNOWN = 'unknown'; |
||
| 50 | |||
| 51 | /** |
||
| 52 | * Disabled status code. |
||
| 53 | * |
||
| 54 | * @access public |
||
| 55 | * |
||
| 56 | * @var string |
||
| 57 | */ |
||
| 58 | const STATUS_DISABLED = 'disabled'; |
||
| 59 | |||
| 60 | /** |
||
| 61 | * Out of sync status code. |
||
| 62 | * |
||
| 63 | * @access public |
||
| 64 | * |
||
| 65 | * @var string |
||
| 66 | */ |
||
| 67 | const STATUS_OUT_OF_SYNC = 'out_of_sync'; |
||
| 68 | |||
| 69 | /** |
||
| 70 | * In sync status code. |
||
| 71 | * |
||
| 72 | * @access public |
||
| 73 | * |
||
| 74 | * @var string |
||
| 75 | */ |
||
| 76 | const STATUS_IN_SYNC = 'in_sync'; |
||
| 77 | |||
| 78 | /** |
||
| 79 | * If sync is active, Health-related hooks will be initialized after plugins are loaded. |
||
| 80 | */ |
||
| 81 | public static function init() { |
||
| 84 | |||
| 85 | /** |
||
| 86 | * Gets health status code. |
||
| 87 | * |
||
| 88 | * @return string Sync Health Status |
||
| 89 | */ |
||
| 90 | public static function get_status() { |
||
| 107 | |||
| 108 | /** |
||
| 109 | * When the Jetpack plugin is upgraded, set status to disabled if sync is not enabled, |
||
| 110 | * or to unknown, if the status has never been set before. |
||
| 111 | */ |
||
| 112 | public static function on_jetpack_upgraded() { |
||
| 121 | |||
| 122 | /** |
||
| 123 | * When the Jetpack plugin is activated, set status to disabled if sync is not enabled, |
||
| 124 | * or to unknown. |
||
| 125 | */ |
||
| 126 | public static function on_jetpack_activated() { |
||
| 133 | |||
| 134 | /** |
||
| 135 | * Updates sync health status with either a valid status, or an unknown status. |
||
| 136 | * |
||
| 137 | * @param string $status Sync Status. |
||
| 138 | * |
||
| 139 | * @return bool True if an update occoured, or false if the status didn't change. |
||
| 140 | */ |
||
| 141 | public static function update_status( $status ) { |
||
| 162 | |||
| 163 | /** |
||
| 164 | * Check if Status has been previously set. |
||
| 165 | * |
||
| 166 | * @return bool is a Status defined |
||
| 167 | */ |
||
| 168 | public static function is_status_defined() { |
||
| 177 | |||
| 178 | /** |
||
| 179 | * Update Sync Status if Full Sync ended of Posts |
||
| 180 | * |
||
| 181 | * @param string $checksum The checksum that's currently being processed. |
||
| 182 | * @param array $range The ranges of object types being processed. |
||
| 183 | */ |
||
| 184 | public static function full_sync_end_update_status( $checksum, $range ) { |
||
| 189 | |||
| 190 | } |
||
| 191 |