WC_Stats::track() - Code Metrics - Inspection of "moved return parse into try" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — try/tracks-store-stats ( 87fce4...010ef0 )

unknown

created 2017-11-16 07:32 UTC

WC_Stats::track() A

↳ Parent: WC_Stats

Complexity

Conditions	3
Paths	3

Size

Total Lines	58
Code Lines	48

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	48
nc	3
nop	0
dl	0
loc	58
rs	9.639
c	0
b	0
f	0

How to fix Long Method

<?php

if ( ! defined( 'ABSPATH' ) ) {
	exit;
}

class WC_Stats {
	/**
	 * @var Jetpack
	 **/
	private $jetpack;

	/**
	 * @var WC_Stats
	 **/
	private static $instance = null;

	static function init() {
		// Tracking only Site pages
		if ( is_admin() ) {
			return;
		}
		// Make sure Jetpack is installed and active
		if ( ! Jetpack::is_active() ) {
			return;
		}
		// Make sure WooCommerce is installed and active
		if ( ! in_array( 'woocommerce/woocommerce.php', apply_filters( 'active_plugins', get_option( 'active_plugins' ) ) ) ) {
			return;
		}
		if ( is_null( self::$instance ) ) {
			self::$instance = new WC_Stats();
		}
		return self::$instance;
	}

	public function __construct() {
		$this->jetpack = Jetpack::init();

		add_action( 'wp_enqueue_scripts', array( $this, 'track' ) );
		add_action( 'rest_api_init', function() {
			register_rest_route( 'jetpack/v4', '/tracks', array(
				'methods' => 'POST',
				'callback' => array( $this, 'handle_client_tracks' ),
			) );
		} );
	}

	public function handle_client_tracks( $request ) {
		return json_encode( $request->get_params() );
	}

	public function get_cart_ids( $item ) {
		return $item[ 'product_id' ];
	}

	public function get_cart_quantities( $item ) {
		return $item[ 'quantity' ];
	}

	public function get_uncachable_page_type( $post_id ) {

		switch ( $post_id ) {
			case get_option( 'woocommerce_cart_page_id' ):
				return 'cart_view';
			case get_option( 'woocommerce_checkout_page_id' ):
				global $wp;
				if ( strpos( $wp->request, 'order-received' ) !== false ) {
					return 'checkout_complete';
				}
				return 'checkout_view';
			case get_option( 'woocommerce_view_order_page_id' ):
				return 'view_order';
			default:
				null;
		}
	}

	public function track() {
		$cart = WC()->cart->get_cart();
		$cart_ids = array_map( array( $this, 'get_cart_ids' ), $cart );
		$cart_quantities = array_map( array( $this, 'get_cart_quantities' ), $cart );
		// Is this the right id? Is WooCommerce id different?
		$store_id = Jetpack::get_option( 'id' );
		$post = get_post();
		$post_id = $post->ID;
		$post_type = get_post_type( $post_id );
		$post_name = $post->post_name;
		$uncachable_page_type = $this->get_uncachable_page_type( $post_id );
		if ( $uncachable_page_type ) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			echo "<pre style=\"font-size: 12px;\">";
			echo "Tracks properties sent by PHP:";
			echo "<br/>";
			echo "post type: ";
			print_r( $post_type );
			echo "<br/>";
			echo "post name: ";
			print_r( $post_name );
			echo "<br/>";
			echo "post id: ";
			print_r( $post_id );
			echo "<br/>";
			echo "store id: ";
			print_r( $store_id );
			echo "<br/>";
			echo "page type: ";
			print_r( $uncachable_page_type );
			echo "<br/>";
			echo "cart ids: ";
			print_r( $cart_ids );
			echo "<br/>";
			echo "cart quantities: ";
			print_r( $cart_quantities );
			if ( isset( $_GET[ 'key' ] ) ) {
				echo "<br/>";
				echo "order number: ";
				print_r( $_GET[ 'key' ] );
			}
			echo "</pre>";
		} else {
			wc_enqueue_js(
				"var data = {
					'post_type': '" . $post_type . "',
					'post_id': " . $post_id . ",
					'post_name': '" . $post_name . "',
					'store_id': " . $store_id . ",
					'cart_ids': " . json_encode( $cart_ids ) . ",
					'cart_quantities': " . json_encode( $cart_quantities ) . "
				};
				jQuery.post( 'wp-json/jetpack/v4/tracks', data, function(response) {
					console.log( 'Tracks properties sent by PHP:' );
					console.log( JSON.parse( response ) );
				});"
			);
		}
	}
}

WC_Stats::init();


1			<?php
2
3			if ( ! defined( 'ABSPATH' ) ) {
4			exit;
5			}
6
7			class WC_Stats {
8			/**
9			* @var Jetpack
10			**/
11			private $jetpack;
12
13			/**
14			* @var WC_Stats
15			**/
16			private static $instance = null;
17
18			static function init() {
19			// Tracking only Site pages
20			if ( is_admin() ) {
21			return;
22			}
23			// Make sure Jetpack is installed and active
24			if ( ! Jetpack::is_active() ) {
25			return;
26			}
27			// Make sure WooCommerce is installed and active
28			if ( ! in_array( 'woocommerce/woocommerce.php', apply_filters( 'active_plugins', get_option( 'active_plugins' ) ) ) ) {
29			return;
30			}
31			if ( is_null( self::$instance ) ) {
32			self::$instance = new WC_Stats();
33			}
34			return self::$instance;
35			}
36
37			public function __construct() {
38			$this->jetpack = Jetpack::init();
39
40			add_action( 'wp_enqueue_scripts', array( $this, 'track' ) );
41			add_action( 'rest_api_init', function() {
42			register_rest_route( 'jetpack/v4', '/tracks', array(
43			'methods' => 'POST',
44			'callback' => array( $this, 'handle_client_tracks' ),
45			) );
46			} );
47			}
48
49			public function handle_client_tracks( $request ) {
50			return json_encode( $request->get_params() );
51			}
52
53			public function get_cart_ids( $item ) {
54			return $item[ 'product_id' ];
55			}
56
57			public function get_cart_quantities( $item ) {
58			return $item[ 'quantity' ];
59			}
60
61			public function get_uncachable_page_type( $post_id ) {
62
63			switch ( $post_id ) {
64			case get_option( 'woocommerce_cart_page_id' ):
65			return 'cart_view';
66			case get_option( 'woocommerce_checkout_page_id' ):
67			global $wp;
68			if ( strpos( $wp->request, 'order-received' ) !== false ) {
69			return 'checkout_complete';
70			}
71			return 'checkout_view';
72			case get_option( 'woocommerce_view_order_page_id' ):
73			return 'view_order';
74			default:
75			null;
76			}
77			}
78
79			public function track() {
80			$cart = WC()->cart->get_cart();
81			$cart_ids = array_map( array( $this, 'get_cart_ids' ), $cart );
82			$cart_quantities = array_map( array( $this, 'get_cart_quantities' ), $cart );
83			// Is this the right id? Is WooCommerce id different?
84			$store_id = Jetpack::get_option( 'id' );
85			$post = get_post();
86			$post_id = $post->ID;
87			$post_type = get_post_type( $post_id );
88			$post_name = $post->post_name;
89			$uncachable_page_type = $this->get_uncachable_page_type( $post_id );
90			if ( $uncachable_page_type ) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-14 21:59 UTC by Report Bug Copy Issue Report The expression `$uncachable_page_type` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
91			echo "<pre style=\"font-size: 12px;\">";
92			echo "Tracks properties sent by PHP:";
93			echo "<br/>";
94			echo "post type: ";
95			print_r( $post_type );
96			echo "<br/>";
97			echo "post name: ";
98			print_r( $post_name );
99			echo "<br/>";
100			echo "post id: ";
101			print_r( $post_id );
102			echo "<br/>";
103			echo "store id: ";
104			print_r( $store_id );
105			echo "<br/>";
106			echo "page type: ";
107			print_r( $uncachable_page_type );
108			echo "<br/>";
109			echo "cart ids: ";
110			print_r( $cart_ids );
111			echo "<br/>";
112			echo "cart quantities: ";
113			print_r( $cart_quantities );
114			if ( isset( $_GET[ 'key' ] ) ) {
115			echo "<br/>";
116			echo "order number: ";
117			print_r( $_GET[ 'key' ] );
118			}
119			echo "</pre>";
120			} else {
121			wc_enqueue_js(
122			"var data = {
123			'post_type': '" . $post_type . "',
124			'post_id': " . $post_id . ",
125			'post_name': '" . $post_name . "',
126			'store_id': " . $store_id . ",
127			'cart_ids': " . json_encode( $cart_ids ) . ",
128			'cart_quantities': " . json_encode( $cart_quantities ) . "
129			};
130			jQuery.post( 'wp-json/jetpack/v4/tracks', data, function(response) {
131			console.log( 'Tracks properties sent by PHP:' );
132			console.log( JSON.parse( response ) );
133			});"
134			);
135			}
136			}
137			}
138
139			WC_Stats::init();
140

Automattic / jetpack

Push — try/tracks-store-stats ( 87fce4...010ef0 )

WC_Stats::track() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like