Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Jetpack_Gutenberg often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Jetpack_Gutenberg, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 45 | class Jetpack_Gutenberg { |
||
| 46 | |||
| 47 | // BLOCKS |
||
| 48 | private static $default_blocks = array( |
||
| 49 | 'map', |
||
| 50 | 'markdown', |
||
| 51 | 'simple-payments', |
||
| 52 | 'related-posts', |
||
| 53 | 'contact-form', |
||
| 54 | 'field-text', |
||
| 55 | 'field-name', |
||
| 56 | 'field-email', |
||
| 57 | 'field-url', |
||
| 58 | 'field-date', |
||
| 59 | 'field-telephone', |
||
| 60 | 'field-textarea', |
||
| 61 | 'field-checkbox', |
||
| 62 | 'field-checkbox-multiple', |
||
| 63 | 'field-radio', |
||
| 64 | 'field-select' |
||
| 65 | ); |
||
| 66 | |||
| 67 | /** |
||
| 68 | * @var array Array of blocks information. |
||
| 69 | * |
||
| 70 | * For each block we have information about the availability for the current user |
||
| 71 | */ |
||
| 72 | private static $blocks = array(); |
||
| 73 | |||
| 74 | private static $availability = array(); |
||
| 75 | |||
| 76 | // PLUGINS |
||
| 77 | private static $default_plugins = array( |
||
| 78 | 'publicize', |
||
| 79 | ); |
||
| 80 | /** |
||
| 81 | * @var array Array of plugins information. |
||
| 82 | * |
||
| 83 | * For each block we have information about the availability for the current user |
||
| 84 | */ |
||
| 85 | private static $plugins = array(); |
||
| 86 | |||
| 87 | /** |
||
| 88 | * @var array Array of extensions we will be registering. |
||
| 89 | */ |
||
| 90 | private static $registered = array(); |
||
| 91 | |||
| 92 | /** |
||
| 93 | * Add a block to the list of blocks to be registered. |
||
| 94 | * |
||
| 95 | * @param string $slug Slug of the block. |
||
| 96 | * @param array $args Arguments that are passed into the register_block_type. |
||
| 97 | * @param array $availability array containing if a block is available and the reason when it is not. |
||
| 98 | */ |
||
| 99 | public static function register( $slug, $args, $availability ) { |
||
| 103 | |||
| 104 | /** |
||
| 105 | * Register all Jetpack blocks available. |
||
| 106 | * |
||
| 107 | * @return void |
||
| 108 | */ |
||
| 109 | public static function init() { |
||
| 127 | |||
| 128 | /** |
||
| 129 | * @deprecated |
||
| 130 | */ |
||
| 131 | static function load_blocks() { |
||
| 134 | |||
| 135 | /** |
||
| 136 | * Add a block to the list of blocks to be registered. |
||
| 137 | * |
||
| 138 | * @param string $slug Slug of the block. |
||
| 139 | * @param array $args Arguments that are passed into the register_block_type. |
||
| 140 | * @param array $availability array containing if a block is available and the reason when it is not. |
||
| 141 | * |
||
| 142 | * @deprecated |
||
| 143 | */ |
||
| 144 | static function add_block( $type, $args, $availability ) { |
||
| 147 | |||
| 148 | static function load( $request = null ) { |
||
| 175 | |||
| 176 | static function is_registered( $slug ) { |
||
| 179 | |||
| 180 | static function get_registered_args( $slug ) { |
||
| 186 | |||
| 187 | static function is_available( $slug ) { |
||
| 193 | |||
| 194 | |||
| 195 | static function get_extension_availability( $slug ) { |
||
| 218 | |||
| 219 | static function set_blocks_availability() { |
||
| 224 | |||
| 225 | static function set_plugins_availability() { |
||
| 230 | |||
| 231 | static function register_blocks() { |
||
| 238 | |||
| 239 | /** |
||
| 240 | * Return the Gutenberg extensions (blocks and plugins) directory |
||
| 241 | * |
||
| 242 | * @return string The Gutenberg extensions directory |
||
| 243 | */ |
||
| 244 | public static function get_blocks_directory() { |
||
| 254 | |||
| 255 | /** |
||
| 256 | * Checks for a given .json file in the blocks folder. |
||
| 257 | * |
||
| 258 | * @param $preset The name of the .json file to look for. |
||
| 259 | * |
||
| 260 | * @return bool True if the file is found. |
||
| 261 | */ |
||
| 262 | public static function preset_exists( $preset ) { |
||
| 265 | |||
| 266 | /** |
||
| 267 | * Decodes JSON loaded from a preset file in the blocks folder |
||
| 268 | * |
||
| 269 | * @param $preset The name of the .json file to load. |
||
| 270 | * |
||
| 271 | * @return mixed Returns an object if the file is present, or false if a valid .json file is not present. |
||
| 272 | */ |
||
| 273 | public static function get_preset( $preset ) { |
||
| 276 | |||
| 277 | /** |
||
| 278 | * Filters the results of `apply_filter( 'jetpack_set_available_blocks', array() )` |
||
| 279 | * using the merged contents of `blocks-manifest.json` ( $preset_blocks ) |
||
| 280 | * and self::$jetpack_blocks ( $internal_blocks ) |
||
| 281 | * |
||
| 282 | * @param $blocks The default list. |
||
| 283 | * |
||
| 284 | * @return array A list of blocks: eg [ 'publicize', 'markdown' ] |
||
| 285 | */ |
||
| 286 | public static function jetpack_set_available_blocks( $blocks ) { |
||
| 287 | $preset_blocks_manifest = self::preset_exists( 'index' ) ? self::get_preset( 'index' ) : (object) array( 'blocks' => $blocks ); |
||
| 288 | // manifest shouldn't remove default blocks... |
||
| 289 | |||
| 290 | $preset_blocks = isset( $preset_blocks_manifest->production ) ? (array) $preset_blocks_manifest->production : array() ; |
||
| 291 | $preset_blocks = array_unique( array_merge( $preset_blocks, $blocks ) ); |
||
| 292 | |||
| 293 | if ( Jetpack_Constants::is_true( 'JETPACK_BETA_BLOCKS' ) ) { |
||
| 294 | $beta_blocks = isset( $preset_blocks_manifest->beta ) ? (array) $preset_blocks_manifest->beta : array(); |
||
| 295 | return array_unique( array_merge( $preset_blocks, $beta_blocks ) ); |
||
| 296 | } |
||
| 297 | |||
| 298 | return $preset_blocks; |
||
| 299 | } |
||
| 300 | |||
| 301 | /** |
||
| 302 | * @deprecated |
||
| 303 | * @return array A list of block-availability information, eg: [ "publicize" => ["available" => true ], "markdown" => [ "available" => false, "unavailable_reason" => 'missing_module' ] ] |
||
| 304 | */ |
||
| 305 | public static function get_block_availability() { |
||
| 308 | |||
| 309 | /** |
||
| 310 | * @return array A list of block and plugins and their availablity status |
||
| 311 | */ |
||
| 312 | public static function get_availability() { |
||
| 319 | |||
| 320 | /** |
||
| 321 | * Check if Gutenberg editor is available |
||
| 322 | * |
||
| 323 | * @since 6.7.0 |
||
| 324 | * |
||
| 325 | * @return bool |
||
| 326 | */ |
||
| 327 | public static function is_gutenberg_available() { |
||
| 330 | |||
| 331 | /** |
||
| 332 | * Check whether conditions indicate Gutenberg blocks should be loaded |
||
| 333 | * |
||
| 334 | * Loading blocks is enabled by default and may be disabled via filter: |
||
| 335 | * add_filter( 'jetpack_gutenberg', '__return_false' ); |
||
| 336 | * |
||
| 337 | * @since 6.7.0 |
||
| 338 | * @deprecated |
||
| 339 | * @return bool |
||
| 340 | */ |
||
| 341 | public static function should_load_blocks() { |
||
| 344 | |||
| 345 | /** |
||
| 346 | * Check whether conditions indicate Gutenberg Extensions (blocks and plugins) should be loaded |
||
| 347 | * |
||
| 348 | * Loading blocks and plugins is enabled by default and may be disabled via filter: |
||
| 349 | * add_filter( 'jetpack_gutenberg', '__return_false' ); |
||
| 350 | * |
||
| 351 | * @since 6.9.0 |
||
| 352 | * |
||
| 353 | * @return bool |
||
| 354 | */ |
||
| 355 | public static function should_load() { |
||
| 369 | |||
| 370 | /** |
||
| 371 | * Only enqueue block assets when needed. |
||
| 372 | * |
||
| 373 | * @param string $type slug of the block. |
||
| 374 | * @param array $script_dependencies An array of view-side Javascript dependencies to be enqueued. |
||
| 375 | * |
||
| 376 | * @return void |
||
| 377 | */ |
||
| 378 | public static function load_assets_as_required( $type, $script_dependencies = array() ) { |
||
| 407 | |||
| 408 | /** |
||
| 409 | * Check if an asset exists for a block. |
||
| 410 | * |
||
| 411 | * @param string $file Path of the file we are looking for. |
||
| 412 | * |
||
| 413 | * @return bool $block_has_asset Does the file exist. |
||
| 414 | */ |
||
| 415 | public static function block_has_asset( $file ) { |
||
| 418 | |||
| 419 | /** |
||
| 420 | * Get the version number to use when loading the file. Allows us to bypass cache when developing. |
||
| 421 | * |
||
| 422 | * @param string $file Path of the file we are looking for. |
||
| 423 | * |
||
| 424 | * @return string $script_version Version number. |
||
| 425 | */ |
||
| 426 | public static function get_asset_version( $file ) { |
||
| 431 | |||
| 432 | /** |
||
| 433 | * Load Gutenberg editor assets |
||
| 434 | * |
||
| 435 | * @since 6.7.0 |
||
| 436 | * |
||
| 437 | * @return void |
||
| 438 | */ |
||
| 439 | public static function enqueue_block_editor_assets() { |
||
| 504 | } |
||
| 505 |
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function.
Consider the following example. The parameter
$italyis not defined by the methodfinale(...).The most likely cause is that the parameter was removed, but the annotation was not.