AMP_Img_Sanitizer::sanitize() - Code Metrics - Inspection of "Initial proof of concept for AMP Integration" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — add/amp-pwa-experiment ( efea12 )

unknown

created 2017-06-15 19:11 UTC

AMP_Img_Sanitizer::sanitize() C

↳ Parent: AMP_Img_Sanitizer

Complexity

Conditions	11
Paths	21

Size

Total Lines	48
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	11
eloc	29
nc	21
nop	0
dl	0
loc	48
rs	5.2653
c	0
b	0
f	0

How to fix Complexity

<?php

require_once( AMP__ROOT__ . '/includes/sanitizers/class-amp-base-sanitizer.php' );
require_once( AMP__ROOT__ . '/includes/utils/class-amp-image-dimension-extractor.php' );

/**
 * Converts <img> tags to <amp-img> or <amp-anim>
 */
class AMP_Img_Sanitizer extends AMP_Base_Sanitizer {
	const FALLBACK_WIDTH = 600;
	const FALLBACK_HEIGHT = 400;

	public static $tag = 'img';

	private static $anim_extension = '.gif';

	private static $script_slug = 'amp-anim';
	private static $script_src = 'https://cdn.ampproject.org/v0/amp-anim-0.1.js';

	public function sanitize() {
		$nodes = $this->dom->getElementsByTagName( self::$tag );
		$num_nodes = $nodes->length;
		if ( 0 === $num_nodes ) {
			return;
		}

		for ( $i = $num_nodes - 1; $i >= 0; $i-- ) {
			$node = $nodes->item( $i );
			$old_attributes = AMP_DOM_Utils::get_node_attributes_as_assoc_array( $node );

			if ( empty( $old_attributes['src'] ) ) {
				$node->parentNode->removeChild( $node );
				continue;
			}

			$new_attributes = $this->filter_attributes( $old_attributes );

			// Try to extract dimensions for the image, if not set.
			if ( ! isset( $new_attributes['width'] ) || ! isset( $new_attributes['height'] ) ) {
				$dimensions = AMP_Image_Dimension_Extractor::extract( $new_attributes['src'] );
				if ( is_array( $dimensions ) ) {
					$new_attributes['width'] = $dimensions[0];
					$new_attributes['height'] = $dimensions[1];
				}
			}

			// Final fallback when we have no dimensions.
			if ( ! isset( $new_attributes['width'] ) || ! isset( $new_attributes['height'] ) ) {
				$new_attributes['width'] = isset( $this->args['content_max_width'] ) ? $this->args['content_max_width'] : self::FALLBACK_WIDTH;
				$new_attributes['height'] = self::FALLBACK_HEIGHT;

				$this->add_or_append_attribute( $new_attributes, 'class', 'amp-wp-unknown-size' );
			}

			$new_attributes = $this->enforce_sizes_attribute( $new_attributes );

			if ( $this->is_gif_url( $new_attributes['src'] ) ) {
				$this->did_convert_elements = true;
				$new_tag = 'amp-anim';
			} else {
				$new_tag = 'amp-img';
			}

			$new_node = AMP_DOM_Utils::create_node( $this->dom, $new_tag, $new_attributes );
			$node->parentNode->replaceChild( $new_node, $node );
		}
	}

	public function get_scripts() {
		if ( ! $this->did_convert_elements ) {
			return array();
		}

		return array( self::$script_slug => self::$script_src );
	}

	private function filter_attributes( $attributes ) {
		$out = array();

		foreach ( $attributes as $name => $value ) {
			switch ( $name ) {
				case 'src':
				case 'alt':
				case 'class':
				case 'srcset':
				case 'sizes':
				case 'on':
					$out[ $name ] = $value;
					break;

				case 'width':
				case 'height':
					$out[ $name ] = $this->sanitize_dimension( $value, $name );
					break;

				default;
switch ($expr) {
    default: { //wrong
        doSomething();
        break;
    }
}

switch ($expr) {
    default: //right
        doSomething();
        break;
}
					break;
			}
		}

		return $out;
	}

	private function is_gif_url( $url ) {
		$ext = self::$anim_extension;
		$path = parse_url( $url, PHP_URL_PATH );
		return $ext === substr( $path, -strlen( $ext ) );
	}
}


1			<?php
2
3			require_once( AMP__ROOT__ . '/includes/sanitizers/class-amp-base-sanitizer.php' );
4			require_once( AMP__ROOT__ . '/includes/utils/class-amp-image-dimension-extractor.php' );
5
6			/**
7			* Converts <img> tags to <amp-img> or <amp-anim>
8			*/
9			class AMP_Img_Sanitizer extends AMP_Base_Sanitizer {
10			const FALLBACK_WIDTH = 600;
11			const FALLBACK_HEIGHT = 400;
12
13			public static $tag = 'img';
14
15			private static $anim_extension = '.gif';
16
17			private static $script_slug = 'amp-anim';
18			private static $script_src = 'https://cdn.ampproject.org/v0/amp-anim-0.1.js';
19
20			public function sanitize() {
21			$nodes = $this->dom->getElementsByTagName( self::$tag );
22			$num_nodes = $nodes->length;
23			if ( 0 === $num_nodes ) {
24			return;
25			}
26
27			for ( $i = $num_nodes - 1; $i >= 0; $i-- ) {
28			$node = $nodes->item( $i );
29			$old_attributes = AMP_DOM_Utils::get_node_attributes_as_assoc_array( $node );
30
31			if ( empty( $old_attributes['src'] ) ) {
32			$node->parentNode->removeChild( $node );
33			continue;
34			}
35
36			$new_attributes = $this->filter_attributes( $old_attributes );
37
38			// Try to extract dimensions for the image, if not set.
39			if ( ! isset( $new_attributes['width'] ) \|\| ! isset( $new_attributes['height'] ) ) {
40			$dimensions = AMP_Image_Dimension_Extractor::extract( $new_attributes['src'] );
41			if ( is_array( $dimensions ) ) {
42			$new_attributes['width'] = $dimensions[0];
43			$new_attributes['height'] = $dimensions[1];
44			}
45			}
46
47			// Final fallback when we have no dimensions.
48			if ( ! isset( $new_attributes['width'] ) \|\| ! isset( $new_attributes['height'] ) ) {
49			$new_attributes['width'] = isset( $this->args['content_max_width'] ) ? $this->args['content_max_width'] : self::FALLBACK_WIDTH;
50			$new_attributes['height'] = self::FALLBACK_HEIGHT;
51
52			$this->add_or_append_attribute( $new_attributes, 'class', 'amp-wp-unknown-size' );
53			}
54
55			$new_attributes = $this->enforce_sizes_attribute( $new_attributes );
56
57			if ( $this->is_gif_url( $new_attributes['src'] ) ) {
58			$this->did_convert_elements = true;
59			$new_tag = 'amp-anim';
60			} else {
61			$new_tag = 'amp-img';
62			}
63
64			$new_node = AMP_DOM_Utils::create_node( $this->dom, $new_tag, $new_attributes );
65			$node->parentNode->replaceChild( $new_node, $node );
66			}
67			}
68
69			public function get_scripts() {
70			if ( ! $this->did_convert_elements ) {
71			return array();
72			}
73
74			return array( self::$script_slug => self::$script_src );
75			}
76
77			private function filter_attributes( $attributes ) {
78			$out = array();
79
80			foreach ( $attributes as $name => $value ) {
81			switch ( $name ) {
82			case 'src':
83			case 'alt':
84			case 'class':
85			case 'srcset':
86			case 'sizes':
87			case 'on':
88			$out[ $name ] = $value;
89			break;
90
91			case 'width':
92			case 'height':
93			$out[ $name ] = $this->sanitize_dimension( $value, $name );
94			break;
95
96			default;
			0 ignored issues – show Coding Style introduced 2017-06-15 19:21 UTC by Report Bug Copy Issue Report DEFAULT statements must be defined using a colon As per the PSR-2 coding standard, default statements should not be wrapped in curly braces. switch ($expr) { default: { //wrong doSomething(); break; } } switch ($expr) { default: //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
97			break;
98			}
99			}
100
101			return $out;
102			}
103
104			private function is_gif_url( $url ) {
105			$ext = self::$anim_extension;
106			$path = parse_url( $url, PHP_URL_PATH );
107			return $ext === substr( $path, -strlen( $ext ) );
108			}
109			}
110

Automattic / jetpack

Push — add/amp-pwa-experiment ( efea12 )

AMP_Img_Sanitizer::sanitize() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like