Jetpack_Sync_Actions::is_scheduled_full_sync() - Code Metrics - Inspection of "Don’t accept default arguments for `jetpack_client..." - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — fix/initial-sync-arguments-for... ( 264142 )

unknown

created 2016-08-25 22:33 UTC

Jetpack_Sync_Actions::is_scheduled_full_sync() A

↳ Parent: Jetpack_Sync_Actions

Complexity

Conditions	4
Paths	4

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	8
c	1
b	0
f	0
nc	4
nop	1
dl	0
loc	14
rs	9.2

<?php
require_once dirname( __FILE__ ) . '/class.jetpack-sync-settings.php';

/**
 * The role of this class is to hook the Sync subsystem into WordPress - when to listen for actions,
 * when to send, when to perform a full sync, etc.
 *
 * It also binds the action to send data to WPCOM to Jetpack's XMLRPC client object.
 */
class Jetpack_Sync_Actions {
	static $sender = null;
class A {
    var $property;
}
	static $listener = null;
class A {
    var $property;
}
	const INITIAL_SYNC_MULTISITE_INTERVAL = 10;

	static function init() {

		// Add a custom "every minute" cron schedule
		add_filter( 'cron_schedules', array( __CLASS__, 'minute_cron_schedule' ) );

		// On jetpack authorization, schedule a full sync
		add_action( 'jetpack_client_authorized', array( __CLASS__, 'schedule_full_sync' ), 10, 0 );

		// When imports are finished, schedule a full sync
		add_action( 'import_end', array( __CLASS__, 'schedule_full_sync' ) );

		// When importing via cron, do not sync
		add_action( 'wp_cron_importer_hook', array( __CLASS__, 'set_is_importing_true' ), 1 );

		// Sync connected user role changes to .com
		require_once dirname( __FILE__ ) . '/class.jetpack-sync-users.php';

		// everything below this point should only happen if we're a valid sync site
		if ( ! self::sync_allowed() ) {
			return;
		}

		// publicize filter to prevent publicizing blacklisted post types
		add_filter( 'publicize_should_publicize_published_post', array( __CLASS__, 'prevent_publicize_blacklisted_posts' ), 10, 2 );

		// cron hooks
		add_action( 'jetpack_sync_full', array( __CLASS__, 'do_full_sync' ), 10, 1 );
		add_action( 'jetpack_sync_cron', array( __CLASS__, 'do_cron_sync' ) );

		if ( ! wp_next_scheduled( 'jetpack_sync_cron' ) ) {
			// Schedule a job to send pending queue items once a minute
			wp_schedule_event( time(), '1min', 'jetpack_sync_cron' );
		}

		/**
		 * Fires on every request before default loading sync listener code.
		 * Return false to not load sync listener code that monitors common
		 * WP actions to be serialized.
		 *
		 * By default this returns true for non-GET-requests, or requests where the
		 * user is logged-in.
		 *
		 * @since 4.2.0
		 *
		 * @param bool should we load sync listener code for this request
		 */
		if ( apply_filters( 'jetpack_sync_listener_should_load',
			(
				( isset( $_SERVER["REQUEST_METHOD"] ) && 'GET' !== $_SERVER['REQUEST_METHOD'] )
				||
				is_user_logged_in()
				||
				defined( 'PHPUNIT_JETPACK_TESTSUITE' )
				||
				defined( '')
			)
		) ) {
			self::initialize_listener();
		}

		/**
		 * Fires on every request before default loading sync sender code.
		 * Return false to not load sync sender code that serializes pending
		 * data and sends it to WPCOM for processing.
		 *
		 * By default this returns true for POST requests, admin requests, or requests
		 * by users who can manage_options.
		 *
		 * @since 4.2.0
		 *
		 * @param bool should we load sync sender code for this request
		 */
		if ( apply_filters( 'jetpack_sync_sender_should_load',
			(
				( isset( $_SERVER["REQUEST_METHOD"] ) && 'POST' === $_SERVER['REQUEST_METHOD'] )
				||
				current_user_can( 'manage_options' )
				||
				is_admin()
				||
				defined( 'PHPUNIT_JETPACK_TESTSUITE' )
			)
		) ) {
			self::initialize_sender();
			add_action( 'shutdown', array( self::$sender, 'do_sync' ) );
		}

	}

	static function sync_allowed() {
		return ( ! Jetpack_Sync_Settings::get_setting( 'disable' ) && Jetpack::is_active() && ! ( Jetpack::is_development_mode() || Jetpack::is_staging_site() ) )
			   || defined( 'PHPUNIT_JETPACK_TESTSUITE' );
	}

	static function prevent_publicize_blacklisted_posts( $should_publicize, $post ) {
		if ( in_array( $post->post_type, Jetpack_Sync_Settings::get_setting( 'post_types_blacklist' ) ) ) {
			return false;
		}

		return $should_publicize;
	}

	static function set_is_importing_true() {
		Jetpack_Sync_Settings::set_importing( true );
	}

	static function send_data( $data, $codec_name, $sent_timestamp, $queue_id ) {
		Jetpack::load_xml_rpc_client();

		$url = add_query_arg( array(
			'sync'      => '1', // add an extra parameter to the URL so we can tell it's a sync action
			'codec'     => $codec_name, // send the name of the codec used to encode the data
			'timestamp' => $sent_timestamp, // send current server time so we can compensate for clock differences
			'queue'     => $queue_id, // sync or full_sync
		), Jetpack::xmlrpc_api_url() );

		$rpc = new Jetpack_IXR_Client( array(
			'url'     => $url,
			'user_id' => JETPACK_MASTER_USER,
			'timeout' => 30,
		) );

		$result = $rpc->query( 'jetpack.syncActions', $data );

		if ( ! $result ) {
			return $rpc->get_jetpack_error();
		}

		return $rpc->getResponse();
	}

	static function schedule_initial_sync( $new_version = null, $old_version = null ) {
		$initial_sync_config = array(
			'options' => true,
			'network_options' => true,
			'functions' => true,
			'constants' => true,
		);

		if ( $old_version && ( version_compare( $old_version, '4.2', '<' ) ) ) {
			$initial_sync_config['users'] = 'initial';
		}

		// we need this function call here because we have to run this function
		// reeeeally early in init, before WP_CRON_LOCK_TIMEOUT is defined.
		wp_functionality_constants();

		if ( is_multisite() ) {
			// stagger initial syncs for multisite blogs so they don't all pile on top of each other
			$time_offset = ( rand() / getrandmax() ) * self::INITIAL_SYNC_MULTISITE_INTERVAL * get_blog_count();
		} else {
			$time_offset = 1;
		}

		self::schedule_full_sync(
			$initial_sync_config,
			$time_offset
		);
	}

	static function schedule_full_sync( $modules = null, $time_offset = 1 ) {
		if ( ! self::sync_allowed() ) {
			return false;
		}

		if ( self::is_scheduled_full_sync() ) {
			self::unschedule_all_full_syncs();
		}

		if ( $modules ) {
			wp_schedule_single_event( time() + $time_offset, 'jetpack_sync_full', array( $modules ) );
		} else {
			wp_schedule_single_event( time() + $time_offset, 'jetpack_sync_full' );
		}

		if ( $time_offset === 1 ) {
			spawn_cron();
		}

		return true;
	}

	static function unschedule_all_full_syncs() {
		foreach ( _get_cron_array() as $timestamp => $cron ) {
			if ( ! empty( $cron['jetpack_sync_full'] ) ) {
				foreach( $cron['jetpack_sync_full'] as $key => $config ) {
					wp_unschedule_event( $timestamp, 'jetpack_sync_full', $config['args'] );
				}
			}
		}
	}

	static function is_scheduled_full_sync( $modules = null ) {
		if ( is_null( $modules ) ) {
			$crons = _get_cron_array();

			foreach ( $crons as $timestamp => $cron ) {
				if ( ! empty( $cron['jetpack_sync_full'] ) ) {
					return true;
				}
			}
			return false;
		}

		return !! wp_next_scheduled( 'jetpack_sync_full', array( $modules ) );
	}

	static function do_full_sync( $modules = null ) {
		if ( ! self::sync_allowed() ) {
			return;
		}

		self::initialize_listener();
		Jetpack_Sync_Modules::get_module( 'full-sync' )->start( $modules );
		self::do_cron_sync(); // immediately run a cron sync, which sends pending data
	}

	static function minute_cron_schedule( $schedules ) {
		if( ! isset( $schedules["1min"] ) ) {
			$schedules["1min"] = array(
				'interval' => 60,
				'display' => __( 'Every minute' )
			);
		}
		return $schedules;
	}

	// try to send actions until we run out of things to send,
	// or have to wait more than 15s before sending again,
	// or we hit a lock or some other sending issue
	static function do_cron_sync() {
		if ( ! self::sync_allowed() ) {
			return;
		}

		self::initialize_sender();

		// remove shutdown hook - no need to sync twice
		if ( has_action( 'shutdown', array( self::$sender, 'do_sync' ) ) ) {
			remove_action( 'shutdown', array( self::$sender, 'do_sync' ) );
		}

		do {
			$next_sync_time = self::$sender->get_next_sync_time();

			if ( $next_sync_time ) {
				$delay = $next_sync_time - time() + 1;
				if ( $delay > 15 ) {
					break;
				} elseif ( $delay > 0 ) {
					sleep( $delay );
				}
			}

			$result = self::$sender->do_sync();
		} while ( $result );
	}

	static function initialize_listener() {
		require_once dirname( __FILE__ ) . '/class.jetpack-sync-listener.php';
		self::$listener = Jetpack_Sync_Listener::get_instance();
	}

	static function initialize_sender() {
		require_once dirname( __FILE__ ) . '/class.jetpack-sync-sender.php';
		self::$sender = Jetpack_Sync_Sender::get_instance();

		// bind the sending process
		add_filter( 'jetpack_sync_send_data', array( __CLASS__, 'send_data' ), 10, 4 );
	}
}

// Allow other plugins to add filters before we initialize the actions.
// Load the listeners if before modules get loaded so that we can capture version changes etc.
add_action( 'init', array( 'Jetpack_Sync_Actions', 'init' ), 90 );

// We need to define this here so that it's hooked before `updating_jetpack_version` is called
add_action( 'updating_jetpack_version', array( 'Jetpack_Sync_Actions', 'schedule_initial_sync' ), 10, 2 );


1			<?php
2			require_once dirname( __FILE__ ) . '/class.jetpack-sync-settings.php';
3
4			/**
5			* The role of this class is to hook the Sync subsystem into WordPress - when to listen for actions,
6			* when to send, when to perform a full sync, etc.
7			*
8			* It also binds the action to send data to WPCOM to Jetpack's XMLRPC client object.
9			*/
10			class Jetpack_Sync_Actions {
11			static $sender = null;
			0 ignored issues – show Coding Style introduced 2016-06-29 22:35 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$sender`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
12			static $listener = null;
			0 ignored issues – show Coding Style introduced 2016-06-30 03:18 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$listener`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
13			const INITIAL_SYNC_MULTISITE_INTERVAL = 10;
14
15			static function init() {
16
17			// Add a custom "every minute" cron schedule
18			add_filter( 'cron_schedules', array( __CLASS__, 'minute_cron_schedule' ) );
19
20			// On jetpack authorization, schedule a full sync
21			add_action( 'jetpack_client_authorized', array( __CLASS__, 'schedule_full_sync' ), 10, 0 );
22
23			// When imports are finished, schedule a full sync
24			add_action( 'import_end', array( __CLASS__, 'schedule_full_sync' ) );
25
26			// When importing via cron, do not sync
27			add_action( 'wp_cron_importer_hook', array( __CLASS__, 'set_is_importing_true' ), 1 );
28
29			// Sync connected user role changes to .com
30			require_once dirname( __FILE__ ) . '/class.jetpack-sync-users.php';
31
32			// everything below this point should only happen if we're a valid sync site
33			if ( ! self::sync_allowed() ) {
34			return;
35			}
36
37			// publicize filter to prevent publicizing blacklisted post types
38			add_filter( 'publicize_should_publicize_published_post', array( __CLASS__, 'prevent_publicize_blacklisted_posts' ), 10, 2 );
39
40			// cron hooks
41			add_action( 'jetpack_sync_full', array( __CLASS__, 'do_full_sync' ), 10, 1 );
42			add_action( 'jetpack_sync_cron', array( __CLASS__, 'do_cron_sync' ) );
43
44			if ( ! wp_next_scheduled( 'jetpack_sync_cron' ) ) {
45			// Schedule a job to send pending queue items once a minute
46			wp_schedule_event( time(), '1min', 'jetpack_sync_cron' );
47			}
48
49			/**
50			* Fires on every request before default loading sync listener code.
51			* Return false to not load sync listener code that monitors common
52			* WP actions to be serialized.
53			*
54			* By default this returns true for non-GET-requests, or requests where the
55			* user is logged-in.
56			*
57			* @since 4.2.0
58			*
59			* @param bool should we load sync listener code for this request
60			*/
61			if ( apply_filters( 'jetpack_sync_listener_should_load',
62			(
63			( isset( $_SERVER["REQUEST_METHOD"] ) && 'GET' !== $_SERVER['REQUEST_METHOD'] )
64			\|\|
65			is_user_logged_in()
66			\|\|
67			defined( 'PHPUNIT_JETPACK_TESTSUITE' )
68			\|\|
69			defined( '')
70			)
71			) ) {
72			self::initialize_listener();
73			}
74
75			/**
76			* Fires on every request before default loading sync sender code.
77			* Return false to not load sync sender code that serializes pending
78			* data and sends it to WPCOM for processing.
79			*
80			* By default this returns true for POST requests, admin requests, or requests
81			* by users who can manage_options.
82			*
83			* @since 4.2.0
84			*
85			* @param bool should we load sync sender code for this request
86			*/
87			if ( apply_filters( 'jetpack_sync_sender_should_load',
88			(
89			( isset( $_SERVER["REQUEST_METHOD"] ) && 'POST' === $_SERVER['REQUEST_METHOD'] )
90			\|\|
91			current_user_can( 'manage_options' )
92			\|\|
93			is_admin()
94			\|\|
95			defined( 'PHPUNIT_JETPACK_TESTSUITE' )
96			)
97			) ) {
98			self::initialize_sender();
99			add_action( 'shutdown', array( self::$sender, 'do_sync' ) );
100			}
101
102			}
103
104			static function sync_allowed() {
105			return ( ! Jetpack_Sync_Settings::get_setting( 'disable' ) && Jetpack::is_active() && ! ( Jetpack::is_development_mode() \|\| Jetpack::is_staging_site() ) )
106			\|\| defined( 'PHPUNIT_JETPACK_TESTSUITE' );
107			}
108
109			static function prevent_publicize_blacklisted_posts( $should_publicize, $post ) {
110			if ( in_array( $post->post_type, Jetpack_Sync_Settings::get_setting( 'post_types_blacklist' ) ) ) {
111			return false;
112			}
113
114			return $should_publicize;
115			}
116
117			static function set_is_importing_true() {
118			Jetpack_Sync_Settings::set_importing( true );
119			}
120
121			static function send_data( $data, $codec_name, $sent_timestamp, $queue_id ) {
122			Jetpack::load_xml_rpc_client();
123
124			$url = add_query_arg( array(
125			'sync' => '1', // add an extra parameter to the URL so we can tell it's a sync action
126			'codec' => $codec_name, // send the name of the codec used to encode the data
127			'timestamp' => $sent_timestamp, // send current server time so we can compensate for clock differences
128			'queue' => $queue_id, // sync or full_sync
129			), Jetpack::xmlrpc_api_url() );
130
131			$rpc = new Jetpack_IXR_Client( array(
132			'url' => $url,
133			'user_id' => JETPACK_MASTER_USER,
134			'timeout' => 30,
135			) );
136
137			$result = $rpc->query( 'jetpack.syncActions', $data );
138
139			if ( ! $result ) {
140			return $rpc->get_jetpack_error();
141			}
142
143			return $rpc->getResponse();
144			}
145
146			static function schedule_initial_sync( $new_version = null, $old_version = null ) {
147			$initial_sync_config = array(
148			'options' => true,
149			'network_options' => true,
150			'functions' => true,
151			'constants' => true,
152			);
153
154			if ( $old_version && ( version_compare( $old_version, '4.2', '<' ) ) ) {
155			$initial_sync_config['users'] = 'initial';
156			}
157
158			// we need this function call here because we have to run this function
159			// reeeeally early in init, before WP_CRON_LOCK_TIMEOUT is defined.
160			wp_functionality_constants();
161
162			if ( is_multisite() ) {
163			// stagger initial syncs for multisite blogs so they don't all pile on top of each other
164			$time_offset = ( rand() / getrandmax() ) * self::INITIAL_SYNC_MULTISITE_INTERVAL * get_blog_count();
165			} else {
166			$time_offset = 1;
167			}
168
169			self::schedule_full_sync(
170			$initial_sync_config,
171			$time_offset
172			);
173			}
174
175			static function schedule_full_sync( $modules = null, $time_offset = 1 ) {
176			if ( ! self::sync_allowed() ) {
177			return false;
178			}
179
180			if ( self::is_scheduled_full_sync() ) {
181			self::unschedule_all_full_syncs();
182			}
183
184			if ( $modules ) {
185			wp_schedule_single_event( time() + $time_offset, 'jetpack_sync_full', array( $modules ) );
186			} else {
187			wp_schedule_single_event( time() + $time_offset, 'jetpack_sync_full' );
188			}
189
190			if ( $time_offset === 1 ) {
191			spawn_cron();
192			}
193
194			return true;
195			}
196
197			static function unschedule_all_full_syncs() {
198			foreach ( _get_cron_array() as $timestamp => $cron ) {
199			if ( ! empty( $cron['jetpack_sync_full'] ) ) {
200			foreach( $cron['jetpack_sync_full'] as $key => $config ) {
201			wp_unschedule_event( $timestamp, 'jetpack_sync_full', $config['args'] );
202			}
203			}
204			}
205			}
206
207			static function is_scheduled_full_sync( $modules = null ) {
208			if ( is_null( $modules ) ) {
209			$crons = _get_cron_array();
210
211			foreach ( $crons as $timestamp => $cron ) {
212			if ( ! empty( $cron['jetpack_sync_full'] ) ) {
213			return true;
214			}
215			}
216			return false;
217			}
218
219			return !! wp_next_scheduled( 'jetpack_sync_full', array( $modules ) );
220			}
221
222			static function do_full_sync( $modules = null ) {
223			if ( ! self::sync_allowed() ) {
224			return;
225			}
226
227			self::initialize_listener();
228			Jetpack_Sync_Modules::get_module( 'full-sync' )->start( $modules );
229			self::do_cron_sync(); // immediately run a cron sync, which sends pending data
230			}
231
232			static function minute_cron_schedule( $schedules ) {
233			if( ! isset( $schedules["1min"] ) ) {
234			$schedules["1min"] = array(
235			'interval' => 60,
236			'display' => __( 'Every minute' )
237			);
238			}
239			return $schedules;
240			}
241
242			// try to send actions until we run out of things to send,
243			// or have to wait more than 15s before sending again,
244			// or we hit a lock or some other sending issue
245			static function do_cron_sync() {
246			if ( ! self::sync_allowed() ) {
247			return;
248			}
249
250			self::initialize_sender();
251
252			// remove shutdown hook - no need to sync twice
253			if ( has_action( 'shutdown', array( self::$sender, 'do_sync' ) ) ) {
254			remove_action( 'shutdown', array( self::$sender, 'do_sync' ) );
255			}
256
257			do {
258			$next_sync_time = self::$sender->get_next_sync_time();
259
260			if ( $next_sync_time ) {
261			$delay = $next_sync_time - time() + 1;
262			if ( $delay > 15 ) {
263			break;
264			} elseif ( $delay > 0 ) {
265			sleep( $delay );
266			}
267			}
268
269			$result = self::$sender->do_sync();
270			} while ( $result );
271			}
272
273			static function initialize_listener() {
274			require_once dirname( __FILE__ ) . '/class.jetpack-sync-listener.php';
275			self::$listener = Jetpack_Sync_Listener::get_instance();
276			}
277
278			static function initialize_sender() {
279			require_once dirname( __FILE__ ) . '/class.jetpack-sync-sender.php';
280			self::$sender = Jetpack_Sync_Sender::get_instance();
281
282			// bind the sending process
283			add_filter( 'jetpack_sync_send_data', array( __CLASS__, 'send_data' ), 10, 4 );
284			}
285			}
286
287			// Allow other plugins to add filters before we initialize the actions.
288			// Load the listeners if before modules get loaded so that we can capture version changes etc.
289			add_action( 'init', array( 'Jetpack_Sync_Actions', 'init' ), 90 );
290
291			// We need to define this here so that it's hooked before `updating_jetpack_version` is called
292			add_action( 'updating_jetpack_version', array( 'Jetpack_Sync_Actions', 'schedule_initial_sync' ), 10, 2 );
293

Automattic / jetpack

Push — fix/initial-sync-arguments-for... ( 264142 )

Jetpack_Sync_Actions::is_scheduled_full_sync() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like