Jetpack_Flickr_Widget::update() - Code Metrics - Inspection of "Content Options: Blog Display: Exclude page conten..." - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — content-options-blog-display-7... ( 930de1 )

unknown

created 2017-05-18 10:21 UTC

Jetpack_Flickr_Widget::update() C

↳ Parent: Jetpack_Flickr_Widget

Complexity

Conditions	7
Paths	24

Size

Total Lines	31
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	18
nc	24
nop	2
dl	0
loc	31
rs	6.7272
c	0
b	0
f	0

<?php
/**
 * Disable direct access/execution to/of the widget code.
 */
if ( ! defined( 'ABSPATH' ) ) {
	exit;
}

if ( ! class_exists( 'Jetpack_Flickr_Widget' ) ) {
	/**
	 * Flickr Widget
	 *
	 * Display your recent Flickr photos.
	 */
	class Jetpack_Flickr_Widget extends WP_Widget {
		/**
		 * Constructor.
		 */
		function __construct() {
			parent::__construct(
				'flickr',
				/** This filter is documented in modules/widgets/facebook-likebox.php */
				apply_filters( 'jetpack_widget_name', esc_html__( 'Flickr', 'jetpack' ) ),
				array(
					'description' => esc_html__( 'Display your recent Flickr photos.', 'jetpack' ),
					'customize_selective_refresh' => true,
				),
				array()
			);

			if ( is_active_widget( false, false, $this->id_base ) || is_customize_preview() ) {
				add_action( 'wp_enqueue_scripts', array( $this, 'enqueue_style' ) );
			}
		}

		/**
		 * Enqueue style.
		 */
		function enqueue_style() {
			wp_enqueue_style( 'flickr-widget-style', plugins_url( 'flickr/style.css', __FILE__ ), array(), '20170405' );
		}

		/**
		 * Return an associative array of default values.
		 *
		 * These values are used in new widgets.
		 *
		 * @return array Default values for the widget options.
		 */
		public function defaults() {
			return array(
				'title'             => esc_html__( 'Flickr Photos', 'jetpack' ),
				'items'             => 3,
				'flickr_image_size' => 'thumbnail',
				'flickr_rss_url'    => ''
			);
		}

		/**
		 * Front-end display of the widget.
		 *
		 * @param array $args     Widget arguments.
		 * @param array $instance Saved values from database.
		 */
		public function widget( $args, $instance ) {
			$instance = wp_parse_args( $instance, $this->defaults() );

			$image_size_string = 'small' == $instance['flickr_image_size'] ? '_m.jpg' : '_t.jpg';

			if ( ! empty( $instance['flickr_rss_url'] ) ) {

				/*
				 * Parse the URL, and rebuild a URL that's sure to display images.
				 * Some Flickr Feeds do not display images by default.
				 */
				$flickr_parameters = parse_url( htmlspecialchars_decode( $instance['flickr_rss_url'] ) );

				// Is it a Flickr Feed.
				if (
					! empty( $flickr_parameters['host'] )
					&& ! empty( $flickr_parameters['query'] )
					&& false !== strpos( $flickr_parameters['host'], 'flickr' )
				) {
					parse_str( $flickr_parameters['query'], $vars );

					// Do we have an ID in the feed? Let's continue.
					if ( isset( $vars['id'] ) ) {

						// Flickr Feeds can be used for groups or for individuals.
						if (
							! empty( $flickr_parameters['path'] )
							&& false !== strpos( $flickr_parameters['path'], 'groups' )
						) {
							$feed_url = 'https://api.flickr.com/services/feeds/groups_pool.gne';
						} else {
							$feed_url = 'https://api.flickr.com/services/feeds/photos_public.gne';
						}

						// Build our new RSS feed.
						$rss_url = sprintf(
							'%1$s?id=%2$s&format=rss_200_enc',
							esc_url( $feed_url ),
							esc_attr( $vars['id'] )
						);
					}
				}
			} // End if().

			// Still no RSS feed URL? Get a default feed from Flickr to grab interesting photos.
			if ( empty( $rss_url ) ) {
				$rss_url = 'https://api.flickr.com/services/feeds/photos_interesting.gne?format=rss_200';
			}

			$rss = fetch_feed( $rss_url );

			$photos = '';
			if ( ! is_wp_error( $rss ) ) {
				foreach ( $rss->get_items( 0, $instance['items'] ) as $photo ) {
					if ( $enclosure = $photo->get_enclosure() ) {
						$src = str_replace( '_s.jpg', $image_size_string, $enclosure->get_thumbnail() );
					} else {
						$src = preg_match( '/src="(.*?)"/i', $photo->get_description(), $p );
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
						$src = str_replace( '_m.jpg', $image_size_string, $p[1] );
					}

					$photos .= '<a href="' . esc_url( $photo->get_permalink(), array( 'http', 'https' ) ) . '">';
					$photos .= '<img src="' . esc_url( $src, array( 'http', 'https' ) ) . '" ';
					$photos .= 'alt="' . esc_attr( $photo->get_title() ) . '" ';
					$photos .= 'border="0" ';
					$photos .= 'title="' . esc_attr( $photo->get_title() ) . '" ';
					$photos .= ' /></a><br /><br />';
				}
				if ( ! empty( $photos ) && class_exists( 'Jetpack_Photon' ) && Jetpack::is_module_active( 'photon' ) ) {
					$photos = Jetpack_Photon::filter_the_content( $photos );
				}

				$flickr_home = $rss->get_link();
			}

			echo $args['before_widget'];
			if ( empty( $photos ) ) {
				if ( current_user_can( 'edit_theme_options' ) ) {
					printf(
						'<p>%1$s<br />%2$s</p>',
						esc_html__( 'There are no photos to display. Make sure your Flickr feed URL is correct, and that your pictures are publicly accessible.', 'jetpack' ),
						esc_html__( '(Only admins can see this message)', 'jetpack' )
					);
				}
			} else {
				echo $args['before_title'] . esc_html( $instance['title'] ) . $args['after_title'];
				require( dirname( __FILE__ ) . '/flickr/widget.php' );
			}
			echo $args['after_widget'];
			/** This action is already documented in modules/widgets/gravatar-profile.php */
			do_action( 'jetpack_stats_extra', 'widget_view', 'flickr' );
		}

		/**
		 * Back-end widget form.
		 *
		 * @param array $instance Previously saved values from database.
		 */
		public function form( $instance ) {
			$instance = wp_parse_args( $instance, $this->defaults() );
			require( dirname( __FILE__ ) . '/flickr/form.php' );
		}

		/**
		 * Sanitize widget form values as they are saved.
		 *
		 * @param  array $new_instance Values just sent to be saved.
		 * @param  array $old_instance Previously saved values from database.
		 * @return array Updated safe values to be saved.
		 */
		public function update( $new_instance, $old_instance ) {
			$instance = array();
			$defaults = $this->defaults();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

			if ( isset( $new_instance['title'] ) ) {
				$instance['title'] = wp_kses( $new_instance['title'], array() );
			}

			if ( isset( $new_instance['items'] ) ) {
				$instance['items'] = intval( $new_instance['items'] );
			}

			if (
				isset( $new_instance['flickr_image_size'] ) &&
				in_array( $new_instance['flickr_image_size'], array( 'thumbnail', 'small' ) )
			) {
				$instance['flickr_image_size'] = $new_instance['flickr_image_size'];
			} else {
				$instance['flickr_image_size'] = 'thumbnail';
			}

			if ( isset( $new_instance['flickr_rss_url'] ) ) {
				$instance['flickr_rss_url'] = esc_url( $new_instance['flickr_rss_url'], array( 'http', 'https' ) );

				if ( strlen( $instance['flickr_rss_url'] ) < 10 ) {
					$instance['flickr_rss_url'] = '';
				}
			}

			return $instance;
		}
	}

	// Register Jetpack_Flickr_Widget widget.
	function jetpack_register_flickr_widget() {
		register_widget( 'Jetpack_Flickr_Widget' );
	}
	add_action( 'widgets_init', 'jetpack_register_flickr_widget' );
}


1		<?php
2		/**
3		* Disable direct access/execution to/of the widget code.
4		*/
5		if ( ! defined( 'ABSPATH' ) ) {
6		exit;
7		}
8
9		if ( ! class_exists( 'Jetpack_Flickr_Widget' ) ) {
10		/**
11		* Flickr Widget
12		*
13		* Display your recent Flickr photos.
14		*/
15		class Jetpack_Flickr_Widget extends WP_Widget {
16		/**
17		* Constructor.
18		*/
19	View Code Duplication	function __construct() {
20		parent::__construct(
21		'flickr',
22		/** This filter is documented in modules/widgets/facebook-likebox.php */
23		apply_filters( 'jetpack_widget_name', esc_html__( 'Flickr', 'jetpack' ) ),
24		array(
25		'description' => esc_html__( 'Display your recent Flickr photos.', 'jetpack' ),
26		'customize_selective_refresh' => true,
27		),
28		array()
29		);
30
31		if ( is_active_widget( false, false, $this->id_base ) \|\| is_customize_preview() ) {
32		add_action( 'wp_enqueue_scripts', array( $this, 'enqueue_style' ) );
33		}
34		}
35
36		/**
37		* Enqueue style.
38		*/
39		function enqueue_style() {
40		wp_enqueue_style( 'flickr-widget-style', plugins_url( 'flickr/style.css', __FILE__ ), array(), '20170405' );
41		}
42
43		/**
44		* Return an associative array of default values.
45		*
46		* These values are used in new widgets.
47		*
48		* @return array Default values for the widget options.
49		*/
50		public function defaults() {
51		return array(
52		'title' => esc_html__( 'Flickr Photos', 'jetpack' ),
53		'items' => 3,
54		'flickr_image_size' => 'thumbnail',
55		'flickr_rss_url' => ''
56		);
57		}
58
59		/**
60		* Front-end display of the widget.
61		*
62		* @param array $args Widget arguments.
63		* @param array $instance Saved values from database.
64		*/
65		public function widget( $args, $instance ) {
66		$instance = wp_parse_args( $instance, $this->defaults() );
67
68		$image_size_string = 'small' == $instance['flickr_image_size'] ? '_m.jpg' : '_t.jpg';
69
70		if ( ! empty( $instance['flickr_rss_url'] ) ) {
71
72		/*
73		* Parse the URL, and rebuild a URL that's sure to display images.
74		* Some Flickr Feeds do not display images by default.
75		*/
76		$flickr_parameters = parse_url( htmlspecialchars_decode( $instance['flickr_rss_url'] ) );
77
78		// Is it a Flickr Feed.
79		if (
80		! empty( $flickr_parameters['host'] )
81		&& ! empty( $flickr_parameters['query'] )
82		&& false !== strpos( $flickr_parameters['host'], 'flickr' )
83		) {
84		parse_str( $flickr_parameters['query'], $vars );
85
86		// Do we have an ID in the feed? Let's continue.
87		if ( isset( $vars['id'] ) ) {
88
89		// Flickr Feeds can be used for groups or for individuals.
90		if (
91		! empty( $flickr_parameters['path'] )
92		&& false !== strpos( $flickr_parameters['path'], 'groups' )
93		) {
94		$feed_url = 'https://api.flickr.com/services/feeds/groups_pool.gne';
95		} else {
96		$feed_url = 'https://api.flickr.com/services/feeds/photos_public.gne';
97		}
98
99		// Build our new RSS feed.
100		$rss_url = sprintf(
101		'%1$s?id=%2$s&format=rss_200_enc',
102		esc_url( $feed_url ),
103		esc_attr( $vars['id'] )
104		);
105		}
106		}
107		} // End if().
108
109		// Still no RSS feed URL? Get a default feed from Flickr to grab interesting photos.
110		if ( empty( $rss_url ) ) {
111		$rss_url = 'https://api.flickr.com/services/feeds/photos_interesting.gne?format=rss_200';
112		}
113
114		$rss = fetch_feed( $rss_url );
115
116		$photos = '';
117		if ( ! is_wp_error( $rss ) ) {
118		foreach ( $rss->get_items( 0, $instance['items'] ) as $photo ) {
119		if ( $enclosure = $photo->get_enclosure() ) {
120		$src = str_replace( '_s.jpg', $image_size_string, $enclosure->get_thumbnail() );
121		} else {
122		$src = preg_match( '/src="(.*?)"/i', $photo->get_description(), $p );
		0 ignored issues – show Unused Code introduced 2017-04-06 19:25 UTC by Report Bug Copy Issue Report `$src` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
123		$src = str_replace( '_m.jpg', $image_size_string, $p[1] );
124		}
125
126		$photos .= '<a href="' . esc_url( $photo->get_permalink(), array( 'http', 'https' ) ) . '">';
127		$photos .= '<img src="' . esc_url( $src, array( 'http', 'https' ) ) . '" ';
128		$photos .= 'alt="' . esc_attr( $photo->get_title() ) . '" ';
129		$photos .= 'border="0" ';
130		$photos .= 'title="' . esc_attr( $photo->get_title() ) . '" ';
131		$photos .= ' /></a><br /><br />';
132		}
133		if ( ! empty( $photos ) && class_exists( 'Jetpack_Photon' ) && Jetpack::is_module_active( 'photon' ) ) {
134		$photos = Jetpack_Photon::filter_the_content( $photos );
135		}
136
137		$flickr_home = $rss->get_link();
138		}
139
140		echo $args['before_widget'];
141		if ( empty( $photos ) ) {
142		if ( current_user_can( 'edit_theme_options' ) ) {
143		printf(
144		'<p>%1$s<br />%2$s</p>',
145		esc_html__( 'There are no photos to display. Make sure your Flickr feed URL is correct, and that your pictures are publicly accessible.', 'jetpack' ),
146		esc_html__( '(Only admins can see this message)', 'jetpack' )
147		);
148		}
149		} else {
150		echo $args['before_title'] . esc_html( $instance['title'] ) . $args['after_title'];
151		require( dirname( __FILE__ ) . '/flickr/widget.php' );
152		}
153		echo $args['after_widget'];
154		/** This action is already documented in modules/widgets/gravatar-profile.php */
155		do_action( 'jetpack_stats_extra', 'widget_view', 'flickr' );
156		}
157
158		/**
159		* Back-end widget form.
160		*
161		* @param array $instance Previously saved values from database.
162		*/
163		public function form( $instance ) {
164		$instance = wp_parse_args( $instance, $this->defaults() );
165		require( dirname( __FILE__ ) . '/flickr/form.php' );
166		}
167
168		/**
169		* Sanitize widget form values as they are saved.
170		*
171		* @param array $new_instance Values just sent to be saved.
172		* @param array $old_instance Previously saved values from database.
173		* @return array Updated safe values to be saved.
174		*/
175		public function update( $new_instance, $old_instance ) {
176		$instance = array();
177		$defaults = $this->defaults();
		0 ignored issues – show Unused Code introduced 2017-04-07 11:05 UTC by Report Bug Copy Issue Report `$defaults` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
178
179		if ( isset( $new_instance['title'] ) ) {
180		$instance['title'] = wp_kses( $new_instance['title'], array() );
181		}
182
183		if ( isset( $new_instance['items'] ) ) {
184		$instance['items'] = intval( $new_instance['items'] );
185		}
186
187		if (
188		isset( $new_instance['flickr_image_size'] ) &&
189		in_array( $new_instance['flickr_image_size'], array( 'thumbnail', 'small' ) )
190		) {
191		$instance['flickr_image_size'] = $new_instance['flickr_image_size'];
192		} else {
193		$instance['flickr_image_size'] = 'thumbnail';
194		}
195
196		if ( isset( $new_instance['flickr_rss_url'] ) ) {
197		$instance['flickr_rss_url'] = esc_url( $new_instance['flickr_rss_url'], array( 'http', 'https' ) );
198
199		if ( strlen( $instance['flickr_rss_url'] ) < 10 ) {
200		$instance['flickr_rss_url'] = '';
201		}
202		}
203
204		return $instance;
205		}
206		}
207
208		// Register Jetpack_Flickr_Widget widget.
209		function jetpack_register_flickr_widget() {
210		register_widget( 'Jetpack_Flickr_Widget' );
211		}
212		add_action( 'widgets_init', 'jetpack_register_flickr_widget' );
213		}
214

Automattic / jetpack

Push — content-options-blog-display-7... ( 930de1 )

Jetpack_Flickr_Widget::update() C

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like