Issues in class.jetpack-data.php - New Issues - Inspection of "Moves `get_access_token` to Connection package." - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — add/jetpack-data-methods ( d7e5a6...2c93cb )

unknown

created 2019-06-06 00:20 UTC

class.jetpack-data.php (2 issues)

Labels

Documentation 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use \Automattic\Jetpack\Connection\Manager as Connection_Manager;

class Jetpack_Data {
	const MAGIC_NORMAL_TOKEN_KEY = ';normal;';

	/**
	 * @deprecated 7.5 Use Connection_Manager instead.
	 */
	public static function get_access_token( $user_id = false, $token_key = false ) {
		$connection = new Connection_Manager();
		return $connection->get_access_token( $user_id, $token_key );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
	}
}


1			<?php
2
3			use \Automattic\Jetpack\Connection\Manager as Connection_Manager;
4
5			class Jetpack_Data {
6			const MAGIC_NORMAL_TOKEN_KEY = ';normal;';
7
8			/**
9			* @deprecated 7.5 Use Connection_Manager instead.
10			*/
11			public static function get_access_token( $user_id = false, $token_key = false ) {
12			$connection = new Connection_Manager();
13			return $connection->get_access_token( $user_id, $token_key );
			0 ignored issues – show Documentation introduced 2019-06-06 00:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$user_id` is of type `boolean`, but the function expects a `false\|integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2019-06-06 00:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$token_key` is of type `boolean`, but the function expects a `false\|string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
14			}
15			}
16

Automattic / jetpack

Push — add/jetpack-data-methods ( d7e5a6...2c93cb )

class.jetpack-data.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like