Jetpack_Sync::slice_ids() - Code Metrics - Inspection of "Add post meta syncing" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — add/sync-rest-2 ( 0f1049...2638b5 )

unknown

created 2016-03-24 00:14 UTC

Jetpack_Sync::slice_ids() B

↳ Parent: Jetpack_Sync

Complexity

Conditions	5
Paths	6

Size

Total Lines	27
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	27
rs	8.439
cc	5
eloc	19
nc	6
nop	3

<?php

require_once 'class.jetpack-sync-posts.php';
require_once 'class.jetpack-sync-post-meta.php';
require_once 'class.jetpack-sync-comments.php';
require_once 'class.jetpack-sync-options.php';
require_once 'class.jetpack-sync-network-options.php';
require_once 'class.jetpack-sync-functions.php';
require_once 'class.jetpack-sync-constants.php';
require_once 'class.jetpack-sync-users.php';
require_once 'class.jetpack-sync-updates.php';
require_once 'class.jetpack-sync-reindex.php';
require_once 'class.jetpack-sync-themes.php';
if ( is_multisite() ) {
	require_once 'class.jetpack-sync-network-options.php';
}

class Jetpack_Sync {
	static $do_shutdown = false;
class A {
    var $property;
}

	static $cron_name = 'jetpack_sync_next_beat';
class A {
    var $property;
}


	static function init() {
		Jetpack_Sync_Posts::init();
		Jetpack_Sync_Comments::init();
		Jetpack_Sync_Options::init();
		Jetpack_Sync_Users::init();
		Jetpack_Sync_Network_Options::init();
		Jetpack_Sync_Updates::init();
		Jetpack_Sync_Reindex::init();

		// On jetpack version bump
		add_action( 'updating_jetpack_version', array( __CLASS__, 'schedule_full_sync' ) );
		// On jetpack registration
		add_action( 'jetpack_site_registered', array( __CLASS__, 'schedule_full_sync' ) );
		// Add on cron
		add_action( self::$cron_name, array( __CLASS__, 'cron_exec' ) );
	}

	static function schedule_sync() {
		if ( ! self::$do_shutdown ) {
			self::$do_shutdown = true;
			if ( function_exists( 'ignore_user_abort' ) ) {
				ignore_user_abort( true );
			}
			add_action( 'shutdown', array( __CLASS__, 'sync_partial_on_shutdown' ), 9 );
		}
	}

	static function cron_exec() {
		Jetpack::xmlrpc_async_call( 'jetpack.sync_v2', self::get_data_to_sync() );
	}

	static function schedule_next_cron() {
		if( ! wp_next_scheduled( self::$cron_name ) ) {
			$next_minute = time() + 60;
			wp_schedule_single_event( $next_minute, self::$cron_name );
		}
	}

	static function remove_cron() {
		$timestamp = wp_next_scheduled( self::$cron_name );
		wp_unschedule_event( $timestamp, self::$cron_name );
	}

	static function slice_ids( $ids, $max, $option_name ) {
		$lock_name = $option_name . '_lock';
		$is_locked = get_option( $lock_name );
		$post_ids_que = get_option( $option_name );

		if( ! empty( $post_ids_que ) ) {
			$ids = array_unique( array_merge( $ids, $post_ids_que ) );
		}
		$pid = getmypid();
		if ( ! $is_locked || $pid === $is_locked ) {
			update_option( $lock_name, $pid );

			if ( sizeof( $ids ) <= $max ) {
				delete_option( $option_name );
				delete_option( $lock_name );
				return $ids;
			}
			$to_save = array_splice( $ids, $max );
			update_option( $option_name, $to_save );
			delete_option( $lock_name );

			Jetpack_Sync::schedule_next_cron();
		} else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}

		}
		return $ids;
	}

	static function schedule_full_sync() {
		add_action( 'shutdown', array( __CLASS__, 'sync_full_on_shutdown' ), 9 );
	}

	static function sync_partial_on_shutdown() {
		if ( ! self::should_sync() ) {
			return;
		}
		Jetpack::xmlrpc_async_call( 'jetpack.sync_v2', self::get_data_to_sync() );
	}

	static function sync_full_on_shutdown() {
		if ( ! self::should_sync() ) {
			return;
		}
		Jetpack::xmlrpc_async_call( 'jetpack.sync_v2', self::get_all_data_() );

	}

	static function should_sync() {
		if ( defined( 'WP_IMPORTING' ) && WP_IMPORTING ) {
			return false;
		}
		if ( Jetpack::is_development_mode() || Jetpack::is_staging_site() ) {
			return false;
		}

		return true;
	}

	static function get_data_to_sync() {
		$send['options']         = Jetpack_Sync_Options::get_to_sync();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		$send['options_delete']  = Jetpack_Sync_Options::get_to_delete();
		$send['constants']       = self::sync_if_has_changed( Jetpack_Sync_Constants::$check_sum_id, Jetpack_Sync_Constants::get_all() );

		$send['posts']           = Jetpack_Sync_Posts::posts_to_sync();
		$send['posts_delete']    = Jetpack_Sync_Posts::posts_to_delete();
		$send['comments']        = Jetpack_Sync_Comments::comments_to_sync();
		$send['delete_comments'] = Jetpack_Sync_Comments::comments_to_delete();
		$send['updates']         = Jetpack_Sync_Updates::get_to_sync();
		$send['themes']           = Jetpack_Sync_Themes::get_to_sync();

		if ( false === ( $do_check = get_transient( 'jetpack_sync_functions' ) ) ) {
			$send['functions'] = self::sync_if_has_changed( Jetpack_Sync_Functions::$check_sum_id, Jetpack_Sync_Functions::get_all() );

			set_transient( 'jetpack_sync_functions', true, MINUTE_IN_SECONDS );
		}
		if ( is_multisite() ) {
			$send['network_options']        = Jetpack_Sync_Network_Options::get_to_sync();
			$send['network_options_delete'] = Jetpack_Sync_Network_Options::get_to_delete();
		}

		return array_filter( $send );
	}

	static function get_all_data() {
		$send['options']   = Jetpack_Sync_Options::get_all();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		$send['constants'] = Jetpack_Sync_Constants::get_all();
		$send['functions'] = Jetpack_Sync_Functions::get_all();
		$send['updates']   = Jetpack_Sync_Updates::get_all();
		$send['themes']     = Jetpack_Sync_Themes::get_all();
		if ( is_multisite() ) {
			$send['network_options'] = Jetpack_Sync_Network_Options::get_all();
		}

		return $send;
	}

	static function sync_if_has_changed( $check_sum_id, $values ) {
		$current_check_sum = self::get_check_sum( $values );
		if ( Jetpack_Options::get_option( $check_sum_id ) !== $current_check_sum ) {
			Jetpack_Options::update_option( $check_sum_id, $current_check_sum );

			return $values;
		}

		return null;
	}

	static function get_check_sum( $values ) {
		return crc32( json_encode( $values ) );
	}

}

Jetpack_Sync::init();


1			<?php
2
3			require_once 'class.jetpack-sync-posts.php';
4			require_once 'class.jetpack-sync-post-meta.php';
5			require_once 'class.jetpack-sync-comments.php';
6			require_once 'class.jetpack-sync-options.php';
7			require_once 'class.jetpack-sync-network-options.php';
8			require_once 'class.jetpack-sync-functions.php';
9			require_once 'class.jetpack-sync-constants.php';
10			require_once 'class.jetpack-sync-users.php';
11			require_once 'class.jetpack-sync-updates.php';
12			require_once 'class.jetpack-sync-reindex.php';
13			require_once 'class.jetpack-sync-themes.php';
14			if ( is_multisite() ) {
15			require_once 'class.jetpack-sync-network-options.php';
16			}
17
18			class Jetpack_Sync {
19			static $do_shutdown = false;
			0 ignored issues – show Coding Style introduced 2016-03-17 19:02 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$do_shutdown`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
20
21			static $cron_name = 'jetpack_sync_next_beat';
			0 ignored issues – show Coding Style introduced 2016-03-22 22:53 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$cron_name`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
22
23
24			static function init() {
25			Jetpack_Sync_Posts::init();
26			Jetpack_Sync_Comments::init();
27			Jetpack_Sync_Options::init();
28			Jetpack_Sync_Users::init();
29			Jetpack_Sync_Network_Options::init();
30			Jetpack_Sync_Updates::init();
31			Jetpack_Sync_Reindex::init();
32
33			// On jetpack version bump
34			add_action( 'updating_jetpack_version', array( __CLASS__, 'schedule_full_sync' ) );
35			// On jetpack registration
36			add_action( 'jetpack_site_registered', array( __CLASS__, 'schedule_full_sync' ) );
37			// Add on cron
38			add_action( self::$cron_name, array( __CLASS__, 'cron_exec' ) );
39			}
40
41			static function schedule_sync() {
42			if ( ! self::$do_shutdown ) {
43			self::$do_shutdown = true;
44			if ( function_exists( 'ignore_user_abort' ) ) {
45			ignore_user_abort( true );
46			}
47			add_action( 'shutdown', array( __CLASS__, 'sync_partial_on_shutdown' ), 9 );
48			}
49			}
50
51			static function cron_exec() {
52			Jetpack::xmlrpc_async_call( 'jetpack.sync_v2', self::get_data_to_sync() );
53			}
54
55			static function schedule_next_cron() {
56			if( ! wp_next_scheduled( self::$cron_name ) ) {
57			$next_minute = time() + 60;
58			wp_schedule_single_event( $next_minute, self::$cron_name );
59			}
60			}
61
62			static function remove_cron() {
63			$timestamp = wp_next_scheduled( self::$cron_name );
64			wp_unschedule_event( $timestamp, self::$cron_name );
65			}
66
67			static function slice_ids( $ids, $max, $option_name ) {
68			$lock_name = $option_name . '_lock';
69			$is_locked = get_option( $lock_name );
70			$post_ids_que = get_option( $option_name );
71
72			if( ! empty( $post_ids_que ) ) {
73			$ids = array_unique( array_merge( $ids, $post_ids_que ) );
74			}
75			$pid = getmypid();
76			if ( ! $is_locked \|\| $pid === $is_locked ) {
77			update_option( $lock_name, $pid );
78
79			if ( sizeof( $ids ) <= $max ) {
80			delete_option( $option_name );
81			delete_option( $lock_name );
82			return $ids;
83			}
84			$to_save = array_splice( $ids, $max );
85			update_option( $option_name, $to_save );
86			delete_option( $lock_name );
87
88			Jetpack_Sync::schedule_next_cron();
89			} else {
			0 ignored issues – show Unused Code introduced 2016-03-24 00:23 UTC by Report Bug Copy Issue Report This `else` statement is empty and can be removed. This check looks for the `else` branches of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `else` branches can be removed. if (rand(1, 6) > 3) { print "Check failed"; } else { //print "Check succeeded"; } could be turned into if (rand(1, 6) > 3) { print "Check failed"; } This is much more concise to read. Loading history...
90
91			}
92			return $ids;
93			}
94
95			static function schedule_full_sync() {
96			add_action( 'shutdown', array( __CLASS__, 'sync_full_on_shutdown' ), 9 );
97			}
98
99			static function sync_partial_on_shutdown() {
100			if ( ! self::should_sync() ) {
101			return;
102			}
103			Jetpack::xmlrpc_async_call( 'jetpack.sync_v2', self::get_data_to_sync() );
104			}
105
106			static function sync_full_on_shutdown() {
107			if ( ! self::should_sync() ) {
108			return;
109			}
110			Jetpack::xmlrpc_async_call( 'jetpack.sync_v2', self::get_all_data_() );
			0 ignored issues – show Bug introduced 2016-03-19 00:14 UTC by Report Bug Copy Issue Report The method `get_all_data_()` does not exist on `Jetpack_Sync`. Did you maybe mean `get_all_data()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
111			}
112
113			static function should_sync() {
114			if ( defined( 'WP_IMPORTING' ) && WP_IMPORTING ) {
115			return false;
116			}
117			if ( Jetpack::is_development_mode() \|\| Jetpack::is_staging_site() ) {
118			return false;
119			}
120
121			return true;
122			}
123
124			static function get_data_to_sync() {
125			$send['options'] = Jetpack_Sync_Options::get_to_sync();
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-03-16 16:33 UTC by Report Bug Copy Issue Report `$send` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$send = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
126			$send['options_delete'] = Jetpack_Sync_Options::get_to_delete();
127			$send['constants'] = self::sync_if_has_changed( Jetpack_Sync_Constants::$check_sum_id, Jetpack_Sync_Constants::get_all() );
			0 ignored issues – show Bug introduced 2016-03-15 14:05 UTC by Report Bug Copy Issue Report The property `check_sum_id` cannot be accessed from this context as it is declared `private` in class `Jetpack_Sync_Constants`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
128			$send['posts'] = Jetpack_Sync_Posts::posts_to_sync();
129			$send['posts_delete'] = Jetpack_Sync_Posts::posts_to_delete();
130			$send['comments'] = Jetpack_Sync_Comments::comments_to_sync();
131			$send['delete_comments'] = Jetpack_Sync_Comments::comments_to_delete();
132			$send['updates'] = Jetpack_Sync_Updates::get_to_sync();
133			$send['themes'] = Jetpack_Sync_Themes::get_to_sync();
134
135			if ( false === ( $do_check = get_transient( 'jetpack_sync_functions' ) ) ) {
136			$send['functions'] = self::sync_if_has_changed( Jetpack_Sync_Functions::$check_sum_id, Jetpack_Sync_Functions::get_all() );
			0 ignored issues – show Bug introduced 2016-03-15 14:05 UTC by Report Bug Copy Issue Report The property `check_sum_id` cannot be accessed from this context as it is declared `private` in class `Jetpack_Sync_Functions`. This check looks for access to properties that are not accessible from the current context. If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class. Loading history...
137			set_transient( 'jetpack_sync_functions', true, MINUTE_IN_SECONDS );
138			}
139			if ( is_multisite() ) {
140			$send['network_options'] = Jetpack_Sync_Network_Options::get_to_sync();
141			$send['network_options_delete'] = Jetpack_Sync_Network_Options::get_to_delete();
142			}
143
144			return array_filter( $send );
145			}
146
147			static function get_all_data() {
148			$send['options'] = Jetpack_Sync_Options::get_all();
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-03-17 19:02 UTC by Report Bug Copy Issue Report `$send` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$send = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
149			$send['constants'] = Jetpack_Sync_Constants::get_all();
150			$send['functions'] = Jetpack_Sync_Functions::get_all();
151			$send['updates'] = Jetpack_Sync_Updates::get_all();
152			$send['themes'] = Jetpack_Sync_Themes::get_all();
153			if ( is_multisite() ) {
154			$send['network_options'] = Jetpack_Sync_Network_Options::get_all();
155			}
156
157			return $send;
158			}
159
160			static function sync_if_has_changed( $check_sum_id, $values ) {
161			$current_check_sum = self::get_check_sum( $values );
162			if ( Jetpack_Options::get_option( $check_sum_id ) !== $current_check_sum ) {
163			Jetpack_Options::update_option( $check_sum_id, $current_check_sum );
164
165			return $values;
166			}
167
168			return null;
169			}
170
171			static function get_check_sum( $values ) {
172			return crc32( json_encode( $values ) );
173			}
174
175			}
176
177			Jetpack_Sync::init();
178

Automattic / jetpack

Push — add/sync-rest-2 ( 0f1049...2638b5 )

Jetpack_Sync::slice_ids() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like