Redirect - Code Metrics - Inspection of "Update dependency css-loader to v3.5.2" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — renovate/css-loader-3.x ( 7c56cb...69f6e1 )

unknown

created 2020-04-23 21:14 UTC

Redirect A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	66
Duplicated Lines	9.09 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	6
loc	66
rs	10
c	0
b	0
f	0
wmc	7
lcom	0
cbo	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	1	1
A	build_raw_urls()	6	6	1
A	get_url()	0	26	5

How to fix Duplicated Code

<?php
/**
 * Jetpack Redirect package.
 *
 * @package  automattic/jetpack-redirect
 */

namespace Automattic\Jetpack;

/**
 * Class Redirect
 */
class Redirect {
	/**
	 * Constructor.
	 *
	 * Static-only class, so nothing here.
	 */
	private function __construct() {}

	/**
	 * Strip http:// or https:// from a url, replaces forward slash with ::,
	 * so we can bring them directly to their site in calypso.
	 *
	 * @param string $url the full URL.
	 * @return string $url without the guff
	 */
	private static function build_raw_urls( $url ) {
		$strip_http = '/.*?:\/\//i';
		$url        = preg_replace( $strip_http, '', $url );
		$url        = str_replace( '/', '::', $url );
		return $url;
	}

	/**
	 * Builds and returns an URL using the jetpack.com/redirect service
	 *
	 * Note to WP.com: Changes to this method must be synced to wpcom
	 *
	 * @param string       $source The URL handler registered in the server.
	 * @param array|string $args {
	 *    Optional. Additional arguments to build the url.
	 *
	 *    @type string $site URL of the site; Default is current site.
	 *    @type string $path Additional path to be appended to the URL.
	 *    @type string $query Query parameters to be added to the URL.
	 *    @type string $anchor Anchor to be added to the URL.
	 * }
	 *
	 * @return string The built URL
	 */
	public static function get_url( $source, $args = array() ) {

		$url           = 'https://jetpack.com/redirect';
		$args          = wp_parse_args( $args, array( 'site' => self::build_raw_urls( get_home_url() ) ) );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$accepted_args = array( 'site', 'path', 'query', 'anchor' );

		$to_be_added = array(
			'source' => rawurlencode( $source ),
		);

		foreach ( $args as $arg_name => $arg_value ) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }

			if ( ! in_array( $arg_name, $accepted_args, true ) || empty( $arg_value ) ) {
				continue;
			}

			$to_be_added[ $arg_name ] = rawurlencode( $arg_value );

		}

		if ( ! empty( $to_be_added ) ) {
			$url = add_query_arg( $to_be_added, $url );
		}

		return $url;
	}
}


1		<?php
2		/**
3		* Jetpack Redirect package.
4		*
5		* @package automattic/jetpack-redirect
6		*/
7
8		namespace Automattic\Jetpack;
9
10		/**
11		* Class Redirect
12		*/
13		class Redirect {
14		/**
15		* Constructor.
16		*
17		* Static-only class, so nothing here.
18		*/
19		private function __construct() {}
20
21		/**
22		* Strip http:// or https:// from a url, replaces forward slash with ::,
23		* so we can bring them directly to their site in calypso.
24		*
25		* @param string $url the full URL.
26		* @return string $url without the guff
27		*/
28	View Code Duplication	private static function build_raw_urls( $url ) {
29		$strip_http = '/.*?:\/\//i';
30		$url = preg_replace( $strip_http, '', $url );
31		$url = str_replace( '/', '::', $url );
32		return $url;
33		}
34
35		/**
36		* Builds and returns an URL using the jetpack.com/redirect service
37		*
38		* Note to WP.com: Changes to this method must be synced to wpcom
39		*
40		* @param string $source The URL handler registered in the server.
41		* @param array\|string $args {
42		* Optional. Additional arguments to build the url.
43		*
44		* @type string $site URL of the site; Default is current site.
45		* @type string $path Additional path to be appended to the URL.
46		* @type string $query Query parameters to be added to the URL.
47		* @type string $anchor Anchor to be added to the URL.
48		* }
49		*
50		* @return string The built URL
51		*/
52		public static function get_url( $source, $args = array() ) {
53
54		$url = 'https://jetpack.com/redirect';
55		$args = wp_parse_args( $args, array( 'site' => self::build_raw_urls( get_home_url() ) ) );
		0 ignored issues – show Documentation introduced 2020-04-07 23:45 UTC by Report Bug Copy Issue Report `array('site' => self::bu...w_urls(get_home_url()))` is of type `array<string,string,{"site":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
56		$accepted_args = array( 'site', 'path', 'query', 'anchor' );
57
58		$to_be_added = array(
59		'source' => rawurlencode( $source ),
60		);
61
62		foreach ( $args as $arg_name => $arg_value ) {
		0 ignored issues – show Bug introduced 2020-04-07 23:45 UTC by Report Bug Copy Issue Report The expression `$args` of type `array\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
63
64		if ( ! in_array( $arg_name, $accepted_args, true ) \|\| empty( $arg_value ) ) {
65		continue;
66		}
67
68		$to_be_added[ $arg_name ] = rawurlencode( $arg_value );
69
70		}
71
72		if ( ! empty( $to_be_added ) ) {
73		$url = add_query_arg( $to_be_added, $url );
74		}
75
76		return $url;
77		}
78		}
79

Automattic / jetpack

Push — renovate/css-loader-3.x ( 7c56cb...69f6e1 )

Redirect A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like