Conditions | 24 |
Paths | > 20000 |
Total Lines | 439 |
Code Lines | 287 |
Lines | 108 |
Ratio | 24.6 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
491 | public function add_my_sites_submenu( $wp_admin_bar ) { |
||
492 | $current_user = wp_get_current_user(); |
||
493 | |||
494 | $blog_name = get_bloginfo( 'name' ); |
||
495 | if ( empty( $blog_name ) ) { |
||
496 | $blog_name = $this->primary_site_slug; |
||
497 | } |
||
498 | |||
499 | if ( mb_strlen( $blog_name ) > 20 ) { |
||
500 | $blog_name = mb_substr( html_entity_decode( $blog_name, ENT_QUOTES ), 0, 20 ) . '…'; |
||
501 | } |
||
502 | |||
503 | $wp_admin_bar->add_menu( array( |
||
504 | 'parent' => 'root-default', |
||
505 | 'id' => 'blog', |
||
506 | 'title' => _n( 'My Site', 'My Sites', $this->user_site_count, 'jetpack' ), |
||
507 | 'href' => '#', |
||
508 | 'meta' => array( |
||
509 | 'class' => 'my-sites', |
||
510 | ), |
||
511 | ) ); |
||
512 | |||
513 | if ( $this->user_site_count > 1 ) { |
||
514 | $wp_admin_bar->add_menu( array( |
||
515 | 'parent' => 'blog', |
||
516 | 'id' => 'switch-site', |
||
517 | 'title' => __( 'Switch Site', 'jetpack' ), |
||
518 | 'href' => 'https://wordpress.com/sites', |
||
519 | ) ); |
||
520 | } else { |
||
521 | $wp_admin_bar->add_menu( array( |
||
522 | 'parent' => 'blog', |
||
523 | 'id' => 'new-site', |
||
524 | 'title' => __( '+ Add New WordPress', 'jetpack' ), |
||
525 | 'href' => 'https://wordpress.com/start?ref=admin-bar-logged-in', |
||
526 | ) ); |
||
527 | } |
||
528 | |||
529 | if ( is_user_member_of_blog( $current_user->ID ) ) { |
||
530 | $blavatar = ''; |
||
531 | $class = 'current-site'; |
||
532 | |||
533 | if ( has_site_icon() ) { |
||
534 | $src = get_site_icon_url(); |
||
535 | $blavatar = '<img class="avatar" src="'. esc_attr( $src ) . '" alt="Current site avatar">'; |
||
536 | $class = 'has-blavatar'; |
||
537 | } |
||
538 | |||
539 | $blog_info = '<div class="ab-site-icon">' . $blavatar . '</div>'; |
||
540 | $blog_info .= '<span class="ab-site-title">' . esc_html( $blog_name ) . '</span>'; |
||
541 | $blog_info .= '<span class="ab-site-description">' . esc_html( $this->primary_site_url ) . '</span>'; |
||
542 | |||
543 | $wp_admin_bar->add_menu( array( |
||
544 | 'parent' => 'blog', |
||
545 | 'id' => 'blog-info', |
||
546 | 'title' => $blog_info, |
||
547 | 'href' => esc_url( trailingslashit( $this->primary_site_url ) ), |
||
548 | 'meta' => array( |
||
549 | 'class' => $class, |
||
550 | ), |
||
551 | ) ); |
||
552 | } |
||
553 | |||
554 | // Stats |
||
555 | View Code Duplication | if ( Jetpack::is_module_active( 'stats' ) ) { |
|
556 | $wp_admin_bar->add_menu( array( |
||
557 | 'parent' => 'blog', |
||
558 | 'id' => 'blog-stats', |
||
559 | 'title' => __( 'Stats', 'jetpack' ), |
||
560 | 'href' => 'https://wordpress.com/stats/' . esc_attr( $this->primary_site_slug ), |
||
561 | 'meta' => array( |
||
562 | 'class' => 'mb-icon', |
||
563 | ), |
||
564 | ) ); |
||
565 | } |
||
566 | |||
567 | // Add Calypso plans link and plan type indicator |
||
568 | if ( is_user_member_of_blog( $current_user->ID ) ) { |
||
569 | $plans_url = 'https://wordpress.com/plans/' . esc_attr( $this->primary_site_slug ); |
||
570 | $label = __( 'Plan', 'jetpack' ); |
||
571 | $plan = Jetpack::get_active_plan(); |
||
572 | |||
573 | $plan_title = $this->create_menu_item_pair( |
||
574 | array( |
||
575 | 'url' => $plans_url, |
||
576 | 'id' => 'wp-admin-bar-plan', |
||
577 | 'label' => $label, |
||
578 | ), |
||
579 | array( |
||
580 | 'url' => $plans_url, |
||
581 | 'id' => 'wp-admin-bar-plan-badge', |
||
582 | 'label' => $plan['product_name_short'] |
||
583 | ) |
||
584 | ); |
||
585 | |||
586 | $wp_admin_bar->add_menu( array( |
||
587 | 'parent' => 'blog', |
||
588 | 'id' => 'plan', |
||
589 | 'title' => $plan_title, |
||
590 | 'meta' => array( |
||
591 | 'class' => 'inline-action', |
||
592 | ), |
||
593 | ) ); |
||
594 | } |
||
595 | |||
596 | // Publish group |
||
597 | $wp_admin_bar->add_group( array( |
||
598 | 'parent' => 'blog', |
||
599 | 'id' => 'publish', |
||
600 | ) ); |
||
601 | |||
602 | // Publish header |
||
603 | $wp_admin_bar->add_menu( array( |
||
604 | 'parent' => 'publish', |
||
605 | 'id' => 'publish-header', |
||
606 | 'title' => _x( 'Publish', 'admin bar menu group label', 'jetpack' ), |
||
607 | 'meta' => array( |
||
608 | 'class' => 'ab-submenu-header', |
||
609 | ), |
||
610 | ) ); |
||
611 | |||
612 | // Blog Posts |
||
613 | $posts_title = $this->create_menu_item_pair( |
||
614 | array( |
||
615 | 'url' => 'https://wordpress.com/posts/' . esc_attr( $this->primary_site_slug ), |
||
616 | 'id' => 'wp-admin-bar-edit-post', |
||
617 | 'label' => __( 'Blog Posts', 'jetpack' ), |
||
618 | ), |
||
619 | array( |
||
620 | 'url' => 'https://wordpress.com/post/' . esc_attr( $this->primary_site_slug ), |
||
621 | 'id' => 'wp-admin-bar-new-post', |
||
622 | 'label' => _x( 'Add', 'admin bar menu new item label', 'jetpack' ), |
||
623 | ) |
||
624 | ); |
||
625 | |||
626 | if ( ! current_user_can( 'edit_posts' ) ) { |
||
627 | $posts_title = $this->create_menu_item_anchor( |
||
628 | 'ab-item ab-primary mb-icon', |
||
629 | 'https://wordpress.com/posts/' . esc_attr( $this->primary_site_slug ), |
||
630 | __( 'Blog Posts', 'jetpack' ), |
||
631 | 'wp-admin-bar-edit-post' |
||
632 | ); |
||
633 | } |
||
634 | |||
635 | $wp_admin_bar->add_menu( array( |
||
636 | 'parent' => 'publish', |
||
637 | 'id' => 'new-post', |
||
638 | 'title' => $posts_title, |
||
639 | 'meta' => array( |
||
640 | 'class' => 'inline-action', |
||
641 | ), |
||
642 | ) ); |
||
643 | |||
644 | // Pages |
||
645 | $pages_title = $this->create_menu_item_pair( |
||
646 | array( |
||
647 | 'url' => 'https://wordpress.com/pages/' . esc_attr( $this->primary_site_slug ), |
||
648 | 'id' => 'wp-admin-bar-edit-page', |
||
649 | 'label' => __( 'Pages', 'jetpack' ), |
||
650 | ), |
||
651 | array( |
||
652 | 'url' => 'https://wordpress.com/page/' . esc_attr( $this->primary_site_slug ), |
||
653 | 'id' => 'wp-admin-bar-new-page', |
||
654 | 'label' => _x( 'Add', 'admin bar menu new item label', 'jetpack' ), |
||
655 | ) |
||
656 | ); |
||
657 | |||
658 | if ( ! current_user_can( 'edit_pages' ) ) { |
||
659 | $pages_title = $this->create_menu_item_anchor( |
||
660 | 'ab-item ab-primary mb-icon', |
||
661 | 'https://wordpress.com/pages/' . esc_attr( $this->primary_site_slug ), |
||
662 | __( 'Pages', 'jetpack' ), |
||
663 | 'wp-admin-bar-edit-page' |
||
664 | ); |
||
665 | } |
||
666 | |||
667 | $wp_admin_bar->add_menu( array( |
||
668 | 'parent' => 'publish', |
||
669 | 'id' => 'new-page', |
||
670 | 'title' => $pages_title, |
||
671 | 'meta' => array( |
||
672 | 'class' => 'inline-action', |
||
673 | ), |
||
674 | ) ); |
||
675 | |||
676 | // Testimonials |
||
677 | View Code Duplication | if ( Jetpack::is_module_active( 'custom-content-types' ) && get_option( 'jetpack_testimonial' ) ) { |
|
678 | $testimonials_title = $this->create_menu_item_pair( |
||
679 | array( |
||
680 | 'url' => 'https://wordpress.com/types/jetpack-testimonial/' . esc_attr( $this->primary_site_slug ), |
||
681 | 'id' => 'wp-admin-bar-edit-testimonial', |
||
682 | 'label' => __( 'Testimonials', 'jetpack' ), |
||
683 | ), |
||
684 | array( |
||
685 | 'url' => 'https://wordpress.com/edit/jetpack-testimonial/' . esc_attr( $this->primary_site_slug ), |
||
686 | 'id' => 'wp-admin-bar-new-testimonial', |
||
687 | 'label' => _x( 'Add', 'Button label for adding a new item via the toolbar menu', 'jetpack' ), |
||
688 | ) |
||
689 | ); |
||
690 | |||
691 | if ( ! current_user_can( 'edit_pages' ) ) { |
||
692 | $testimonials_title = $this->create_menu_item_anchor( |
||
693 | 'ab-item ab-primary mb-icon', |
||
694 | 'https://wordpress.com/types/jetpack-testimonial/' . esc_attr( $this->primary_site_slug ), |
||
695 | __( 'Testimonials', 'jetpack' ), |
||
696 | 'wp-admin-bar-edit-testimonial' |
||
697 | ); |
||
698 | } |
||
699 | |||
700 | $wp_admin_bar->add_menu( array( |
||
701 | 'parent' => 'publish', |
||
702 | 'id' => 'new-jetpack-testimonial', |
||
703 | 'title' => $testimonials_title, |
||
704 | 'meta' => array( |
||
705 | 'class' => 'inline-action', |
||
706 | ), |
||
707 | ) ); |
||
708 | } |
||
709 | |||
710 | // Portfolio |
||
711 | View Code Duplication | if ( Jetpack::is_module_active( 'custom-content-types' ) && get_option( 'jetpack_portfolio' ) ) { |
|
712 | $portfolios_title = $this->create_menu_item_pair( |
||
713 | array( |
||
714 | 'url' => 'https://wordpress.com/types/jetpack-portfolio/' . esc_attr( $this->primary_site_slug ), |
||
715 | 'id' => 'wp-admin-bar-edit-portfolio', |
||
716 | 'label' => __( 'Portfolio', 'jetpack' ), |
||
717 | ), |
||
718 | array( |
||
719 | 'url' => 'https://wordpress.com/edit/jetpack-portfolio/' . esc_attr( $this->primary_site_slug ), |
||
720 | 'id' => 'wp-admin-bar-new-portfolio', |
||
721 | 'label' => _x( 'Add', 'Button label for adding a new item via the toolbar menu', 'jetpack' ), |
||
722 | ) |
||
723 | ); |
||
724 | |||
725 | if ( ! current_user_can( 'edit_pages' ) ) { |
||
726 | $portfolios_title = $this->create_menu_item_anchor( |
||
727 | 'ab-item ab-primary mb-icon', |
||
728 | 'https://wordpress.com/types/jetpack-portfolio/' . esc_attr( $this->primary_site_slug ), |
||
729 | __( 'Portfolio', 'jetpack' ), |
||
730 | 'wp-admin-bar-edit-portfolio' |
||
731 | ); |
||
732 | } |
||
733 | |||
734 | $wp_admin_bar->add_menu( array( |
||
735 | 'parent' => 'publish', |
||
736 | 'id' => 'new-jetpack-portfolio', |
||
737 | 'title' => $portfolios_title, |
||
738 | 'meta' => array( |
||
739 | 'class' => 'inline-action', |
||
740 | ), |
||
741 | ) ); |
||
742 | } |
||
743 | |||
744 | if ( current_user_can( 'edit_theme_options' ) ) { |
||
745 | // Look and Feel group |
||
746 | $wp_admin_bar->add_group( array( |
||
747 | 'parent' => 'blog', |
||
748 | 'id' => 'look-and-feel', |
||
749 | ) ); |
||
750 | |||
751 | // Look and Feel header |
||
752 | $wp_admin_bar->add_menu( array( |
||
753 | 'parent' => 'look-and-feel', |
||
754 | 'id' => 'look-and-feel-header', |
||
755 | 'title' => _x( 'Personalize', 'admin bar menu group label', 'jetpack' ), |
||
756 | 'meta' => array( |
||
757 | 'class' => 'ab-submenu-header', |
||
758 | ), |
||
759 | ) ); |
||
760 | |||
761 | if ( is_admin() ) { |
||
762 | // In wp-admin the `return` query arg will return to that page after closing the Customizer |
||
763 | $customizer_url = add_query_arg( array( 'return' => urlencode( site_url( $_SERVER['REQUEST_URI'] ) ) ), wp_customize_url() ); |
||
764 | } else { |
||
765 | // On the frontend the `url` query arg will load that page in the Customizer and also return to it after closing |
||
766 | // non-home URLs won't work unless we undo domain mapping since the Customizer preview is unmapped to always have HTTPS |
||
767 | $current_page = '//' . $this->primary_site_slug . $_SERVER['REQUEST_URI']; |
||
768 | $customizer_url = add_query_arg( array( 'url' => urlencode( $current_page ) ), wp_customize_url() ); |
||
769 | } |
||
770 | |||
771 | $theme_title = $this->create_menu_item_pair( |
||
772 | array( |
||
773 | 'url' => 'https://wordpress.com/design/' . esc_attr( $this->primary_site_slug ), |
||
774 | 'id' => 'wp-admin-bar-themes', |
||
775 | 'label' => __( 'Themes', 'jetpack' ), |
||
776 | ), |
||
777 | array( |
||
778 | 'url' => $customizer_url, |
||
779 | 'id' => 'wp-admin-bar-cmz', |
||
780 | 'label' => _x( 'Customize', 'admin bar customize item label', 'jetpack' ), |
||
781 | ) |
||
782 | ); |
||
783 | $meta = array( 'class' => 'mb-icon', 'class' => 'inline-action' ); |
||
784 | $href = false; |
||
785 | |||
786 | $wp_admin_bar->add_menu( array( |
||
787 | 'parent' => 'look-and-feel', |
||
788 | 'id' => 'themes', |
||
789 | 'title' => $theme_title, |
||
790 | 'href' => $href, |
||
791 | 'meta' => $meta |
||
792 | ) ); |
||
793 | |||
794 | View Code Duplication | if ( current_theme_supports( 'menus' ) ) { |
|
795 | $wp_admin_bar->add_menu( array( |
||
796 | 'parent' => 'look-and-feel', |
||
797 | 'id' => 'menus', |
||
798 | 'title' => __( 'Menus', 'jetpack' ), |
||
799 | 'href' => 'https://wordpress.com/menus/' . esc_attr( $this->primary_site_slug ), |
||
800 | 'meta' => array( |
||
801 | 'class' => 'mb-icon', |
||
802 | ), |
||
803 | ) ); |
||
804 | } |
||
805 | } |
||
806 | |||
807 | if ( current_user_can( 'manage_options' ) ) { |
||
808 | // Configuration group |
||
809 | $wp_admin_bar->add_group( array( |
||
810 | 'parent' => 'blog', |
||
811 | 'id' => 'configuration', |
||
812 | ) ); |
||
813 | |||
814 | // Configuration header |
||
815 | $wp_admin_bar->add_menu( array( |
||
816 | 'parent' => 'configuration', |
||
817 | 'id' => 'configuration-header', |
||
818 | 'title' => __( 'Configure', 'admin bar menu group label', 'jetpack' ), |
||
819 | 'meta' => array( |
||
820 | 'class' => 'ab-submenu-header', |
||
821 | ), |
||
822 | ) ); |
||
823 | |||
824 | View Code Duplication | if ( Jetpack::is_module_active( 'publicize' ) || Jetpack::is_module_active( 'sharedaddy' ) ) { |
|
825 | $wp_admin_bar->add_menu( array( |
||
826 | 'parent' => 'configuration', |
||
827 | 'id' => 'sharing', |
||
828 | 'title' => __( 'Sharing', 'jetpack' ), |
||
829 | 'href' => 'https://wordpress.com/sharing/' . esc_attr( $this->primary_site_slug ), |
||
830 | 'meta' => array( |
||
831 | 'class' => 'mb-icon', |
||
832 | ), |
||
833 | ) ); |
||
834 | } |
||
835 | |||
836 | $people_title = $this->create_menu_item_pair( |
||
837 | array( |
||
838 | 'url' => 'https://wordpress.com/people/team/' . esc_attr( $this->primary_site_slug ), |
||
839 | 'id' => 'wp-admin-bar-people', |
||
840 | 'label' => __( 'People', 'jetpack' ), |
||
841 | ), |
||
842 | array( |
||
843 | 'url' => '//' . esc_attr( $this->primary_site_url ) . '/wp-admin/user-new.php', |
||
844 | 'id' => 'wp-admin-bar-people-add', |
||
845 | 'label' => _x( 'Add', 'admin bar people item label', 'jetpack' ), |
||
846 | ) |
||
847 | ); |
||
848 | |||
849 | $wp_admin_bar->add_menu( array( |
||
850 | 'parent' => 'configuration', |
||
851 | 'id' => 'users-toolbar', |
||
852 | 'title' => $people_title, |
||
853 | 'href' => false, |
||
854 | 'meta' => array( |
||
855 | 'class' => 'inline-action', |
||
856 | ), |
||
857 | ) ); |
||
858 | |||
859 | $plugins_title = $this->create_menu_item_pair( |
||
860 | array( |
||
861 | 'url' => 'https://wordpress.com/plugins/' . esc_attr( $this->primary_site_slug ), |
||
862 | 'id' => 'wp-admin-bar-plugins', |
||
863 | 'label' => __( 'Plugins', 'jetpack' ), |
||
864 | ), |
||
865 | array( |
||
866 | 'url' => 'https://wordpress.com/plugins/browse/' . esc_attr( $this->primary_site_slug ), |
||
867 | 'id' => 'wp-admin-bar-plugins-add', |
||
868 | 'label' => _x( 'Add', 'Label for the button on the Masterbar to add a new plugin', 'jetpack' ), |
||
869 | ) |
||
870 | ); |
||
871 | |||
872 | $wp_admin_bar->add_menu( array( |
||
873 | 'parent' => 'configuration', |
||
874 | 'id' => 'plugins', |
||
875 | 'title' => $plugins_title, |
||
876 | 'href' => false, |
||
877 | 'meta' => array( |
||
878 | 'class' => 'inline-action', |
||
879 | ), |
||
880 | ) ); |
||
881 | |||
882 | if ( $this->is_automated_transfer_site() ) { |
||
883 | $domain_title = $this->create_menu_item_pair( |
||
884 | array( |
||
885 | 'url' => 'https://wordpress.com/domains/' . esc_attr( $this->primary_site_slug ), |
||
886 | 'id' => 'wp-admin-bar-domains', |
||
887 | 'label' => __( 'Domains', 'jetpack' ), |
||
888 | ), |
||
889 | array( |
||
890 | 'url' => 'https://wordpress.com/domains/add/' . esc_attr( $this->primary_site_slug ), |
||
891 | 'id' => 'wp-admin-bar-domains-add', |
||
892 | 'label' => _x( 'Add', 'Label for the button on the Masterbar to add a new domain', 'jetpack' ), |
||
893 | ) |
||
894 | ); |
||
895 | $wp_admin_bar->add_menu( array( |
||
896 | 'parent' => 'configuration', |
||
897 | 'id' => 'domains', |
||
898 | 'title' => $domain_title, |
||
899 | 'href' => false, |
||
900 | 'meta' => array( |
||
901 | 'class' => 'inline-action', |
||
902 | ), |
||
903 | ) ); |
||
904 | } |
||
905 | |||
906 | |||
907 | $wp_admin_bar->add_menu( array( |
||
908 | 'parent' => 'configuration', |
||
909 | 'id' => 'blog-settings', |
||
910 | 'title' => __( 'Settings', 'jetpack' ), |
||
911 | 'href' => 'https://wordpress.com/settings/general/' . esc_attr( $this->primary_site_slug ), |
||
912 | 'meta' => array( |
||
913 | 'class' => 'mb-icon', |
||
914 | ), |
||
915 | ) ); |
||
916 | |||
917 | View Code Duplication | if ( $this->is_automated_transfer_site() ) { |
|
918 | $wp_admin_bar->add_menu( array( |
||
919 | 'parent' => 'configuration', |
||
920 | 'id' => 'legacy-dashboard', |
||
921 | 'title' => __( 'WP Admin', 'jetpack' ), |
||
922 | 'href' => '//' . esc_attr( $this->primary_site_url ) . '/wp-admin/', |
||
923 | 'meta' => array( |
||
924 | 'class' => 'mb-icon', |
||
925 | ), |
||
926 | ) ); |
||
927 | } |
||
928 | } |
||
929 | } |
||
930 | } |
||
931 |
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: