Complex classes like Jetpack_Sync_Actions often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Jetpack_Sync_Actions, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
10 | class Jetpack_Sync_Actions { |
||
11 | static $sender = null; |
||
|
|||
12 | static $listener = null; |
||
13 | const MAX_INITIAL_SYNC_USERS = 500; |
||
14 | |||
15 | static function init() { |
||
16 | |||
17 | // Add a custom "every minute" cron schedule |
||
18 | add_filter( 'cron_schedules', array( __CLASS__, 'minute_cron_schedule' ) ); |
||
19 | |||
20 | // On jetpack authorization, schedule a full sync |
||
21 | add_action( 'jetpack_client_authorized', array( __CLASS__, 'schedule_full_sync' ) ); |
||
22 | |||
23 | // When imports are finished, schedule a full sync |
||
24 | add_action( 'import_end', array( __CLASS__, 'schedule_full_sync' ) ); |
||
25 | |||
26 | // When importing via cron, do not sync |
||
27 | add_action( 'wp_cron_importer_hook', array( __CLASS__, 'set_is_importing_true' ), 1 ); |
||
28 | |||
29 | // Sync connected user role changes to .com |
||
30 | require_once dirname( __FILE__ ) . '/class.jetpack-sync-users.php'; |
||
31 | |||
32 | // everything below this point should only happen if we're a valid sync site |
||
33 | if ( ! self::sync_allowed() ) { |
||
34 | return; |
||
35 | } |
||
36 | |||
37 | // cron hooks |
||
38 | add_action( 'jetpack_sync_send_db_checksum', array( __CLASS__, 'send_db_checksum' ) ); |
||
39 | add_action( 'jetpack_sync_full', array( __CLASS__, 'do_full_sync' ), 10, 1 ); |
||
40 | add_action( 'jetpack_sync_cron', array( __CLASS__, 'do_cron_sync' ) ); |
||
41 | |||
42 | if ( ! wp_next_scheduled( 'jetpack_sync_send_db_checksum' ) ) { |
||
43 | // Schedule a job to send DB checksums once an hour |
||
44 | wp_schedule_event( time(), 'hourly', 'jetpack_sync_send_db_checksum' ); |
||
45 | } |
||
46 | |||
47 | if ( ! wp_next_scheduled( 'jetpack_sync_cron' ) ) { |
||
48 | // Schedule a job to send pending queue items once a minute |
||
49 | wp_schedule_event( time(), '1min', 'jetpack_sync_cron' ); |
||
50 | } |
||
51 | |||
52 | /** |
||
53 | * Fires on every request before default loading sync listener code. |
||
54 | * Return false to not load sync listener code that monitors common |
||
55 | * WP actions to be serialized. |
||
56 | * |
||
57 | * By default this returns true for non-GET-requests, or requests where the |
||
58 | * user is logged-in. |
||
59 | * |
||
60 | * @since 4.2.0 |
||
61 | * |
||
62 | * @param bool should we load sync listener code for this request |
||
63 | */ |
||
64 | if ( apply_filters( 'jetpack_sync_listener_should_load', |
||
65 | ( |
||
66 | 'GET' !== $_SERVER['REQUEST_METHOD'] |
||
67 | || |
||
68 | is_user_logged_in() |
||
69 | || |
||
70 | defined( 'PHPUNIT_JETPACK_TESTSUITE' ) |
||
71 | ) |
||
72 | ) ) { |
||
73 | self::initialize_listener(); |
||
74 | } |
||
75 | |||
76 | /** |
||
77 | * Fires on every request before default loading sync sender code. |
||
78 | * Return false to not load sync sender code that serializes pending |
||
79 | * data and sends it to WPCOM for processing. |
||
80 | * |
||
81 | * By default this returns true for POST requests, admin requests, or requests |
||
82 | * by users who can manage_options. |
||
83 | * |
||
84 | * @since 4.2.0 |
||
85 | * |
||
86 | * @param bool should we load sync sender code for this request |
||
87 | */ |
||
88 | if ( apply_filters( 'jetpack_sync_sender_should_load', |
||
89 | ( |
||
90 | 'POST' === $_SERVER['REQUEST_METHOD'] |
||
91 | || |
||
92 | current_user_can( 'manage_options' ) |
||
93 | || |
||
94 | is_admin() |
||
95 | || |
||
96 | defined( 'PHPUNIT_JETPACK_TESTSUITE' ) |
||
97 | ) |
||
98 | ) ) { |
||
99 | self::initialize_sender(); |
||
100 | add_action( 'shutdown', array( self::$sender, 'do_sync' ) ); |
||
101 | } |
||
102 | |||
103 | } |
||
104 | |||
105 | static function sync_allowed() { |
||
106 | return ( ! Jetpack_Sync_Settings::get_setting( 'disable' ) && Jetpack::is_active() && ! ( Jetpack::is_development_mode() || Jetpack::is_staging_site() ) ) |
||
107 | || defined( 'PHPUNIT_JETPACK_TESTSUITE' ); |
||
108 | } |
||
109 | |||
110 | static function set_is_importing_true() { |
||
111 | Jetpack_Sync_Settings::set_importing( true ); |
||
112 | } |
||
113 | |||
114 | static function send_data( $data, $codec_name, $sent_timestamp, $queue_id ) { |
||
138 | |||
139 | static function get_initial_sync_user_config() { |
||
151 | |||
152 | static function schedule_initial_sync() { |
||
158 | |||
159 | static function schedule_full_sync( $modules = null ) { |
||
160 | if ( ! self::sync_allowed() ) { |
||
161 | return false; |
||
174 | |||
175 | static function is_scheduled_full_sync( $modules = null ) { |
||
190 | |||
191 | static function do_full_sync( $modules = null ) { |
||
200 | |||
201 | static function minute_cron_schedule( $schedules ) { |
||
210 | |||
211 | // try to send actions until we run out of things to send, |
||
212 | // or have to wait more than 15s before sending again, |
||
213 | // or we hit a lock or some other sending issue |
||
214 | static function do_cron_sync() { |
||
241 | |||
242 | static function send_db_checksum() { |
||
248 | |||
249 | static function initialize_listener() { |
||
253 | |||
254 | static function initialize_sender() { |
||
261 | } |
||
262 | |||
269 |
The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using
the property is implicitly global.
To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2.