Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 15 | class Atomic_Admin_Menu extends Admin_Menu { |
||
| 16 | |||
| 17 | /** |
||
| 18 | * Atomic_Admin_Menu constructor. |
||
| 19 | */ |
||
| 20 | protected function __construct() { |
||
| 34 | |||
| 35 | /** |
||
| 36 | * Dequeues unnecessary scripts. |
||
| 37 | */ |
||
| 38 | public function dequeue_scripts() { |
||
| 41 | |||
| 42 | /** |
||
| 43 | * Determines whether the current locale is right-to-left (RTL). |
||
| 44 | * |
||
| 45 | * Performs the check against the current locale set on the WordPress.com's account settings. |
||
| 46 | * See `Masterbar::__construct` in `modules/masterbar/masterbar/class-masterbar.php`. |
||
| 47 | */ |
||
| 48 | public function is_rtl() { |
||
| 51 | |||
| 52 | /** |
||
| 53 | * Create the desired menu output. |
||
| 54 | */ |
||
| 55 | View Code Duplication | public function reregister_menu_items() { |
|
| 69 | |||
| 70 | /** |
||
| 71 | * Forces Posts menu to WPAdmin for Atomic sites only. |
||
| 72 | * Overloads `add_posts_menu` in parent class. |
||
| 73 | * |
||
| 74 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 75 | */ |
||
| 76 | public function add_posts_menu( $wp_admin = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
| 79 | |||
| 80 | /** |
||
| 81 | * Forces Pages menu to WPAdmin for Atomic sites only. |
||
| 82 | * Overloads `add_page_menu` in parent class. |
||
| 83 | * |
||
| 84 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 85 | */ |
||
| 86 | public function add_page_menu( $wp_admin = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
| 89 | |||
| 90 | /** |
||
| 91 | * Adds Plugins menu. |
||
| 92 | * |
||
| 93 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 94 | */ |
||
| 95 | public function add_plugins_menu( $wp_admin = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
| 99 | |||
| 100 | /** |
||
| 101 | * Adds the site switcher link if user has more than one site. |
||
| 102 | */ |
||
| 103 | public function add_browse_sites_link() { |
||
| 113 | |||
| 114 | /** |
||
| 115 | * Adds a custom element class for Site Switcher menu item. |
||
| 116 | * |
||
| 117 | * @param array $menu Associative array of administration menu items. |
||
| 118 | * |
||
| 119 | * @return array |
||
| 120 | */ |
||
| 121 | View Code Duplication | public function set_browse_sites_link_class( array $menu ) { |
|
| 133 | |||
| 134 | /** |
||
| 135 | * Adds a link to the menu to create a new site. |
||
| 136 | */ |
||
| 137 | public function add_new_site_link() { |
||
| 154 | |||
| 155 | /** |
||
| 156 | * Adds site card component. |
||
| 157 | */ |
||
| 158 | public function add_site_card_menu() { |
||
| 188 | |||
| 189 | /** |
||
| 190 | * Adds a custom element class and id for Site Card's menu item. |
||
| 191 | * |
||
| 192 | * @param array $menu Associative array of administration menu items. |
||
| 193 | * |
||
| 194 | * @return array |
||
| 195 | */ |
||
| 196 | public function set_site_card_menu_class( array $menu ) { |
||
| 216 | |||
| 217 | /** |
||
| 218 | * Adds Upgrades menu. |
||
| 219 | */ |
||
| 220 | public function add_upgrades_menu() { |
||
| 225 | |||
| 226 | /** |
||
| 227 | * Adds Tools menu. |
||
| 228 | * |
||
| 229 | * @param bool $wp_admin_import Optional. Whether Import link should point to Calypso or wp-admin. Default false (Calypso). |
||
| 230 | * @param bool $wp_admin_export Optional. Whether Export link should point to Calypso or wp-admin. Default false (Calypso). |
||
| 231 | */ |
||
| 232 | public function add_tools_menu( $wp_admin_import = false, $wp_admin_export = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
| 236 | |||
| 237 | /** |
||
| 238 | * Adds Settings menu. |
||
| 239 | * |
||
| 240 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 241 | */ |
||
| 242 | public function add_options_menu( $wp_admin = false ) { |
||
| 253 | |||
| 254 | /** |
||
| 255 | * Adds Appearance menu. |
||
| 256 | * |
||
| 257 | * @param bool $wp_admin_themes Optional. Whether Themes link should point to Calypso or wp-admin. Default false (Calypso). |
||
| 258 | * @param bool $wp_admin_customize Optional. Whether Customize link should point to Calypso or wp-admin. Default false (Calypso). |
||
| 259 | */ |
||
| 260 | public function add_appearance_menu( $wp_admin_themes = false, $wp_admin_customize = false ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable |
||
| 266 | |||
| 267 | /** |
||
| 268 | * Adds Users menu. |
||
| 269 | * |
||
| 270 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 271 | */ |
||
| 272 | public function add_users_menu( $wp_admin = false ) { |
||
| 277 | |||
| 278 | /** |
||
| 279 | * Also remove the Gutenberg plugin menu. |
||
| 280 | * |
||
| 281 | * @param bool $wp_admin Optional. Whether links should point to Calypso or wp-admin. Default false (Calypso). |
||
| 282 | */ |
||
| 283 | public function add_gutenberg_menus( $wp_admin = false ) { |
||
| 288 | } |
||
| 289 |