VideoPress_XMLRPC::update_videopress_media_item() - Code Metrics - Inspection of "Shortcodes: update JS files to pass jshint" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — add/wpcom-shortcodes ( 38c379...fb6212 )

unknown

created 2016-12-09 15:18 UTC

VideoPress_XMLRPC::update_videopress_media_item() B

↳ Parent: VideoPress_XMLRPC

Complexity

Conditions	8
Paths	13

Size

Total Lines	56
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	30
nc	13
nop	1
dl	0
loc	56
rs	7.3333
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * VideoPress playback module markup generator.
 *
 * @since 1.3
 */
class VideoPress_XMLRPC {

	/**
	 * @var VideoPress_XMLRPC
	 **/
	private static $instance = null;


	/**
	 * Private VideoPress_XMLRPC constructor.
	 *
	 * Use the VideoPress_XMLRPC::init() method to get an instance.
	 */
	private function __construct() {
		add_filter( 'jetpack_xmlrpc_methods', array( $this, 'xmlrpc_methods' ) );
	}

	/**
	 * Initialize the VideoPress_XMLRPC and get back a singleton instance.
	 *
	 * @return VideoPress_XMLRPC
	 */
	public static function init() {
		if ( is_null( self::$instance ) ) {
			self::$instance = new VideoPress_XMLRPC;
		}

		return self::$instance;
	}

	/**
	 * Adds additional methods the WordPress xmlrpc API for handling VideoPress specific features
	 *
	 * @param array $methods
	 *
	 * @return array
	 */
	public function xmlrpc_methods( $methods ) {

		$methods['jetpack.createMediaItem']           = array( $this, 'create_media_item' );
		$methods['jetpack.updateVideoPressMediaItem'] = array( $this, 'update_videopress_media_item' );
		$methods['jetpack.updateVideoPressPosterImage'] = array( $this, 'update_poster_image' );

		return $methods;
	}

	/**
	 * This is used by the WPCOM VideoPress uploader in order to create a media item with
	 * specific meta data about an uploaded file. After this, the transcoding session will
	 * update the meta information via the update_videopress_media_item() method.
	 *
	 * Note: This method technically handles the creation of multiple media objects, though
	 * in practice this is never done.
	 *
	 * @param array $media
	 * @return array
	 */
	public function create_media_item( $media ) {
		foreach ( $media as & $media_item ) {
			$title = sanitize_title( basename( $media_item['url'] ) );
			$guid  = isset( $media['guid'] ) ? $media['guid'] : null;

			$media_id = videopress_create_new_media_item( $title, $guid );

			wp_update_attachment_metadata( $media_id, array(
				'original' => array(
					'url' => $media_item['url'],
				),
			) );

			$media_item['post'] = get_post( $media_id );
		}

		return array( 'media' => $media );
	}

	/**
	 * @param array $request
	 *
	 * @return bool
	 */
	public function update_videopress_media_item( $request ) {

		$id     = $request['post_id'];
		$status = $request['status'];
		$format = $request['format'];
        $info   = $request['info'];

        if ( ! $attachment = get_post( $id ) )  {
            return false;
        }

		$attachment->guid = $info['original'];

		wp_update_post( $attachment );

		// Update the vp guid and set it to a direct meta property.
		update_post_meta( $id, 'videopress_guid', $info['guid'] );

        $meta = wp_get_attachment_metadata( $id );

        $meta['width']             = $info['width'];
        $meta['height']            = $info['height'];
        $meta['original']['url']   = $info['original'];
		$meta['videopress']        = $info;
		$meta['videopress']['url'] = 'https://videopress.com/v/' . $info['guid'];

        // Update file statuses
		$valid_formats = array( 'hd', 'ogg', 'mp4', 'dvd' );
		if ( in_array( $format, $valid_formats ) ) {
            $meta['file_statuses'][ $format ] = $status;
		}

		if ( ! get_post_meta( $id, '_thumbnail_id', true ) ) {
			// Update the poster in the VideoPress info.
			$thumbnail_id = videopress_download_poster_image( $info['poster'], $id );

			if ( is_int( $thumbnail_id ) ) {
				update_post_meta( $id, '_thumbnail_id', $thumbnail_id );
			}
		}

		wp_update_attachment_metadata( $id, $meta );

		videopress_update_meta_data( $id );

		// update the meta to tell us that we're processing or complete
		update_post_meta( $id, 'videopress_status', videopress_is_finished_processing( $id ) ? 'complete' : 'processing' );

		// Get the attached file and if there isn't one, then let's update it with the one from the server.
		$file = get_attached_file( $id );
		if ( ! $file && is_string( $info['original'] ) ) {
			videopress_download_video( $info['original'], $id );
		}

		return true;
	}

	/**
	 * @param array $request
	 * @return bool
	 */
	public function update_poster_image( $request ) {

		$post_id = $request['post_id'];
		$poster  = $request['poster'];

		if ( ! $attachment = get_post( $post_id ) )  {
			return false;
		}

		// Update the poster in the VideoPress info.
		$thumbnail_id = videopress_download_poster_image( $poster, $post_id );

		if ( !is_int( $thumbnail_id ) ) {
			return false;
		}

		update_post_meta( $post_id, '_thumbnail_id', $thumbnail_id );
		$meta = wp_get_attachment_metadata( $post_id );

		$meta['videopress']['poster'] = $poster;
		wp_update_attachment_metadata( $post_id, $meta );

		return true;
	}
}


1			<?php
2			/**
3			* VideoPress playback module markup generator.
4			*
5			* @since 1.3
6			*/
7			class VideoPress_XMLRPC {
8
9			/**
10			* @var VideoPress_XMLRPC
11			**/
12			private static $instance = null;
13
14
15			/**
16			* Private VideoPress_XMLRPC constructor.
17			*
18			* Use the VideoPress_XMLRPC::init() method to get an instance.
19			*/
20			private function __construct() {
21			add_filter( 'jetpack_xmlrpc_methods', array( $this, 'xmlrpc_methods' ) );
22			}
23
24			/**
25			* Initialize the VideoPress_XMLRPC and get back a singleton instance.
26			*
27			* @return VideoPress_XMLRPC
28			*/
29			public static function init() {
30			if ( is_null( self::$instance ) ) {
31			self::$instance = new VideoPress_XMLRPC;
32			}
33
34			return self::$instance;
35			}
36
37			/**
38			* Adds additional methods the WordPress xmlrpc API for handling VideoPress specific features
39			*
40			* @param array $methods
41			*
42			* @return array
43			*/
44			public function xmlrpc_methods( $methods ) {
45
46			$methods['jetpack.createMediaItem'] = array( $this, 'create_media_item' );
47			$methods['jetpack.updateVideoPressMediaItem'] = array( $this, 'update_videopress_media_item' );
48			$methods['jetpack.updateVideoPressPosterImage'] = array( $this, 'update_poster_image' );
49
50			return $methods;
51			}
52
53			/**
54			* This is used by the WPCOM VideoPress uploader in order to create a media item with
55			* specific meta data about an uploaded file. After this, the transcoding session will
56			* update the meta information via the update_videopress_media_item() method.
57			*
58			* Note: This method technically handles the creation of multiple media objects, though
59			* in practice this is never done.
60			*
61			* @param array $media
62			* @return array
63			*/
64			public function create_media_item( $media ) {
65			foreach ( $media as & $media_item ) {
66			$title = sanitize_title( basename( $media_item['url'] ) );
67			$guid = isset( $media['guid'] ) ? $media['guid'] : null;
68
69			$media_id = videopress_create_new_media_item( $title, $guid );
70
71			wp_update_attachment_metadata( $media_id, array(
72			'original' => array(
73			'url' => $media_item['url'],
74			),
75			) );
76
77			$media_item['post'] = get_post( $media_id );
78			}
79
80			return array( 'media' => $media );
81			}
82
83			/**
84			* @param array $request
85			*
86			* @return bool
87			*/
88			public function update_videopress_media_item( $request ) {
89
90			$id = $request['post_id'];
91			$status = $request['status'];
92			$format = $request['format'];
93			$info = $request['info'];
94
95			if ( ! $attachment = get_post( $id ) ) {
96			return false;
97			}
98
99			$attachment->guid = $info['original'];
100
101			wp_update_post( $attachment );
102
103			// Update the vp guid and set it to a direct meta property.
104			update_post_meta( $id, 'videopress_guid', $info['guid'] );
105
106			$meta = wp_get_attachment_metadata( $id );
107
108			$meta['width'] = $info['width'];
109			$meta['height'] = $info['height'];
110			$meta['original']['url'] = $info['original'];
111			$meta['videopress'] = $info;
112			$meta['videopress']['url'] = 'https://videopress.com/v/' . $info['guid'];
113
114			// Update file statuses
115			$valid_formats = array( 'hd', 'ogg', 'mp4', 'dvd' );
116			if ( in_array( $format, $valid_formats ) ) {
117			$meta['file_statuses'][ $format ] = $status;
118			}
119
120			if ( ! get_post_meta( $id, '_thumbnail_id', true ) ) {
121			// Update the poster in the VideoPress info.
122			$thumbnail_id = videopress_download_poster_image( $info['poster'], $id );
123
124			if ( is_int( $thumbnail_id ) ) {
125			update_post_meta( $id, '_thumbnail_id', $thumbnail_id );
126			}
127			}
128
129			wp_update_attachment_metadata( $id, $meta );
130
131			videopress_update_meta_data( $id );
132
133			// update the meta to tell us that we're processing or complete
134			update_post_meta( $id, 'videopress_status', videopress_is_finished_processing( $id ) ? 'complete' : 'processing' );
135
136			// Get the attached file and if there isn't one, then let's update it with the one from the server.
137			$file = get_attached_file( $id );
138			if ( ! $file && is_string( $info['original'] ) ) {
139			videopress_download_video( $info['original'], $id );
140			}
141
142			return true;
143			}
144
145			/**
146			* @param array $request
147			* @return bool
148			*/
149			public function update_poster_image( $request ) {
150
151			$post_id = $request['post_id'];
152			$poster = $request['poster'];
153
154			if ( ! $attachment = get_post( $post_id ) ) {
155			return false;
156			}
157
158			// Update the poster in the VideoPress info.
159			$thumbnail_id = videopress_download_poster_image( $poster, $post_id );
160
161			if ( !is_int( $thumbnail_id ) ) {
162			return false;
163			}
164
165			update_post_meta( $post_id, '_thumbnail_id', $thumbnail_id );
166			$meta = wp_get_attachment_metadata( $post_id );
167
168			$meta['videopress']['poster'] = $poster;
169			wp_update_attachment_metadata( $post_id, $meta );
170
171			return true;
172			}
173			}
174

Automattic / jetpack

Push — add/wpcom-shortcodes ( 38c379...fb6212 )

VideoPress_XMLRPC::update_videopress_media_item() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like