Automattic /
jetpack
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 5 | class Keyring { |
||
| 6 | |||
| 7 | function __construct() { |
||
| 8 | |||
| 9 | add_action( 'load-settings_page_sharing', array( $this, 'admin_page_load' ), 9 ); |
||
| 10 | |||
| 11 | } |
||
| 12 | |||
| 13 | function display_connection_error() { |
||
| 14 | $code = false; |
||
| 15 | if ( isset( $_GET['service'] ) ) { |
||
| 16 | $service_name = $_GET['service']; |
||
| 17 | $error = sprintf( __( 'There was a problem connecting to %s to create an authorized connection. Please try again in a moment.', 'jetpack' ), Publicize::get_service_label( $service_name ) ); |
||
| 18 | } else { |
||
| 19 | if ( isset( $_GET['publicize_error'] ) ) { |
||
| 20 | $code = strtolower( $_GET['publicize_error'] ); |
||
| 21 | switch ( $code ) { |
||
| 22 | case '400': |
||
| 23 | $error = __( 'An invalid request was made. This normally means that something intercepted or corrupted the request from your server to the Jetpack Server. Try again and see if it works this time.', 'jetpack' ); |
||
| 24 | break; |
||
| 25 | case 'secret_mismatch': |
||
| 26 | $error = __( 'We could not verify that your server is making an authorized request. Please try again, and make sure there is nothing interfering with requests from your server to the Jetpack Server.', 'jetpack' ); |
||
| 27 | break; |
||
| 28 | case 'empty_blog_id': |
||
| 29 | $error = __( 'No blog_id was included in your request. Please try disconnecting Jetpack from WordPress.com and then reconnecting it. Once you have done that, try connecting Publicize again.', 'jetpack' ); |
||
| 30 | break; |
||
| 31 | case 'empty_state': |
||
| 32 | $error = sprintf( __( 'No user information was included in your request. Please make sure that your user account has connected to Jetpack. Connect your user account by going to the <a href="%s">Jetpack page</a> within wp-admin.', 'jetpack' ), Jetpack::admin_url() ); |
||
| 33 | break; |
||
| 34 | default: |
||
| 35 | $error = __( 'Something which should never happen, happened. Sorry about that. If you try again, maybe it will work.', 'jetpack' ); |
||
| 36 | break; |
||
| 37 | } |
||
| 38 | } else { |
||
| 39 | $error = __( 'There was a problem connecting with Publicize. Please try again in a moment.', 'jetpack' ); |
||
| 40 | } |
||
| 41 | } |
||
| 42 | // Using the same formatting/style as Jetpack::admin_notices() error |
||
| 43 | ?> |
||
| 44 | <div id="message" class="jetpack-message jetpack-err"> |
||
| 45 | <div class="squeezer"> |
||
| 46 | <h2><?php echo wp_kses( $error, array( 'a' => array( 'href' => true ), |
||
| 47 | 'code' => true, |
||
| 48 | 'strong' => true, |
||
| 49 | 'br' => true, |
||
| 50 | 'b' => true |
||
| 51 | ) ); ?></h2> |
||
| 52 | <?php if ( $code ) : ?> |
||
|
|
|||
| 53 | <p><?php printf( __( 'Error code: %s', 'jetpack' ), esc_html( stripslashes( $code ) ) ); ?></p> |
||
| 54 | <?php endif; ?> |
||
| 55 | </div> |
||
| 56 | </div> |
||
| 57 | <?php |
||
| 58 | } |
||
| 59 | |||
| 60 | function admin_page_load() { |
||
| 61 | if ( isset( $_GET['action'] ) ) { |
||
| 62 | if ( isset( $_GET['service'] ) ) { |
||
| 63 | $service_name = $_GET['service']; |
||
| 64 | } |
||
| 65 | |||
| 66 | switch ( $_GET['action'] ) { |
||
| 67 | case 'error': |
||
| 68 | add_action( 'pre_admin_screen_sharing', array( $this, 'display_connection_error' ), 9 ); |
||
| 69 | break; |
||
| 70 | |||
| 71 | case 'request': |
||
| 72 | check_admin_referer( 'keyring-request', 'kr_nonce' ); |
||
| 73 | check_admin_referer( "keyring-request-$service_name", 'nonce' ); |
||
| 74 | |||
| 75 | $verification = Jetpack::generate_secrets( 'publicize' ); |
||
| 76 | if ( ! $verification ) { |
||
| 77 | $url = Jetpack::admin_url( 'jetpack#/settings' ); |
||
| 78 | wp_die( sprintf( __( "Jetpack is not connected. Please connect Jetpack by visiting <a href='%s'>Settings</a>.", 'jetpack' ), $url ) ); |
||
| 79 | |||
| 80 | } |
||
| 81 | $stats_options = get_option( 'stats_options' ); |
||
| 82 | $wpcom_blog_id = Jetpack_Options::get_option( 'id' ); |
||
| 83 | $wpcom_blog_id = ! empty( $wpcom_blog_id ) ? $wpcom_blog_id : $stats_options['blog_id']; |
||
| 84 | |||
| 85 | $user = wp_get_current_user(); |
||
| 86 | $redirect = $this->api_url( $service_name, urlencode_deep( array( |
||
| 87 | 'action' => 'request', |
||
| 88 | 'redirect_uri' => add_query_arg( array( 'action' => 'done' ), menu_page_url( 'sharing', false ) ), |
||
| 89 | 'for' => 'publicize', |
||
| 90 | // required flag that says this connection is intended for publicize |
||
| 91 | 'siteurl' => site_url(), |
||
| 92 | 'state' => $user->ID, |
||
| 93 | 'blog_id' => $wpcom_blog_id, |
||
| 94 | 'secret_1' => $verification['secret_1'], |
||
| 95 | 'secret_2' => $verification['secret_2'], |
||
| 96 | 'eol' => $verification['exp'], |
||
| 97 | ) ) ); |
||
| 98 | wp_redirect( $redirect ); |
||
| 99 | exit; |
||
| 100 | break; |
||
| 101 | |||
| 102 | case 'completed': |
||
| 103 | Jetpack::load_xml_rpc_client(); |
||
| 104 | $xml = new Jetpack_IXR_Client(); |
||
| 105 | $xml->query( 'jetpack.fetchPublicizeConnections' ); |
||
| 106 | |||
| 107 | if ( ! $xml->isError() ) { |
||
| 108 | $response = $xml->getResponse(); |
||
| 109 | Jetpack_Options::update_option( 'publicize_connections', $response ); |
||
| 110 | } |
||
| 111 | |||
| 112 | break; |
||
| 113 | |||
| 114 | case 'delete': |
||
| 115 | $id = $_GET['id']; |
||
| 116 | |||
| 117 | check_admin_referer( 'keyring-request', 'kr_nonce' ); |
||
| 118 | check_admin_referer( "keyring-request-$service_name", 'nonce' ); |
||
| 119 | |||
| 120 | $this->disconnect( $service_name, $id ); |
||
| 121 | |||
| 122 | add_action( 'admin_notices', array( $this, 'display_disconnected' ) ); |
||
| 123 | break; |
||
| 124 | } |
||
| 125 | } |
||
| 126 | |||
| 127 | /** |
||
| 128 | * Remove a Publicize connection |
||
| 129 | */ |
||
| 130 | View Code Duplication | function disconnect( $service_name, $connection_id, $_blog_id = false, $_user_id = false, $force_delete = false ) { |
|
| 141 | |||
| 142 | // Do we really need `admin_styles`? With the new admin UI, it's breaking some bits. |
||
| 143 | // Errors encountered on WordPress.com's end are passed back as a code |
||
| 151 | |||
| 152 | /** |
||
| 153 | * Gets a URL to the public-api actions. Works like WP's admin_url |
||
| 154 | * |
||
| 155 | * @param string $service Shortname of a specific service. |
||
| 156 | * |
||
| 157 | * @return URL to specific public-api process |
||
| 158 | */ |
||
| 159 | // on WordPress.com this is/calls Keyring::admin_url |
||
| 160 | function api_url( $service = false, $params = array() ) { |
||
| 182 | |||
| 183 | View Code Duplication | static function connect_url( $service_name ) { |
|
| 191 | |||
| 192 | static function refresh_url( $service_name ) { |
||
| 202 | |||
| 203 | View Code Duplication | static function disconnect_url( $service_name, $id ) { |
|
| 212 | |||
| 213 | function get_services() { |
||
| 225 | |||
| 226 | } |
||
| 227 |
Loading history...
In PHP, under loose comparison (like
==, or!=, orswitchconditions), values of different types might be equal.For
stringvalues, the empty string''is a special case, in particular the following results might be unexpected: