Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Jetpack_React_Page often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Jetpack_React_Page, and based on these observations, apply Extract Interface, too.
| 1 | <?php  | 
            ||
| 5 | class Jetpack_React_Page extends Jetpack_Admin_Page { | 
            ||
| 6 | |||
| 7 | protected $dont_show_if_not_active = false;  | 
            ||
| 8 | |||
| 9 | protected $is_redirecting = false;  | 
            ||
| 10 | |||
| 11 | 	function get_page_hook() { | 
            ||
| 12 | // Add the main admin Jetpack menu  | 
            ||
| 13 | return add_menu_page( 'Jetpack', 'Jetpack', 'jetpack_admin_page', 'jetpack', array( $this, 'render' ), 'div' );  | 
            ||
| 14 | }  | 
            ||
| 15 | |||
| 16 | 	function add_page_actions( $hook ) { | 
            ||
| 17 | /** This action is documented in class.jetpack.php */  | 
            ||
| 18 | do_action( 'jetpack_admin_menu', $hook );  | 
            ||
| 19 | |||
| 20 | // Place the Jetpack menu item on top and others in the order they appear  | 
            ||
| 21 | add_filter( 'custom_menu_order', '__return_true' );  | 
            ||
| 22 | add_filter( 'menu_order', array( $this, 'jetpack_menu_order' ) );  | 
            ||
| 23 | |||
| 24 | 		if ( ! isset( $_GET['page'] ) || 'jetpack' !== $_GET['page'] ) { | 
            ||
| 25 | return; // No need to handle the fallback redirection if we are not on the Jetpack page  | 
            ||
| 26 | }  | 
            ||
| 27 | |||
| 28 | // Adding a redirect meta tag if the REST API is disabled  | 
            ||
| 29 | 		if ( ! $this->is_rest_api_enabled() ) { | 
            ||
| 30 | $this->is_redirecting = true;  | 
            ||
| 31 | add_action( 'admin_head', array( $this, 'add_fallback_head_meta' ) );  | 
            ||
| 32 | }  | 
            ||
| 33 | |||
| 34 | // Adding a redirect meta tag wrapped in noscript tags for all browsers in case they have JavaScript disabled  | 
            ||
| 35 | add_action( 'admin_head', array( $this, 'add_noscript_head_meta' ) );  | 
            ||
| 36 | |||
| 37 | // If this is the first time the user is viewing the admin, don't show JITMs.  | 
            ||
| 38 | // This filter is added just in time because this function is called on admin_menu  | 
            ||
| 39 | // and JITMs are initialized on admin_init  | 
            ||
| 40 | 		if ( Jetpack::is_active() && ! Jetpack_Options::get_option( 'first_admin_view', false ) ) { | 
            ||
| 41 | Jetpack_Options::update_option( 'first_admin_view', true );  | 
            ||
| 42 | add_filter( 'jetpack_just_in_time_msgs', '__return_false' );  | 
            ||
| 43 | }  | 
            ||
| 44 | }  | 
            ||
| 45 | |||
| 46 | /**  | 
            ||
| 47 | * Add Jetpack Dashboard sub-link and point it to AAG if the user can view stats, manage modules or if Protect is active.  | 
            ||
| 48 | *  | 
            ||
| 49 | * Works in Dev Mode or when user is connected.  | 
            ||
| 50 | *  | 
            ||
| 51 | * @since 4.3.0  | 
            ||
| 52 | */  | 
            ||
| 53 | 	function jetpack_add_dashboard_sub_nav_item() { | 
            ||
| 54 | View Code Duplication | 		if ( Jetpack::is_development_mode() || Jetpack::is_active() ) { | 
            |
| 55 | global $submenu;  | 
            ||
| 56 | 			if ( current_user_can( 'jetpack_admin_page' ) ) { | 
            ||
| 57 | $submenu['jetpack'][] = array( __( 'Dashboard', 'jetpack' ), 'jetpack_admin_page', 'admin.php?page=jetpack#/dashboard' );  | 
            ||
| 58 | }  | 
            ||
| 59 | }  | 
            ||
| 60 | }  | 
            ||
| 61 | |||
| 62 | /**  | 
            ||
| 63 | * If user is allowed to see the Jetpack Admin, add Settings sub-link.  | 
            ||
| 64 | *  | 
            ||
| 65 | * @since 4.3.0  | 
            ||
| 66 | */  | 
            ||
| 67 | 	function jetpack_add_settings_sub_nav_item() { | 
            ||
| 68 | View Code Duplication | 		if ( ( Jetpack::is_development_mode() || Jetpack::is_active() ) && current_user_can( 'jetpack_admin_page' ) && current_user_can( 'edit_posts' ) ) { | 
            |
| 69 | global $submenu;  | 
            ||
| 70 | $submenu['jetpack'][] = array( __( 'Settings', 'jetpack' ), 'jetpack_admin_page', 'admin.php?page=jetpack#/settings' );  | 
            ||
| 71 | }  | 
            ||
| 72 | }  | 
            ||
| 73 | |||
| 74 | 	function add_fallback_head_meta() { | 
            ||
| 75 | echo '<meta http-equiv="refresh" content="0; url=?page=jetpack_modules">';  | 
            ||
| 76 | }  | 
            ||
| 77 | |||
| 78 | 	function add_noscript_head_meta() { | 
            ||
| 79 | echo '<noscript>';  | 
            ||
| 80 | $this->add_fallback_head_meta();  | 
            ||
| 81 | echo '</noscript>';  | 
            ||
| 82 | }  | 
            ||
| 83 | |||
| 84 | View Code Duplication | 	function jetpack_menu_order( $menu_order ) { | 
            |
| 85 | $jp_menu_order = array();  | 
            ||
| 86 | |||
| 87 | 		foreach ( $menu_order as $index => $item ) { | 
            ||
| 88 | if ( $item != 'jetpack' )  | 
            ||
| 89 | $jp_menu_order[] = $item;  | 
            ||
| 90 | |||
| 91 | if ( $index == 0 )  | 
            ||
| 92 | $jp_menu_order[] = 'jetpack';  | 
            ||
| 93 | }  | 
            ||
| 94 | |||
| 95 | return $jp_menu_order;  | 
            ||
| 96 | }  | 
            ||
| 97 | |||
| 98 | 	function page_render() { | 
            ||
| 99 | /** This action is already documented in views/admin/admin-page.php */  | 
            ||
| 100 | do_action( 'jetpack_notices' );  | 
            ||
| 101 | |||
| 102 | // Try fetching by patch  | 
            ||
| 103 | $static_html = @file_get_contents( JETPACK__PLUGIN_DIR . '_inc/build/static.html' );  | 
            ||
| 104 | |||
| 105 | 		if ( false === $static_html ) { | 
            ||
| 106 | |||
| 107 | // If we still have nothing, display an error  | 
            ||
| 108 | echo '<p>';  | 
            ||
| 109 | esc_html_e( 'Error fetching static.html. Try running: ', 'jetpack' );  | 
            ||
| 110 | echo '<code>yarn distclean && yarn build</code>';  | 
            ||
| 111 | echo '</p>';  | 
            ||
| 112 | 		} else { | 
            ||
| 113 | |||
| 114 | // We got the static.html so let's display it  | 
            ||
| 115 | echo $static_html;  | 
            ||
| 116 | }  | 
            ||
| 117 | }  | 
            ||
| 118 | |||
| 119 | /**  | 
            ||
| 120 | * Gets array of any Jetpack notices that have been dismissed.  | 
            ||
| 121 | *  | 
            ||
| 122 | * @since 4.0.1  | 
            ||
| 123 | * @return mixed|void  | 
            ||
| 124 | */  | 
            ||
| 125 | 	function get_dismissed_jetpack_notices() { | 
            ||
| 126 | $jetpack_dismissed_notices = get_option( 'jetpack_dismissed_notices', array() );  | 
            ||
| 127 | /**  | 
            ||
| 128 | * Array of notices that have been dismissed.  | 
            ||
| 129 | *  | 
            ||
| 130 | * @since 4.0.1  | 
            ||
| 131 | *  | 
            ||
| 132 | * @param array $jetpack_dismissed_notices If empty, will not show any Jetpack notices.  | 
            ||
| 133 | */  | 
            ||
| 134 | $dismissed_notices = apply_filters( 'jetpack_dismissed_notices', $jetpack_dismissed_notices );  | 
            ||
| 135 | return $dismissed_notices;  | 
            ||
| 136 | }  | 
            ||
| 137 | |||
| 138 | 	function additional_styles() { | 
            ||
| 139 | Jetpack_Admin_Page::load_wrapper_styles();  | 
            ||
| 140 | }  | 
            ||
| 141 | |||
| 142 | 	function page_admin_scripts() { | 
            ||
| 143 | 		if ( $this->is_redirecting ) { | 
            ||
| 144 | return; // No need for scripts on a fallback page  | 
            ||
| 145 | }  | 
            ||
| 146 | |||
| 147 | $script_deps_path = JETPACK__PLUGIN_DIR . '_inc/build/admin.deps.json';  | 
            ||
| 148 | $script_dependencies = file_exists( $script_deps_path )  | 
            ||
| 149 | ? json_decode( file_get_contents( $script_deps_path ) )  | 
            ||
| 150 | : array();  | 
            ||
| 151 | $script_dependencies[] = 'wp-polyfill';  | 
            ||
| 152 | |||
| 153 | wp_enqueue_script(  | 
            ||
| 154 | 'react-plugin',  | 
            ||
| 155 | plugins_url( '_inc/build/admin.js', JETPACK__PLUGIN_FILE ),  | 
            ||
| 156 | $script_dependencies,  | 
            ||
| 157 | JETPACK__VERSION,  | 
            ||
| 158 | true  | 
            ||
| 159 | );  | 
            ||
| 160 | |||
| 161 | View Code Duplication | 		if ( ! Jetpack::is_development_mode() && Jetpack::is_active() ) { | 
            |
| 162 | // Required for Analytics.  | 
            ||
| 163 | wp_enqueue_script( 'jp-tracks', '//stats.wp.com/w.js', array(), gmdate( 'YW' ), true );  | 
            ||
| 164 | }  | 
            ||
| 165 | |||
| 166 | // Add objects to be passed to the initial state of the app.  | 
            ||
| 167 | wp_localize_script( 'react-plugin', 'Initial_State', $this->get_initial_state() );  | 
            ||
| 168 | }  | 
            ||
| 169 | |||
| 170 | 	function get_initial_state() { | 
            ||
| 171 | // Load API endpoint base classes and endpoints for getting the module list fed into the JS Admin Page  | 
            ||
| 172 | require_once JETPACK__PLUGIN_DIR . '_inc/lib/core-api/class.jetpack-core-api-xmlrpc-consumer-endpoint.php';  | 
            ||
| 173 | require_once JETPACK__PLUGIN_DIR . '_inc/lib/core-api/class.jetpack-core-api-module-endpoints.php';  | 
            ||
| 174 | $moduleListEndpoint = new Jetpack_Core_API_Module_List_Endpoint();  | 
            ||
| 175 | $modules = $moduleListEndpoint->get_modules();  | 
            ||
| 176 | |||
| 177 | // Preparing translated fields for JSON encoding by transforming all HTML entities to  | 
            ||
| 178 | // respective characters.  | 
            ||
| 179 | 		foreach( $modules as $slug => $data ) { | 
            ||
| 
                                                                                                    
                        
                         | 
                |||
| 180 | $modules[ $slug ]['name'] = html_entity_decode( $data['name'] );  | 
            ||
| 181 | $modules[ $slug ]['description'] = html_entity_decode( $data['description'] );  | 
            ||
| 182 | $modules[ $slug ]['short_description'] = html_entity_decode( $data['short_description'] );  | 
            ||
| 183 | $modules[ $slug ]['long_description'] = html_entity_decode( $data['long_description'] );  | 
            ||
| 184 | }  | 
            ||
| 185 | |||
| 186 | // Collecting roles that can view site stats.  | 
            ||
| 187 | $stats_roles = array();  | 
            ||
| 188 | $enabled_roles = function_exists( 'stats_get_option' ) ? stats_get_option( 'roles' ) : array( 'administrator' );  | 
            ||
| 189 | |||
| 190 | 		if ( ! function_exists( 'get_editable_roles' ) ) { | 
            ||
| 191 | require_once ABSPATH . 'wp-admin/includes/user.php';  | 
            ||
| 192 | }  | 
            ||
| 193 | 		foreach ( get_editable_roles() as $slug => $role ) { | 
            ||
| 194 | $stats_roles[ $slug ] = array(  | 
            ||
| 195 | 'name' => translate_user_role( $role['name'] ),  | 
            ||
| 196 | 'canView' => is_array( $enabled_roles ) ? in_array( $slug, $enabled_roles, true ) : false,  | 
            ||
| 197 | );  | 
            ||
| 198 | }  | 
            ||
| 199 | |||
| 200 | // Get information about current theme.  | 
            ||
| 201 | $current_theme = wp_get_theme();  | 
            ||
| 202 | |||
| 203 | // Get all themes that Infinite Scroll provides support for natively.  | 
            ||
| 204 | $inf_scr_support_themes = array();  | 
            ||
| 205 | 		foreach ( Jetpack::glob_php( JETPACK__PLUGIN_DIR . 'modules/infinite-scroll/themes' ) as $path ) { | 
            ||
| 206 | 			if ( is_readable( $path ) ) { | 
            ||
| 207 | $inf_scr_support_themes[] = basename( $path, '.php' );  | 
            ||
| 208 | }  | 
            ||
| 209 | }  | 
            ||
| 210 | |||
| 211 | // Get last post, to build the link to Customizer in the Related Posts module.  | 
            ||
| 212 | $last_post = get_posts( array( 'posts_per_page' => 1 ) );  | 
            ||
| 213 | $last_post = isset( $last_post[0] ) && $last_post[0] instanceof WP_Post  | 
            ||
| 214 | ? get_permalink( $last_post[0]->ID )  | 
            ||
| 215 | : get_home_url();  | 
            ||
| 216 | |||
| 217 | // Ensure that class to get the affiliate code is loaded  | 
            ||
| 218 | 		if ( ! class_exists( 'Jetpack_Affiliate' ) ) { | 
            ||
| 219 | require_once JETPACK__PLUGIN_DIR . 'class.jetpack-affiliate.php';  | 
            ||
| 220 | }  | 
            ||
| 221 | |||
| 222 | $current_user_data = jetpack_current_user_data();  | 
            ||
| 223 | |||
| 224 | return array(  | 
            ||
| 225 | 'WP_API_root' => esc_url_raw( rest_url() ),  | 
            ||
| 226 | 'WP_API_nonce' => wp_create_nonce( 'wp_rest' ),  | 
            ||
| 227 | 'pluginBaseUrl' => plugins_url( '', JETPACK__PLUGIN_FILE ),  | 
            ||
| 228 | 'connectionStatus' => array(  | 
            ||
| 229 | 'isActive' => Jetpack::is_active(),  | 
            ||
| 230 | 'isStaging' => Jetpack::is_staging_site(),  | 
            ||
| 231 | 'devMode' => array(  | 
            ||
| 232 | 'isActive' => Jetpack::is_development_mode(),  | 
            ||
| 233 | 'constant' => defined( 'JETPACK_DEV_DEBUG' ) && JETPACK_DEV_DEBUG,  | 
            ||
| 234 | 'url' => site_url() && false === strpos( site_url(), '.' ),  | 
            ||
| 235 | 'filter' => apply_filters( 'jetpack_development_mode', false ),  | 
            ||
| 236 | ),  | 
            ||
| 237 | 'isPublic' => '1' == get_option( 'blog_public' ),  | 
            ||
| 238 | 'isInIdentityCrisis' => Jetpack::validate_sync_error_idc_option(),  | 
            ||
| 239 | 'sandboxDomain' => JETPACK__SANDBOX_DOMAIN,  | 
            ||
| 240 | ),  | 
            ||
| 241 | 'connectUrl' => $current_user_data['isConnected'] == false ? Jetpack::init()->build_connect_url( true, false, false ) : '',  | 
            ||
| 242 | 'dismissedNotices' => $this->get_dismissed_jetpack_notices(),  | 
            ||
| 243 | 'isDevVersion' => Jetpack::is_development_version(),  | 
            ||
| 244 | 'currentVersion' => JETPACK__VERSION,  | 
            ||
| 245 | 'is_gutenberg_available' => true,  | 
            ||
| 246 | 'getModules' => $modules,  | 
            ||
| 247 | 'rawUrl' => Jetpack::build_raw_urls( get_home_url() ),  | 
            ||
| 248 | 'adminUrl' => esc_url( admin_url() ),  | 
            ||
| 249 | 'stats' => array(  | 
            ||
| 250 | // data is populated asynchronously on page load  | 
            ||
| 251 | 'data' => array(  | 
            ||
| 252 | 'general' => false,  | 
            ||
| 253 | 'day' => false,  | 
            ||
| 254 | 'week' => false,  | 
            ||
| 255 | 'month' => false,  | 
            ||
| 256 | ),  | 
            ||
| 257 | 'roles' => $stats_roles,  | 
            ||
| 258 | ),  | 
            ||
| 259 | 'aff' => Jetpack_Affiliate::init()->get_affiliate_code(),  | 
            ||
| 260 | 'settings' => $this->get_flattened_settings( $modules ),  | 
            ||
| 261 | 'userData' => array(  | 
            ||
| 262 | // 'othersLinked' => Jetpack::get_other_linked_admins(),  | 
            ||
| 263 | 'currentUser' => $current_user_data,  | 
            ||
| 264 | ),  | 
            ||
| 265 | 'siteData' => array(  | 
            ||
| 266 | 'icon' => has_site_icon()  | 
            ||
| 267 | ? apply_filters( 'jetpack_photon_url', get_site_icon_url(), array( 'w' => 64 ) )  | 
            ||
| 268 | : '',  | 
            ||
| 269 | 'siteVisibleToSearchEngines' => '1' == get_option( 'blog_public' ),  | 
            ||
| 270 | /**  | 
            ||
| 271 | * Whether promotions are visible or not.  | 
            ||
| 272 | *  | 
            ||
| 273 | * @since 4.8.0  | 
            ||
| 274 | *  | 
            ||
| 275 | * @param bool $are_promotions_active Status of promotions visibility. True by default.  | 
            ||
| 276 | */  | 
            ||
| 277 | 'showPromotions' => apply_filters( 'jetpack_show_promotions', true ),  | 
            ||
| 278 | 'isAtomicSite' => jetpack_is_atomic_site(),  | 
            ||
| 279 | 'plan' => Jetpack_Plan::get(),  | 
            ||
| 280 | 'showBackups' => Jetpack::show_backups_ui(),  | 
            ||
| 281 | ),  | 
            ||
| 282 | 'themeData' => array(  | 
            ||
| 283 | 'name' => $current_theme->get( 'Name' ),  | 
            ||
| 284 | 'hasUpdate' => (bool) get_theme_update_available( $current_theme ),  | 
            ||
| 285 | 'support' => array(  | 
            ||
| 286 | 'infinite-scroll' => current_theme_supports( 'infinite-scroll' ) || in_array( $current_theme->get_stylesheet(), $inf_scr_support_themes ),  | 
            ||
| 287 | ),  | 
            ||
| 288 | ),  | 
            ||
| 289 | 'locale' => Jetpack::get_i18n_data_json(),  | 
            ||
| 290 | 'localeSlug' => join( '-', explode( '_', get_user_locale() ) ),  | 
            ||
| 291 | 'jetpackStateNotices' => array(  | 
            ||
| 292 | 'messageCode' => Jetpack::state( 'message' ),  | 
            ||
| 293 | 'errorCode' => Jetpack::state( 'error' ),  | 
            ||
| 294 | 'errorDescription' => Jetpack::state( 'error_description' ),  | 
            ||
| 295 | ),  | 
            ||
| 296 | 'tracksUserData' => Jetpack_Tracks_Client::get_connected_user_tracks_identity(),  | 
            ||
| 297 | 'currentIp' => function_exists( 'jetpack_protect_get_ip' ) ? jetpack_protect_get_ip() : false,  | 
            ||
| 298 | 'lastPostUrl' => esc_url( $last_post ),  | 
            ||
| 299 | 'externalServicesConnectUrls' => $this->get_external_services_connect_urls(),  | 
            ||
| 300 | 'calypsoEnv' => Jetpack::get_calypso_env(),  | 
            ||
| 301 | );  | 
            ||
| 302 | }  | 
            ||
| 303 | |||
| 304 | 	function get_external_services_connect_urls() { | 
            ||
| 305 | $connect_urls = array();  | 
            ||
| 306 | jetpack_require_lib( 'class.jetpack-keyring-service-helper' );  | 
            ||
| 307 | 		foreach ( Jetpack_Keyring_Service_Helper::$SERVICES as $service_name => $service_info ) { | 
            ||
| 308 | $connect_urls[ $service_name ] = Jetpack_Keyring_Service_Helper::connect_url( $service_name, $service_info[ 'for' ] );  | 
            ||
| 309 | }  | 
            ||
| 310 | return $connect_urls;  | 
            ||
| 311 | }  | 
            ||
| 312 | |||
| 313 | /**  | 
            ||
| 314 | * Returns an array of modules and settings both as first class members of the object.  | 
            ||
| 315 | *  | 
            ||
| 316 | * @param array $modules the result of an API request to get all modules.  | 
            ||
| 317 | *  | 
            ||
| 318 | * @return array flattened settings with modules.  | 
            ||
| 319 | */  | 
            ||
| 320 | 	function get_flattened_settings( $modules ) { | 
            ||
| 325 | }  | 
            ||
| 326 | |||
| 327 | /**  | 
            ||
| 328 | * Gather data about the current user.  | 
            ||
| 329 | *  | 
            ||
| 330 | * @since 4.1.0  | 
            ||
| 331 | *  | 
            ||
| 332 | * @return array  | 
            ||
| 333 | */  | 
            ||
| 334 | function jetpack_current_user_data() { | 
            ||
| 335 | $current_user = wp_get_current_user();  | 
            ||
| 336 | $is_master_user = $current_user->ID == Jetpack_Options::get_option( 'master_user' );  | 
            ||
| 337 | $dotcom_data = Jetpack::get_connected_user_data();  | 
            ||
| 338 | // Add connected user gravatar to the returned dotcom_data.  | 
            ||
| 368 | 
There are different options of fixing this problem.
If you want to be on the safe side, you can add an additional type-check:
If you are sure that the expression is traversable, you might want to add a doc comment cast to improve IDE auto-completion and static analysis:
Mark the issue as a false-positive: Just hover the remove button, in the top-right corner of this issue for more options.