Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
14 | View Code Duplication | class Initial_State { |
|
|
|||
15 | /** |
||
16 | * Get the initial state data. |
||
17 | * |
||
18 | * @return array |
||
19 | */ |
||
20 | private function get_data() { |
||
32 | |||
33 | /** |
||
34 | * Whether we can the connection iframe. |
||
35 | * |
||
36 | * @return bool |
||
37 | */ |
||
38 | private function can_use_connection_iframe() { |
||
57 | |||
58 | /** |
||
59 | * Render the initial state into a JavaScript variable. |
||
60 | * |
||
61 | * @return string |
||
62 | */ |
||
63 | public function render() { |
||
68 | |||
69 | } |
||
70 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.