Issues in class.jetpack-sync-defaults.php - New Issues - Inspection of "New build" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master-stable ( acd8d4...fb4264 )

unknown

created 2016-08-10 22:38 UTC

sync/class.jetpack-sync-defaults.php (1 issue)

Labels

Coding Style 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
require_once( JETPACK__PLUGIN_DIR . 'modules/sso/class.jetpack-sso-helpers.php' );

/**
 * Just some defaults that we share with the server
 */
class Jetpack_Sync_Defaults {
	static $default_options_whitelist = array(
		'stylesheet',
		'blogname',
		'home',
		'siteurl',
		'blogdescription',
		'blog_charset',
		'permalink_structure',
		'category_base',
		'tag_base',
		'comment_moderation',
		'default_comment_status',
		'jetpack_site_icon_url',
		'page_on_front',
		'rss_use_excerpt',
		'subscription_options',
		'stb_enabled',
		'stc_enabled',
		'comment_registration',
		'show_avatars',
		'avatar_default',
		'avatar_rating',
		'highlander_comment_form_prompt',
		'jetpack_comment_form_color_scheme',
		'stats_options',
		'gmt_offset',
		'timezone_string',
		'jetpack_sync_non_public_post_stati',
		'jetpack_options',
		'site_icon', // (int) - ID of core's Site Icon attachment ID
		'default_post_format',
		'default_category',
		'large_size_w',
		'large_size_h',
		'thumbnail_size_w',
		'thumbnail_size_h',
		'medium_size_w',
		'medium_size_h',
		'thumbnail_crop',
		'image_default_link_type',
		'site_logo',
		'sharing-options',
		'sharing-services',
		'post_count',
		'default_ping_status',
		'sticky_posts',
		'blog_public',
		'default_pingback_flag',
		'require_name_email',
		'close_comments_for_old_posts',
		'close_comments_days_old',
		'thread_comments',
		'thread_comments_depth',
		'page_comments',
		'comments_per_page',
		'default_comments_page',
		'comment_order',
		'comments_notify',
		'moderation_notify',
		'social_notifications_like',
		'social_notifications_reblog',
		'social_notifications_subscribe',
		'comment_whitelist',
		'comment_max_links',
		'moderation_keys',
		'blacklist_keys',
		'lang_id',
		'wga',
		'disabled_likes',
		'disabled_reblogs',
		'jetpack_comment_likes_enabled',
		'twitter_via',
		'jetpack-twitter-cards-site-tag',
		'wpcom_publish_posts_with_markdown',
		'wpcom_publish_comments_with_markdown',
		'jetpack_activated',
		'jetpack_available_modules',
		'jetpack_autoupdate_plugins',
		'jetpack_autoupdate_themes',
		'jetpack_autoupdate_core',
		'carousel_background_color',
		'carousel_display_exif',
		'jetpack_portfolio',
		'jetpack_portfolio_posts_per_page',
		'jetpack_testimonial',
		'jetpack_testimonial_posts_per_page',
		'tiled_galleries',
		'gravatar_disable_hovercards',
		'infinite_scroll',
		'infinite_scroll_google_analytics',
		'wp_mobile_excerpt',
		'wp_mobile_featured_images',
		'wp_mobile_app_promos',
		'monitor_receive_notifications',
		'post_by_email_address',
		'jetpack_protect_key',
		'jetpack_protect_global_whitelist',
		'sharing_services',
		'jetpack_sso_require_two_step',
		'jetpack_relatedposts',
		'verification_services_codes',
		'users_can_register',
		'active_plugins',
		'uninstall_plugins',
	);

	static $default_constants_whitelist = array(
		'EMPTY_TRASH_DAYS',
		'WP_POST_REVISIONS',
		'AUTOMATIC_UPDATER_DISABLED',
		'ABSPATH',
		'WP_CONTENT_DIR',
		'FS_METHOD',
		'DISALLOW_FILE_EDIT',
		'DISALLOW_FILE_MODS',
		'WP_AUTO_UPDATE_CORE',
		'WP_HTTP_BLOCK_EXTERNAL',
		'WP_ACCESSIBLE_HOSTS',
		'JETPACK__VERSION',
		'IS_PRESSABLE',
	);

	static $default_callable_whitelist = array(
		'wp_max_upload_size'               => 'wp_max_upload_size',
		'is_main_network'                  => array( 'Jetpack', 'is_multi_network' ),
		'is_multi_site'                    => 'is_multisite',
		'main_network_site'                => array( 'Jetpack_Sync_Functions', 'main_network_site_url' ),
		'site_url'                         => array( 'Jetpack_Sync_Functions', 'site_url' ),
		'home_url'                         => array( 'Jetpack_Sync_Functions', 'home_url' ),
		'single_user_site'                 => array( 'Jetpack', 'is_single_user_site' ),
		'updates'                          => array( 'Jetpack', 'get_updates' ),
		'has_file_system_write_access'     => array( 'Jetpack_Sync_Functions', 'file_system_write_access' ),
		'is_version_controlled'            => array( 'Jetpack_Sync_Functions', 'is_version_controlled' ),
		'taxonomies'                       => array( 'Jetpack_Sync_Functions', 'get_taxonomies' ),
		'post_types'                       => array( 'Jetpack_Sync_Functions', 'get_post_types' ),
		'post_type_features'               => array( 'Jetpack_Sync_Functions', 'get_post_type_features' ),
		'rest_api_allowed_post_types'      => array( 'Jetpack_Sync_Functions', 'rest_api_allowed_post_types' ),
		'rest_api_allowed_public_metadata' => array( 'Jetpack_Sync_Functions', 'rest_api_allowed_public_metadata' ),
		'sso_is_two_step_required'         => array( 'Jetpack_SSO_Helpers', 'is_two_step_required' ),
		'sso_should_hide_login_form'       => array( 'Jetpack_SSO_Helpers', 'should_hide_login_form' ),
		'sso_match_by_email'               => array( 'Jetpack_SSO_Helpers', 'match_by_email' ),
		'sso_new_user_override'            => array( 'Jetpack_SSO_Helpers', 'new_user_override' ),
		'sso_bypass_default_login_form'    => array( 'Jetpack_SSO_Helpers', 'bypass_login_forward_wpcom' ),
		'wp_version'                       => array( 'Jetpack_Sync_Functions', 'wp_version' ),
		'get_plugins'                      => array( 'Jetpack_Sync_Functions', 'get_plugins' ),
		'active_modules'                   => array( 'Jetpack', 'get_active_modules' ),
	);

	static $blacklisted_post_types = array(
		'ai1ec_event',
		'snitch',
	);

	static $default_post_checksum_columns = array(
		'ID',
		'post_modified',
	); 

	static $default_comment_checksum_columns = array(
		'comment_ID',
		'comment_content',
	); 

	static $default_option_checksum_columns = array(
		'option_name',
		'option_value',
	);

	// returns escapted SQL that can be injected into a WHERE clause
	static function get_blacklisted_post_types_sql() {
		return 'post_type NOT IN (\'' . join( '\', \'', array_map( 'esc_sql', self::$blacklisted_post_types ) ) . '\')';
	}

	static $default_multisite_callable_whitelist = array(
		'network_name'                        => array( 'Jetpack', 'network_name' ),
		'network_allow_new_registrations'     => array( 'Jetpack', 'network_allow_new_registrations' ),
		'network_add_new_users'               => array( 'Jetpack', 'network_add_new_users' ),
		'network_site_upload_space'           => array( 'Jetpack', 'network_site_upload_space' ),
		'network_upload_file_types'           => array( 'Jetpack', 'network_upload_file_types' ),
		'network_enable_administration_menus' => array( 'Jetpack', 'network_enable_administration_menus' ),
	);


	static $default_whitelist_meta_keys = array(
		'_wp_attachment_metadata',
		'_thumbnail_id',
		'_wpas_mess',
		'_wpas_skip_',
		'_g_feedback_shortcode',
		'_feedback_extra_fields',
		'_feedback_akismet_values',
		'_publicize_facebook_user',
		'_wp_attachment_image_alt',
		'_jetpack_post_thumbnail',
		'_thumbnail_id',
		'_wp_attachment_metadata',
		'_wp_page_template',
		'_publicize_twitter_user',
	);

	// TODO: move this to server? - these are theme support values
	// that should be synced as jetpack_current_theme_supports_foo option values
	static $default_theme_support_whitelist = array(
		'post-thumbnails',
		'post-formats',
		'custom-header',
		'custom-background',
		'custom-logo',
		'menus',
		'automatic-feed-links',
		'editor-style',
		'widgets',
		'html5',
		'title-tag',
		'jetpack-social-menu',
		'jetpack-responsive-videos',
		'infinite-scroll',
		'site-logo',
	);

	static function is_whitelisted_option( $option ) {
		foreach ( self::$default_options_whitelist as $whitelisted_option ) {
			if ( $whitelisted_option[0] === '/' && preg_match( $whitelisted_option, $option ) ) {
				return true;
			} elseif ( $whitelisted_option === $option ) {
				return true;
			}
		}

		return false;
	}

	static $default_network_options_whitelist = array(
		'site_name',
		'jetpack_protect_key',
		'jetpack_protect_global_whitelist',
		'active_sitewide_plugins',
	);
	static $default_taxonomy_whitelist = array();
	static $default_dequeue_max_bytes = 500000; // very conservative value, 1/2 MB
	static $default_upload_max_bytes = 600000; // a little bigger than the upload limit to account for serialization
	static $default_upload_max_rows = 500;
	static $default_sync_wait_time = 10; // seconds, between syncs
	static $default_sync_wait_threshold = 5; // only wait before next send if the current send took more than X seconds
	static $default_max_queue_size = 1000;
	static $default_max_queue_lag = 900; // 15 minutes
	static $default_queue_max_writes_sec = 100; // 100 rows a second
class A {
    var $property;
}
	static $default_sync_callables_wait_time = MINUTE_IN_SECONDS; // seconds before sending callables again
	static $default_sync_constants_wait_time = HOUR_IN_SECONDS; // seconds before sending constants again
}


1			<?php
2			require_once( JETPACK__PLUGIN_DIR . 'modules/sso/class.jetpack-sso-helpers.php' );
3
4			/**
5			* Just some defaults that we share with the server
6			*/
7			class Jetpack_Sync_Defaults {
8			static $default_options_whitelist = array(
9			'stylesheet',
10			'blogname',
11			'home',
12			'siteurl',
13			'blogdescription',
14			'blog_charset',
15			'permalink_structure',
16			'category_base',
17			'tag_base',
18			'comment_moderation',
19			'default_comment_status',
20			'jetpack_site_icon_url',
21			'page_on_front',
22			'rss_use_excerpt',
23			'subscription_options',
24			'stb_enabled',
25			'stc_enabled',
26			'comment_registration',
27			'show_avatars',
28			'avatar_default',
29			'avatar_rating',
30			'highlander_comment_form_prompt',
31			'jetpack_comment_form_color_scheme',
32			'stats_options',
33			'gmt_offset',
34			'timezone_string',
35			'jetpack_sync_non_public_post_stati',
36			'jetpack_options',
37			'site_icon', // (int) - ID of core's Site Icon attachment ID
38			'default_post_format',
39			'default_category',
40			'large_size_w',
41			'large_size_h',
42			'thumbnail_size_w',
43			'thumbnail_size_h',
44			'medium_size_w',
45			'medium_size_h',
46			'thumbnail_crop',
47			'image_default_link_type',
48			'site_logo',
49			'sharing-options',
50			'sharing-services',
51			'post_count',
52			'default_ping_status',
53			'sticky_posts',
54			'blog_public',
55			'default_pingback_flag',
56			'require_name_email',
57			'close_comments_for_old_posts',
58			'close_comments_days_old',
59			'thread_comments',
60			'thread_comments_depth',
61			'page_comments',
62			'comments_per_page',
63			'default_comments_page',
64			'comment_order',
65			'comments_notify',
66			'moderation_notify',
67			'social_notifications_like',
68			'social_notifications_reblog',
69			'social_notifications_subscribe',
70			'comment_whitelist',
71			'comment_max_links',
72			'moderation_keys',
73			'blacklist_keys',
74			'lang_id',
75			'wga',
76			'disabled_likes',
77			'disabled_reblogs',
78			'jetpack_comment_likes_enabled',
79			'twitter_via',
80			'jetpack-twitter-cards-site-tag',
81			'wpcom_publish_posts_with_markdown',
82			'wpcom_publish_comments_with_markdown',
83			'jetpack_activated',
84			'jetpack_available_modules',
85			'jetpack_autoupdate_plugins',
86			'jetpack_autoupdate_themes',
87			'jetpack_autoupdate_core',
88			'carousel_background_color',
89			'carousel_display_exif',
90			'jetpack_portfolio',
91			'jetpack_portfolio_posts_per_page',
92			'jetpack_testimonial',
93			'jetpack_testimonial_posts_per_page',
94			'tiled_galleries',
95			'gravatar_disable_hovercards',
96			'infinite_scroll',
97			'infinite_scroll_google_analytics',
98			'wp_mobile_excerpt',
99			'wp_mobile_featured_images',
100			'wp_mobile_app_promos',
101			'monitor_receive_notifications',
102			'post_by_email_address',
103			'jetpack_protect_key',
104			'jetpack_protect_global_whitelist',
105			'sharing_services',
106			'jetpack_sso_require_two_step',
107			'jetpack_relatedposts',
108			'verification_services_codes',
109			'users_can_register',
110			'active_plugins',
111			'uninstall_plugins',
112			);
113
114			static $default_constants_whitelist = array(
115			'EMPTY_TRASH_DAYS',
116			'WP_POST_REVISIONS',
117			'AUTOMATIC_UPDATER_DISABLED',
118			'ABSPATH',
119			'WP_CONTENT_DIR',
120			'FS_METHOD',
121			'DISALLOW_FILE_EDIT',
122			'DISALLOW_FILE_MODS',
123			'WP_AUTO_UPDATE_CORE',
124			'WP_HTTP_BLOCK_EXTERNAL',
125			'WP_ACCESSIBLE_HOSTS',
126			'JETPACK__VERSION',
127			'IS_PRESSABLE',
128			);
129
130			static $default_callable_whitelist = array(
131			'wp_max_upload_size' => 'wp_max_upload_size',
132			'is_main_network' => array( 'Jetpack', 'is_multi_network' ),
133			'is_multi_site' => 'is_multisite',
134			'main_network_site' => array( 'Jetpack_Sync_Functions', 'main_network_site_url' ),
135			'site_url' => array( 'Jetpack_Sync_Functions', 'site_url' ),
136			'home_url' => array( 'Jetpack_Sync_Functions', 'home_url' ),
137			'single_user_site' => array( 'Jetpack', 'is_single_user_site' ),
138			'updates' => array( 'Jetpack', 'get_updates' ),
139			'has_file_system_write_access' => array( 'Jetpack_Sync_Functions', 'file_system_write_access' ),
140			'is_version_controlled' => array( 'Jetpack_Sync_Functions', 'is_version_controlled' ),
141			'taxonomies' => array( 'Jetpack_Sync_Functions', 'get_taxonomies' ),
142			'post_types' => array( 'Jetpack_Sync_Functions', 'get_post_types' ),
143			'post_type_features' => array( 'Jetpack_Sync_Functions', 'get_post_type_features' ),
144			'rest_api_allowed_post_types' => array( 'Jetpack_Sync_Functions', 'rest_api_allowed_post_types' ),
145			'rest_api_allowed_public_metadata' => array( 'Jetpack_Sync_Functions', 'rest_api_allowed_public_metadata' ),
146			'sso_is_two_step_required' => array( 'Jetpack_SSO_Helpers', 'is_two_step_required' ),
147			'sso_should_hide_login_form' => array( 'Jetpack_SSO_Helpers', 'should_hide_login_form' ),
148			'sso_match_by_email' => array( 'Jetpack_SSO_Helpers', 'match_by_email' ),
149			'sso_new_user_override' => array( 'Jetpack_SSO_Helpers', 'new_user_override' ),
150			'sso_bypass_default_login_form' => array( 'Jetpack_SSO_Helpers', 'bypass_login_forward_wpcom' ),
151			'wp_version' => array( 'Jetpack_Sync_Functions', 'wp_version' ),
152			'get_plugins' => array( 'Jetpack_Sync_Functions', 'get_plugins' ),
153			'active_modules' => array( 'Jetpack', 'get_active_modules' ),
154			);
155
156			static $blacklisted_post_types = array(
157			'ai1ec_event',
158			'snitch',
159			);
160
161			static $default_post_checksum_columns = array(
162			'ID',
163			'post_modified',
164			);
165
166			static $default_comment_checksum_columns = array(
167			'comment_ID',
168			'comment_content',
169			);
170
171			static $default_option_checksum_columns = array(
172			'option_name',
173			'option_value',
174			);
175
176			// returns escapted SQL that can be injected into a WHERE clause
177			static function get_blacklisted_post_types_sql() {
178			return 'post_type NOT IN (\'' . join( '\', \'', array_map( 'esc_sql', self::$blacklisted_post_types ) ) . '\')';
179			}
180
181			static $default_multisite_callable_whitelist = array(
182			'network_name' => array( 'Jetpack', 'network_name' ),
183			'network_allow_new_registrations' => array( 'Jetpack', 'network_allow_new_registrations' ),
184			'network_add_new_users' => array( 'Jetpack', 'network_add_new_users' ),
185			'network_site_upload_space' => array( 'Jetpack', 'network_site_upload_space' ),
186			'network_upload_file_types' => array( 'Jetpack', 'network_upload_file_types' ),
187			'network_enable_administration_menus' => array( 'Jetpack', 'network_enable_administration_menus' ),
188			);
189
190
191			static $default_whitelist_meta_keys = array(
192			'_wp_attachment_metadata',
193			'_thumbnail_id',
194			'_wpas_mess',
195			'_wpas_skip_',
196			'_g_feedback_shortcode',
197			'_feedback_extra_fields',
198			'_feedback_akismet_values',
199			'_publicize_facebook_user',
200			'_wp_attachment_image_alt',
201			'_jetpack_post_thumbnail',
202			'_thumbnail_id',
203			'_wp_attachment_metadata',
204			'_wp_page_template',
205			'_publicize_twitter_user',
206			);
207
208			// TODO: move this to server? - these are theme support values
209			// that should be synced as jetpack_current_theme_supports_foo option values
210			static $default_theme_support_whitelist = array(
211			'post-thumbnails',
212			'post-formats',
213			'custom-header',
214			'custom-background',
215			'custom-logo',
216			'menus',
217			'automatic-feed-links',
218			'editor-style',
219			'widgets',
220			'html5',
221			'title-tag',
222			'jetpack-social-menu',
223			'jetpack-responsive-videos',
224			'infinite-scroll',
225			'site-logo',
226			);
227
228			static function is_whitelisted_option( $option ) {
229			foreach ( self::$default_options_whitelist as $whitelisted_option ) {
230			if ( $whitelisted_option[0] === '/' && preg_match( $whitelisted_option, $option ) ) {
231			return true;
232			} elseif ( $whitelisted_option === $option ) {
233			return true;
234			}
235			}
236
237			return false;
238			}
239
240			static $default_network_options_whitelist = array(
241			'site_name',
242			'jetpack_protect_key',
243			'jetpack_protect_global_whitelist',
244			'active_sitewide_plugins',
245			);
246			static $default_taxonomy_whitelist = array();
247			static $default_dequeue_max_bytes = 500000; // very conservative value, 1/2 MB
248			static $default_upload_max_bytes = 600000; // a little bigger than the upload limit to account for serialization
249			static $default_upload_max_rows = 500;
250			static $default_sync_wait_time = 10; // seconds, between syncs
251			static $default_sync_wait_threshold = 5; // only wait before next send if the current send took more than X seconds
252			static $default_max_queue_size = 1000;
253			static $default_max_queue_lag = 900; // 15 minutes
254			static $default_queue_max_writes_sec = 100; // 100 rows a second
			0 ignored issues – show Coding Style introduced 2016-08-10 22:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The visibility should be declared for property `$default_queue_max_writes_sec`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
255			static $default_sync_callables_wait_time = MINUTE_IN_SECONDS; // seconds before sending callables again
256			static $default_sync_constants_wait_time = HOUR_IN_SECONDS; // seconds before sending constants again
257			}
258

Automattic / jetpack

Push — master-stable ( acd8d4...fb4264 )

sync/class.jetpack-sync-defaults.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like