Issues in flickr.php - New Issues - Inspection of "[not verified] rename stats package to mc-stats" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — add/stats-package ( 873a22...c3aabb )

unknown

created 2020-06-24 14:55 UTC

modules/shortcodes/flickr.php (1 issue)

Labels

Unused Code 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Flickr Short Code
 * Author: kellan
 * License: BSD/GPL/public domain (take your pick)
 *
 * [flickr video=www.flickr.com/photos/kalakeli/49931239842]
 * [flickr video=49931239842]
 * [flickr video=49931239842 w=200 h=150]
 * [flickr video=49931239842 autoplay="yes" controls="no"]
 * [flickr video=49931239842 autoplay="no" controls="yes" w=200 h=150]
 *
 * <div class="flick_video" style="max-width: 100%;width: 500px;height: 300px;"><video src="https://www.flickr.com/photos/kalakeli/49931239842/play/360p/183f75d545/" controls autoplay ></video></div>
 *
 * @package Jetpack
 */

/**
 * Transform embed to shortcode on save.
 *
 * @param string $content Post content.
 *
 * @return string Shortcode or the embed content itself.
 */
function flickr_embed_to_shortcode( $content ) {
	if ( ! is_string( $content ) ) {
		return $content;
	}

	if ( false !== strpos( $content, '<div class="flickr_video"' ) && false !== strpos( $content, '<video' ) ) {
		return jetpack_flickr_video_to_shortcode( $content );
	} elseif ( preg_match( '/<iframe src="(https?:)?\/\/([\da-z\-]+\.)*?((static)?flickr\.com|flic\.kr)\/[^\"]+\"/', $content ) ) {
		return jetpack_flickr_photo_to_shortcode( $content );
	}

	return $content;
}

/**
 * Transforms embed to shortcode on save when the photo param is used.
 * If embed content can not be transformed to a valid shortcode,
 * the embed content itself is returned.
 *
 * @param string $content Embed output.
 *
 * @return string Shortcode or the embed content.
 */
function jetpack_flickr_photo_to_shortcode( $content ) {
	preg_match( '/<iframe src=\"([^\"]+)\"(\s+height=\"([^\"]*)\")?(\s+width=\"([^\"]*)\")?/', $content, $matches );

	if ( empty( $matches[1] ) ) {
		return $content;
	}

	$src    = esc_attr( str_replace( 'player/', '', $matches[1] ) );
	$height = empty( $matches[3] ) ? '' : esc_attr( $matches[3] );
	$width  = empty( $matches[5] ) ? '' : esc_attr( $matches[5] );

	/** This action is documented in modules/shortcodes/youtube.php */
	do_action( 'jetpack_embed_to_shortcode', 'flickr_photo', $src );

	return '[flickr photo="' . $src . '" w=' . $width . ' h=' . $height . ']';
}

/**
 * Transforms embed to shortcode on save when the video param is used.
 * If embed content can not be transformed to a valid shortcode,
 * the embed content itself is returned.
 *
 * @param string $content Embed output.
 *
 * @return string Shortcode or the embed content.
 */
function jetpack_flickr_video_to_shortcode( $content ) {
	// Get video src.
	preg_match( '/<video src=\"([^\"]+)\"/', $content, $matches );

	if ( empty( $matches[1] ) ) {
		return $content;
	}

	preg_match( '/(https?:)?\/\/([\da-z\-]+\.)*?((static)?flickr\.com|flic\.kr)\/photos\/([^\/]+)\/\d+\//', $matches[1], $matches );

	$video_src = esc_attr( $matches[0] );

	// Get width and height.

	preg_match( '/style=\"max-width: 100%;(width:\s(\d+)px;)?(height:\s(\d+)px;)?/', $content, $matches );

	$width = empty( $matches[2] ) ? '' : 'w=' . esc_attr( $matches[2] );

	$height = empty( $matches[4] ) ? '' : 'h=' . esc_attr( $matches[4] );

	$controls = false !== strpos( $content, 'controls' ) ? 'yes' : 'no';

	$autoplay = false !== strpos( $content, 'autoplay' ) ? 'yes' : 'no';

	/** This action is documented in modules/shortcodes/youtube.php */
	do_action( 'jetpack_embed_to_shortcode', 'flickr_video', $video_src );

	return '[flickr video="' . $video_src . '" ' . $width . ' ' . $height . ' controls="' . $controls . '" autoplay="' . $autoplay . '"]';
}

add_filter( 'pre_kses', 'flickr_embed_to_shortcode' );

/**
 * Flickr Shortcode handler.
 *
 * @param array $atts Shortcode attributes.
 *
 * @return string Shortcode Output.
 */
function flickr_shortcode_handler( $atts ) {
	$atts = shortcode_atts(
		array(
			'video'    => 0,
			'photo'    => 0,
			'w'        => '',
			'h'        => '',
			'controls' => 'yes',
			'autoplay' => '',
		),
		$atts,
		'flickr'
	);

	if ( ! empty( $atts['video'] ) ) {
		$showing = 'video';
		$src     = $atts['video'];
	} elseif ( ! empty( $atts['photo'] ) ) {
		$showing = 'photo';
		$src     = $atts['photo'];
	} else {
		return '';
	}

	$src = str_replace( 'http://', 'https://', $src );

	if ( 'video' === $showing ) {

		$video_id = flick_shortcode_video_id( $src );

		if ( empty( $video_id ) ) {
			return '';
		}

		$atts = array_map( 'esc_attr', $atts );
		return flickr_shortcode_video_markup( $atts, $video_id, $src );
	} elseif ( 'photo' === $showing ) {

		if ( ! preg_match( '~^(https?:)?//([\da-z\-]+\.)*?((static)?flickr\.com|flic\.kr)/.*~i', $src ) ) {
			return '';
		}

		$height = empty( $atts['h'] ) ? 'auto' : esc_attr( $atts['h'] );

		$src = sprintf( '%s/player/', untrailingslashit( $src ) );

		$allow_full_screen = 'allowfullscreen webkitallowfullscreen mozallowfullscreen oallowfullscreen msallowfullscreen';

		if ( class_exists( 'Jetpack_AMP_Support' ) && Jetpack_AMP_Support::is_amp_request() ) {
			$allow_full_screen = str_replace( ' oallowfullscreen msallowfullscreen', '', $allow_full_screen );
		}

		return sprintf( '<iframe src="%s" height="%s" width="%s"  frameborder="0" %s></iframe>', esc_url( $src ), $height, esc_attr( $atts['w'] ), $allow_full_screen );
	}

	return false;
}

/**
 * Return HTML markup for a Flickr embed.
 *
 * @param array  $atts Shortcode attributes.
 * @param string $id Video ID.
 * @param string $video_param video param of the shortcode.
 *
 * @return string Shortcode ouput for video.
 */
function flickr_shortcode_video_markup( $atts, $id, $video_param ) {

	$transient_name = "flickr_video_$id";
	$video_src      = get_transient( $transient_name );

	if ( empty( $video_src ) ) {
		$video_url = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		if ( ! is_numeric( $video_param ) ) {
			$video_url = $video_param;
		} else {
			// Get the URL of the video from the page of the video.
			$video_page_content = wp_remote_get( "http://flickr.com/photo.gne?id=$video_param" );

			// Extract the URL from the og:url meta tag.
			preg_match( '/property=\"og:url\"\scontent=\"([^\"]+)\"/', $video_page_content['body'], $matches );
			if ( empty( $matches[1] ) ) {
				return '';
			}
			$video_url = $matches[1];
		}

		$provider = 'https://www.flickr.com/services/oembed/';
		$oembed   = _wp_oembed_get_object();
		$data     = (array) $oembed->fetch( $provider, $video_url );
		if ( empty( $data['html'] ) ) {
			return '';
		}

		// Get the embed url.
		preg_match( '/src=\"([^\"]+)\"/', $data['html'], $matches );

		$embed_url = $matches[1];

		$embed_page = wp_remote_get( $embed_url );

		// Get the video url from embed html markup.

		preg_match( '/video.+src=\"([^\"]+)\"/', $embed_page['body'], $matches );

		$video_src = $matches[1];

		set_transient( $transient_name, $video_src, 2592000 ); // 30 days transient.
	}

	$style = 'max-width: 100%;';

	if ( ! empty( $atts['w'] ) && is_numeric( $atts['w'] ) ) {
		$style .= sprintf( 'width: %dpx;', $atts['w'] );
	}

	if ( ! empty( $atts['h'] ) && is_numeric( $atts['h'] ) ) {
		$style .= sprintf( 'height: %dpx;', $atts['h'] );
	}

	$controls = 'yes' === $atts['controls'] ? 'controls' : '';
	$autoplay = 'yes' === $atts['autoplay'] ? 'autoplay' : '';

	return sprintf(
		'<div class="flick_video" style="%s"><video src="%s" %s %s /></div>',
		esc_attr( $style ),
		esc_attr( $video_src ),
		$controls,
		$autoplay
	);
}

/**
 * Extract the id of the flickr video from the video param.
 *
 * @param string $video_param Video parameter of the shortcode.
 *
 * @return string|boolean ID of the video or false in case the ID can not be extracted.
 */
function flick_shortcode_video_id( $video_param ) {
	if ( preg_match( '/^https?:\/\/(www\.)?flickr\.com\/.+/', $video_param ) || preg_match( '/^https?:\/\/flic\.kr\/.+/', $video_param ) ) {

		// Extract the video id from the url.
		preg_match( '/\d+/', $video_param, $matches );

		if ( empty( $matches ) ) {
			return false;
		}

		return $matches[0];

	} elseif ( is_numeric( $video_param ) ) {
		return $video_param;
	}

	return false;
}

add_shortcode( 'flickr', 'flickr_shortcode_handler' );

// Override core's Flickr support because Flickr oEmbed doesn't support web embeds.
wp_embed_register_handler( 'flickr', '#https?://(www\.)?flickr\.com/.*#i', 'jetpack_flickr_oembed_handler' );

/**
 * Callback to modify output of embedded Vimeo video using Jetpack's shortcode.
 *
 * @since 3.9
 *
 * @param array $matches Regex partial matches against the URL passed.
 * @param array $attr    Attributes received in embed response.
 * @param array $url     Requested URL to be embedded.
 *
 * @return string Return output of Vimeo shortcode with the proper markup.
 */
function jetpack_flickr_oembed_handler( $matches, $attr, $url ) {
	/*
	 * Legacy slideshow embeds end with /show/
	 * e.g. http://www.flickr.com/photos/yarnaholic/sets/72157615194738969/show/
	 */
	if ( '/show/' !== substr( $url, -strlen( '/show/' ) ) ) {
		// These lookups need cached, as they don't use WP_Embed (which caches).
		$cache_key   = md5( $url . wp_json_encode( $attr ) );
		$cache_group = 'oembed_flickr';

		$html = wp_cache_get( $cache_key, $cache_group );

		if ( false === $html ) {
			$html = _wp_oembed_get_object()->get_html( $url, $attr );

			wp_cache_set( $cache_key, $html, $cache_group, 60 * MINUTE_IN_SECONDS );
		}

		return $html;
	}

	return flickr_shortcode_handler( array( 'photo' => $url ) );
}


1			<?php
2			/**
3			* Flickr Short Code
4			* Author: kellan
5			* License: BSD/GPL/public domain (take your pick)
6			*
7			* [flickr video=www.flickr.com/photos/kalakeli/49931239842]
8			* [flickr video=49931239842]
9			* [flickr video=49931239842 w=200 h=150]
10			* [flickr video=49931239842 autoplay="yes" controls="no"]
11			* [flickr video=49931239842 autoplay="no" controls="yes" w=200 h=150]
12			*
13			* <div class="flick_video" style="max-width: 100%;width: 500px;height: 300px;"><video src="https://www.flickr.com/photos/kalakeli/49931239842/play/360p/183f75d545/" controls autoplay ></video></div>
14			*
15			* @package Jetpack
16			*/
17
18			/**
19			* Transform embed to shortcode on save.
20			*
21			* @param string $content Post content.
22			*
23			* @return string Shortcode or the embed content itself.
24			*/
25			function flickr_embed_to_shortcode( $content ) {
26			if ( ! is_string( $content ) ) {
27			return $content;
28			}
29
30			if ( false !== strpos( $content, '<div class="flickr_video"' ) && false !== strpos( $content, '<video' ) ) {
31			return jetpack_flickr_video_to_shortcode( $content );
32			} elseif ( preg_match( '/<iframe src="(https?:)?\/\/([\da-z\-]+\.)*?((static)?flickr\.com\|flic\.kr)\/[^\"]+\"/', $content ) ) {
33			return jetpack_flickr_photo_to_shortcode( $content );
34			}
35
36			return $content;
37			}
38
39			/**
40			* Transforms embed to shortcode on save when the photo param is used.
41			* If embed content can not be transformed to a valid shortcode,
42			* the embed content itself is returned.
43			*
44			* @param string $content Embed output.
45			*
46			* @return string Shortcode or the embed content.
47			*/
48			function jetpack_flickr_photo_to_shortcode( $content ) {
49			preg_match( '/<iframe src=\"([^\"]+)\"(\s+height=\"([^\"])\")?(\s+width=\"([^\"])\")?/', $content, $matches );
50
51			if ( empty( $matches[1] ) ) {
52			return $content;
53			}
54
55			$src = esc_attr( str_replace( 'player/', '', $matches[1] ) );
56			$height = empty( $matches[3] ) ? '' : esc_attr( $matches[3] );
57			$width = empty( $matches[5] ) ? '' : esc_attr( $matches[5] );
58
59			/** This action is documented in modules/shortcodes/youtube.php */
60			do_action( 'jetpack_embed_to_shortcode', 'flickr_photo', $src );
61
62			return '[flickr photo="' . $src . '" w=' . $width . ' h=' . $height . ']';
63			}
64
65			/**
66			* Transforms embed to shortcode on save when the video param is used.
67			* If embed content can not be transformed to a valid shortcode,
68			* the embed content itself is returned.
69			*
70			* @param string $content Embed output.
71			*
72			* @return string Shortcode or the embed content.
73			*/
74			function jetpack_flickr_video_to_shortcode( $content ) {
75			// Get video src.
76			preg_match( '/<video src=\"([^\"]+)\"/', $content, $matches );
77
78			if ( empty( $matches[1] ) ) {
79			return $content;
80			}
81
82			preg_match( '/(https?:)?\/\/([\da-z\-]+\.)*?((static)?flickr\.com\|flic\.kr)\/photos\/([^\/]+)\/\d+\//', $matches[1], $matches );
83
84			$video_src = esc_attr( $matches[0] );
85
86			// Get width and height.
87
88			preg_match( '/style=\"max-width: 100%;(width:\s(\d+)px;)?(height:\s(\d+)px;)?/', $content, $matches );
89
90			$width = empty( $matches[2] ) ? '' : 'w=' . esc_attr( $matches[2] );
91
92			$height = empty( $matches[4] ) ? '' : 'h=' . esc_attr( $matches[4] );
93
94			$controls = false !== strpos( $content, 'controls' ) ? 'yes' : 'no';
95
96			$autoplay = false !== strpos( $content, 'autoplay' ) ? 'yes' : 'no';
97
98			/** This action is documented in modules/shortcodes/youtube.php */
99			do_action( 'jetpack_embed_to_shortcode', 'flickr_video', $video_src );
100
101			return '[flickr video="' . $video_src . '" ' . $width . ' ' . $height . ' controls="' . $controls . '" autoplay="' . $autoplay . '"]';
102			}
103
104			add_filter( 'pre_kses', 'flickr_embed_to_shortcode' );
105
106			/**
107			* Flickr Shortcode handler.
108			*
109			* @param array $atts Shortcode attributes.
110			*
111			* @return string Shortcode Output.
112			*/
113			function flickr_shortcode_handler( $atts ) {
114			$atts = shortcode_atts(
115			array(
116			'video' => 0,
117			'photo' => 0,
118			'w' => '',
119			'h' => '',
120			'controls' => 'yes',
121			'autoplay' => '',
122			),
123			$atts,
124			'flickr'
125			);
126
127			if ( ! empty( $atts['video'] ) ) {
128			$showing = 'video';
129			$src = $atts['video'];
130			} elseif ( ! empty( $atts['photo'] ) ) {
131			$showing = 'photo';
132			$src = $atts['photo'];
133			} else {
134			return '';
135			}
136
137			$src = str_replace( 'http://', 'https://', $src );
138
139			if ( 'video' === $showing ) {
140
141			$video_id = flick_shortcode_video_id( $src );
142
143			if ( empty( $video_id ) ) {
144			return '';
145			}
146
147			$atts = array_map( 'esc_attr', $atts );
148			return flickr_shortcode_video_markup( $atts, $video_id, $src );
149			} elseif ( 'photo' === $showing ) {
150
151			if ( ! preg_match( '~^(https?:)?//([\da-z\-]+\.)?((static)?flickr\.com\|flic\.kr)/.~i', $src ) ) {
152			return '';
153			}
154
155			$height = empty( $atts['h'] ) ? 'auto' : esc_attr( $atts['h'] );
156
157			$src = sprintf( '%s/player/', untrailingslashit( $src ) );
158
159			$allow_full_screen = 'allowfullscreen webkitallowfullscreen mozallowfullscreen oallowfullscreen msallowfullscreen';
160
161			if ( class_exists( 'Jetpack_AMP_Support' ) && Jetpack_AMP_Support::is_amp_request() ) {
162			$allow_full_screen = str_replace( ' oallowfullscreen msallowfullscreen', '', $allow_full_screen );
163			}
164
165			return sprintf( '<iframe src="%s" height="%s" width="%s" frameborder="0" %s></iframe>', esc_url( $src ), $height, esc_attr( $atts['w'] ), $allow_full_screen );
166			}
167
168			return false;
169			}
170
171			/**
172			* Return HTML markup for a Flickr embed.
173			*
174			* @param array $atts Shortcode attributes.
175			* @param string $id Video ID.
176			* @param string $video_param video param of the shortcode.
177			*
178			* @return string Shortcode ouput for video.
179			*/
180			function flickr_shortcode_video_markup( $atts, $id, $video_param ) {
181
182			$transient_name = "flickr_video_$id";
183			$video_src = get_transient( $transient_name );
184
185			if ( empty( $video_src ) ) {
186			$video_url = '';
			0 ignored issues – show Unused Code introduced 2020-05-24 05:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$video_url` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
187			if ( ! is_numeric( $video_param ) ) {
188			$video_url = $video_param;
189			} else {
190			// Get the URL of the video from the page of the video.
191			$video_page_content = wp_remote_get( "http://flickr.com/photo.gne?id=$video_param" );
192
193			// Extract the URL from the og:url meta tag.
194			preg_match( '/property=\"og:url\"\scontent=\"([^\"]+)\"/', $video_page_content['body'], $matches );
195			if ( empty( $matches[1] ) ) {
196			return '';
197			}
198			$video_url = $matches[1];
199			}
200
201			$provider = 'https://www.flickr.com/services/oembed/';
202			$oembed = _wp_oembed_get_object();
203			$data = (array) $oembed->fetch( $provider, $video_url );
204			if ( empty( $data['html'] ) ) {
205			return '';
206			}
207
208			// Get the embed url.
209			preg_match( '/src=\"([^\"]+)\"/', $data['html'], $matches );
210
211			$embed_url = $matches[1];
212
213			$embed_page = wp_remote_get( $embed_url );
214
215			// Get the video url from embed html markup.
216
217			preg_match( '/video.+src=\"([^\"]+)\"/', $embed_page['body'], $matches );
218
219			$video_src = $matches[1];
220
221			set_transient( $transient_name, $video_src, 2592000 ); // 30 days transient.
222			}
223
224			$style = 'max-width: 100%;';
225
226			if ( ! empty( $atts['w'] ) && is_numeric( $atts['w'] ) ) {
227			$style .= sprintf( 'width: %dpx;', $atts['w'] );
228			}
229
230			if ( ! empty( $atts['h'] ) && is_numeric( $atts['h'] ) ) {
231			$style .= sprintf( 'height: %dpx;', $atts['h'] );
232			}
233
234			$controls = 'yes' === $atts['controls'] ? 'controls' : '';
235			$autoplay = 'yes' === $atts['autoplay'] ? 'autoplay' : '';
236
237			return sprintf(
238			'<div class="flick_video" style="%s"><video src="%s" %s %s /></div>',
239			esc_attr( $style ),
240			esc_attr( $video_src ),
241			$controls,
242			$autoplay
243			);
244			}
245
246			/**
247			* Extract the id of the flickr video from the video param.
248			*
249			* @param string $video_param Video parameter of the shortcode.
250			*
251			* @return string\|boolean ID of the video or false in case the ID can not be extracted.
252			*/
253			function flick_shortcode_video_id( $video_param ) {
254			if ( preg_match( '/^https?:\/\/(www\.)?flickr\.com\/.+/', $video_param ) \|\| preg_match( '/^https?:\/\/flic\.kr\/.+/', $video_param ) ) {
255
256			// Extract the video id from the url.
257			preg_match( '/\d+/', $video_param, $matches );
258
259			if ( empty( $matches ) ) {
260			return false;
261			}
262
263			return $matches[0];
264
265			} elseif ( is_numeric( $video_param ) ) {
266			return $video_param;
267			}
268
269			return false;
270			}
271
272			add_shortcode( 'flickr', 'flickr_shortcode_handler' );
273
274			// Override core's Flickr support because Flickr oEmbed doesn't support web embeds.
275			wp_embed_register_handler( 'flickr', '#https?://(www\.)?flickr\.com/.*#i', 'jetpack_flickr_oembed_handler' );
276
277			/**
278			* Callback to modify output of embedded Vimeo video using Jetpack's shortcode.
279			*
280			* @since 3.9
281			*
282			* @param array $matches Regex partial matches against the URL passed.
283			* @param array $attr Attributes received in embed response.
284			* @param array $url Requested URL to be embedded.
285			*
286			* @return string Return output of Vimeo shortcode with the proper markup.
287			*/
288			function jetpack_flickr_oembed_handler( $matches, $attr, $url ) {
289			/*
290			* Legacy slideshow embeds end with /show/
291			* e.g. http://www.flickr.com/photos/yarnaholic/sets/72157615194738969/show/
292			*/
293			if ( '/show/' !== substr( $url, -strlen( '/show/' ) ) ) {
294			// These lookups need cached, as they don't use WP_Embed (which caches).
295			$cache_key = md5( $url . wp_json_encode( $attr ) );
296			$cache_group = 'oembed_flickr';
297
298			$html = wp_cache_get( $cache_key, $cache_group );
299
300			if ( false === $html ) {
301			$html = _wp_oembed_get_object()->get_html( $url, $attr );
302
303			wp_cache_set( $cache_key, $html, $cache_group, 60 * MINUTE_IN_SECONDS );
304			}
305
306			return $html;
307			}
308
309			return flickr_shortcode_handler( array( 'photo' => $url ) );
310			}
311

Automattic / jetpack

Push — add/stats-package ( 873a22...c3aabb )

modules/shortcodes/flickr.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like