| Conditions | 1 |
| Paths | 1 |
| Total Lines | 262 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php // phpcs:ignore WordPress.Files.FileName.InvalidClassFileName |
||
| 120 | public function provideCompare() { |
||
| 121 | return array( |
||
| 122 | 'Default config, equal' => array( |
||
| 123 | new ChangeEntry( |
||
| 124 | array( |
||
| 125 | 'significance' => 'major', |
||
| 126 | 'subheading' => 'Head', |
||
| 127 | 'author' => 'XXX', |
||
| 128 | 'timestamp' => '2020-01-01', |
||
| 129 | 'content' => 'A change.', |
||
| 130 | ) |
||
| 131 | ), |
||
| 132 | new ChangeEntry( |
||
| 133 | array( |
||
| 134 | 'significance' => 'patch', |
||
| 135 | 'subheading' => 'Head', |
||
| 136 | 'author' => 'YYY', |
||
| 137 | 'timestamp' => '2020-02-02', |
||
| 138 | 'content' => 'A change.', |
||
| 139 | ) |
||
| 140 | ), |
||
| 141 | array(), |
||
| 142 | 0, |
||
| 143 | ), |
||
| 144 | 'Default config, equal but for case' => array( |
||
| 145 | new ChangeEntry( |
||
| 146 | array( |
||
| 147 | 'significance' => 'major', |
||
| 148 | 'subheading' => 'Head', |
||
| 149 | 'author' => 'Xxx', |
||
| 150 | 'timestamp' => '2020-01-01', |
||
| 151 | 'content' => 'A change.', |
||
| 152 | ) |
||
| 153 | ), |
||
| 154 | new ChangeEntry( |
||
| 155 | array( |
||
| 156 | 'significance' => 'patch', |
||
| 157 | 'subheading' => 'hEAD', |
||
| 158 | 'author' => 'xXX', |
||
| 159 | 'timestamp' => '2020-02-02', |
||
| 160 | 'content' => 'a CHANGE.', |
||
| 161 | ) |
||
| 162 | ), |
||
| 163 | array( |
||
| 164 | 'ordering' => array( 'subheading', 'author', 'content' ), |
||
| 165 | ), |
||
| 166 | 0, |
||
| 167 | ), |
||
| 168 | 'Default config, subheading before content' => array( |
||
| 169 | new ChangeEntry( |
||
| 170 | array( |
||
| 171 | 'significance' => 'major', |
||
| 172 | 'subheading' => 'A', |
||
| 173 | 'author' => 'XXX', |
||
| 174 | 'timestamp' => '2020-01-01', |
||
| 175 | 'content' => 'B', |
||
| 176 | ) |
||
| 177 | ), |
||
| 178 | new ChangeEntry( |
||
| 179 | array( |
||
| 180 | 'significance' => 'patch', |
||
| 181 | 'subheading' => 'B', |
||
| 182 | 'author' => 'YYY', |
||
| 183 | 'timestamp' => '2020-01-01', |
||
| 184 | 'content' => 'A', |
||
| 185 | ) |
||
| 186 | ), |
||
| 187 | array(), |
||
| 188 | -1, |
||
| 189 | ), |
||
| 190 | 'Default config, content differs' => array( |
||
| 191 | new ChangeEntry( |
||
| 192 | array( |
||
| 193 | 'significance' => 'major', |
||
| 194 | 'subheading' => 'Head', |
||
| 195 | 'author' => 'XXX', |
||
| 196 | 'timestamp' => '2020-01-01', |
||
| 197 | 'content' => 'B', |
||
| 198 | ) |
||
| 199 | ), |
||
| 200 | new ChangeEntry( |
||
| 201 | array( |
||
| 202 | 'significance' => 'patch', |
||
| 203 | 'subheading' => 'Head', |
||
| 204 | 'author' => 'YYY', |
||
| 205 | 'timestamp' => '2020-02-02', |
||
| 206 | 'content' => 'A', |
||
| 207 | ) |
||
| 208 | ), |
||
| 209 | array(), |
||
| 210 | 1, |
||
| 211 | ), |
||
| 212 | 'Add timestamp to config' => array( |
||
| 213 | new ChangeEntry( |
||
| 214 | array( |
||
| 215 | 'significance' => 'major', |
||
| 216 | 'subheading' => 'Head', |
||
| 217 | 'author' => 'XXX', |
||
| 218 | 'timestamp' => '2020-01-01', |
||
| 219 | 'content' => 'B', |
||
| 220 | ) |
||
| 221 | ), |
||
| 222 | new ChangeEntry( |
||
| 223 | array( |
||
| 224 | 'significance' => 'patch', |
||
| 225 | 'subheading' => 'Head', |
||
| 226 | 'author' => 'YYY', |
||
| 227 | 'timestamp' => '2020-02-02', |
||
| 228 | 'content' => 'A', |
||
| 229 | ) |
||
| 230 | ), |
||
| 231 | array( |
||
| 232 | 'ordering' => array( 'subheading', 'timestamp', 'content' ), |
||
| 233 | ), |
||
| 234 | -1, |
||
| 235 | ), |
||
| 236 | 'Add significance to config' => array( |
||
| 237 | new ChangeEntry( |
||
| 238 | array( |
||
| 239 | 'significance' => 'major', |
||
| 240 | 'subheading' => 'Head', |
||
| 241 | 'author' => 'XXX', |
||
| 242 | 'timestamp' => '2020-01-01', |
||
| 243 | 'content' => 'B', |
||
| 244 | ) |
||
| 245 | ), |
||
| 246 | new ChangeEntry( |
||
| 247 | array( |
||
| 248 | 'significance' => 'patch', |
||
| 249 | 'subheading' => 'Head', |
||
| 250 | 'author' => 'YYY', |
||
| 251 | 'timestamp' => '2020-02-02', |
||
| 252 | 'content' => 'A', |
||
| 253 | ) |
||
| 254 | ), |
||
| 255 | array( |
||
| 256 | 'ordering' => array( 'subheading', 'significance', 'content' ), |
||
| 257 | ), |
||
| 258 | -1, |
||
| 259 | ), |
||
| 260 | 'Use knownSubheadings' => array( |
||
| 261 | new ChangeEntry( |
||
| 262 | array( |
||
| 263 | 'significance' => 'major', |
||
| 264 | 'subheading' => 'AAA', |
||
| 265 | 'author' => 'XXX', |
||
| 266 | 'timestamp' => '2020-01-01', |
||
| 267 | 'content' => 'Content', |
||
| 268 | ) |
||
| 269 | ), |
||
| 270 | new ChangeEntry( |
||
| 271 | array( |
||
| 272 | 'significance' => 'major', |
||
| 273 | 'subheading' => 'BBB', |
||
| 274 | 'author' => 'XXX', |
||
| 275 | 'timestamp' => '2020-01-01', |
||
| 276 | 'content' => 'Content', |
||
| 277 | ) |
||
| 278 | ), |
||
| 279 | array( |
||
| 280 | 'knownSubheadings' => array( 'BBB', 'AAA' ), |
||
| 281 | ), |
||
| 282 | 1, |
||
| 283 | ), |
||
| 284 | 'Use knownSubheadings, case mismatch' => array( |
||
| 285 | new ChangeEntry( |
||
| 286 | array( |
||
| 287 | 'significance' => 'major', |
||
| 288 | 'subheading' => 'aAa', |
||
| 289 | 'author' => 'XXX', |
||
| 290 | 'timestamp' => '2020-01-01', |
||
| 291 | 'content' => 'Content', |
||
| 292 | ) |
||
| 293 | ), |
||
| 294 | new ChangeEntry( |
||
| 295 | array( |
||
| 296 | 'significance' => 'major', |
||
| 297 | 'subheading' => 'AaA', |
||
| 298 | 'author' => 'XXX', |
||
| 299 | 'timestamp' => '2020-01-01', |
||
| 300 | 'content' => 'Content', |
||
| 301 | ) |
||
| 302 | ), |
||
| 303 | array( |
||
| 304 | 'knownSubheadings' => array( 'BBB', 'AAA' ), |
||
| 305 | ), |
||
| 306 | 0, |
||
| 307 | ), |
||
| 308 | 'Use knownSubheadings, one subheading unknown' => array( |
||
| 309 | new ChangeEntry( |
||
| 310 | array( |
||
| 311 | 'significance' => 'major', |
||
| 312 | 'subheading' => 'AAA?', |
||
| 313 | 'author' => 'XXX', |
||
| 314 | 'timestamp' => '2020-01-01', |
||
| 315 | 'content' => 'Content', |
||
| 316 | ) |
||
| 317 | ), |
||
| 318 | new ChangeEntry( |
||
| 319 | array( |
||
| 320 | 'significance' => 'major', |
||
| 321 | 'subheading' => 'BBB', |
||
| 322 | 'author' => 'XXX', |
||
| 323 | 'timestamp' => '2020-01-01', |
||
| 324 | 'content' => 'Content', |
||
| 325 | ) |
||
| 326 | ), |
||
| 327 | array( |
||
| 328 | 'knownSubheadings' => array( 'AAA', 'BBB' ), |
||
| 329 | ), |
||
| 330 | 1, |
||
| 331 | ), |
||
| 332 | 'Use knownSubheadings, both subheadings unknown' => array( |
||
| 333 | new ChangeEntry( |
||
| 334 | array( |
||
| 335 | 'significance' => 'major', |
||
| 336 | 'subheading' => 'AAA?', |
||
| 337 | 'author' => 'XXX', |
||
| 338 | 'timestamp' => '2020-01-01', |
||
| 339 | 'content' => 'Content', |
||
| 340 | ) |
||
| 341 | ), |
||
| 342 | new ChangeEntry( |
||
| 343 | array( |
||
| 344 | 'significance' => 'major', |
||
| 345 | 'subheading' => 'BBB?', |
||
| 346 | 'author' => 'XXX', |
||
| 347 | 'timestamp' => '2020-01-01', |
||
| 348 | 'content' => 'Content', |
||
| 349 | ) |
||
| 350 | ), |
||
| 351 | array( |
||
| 352 | 'knownSubheadings' => array( 'BBB', 'AAA' ), |
||
| 353 | ), |
||
| 354 | -1, |
||
| 355 | ), |
||
| 356 | 'Use knownSubheadings, empty subheading cannot be known' => array( |
||
| 357 | new ChangeEntry( |
||
| 358 | array( |
||
| 359 | 'significance' => 'major', |
||
| 360 | 'subheading' => '', |
||
| 361 | 'author' => 'XXX', |
||
| 362 | 'timestamp' => '2020-01-01', |
||
| 363 | 'content' => 'Content', |
||
| 364 | ) |
||
| 365 | ), |
||
| 366 | new ChangeEntry( |
||
| 367 | array( |
||
| 368 | 'significance' => 'major', |
||
| 369 | 'subheading' => 'BBB', |
||
| 370 | 'author' => 'XXX', |
||
| 371 | 'timestamp' => '2020-01-01', |
||
| 372 | 'content' => 'Content', |
||
| 373 | ) |
||
| 374 | ), |
||
| 375 | array( |
||
| 376 | 'knownSubheadings' => array( 'BBB', 'AAA', '' ), |
||
| 377 | ), |
||
| 378 | -1, |
||
| 379 | ), |
||
| 380 | ); |
||
| 381 | } |
||
| 382 | |||
| 441 |