Jetpack_JSON_API_Themes_Modify_Endpoint - Code Metrics - Inspection of "Subscriptions: Send subscriptions for posts that a..." - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — update/sync-subscriptions-edit... ( 3e7813...304e22 )

unknown

created 2016-11-11 21:09 UTC

Jetpack_JSON_API_Themes_Modify_Endpoint A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	130
Duplicated Lines	16.92 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	22
lcom	1
cbo	2
dl	22
loc	130
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Duplication	Size	Complexity
B	default_action()	19	19	7
A	autoupdate_on()	0	5	1
A	autoupdate_off()	0	5	1
A	autoupdate_translations_on()	0	5	1
A	autoupdate_translations_off()	0	5	1
C	update_translations()	0	45	7
B	update()	3	30	4

How to fix Duplicated Code

<?php

class Jetpack_JSON_API_Themes_Modify_Endpoint extends Jetpack_JSON_API_Themes_Endpoint {
	// POST  /sites/%s/themes/%s
	// POST  /sites/%s/themes

	protected $needed_capabilities = 'update_themes';
	protected $action              = 'default_action';
	protected $expected_actions    = array( 'update', 'update_translations' );

	public function default_action() {
		$args = $this->input();
		if ( isset( $args['autoupdate'] ) && is_bool( $args['autoupdate'] ) ) {
			if ( $args['autoupdate'] ) {
				$this->autoupdate_on();
			} else {
				$this->autoupdate_off();
			}
		}
		if ( isset( $args['autoupdate_translations'] ) && is_bool( $args['autoupdate_translations'] ) ) {
			if ( $args['autoupdate_translations'] ) {
				$this->autoupdate_translations_on();
			} else {
				$this->autoupdate_translations_off();
			}
		}

		return true;
	}

	function autoupdate_on() {
		$autoupdate_themes = Jetpack_Options::get_option( 'autoupdate_themes', array() );
		$autoupdate_themes = array_unique( array_merge( $autoupdate_themes, $this->themes ) );
		Jetpack_Options::update_option( 'autoupdate_themes', $autoupdate_themes );
	}

	function autoupdate_off() {
		$autoupdate_themes = Jetpack_Options::get_option( 'autoupdate_themes', array() );
		$autoupdate_themes = array_diff( $autoupdate_themes, $this->themes );
		Jetpack_Options::update_option( 'autoupdate_themes', $autoupdate_themes );
	}

	function autoupdate_translations_on() {
		$autoupdate_themes_translations = Jetpack_Options::get_option( 'autoupdate_themes_translations', array() );
		$autoupdate_themes_translations = array_unique( array_merge( $autoupdate_themes_translations, $this->themes ) );
		Jetpack_Options::update_option( 'autoupdate_themes_translations', $autoupdate_themes_translations );
	}

	function autoupdate_translations_off() {
		$autoupdate_themes_translations = Jetpack_Options::get_option( 'autoupdate_themes_translations', array() );
		$autoupdate_themes_translations = array_diff( $autoupdate_themes_translations, $this->themes );
		Jetpack_Options::update_option( 'autoupdate_themes_translations', $autoupdate_themes_translations );
	}

	function update() {
		include_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';

		// Clear the cache.
		wp_update_themes();

		foreach ( $this->themes as $theme ) {
			/**
			 * Pre-upgrade action
			 * 
			 * @since 3.9.3
			 * 
			 * @param object $theme WP_Theme object
			 * @param array $themes Array of theme objects
			 */
			do_action('jetpack_pre_theme_upgrade', $theme, $this->themes);
			// Objects created inside the for loop to clean the messages for each theme
			$skin = new Automatic_Upgrader_Skin();
			$upgrader = new Theme_Upgrader( $skin );
			$upgrader->init();
			$result   = $upgrader->upgrade( $theme );
			$this->log[ $theme ][] = $upgrader->skin->get_upgrade_messages();
		}

		if ( ! $this->bulk && ! $result ) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			return new WP_Error( 'update_fail', __( 'There was an error updating your theme', 'jetpack' ), 400 );
		}

		return true;
	}

	function update_translations() {
		include_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';

		// Clear the cache.
		wp_update_themes();
	
		$available_themes_updates = get_site_transient( 'update_themes' );
		
		if ( ! isset( $available_themes_updates->translations ) || empty( $available_themes_updates->translations ) ) {
			
			return new WP_Error( 'nothing_to_translate' );
		}

		foreach( $available_themes_updates->translations as $translation ) {
			if ( ! in_array( $translation['slug'], $this->themes )  ) {
				continue;
			}

			$theme = $translation['slug'] ;


			/**
			 * Pre-upgrade action
			 *
			 * @since 3.9.3
			 *
			 * @param object $theme WP_Theme object
			 * @param array $themes Array of theme objects
			 */
			do_action('jetpack_pre_theme_upgrade', $theme, $this->themes);
			// Objects created inside the for loop to clean the messages for each theme
			$skin = new Automatic_Upgrader_Skin();
			$upgrader = new Language_Pack_Upgrader( $skin );
			$upgrader->init();

			$result   = $upgrader->upgrade( (object) $translation );
			$this->log[ $theme ][] = $upgrader->skin->get_upgrade_messages();
		}

		if ( ! $this->bulk && ! $result ) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			return new WP_Error( 'update_fail', __( 'There was an error updating your theme', 'jetpack' ), 400 );
		}

		return true;
	}

}


1		<?php
2
3		class Jetpack_JSON_API_Themes_Modify_Endpoint extends Jetpack_JSON_API_Themes_Endpoint {
4		// POST /sites/%s/themes/%s
5		// POST /sites/%s/themes
6
7		protected $needed_capabilities = 'update_themes';
8		protected $action = 'default_action';
9		protected $expected_actions = array( 'update', 'update_translations' );
10
11	View Code Duplication	public function default_action() {
12		$args = $this->input();
13		if ( isset( $args['autoupdate'] ) && is_bool( $args['autoupdate'] ) ) {
14		if ( $args['autoupdate'] ) {
15		$this->autoupdate_on();
16		} else {
17		$this->autoupdate_off();
18		}
19		}
20		if ( isset( $args['autoupdate_translations'] ) && is_bool( $args['autoupdate_translations'] ) ) {
21		if ( $args['autoupdate_translations'] ) {
22		$this->autoupdate_translations_on();
23		} else {
24		$this->autoupdate_translations_off();
25		}
26		}
27
28		return true;
29		}
30
31		function autoupdate_on() {
32		$autoupdate_themes = Jetpack_Options::get_option( 'autoupdate_themes', array() );
33		$autoupdate_themes = array_unique( array_merge( $autoupdate_themes, $this->themes ) );
34		Jetpack_Options::update_option( 'autoupdate_themes', $autoupdate_themes );
35		}
36
37		function autoupdate_off() {
38		$autoupdate_themes = Jetpack_Options::get_option( 'autoupdate_themes', array() );
39		$autoupdate_themes = array_diff( $autoupdate_themes, $this->themes );
40		Jetpack_Options::update_option( 'autoupdate_themes', $autoupdate_themes );
41		}
42
43		function autoupdate_translations_on() {
44		$autoupdate_themes_translations = Jetpack_Options::get_option( 'autoupdate_themes_translations', array() );
45		$autoupdate_themes_translations = array_unique( array_merge( $autoupdate_themes_translations, $this->themes ) );
46		Jetpack_Options::update_option( 'autoupdate_themes_translations', $autoupdate_themes_translations );
47		}
48
49		function autoupdate_translations_off() {
50		$autoupdate_themes_translations = Jetpack_Options::get_option( 'autoupdate_themes_translations', array() );
51		$autoupdate_themes_translations = array_diff( $autoupdate_themes_translations, $this->themes );
52		Jetpack_Options::update_option( 'autoupdate_themes_translations', $autoupdate_themes_translations );
53		}
54
55		function update() {
56		include_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
57
58		// Clear the cache.
59		wp_update_themes();
60
61		foreach ( $this->themes as $theme ) {
62		/**
63		* Pre-upgrade action
64		*
65		* @since 3.9.3
66		*
67		* @param object $theme WP_Theme object
68		* @param array $themes Array of theme objects
69		*/
70		do_action('jetpack_pre_theme_upgrade', $theme, $this->themes);
71		// Objects created inside the for loop to clean the messages for each theme
72		$skin = new Automatic_Upgrader_Skin();
73		$upgrader = new Theme_Upgrader( $skin );
74		$upgrader->init();
75		$result = $upgrader->upgrade( $theme );
76		$this->log[ $theme ][] = $upgrader->skin->get_upgrade_messages();
77		}
78
79	View Code Duplication	if ( ! $this->bulk && ! $result ) {
		0 ignored issues – show Bug introduced 2015-11-20 23:03 UTC by Report Bug Copy Issue Report The variable `$result` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
80		return new WP_Error( 'update_fail', __( 'There was an error updating your theme', 'jetpack' ), 400 );
81		}
82
83		return true;
84		}
85
86		function update_translations() {
87		include_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
88
89		// Clear the cache.
90		wp_update_themes();
91
92		$available_themes_updates = get_site_transient( 'update_themes' );
93
94		if ( ! isset( $available_themes_updates->translations ) \|\| empty( $available_themes_updates->translations ) ) {
95
96		return new WP_Error( 'nothing_to_translate' );
97		}
98
99		foreach( $available_themes_updates->translations as $translation ) {
100		if ( ! in_array( $translation['slug'], $this->themes ) ) {
101		continue;
102		}
103
104		$theme = $translation['slug'] ;
105
106
107		/**
108		* Pre-upgrade action
109		*
110		* @since 3.9.3
111		*
112		* @param object $theme WP_Theme object
113		* @param array $themes Array of theme objects
114		*/
115		do_action('jetpack_pre_theme_upgrade', $theme, $this->themes);
116		// Objects created inside the for loop to clean the messages for each theme
117		$skin = new Automatic_Upgrader_Skin();
118		$upgrader = new Language_Pack_Upgrader( $skin );
119		$upgrader->init();
120
121		$result = $upgrader->upgrade( (object) $translation );
122		$this->log[ $theme ][] = $upgrader->skin->get_upgrade_messages();
123		}
124
125		if ( ! $this->bulk && ! $result ) {
		0 ignored issues – show Bug introduced 2016-11-09 01:42 UTC by Report Bug Copy Issue Report The variable `$result` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
126		return new WP_Error( 'update_fail', __( 'There was an error updating your theme', 'jetpack' ), 400 );
127		}
128
129		return true;
130		}
131
132		}
133

Automattic / jetpack

Push — update/sync-subscriptions-edit... ( 3e7813...304e22 )

Jetpack_JSON_API_Themes_Modify_Endpoint A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like