Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 19 | class Test_Jetpack_Admin_Menu extends WP_UnitTestCase { |
||
| 20 | |||
| 21 | /** |
||
| 22 | * Menu data fixture. |
||
| 23 | * |
||
| 24 | * @var array |
||
| 25 | */ |
||
| 26 | public static $menu_data; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * Submenu data fixture. |
||
| 30 | * |
||
| 31 | * @var array |
||
| 32 | */ |
||
| 33 | public static $submenu_data; |
||
| 34 | |||
| 35 | /** |
||
| 36 | * Test domain. |
||
| 37 | * |
||
| 38 | * @var string |
||
| 39 | */ |
||
| 40 | public static $domain; |
||
| 41 | |||
| 42 | /** |
||
| 43 | * Whether this testsuite is run on WP.com. |
||
| 44 | * |
||
| 45 | * @var bool |
||
| 46 | */ |
||
| 47 | public static $is_wpcom; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * Admin menu instance. |
||
| 51 | * |
||
| 52 | * @var Jetpack_Admin_Menu |
||
| 53 | */ |
||
| 54 | public static $admin_menu; |
||
| 55 | |||
| 56 | /** |
||
| 57 | * Mock user ID. |
||
| 58 | * |
||
| 59 | * @var int |
||
| 60 | */ |
||
| 61 | private static $user_id = 0; |
||
| 62 | |||
| 63 | /** |
||
| 64 | * Create shared fixtures. |
||
| 65 | * |
||
| 66 | * @param WP_UnitTest_Factory $factory Fixture factory. |
||
| 67 | */ |
||
| 68 | View Code Duplication | public static function wpSetUpBeforeClass( $factory ) { |
|
| 75 | |||
| 76 | /** |
||
| 77 | * Set up data. |
||
| 78 | */ |
||
| 79 | View Code Duplication | public function setUp() { |
|
| 91 | |||
| 92 | /** |
||
| 93 | * Tests add_jetpack_menu |
||
| 94 | * |
||
| 95 | * @covers ::add_jetpack_menu |
||
| 96 | */ |
||
| 97 | View Code Duplication | public function test_add_jetpack_menu() { |
|
| 110 | |||
| 111 | /** |
||
| 112 | * Tests add_tools_menu |
||
| 113 | * |
||
| 114 | * @covers ::add_tools_menu |
||
| 115 | */ |
||
| 116 | public function test_add_tools_menu() { |
||
| 140 | |||
| 141 | /** |
||
| 142 | * Tests add_wp_admin_menu |
||
| 143 | * |
||
| 144 | * @covers ::add_wp_admin_menu |
||
| 145 | */ |
||
| 146 | public function test_add_wp_admin_menu() { |
||
| 162 | |||
| 163 | /** |
||
| 164 | * Tests add_appearance_menu |
||
| 165 | * |
||
| 166 | * @covers ::add_appearance_menu |
||
| 167 | */ |
||
| 168 | public function test_add_appearance_menu() { |
||
| 183 | |||
| 184 | /** |
||
| 185 | * Tests add_posts_menu |
||
| 186 | * |
||
| 187 | * @covers ::add_posts_menu |
||
| 188 | */ |
||
| 189 | View Code Duplication | public function test_add_posts_menu() { |
|
| 196 | |||
| 197 | /** |
||
| 198 | * Tests add_page_menu |
||
| 199 | * |
||
| 200 | * @covers ::add_page_menu |
||
| 201 | */ |
||
| 202 | View Code Duplication | public function test_add_page_menu() { |
|
| 209 | |||
| 210 | /** |
||
| 211 | * Tests add_users_menu |
||
| 212 | * |
||
| 213 | * @covers ::add_users_menu |
||
| 214 | */ |
||
| 215 | View Code Duplication | public function test_add_users_menu() { |
|
| 222 | |||
| 223 | /** |
||
| 224 | * Tests add_users_menu |
||
| 225 | * |
||
| 226 | * @covers ::add_feedback_menu |
||
| 227 | */ |
||
| 228 | public function add_feedback_menu() { |
||
| 242 | |||
| 243 | /** |
||
| 244 | * Tests add_plugins_menu |
||
| 245 | * |
||
| 246 | * @covers ::add_plugins_menu |
||
| 247 | */ |
||
| 248 | View Code Duplication | public function test_add_plugins_menu() { |
|
| 256 | } |
||
| 257 |
Let’s assume you have a class which uses late-static binding:
The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the
getSomeVariable()on that sub-class, you will receive a runtime error:In the case above, it makes sense to update
SomeClassto useselfinstead: