Automattic /
jetpack
| Conditions | 8 |
| Paths | 2 |
| Total Lines | 89 |
| Lines | 9 |
| Ratio | 10.11 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 31 | function jetpack_debugger_site_status_tests( $core_tests ) { |
||
| 32 | $cxn_tests = new Jetpack_Cxn_Tests(); |
||
| 33 | $tests = $cxn_tests->list_tests( 'direct' ); |
||
| 34 | foreach ( $tests as $test ) { |
||
| 35 | |||
| 36 | $core_tests['direct'][ $test['name'] ] = array( |
||
| 37 | 'label' => __( 'Jetpack: ', 'jetpack' ) . $test['name'], |
||
| 38 | /** |
||
| 39 | * Callable for Core's Site Health system to execute. |
||
| 40 | * |
||
| 41 | * @param array $test A Jetpack Testing Suite test array. |
||
| 42 | * @param Jetpack_Cxn_Tests $cxn_tests An instance of the Jetpack Test Suite. |
||
| 43 | * |
||
| 44 | * @return array { |
||
| 45 | * A results array to match the format expected by WordPress Core. |
||
| 46 | * |
||
| 47 | * @type string $label Name for the test. |
||
| 48 | * @type string $status 'critical', 'recommended', or 'good'. |
||
| 49 | * @type array $badge Array for Site Health status. Keys label and color. |
||
| 50 | * @type string $description Description of the test result. |
||
| 51 | * @type string $action HTML to a link to resolve issue. |
||
| 52 | * @type string $test Unique test identifier. |
||
| 53 | * } |
||
| 54 | */ |
||
| 55 | 'test' => function() use ( $test, $cxn_tests ) { |
||
| 56 | $results = $cxn_tests->run_test( $test['name'] ); |
||
| 57 | if ( is_wp_error( $results ) ) { |
||
| 58 | return; |
||
| 59 | } |
||
| 60 | |||
| 61 | $label = $results['label'] ? |
||
| 62 | $results['label'] : |
||
| 63 | ucwords( |
||
| 64 | str_replace( |
||
| 65 | '_', |
||
| 66 | ' ', |
||
| 67 | str_replace( 'test__', '', $test['name'] ) |
||
| 68 | ) |
||
| 69 | ); |
||
| 70 | if ( $results['long_description'] ) { |
||
| 71 | $description = $results['long_description']; |
||
| 72 | } elseif ( $results['short_description'] ) { |
||
| 73 | $description = sprintf( |
||
| 74 | '<p>%s</p>', |
||
| 75 | $results['short_description'] |
||
| 76 | ); |
||
| 77 | } else { |
||
| 78 | $description = sprintf( |
||
| 79 | '<p>%s</p>', |
||
| 80 | __( 'This test successfully passed!', 'jetpack' ) |
||
| 81 | ); |
||
| 82 | } |
||
| 83 | |||
| 84 | $return = array( |
||
| 85 | 'label' => $label, |
||
| 86 | 'status' => 'good', |
||
| 87 | 'badge' => array( |
||
| 88 | 'label' => __( 'Jetpack', 'jetpack' ), |
||
| 89 | 'color' => 'green', |
||
| 90 | ), |
||
| 91 | 'description' => $description, |
||
| 92 | 'actions' => '', |
||
| 93 | 'test' => 'jetpack_' . $test['name'], |
||
| 94 | ); |
||
| 95 | |||
| 96 | if ( false === $results['pass'] ) { |
||
| 97 | $return['status'] = $results['severity']; |
||
| 98 | View Code Duplication | if ( ! empty( $results['action'] ) ) { |
|
| 99 | $return['actions'] = sprintf( |
||
| 100 | '<a href="%1$s" target="_blank" rel="noopener noreferrer">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>', |
||
| 101 | esc_url( $results['action'] ), |
||
| 102 | $results['action_label'], |
||
| 103 | /* translators: accessibility text */ |
||
| 104 | __( '(opens in a new tab)', 'jetpack' ) |
||
| 105 | ); |
||
| 106 | } |
||
| 107 | } |
||
| 108 | |||
| 109 | return $return; |
||
| 110 | }, |
||
| 111 | ); |
||
| 112 | } |
||
| 113 | $core_tests['async']['jetpack_test_suite'] = array( |
||
| 114 | 'label' => __( 'Jetpack Tests', 'jetpack' ), |
||
| 115 | 'test' => 'jetpack_local_testing_suite', |
||
| 116 | ); |
||
| 117 | |||
| 118 | return $core_tests; |
||
| 119 | } |
||
| 120 | |||
| 194 |
