Class_Method_Moved::find_invocation_warnings() - Code Metrics - Inspection of "Some fixes, plus support for moved declarations" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — try/code-signature-diff ( 313026...01fa4f )

unknown

created 2019-06-25 04:20 UTC

Class_Method_Moved::find_invocation_warnings() A

↳ Parent: Class_Method_Moved

Complexity

Conditions	5
Paths	3

Size

Total Lines

Duplication

Lines	10
Ratio	100 %

Importance

Changes

Metric	Value
cc	5
nc	3
nop	2
dl	10
loc	10
rs	9.6111
c	0
b	0
f	0

<?php

namespace Automattic\Jetpack\Analyzer\Differences;

use Automattic\Jetpack\Analyzer\PersistentList\Item as PersistentListItem;
use Automattic\Jetpack\Analyzer\Invocations\Static_Call;
use Automattic\Jetpack\Analyzer\Warnings\Warning; // TODO - subclasses?

class Class_Method_Moved extends PersistentListItem implements Invocation_Warner {

	public $old_declaration;
	public $new_declaration;

	function __construct( $old_declaration, $new_declaration ) {
		$this->old_declaration = $old_declaration;
		$this->new_declaration = $new_declaration;
	}

	function to_csv_array() {
		return array(
			$this->type(),
			$this->old_declaration->path,
			$this->old_declaration->line,
			$this->old_declaration->display_name(),
		);
	}

	public function type() {
		return 'method_missing';
	}

	public function display_name() {
		return $this->declaration->display_name();

	}

	public function find_invocation_warnings( $invocation, $warnings ) {
		if ( $invocation instanceof Static_Call ) {
			// check if it's instantiating this missing class
			if ( $invocation->class_name === $this->old_declaration->class_name
				&& $invocation->method_name === $this->old_declaration->method_name
				&& $this->old_declaration->static ) {
				$warnings->add( new Warning( $invocation->path, $invocation->line, 'Class static method ' . $this->old_declaration->display_name() . ' was moved from ' . $this->old_declaration->path . ' to ' . $this->new_declaration->path ) );
			}
		}
	}
}


1		<?php
2
3		namespace Automattic\Jetpack\Analyzer\Differences;
4
5		use Automattic\Jetpack\Analyzer\PersistentList\Item as PersistentListItem;
6		use Automattic\Jetpack\Analyzer\Invocations\Static_Call;
7		use Automattic\Jetpack\Analyzer\Warnings\Warning; // TODO - subclasses?
8
9	View Code Duplication	class Class_Method_Moved extends PersistentListItem implements Invocation_Warner {
		0 ignored issues – show Duplication introduced 2019-06-25 04:28 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10		public $old_declaration;
11		public $new_declaration;
12
13		function __construct( $old_declaration, $new_declaration ) {
14		$this->old_declaration = $old_declaration;
15		$this->new_declaration = $new_declaration;
16		}
17
18		function to_csv_array() {
19		return array(
20		$this->type(),
21		$this->old_declaration->path,
22		$this->old_declaration->line,
23		$this->old_declaration->display_name(),
24		);
25		}
26
27		public function type() {
28		return 'method_missing';
29		}
30
31		public function display_name() {
32		return $this->declaration->display_name();
		0 ignored issues – show Bug introduced 2019-06-25 04:28 UTC by Report Bug Copy Issue Report The property `declaration` does not seem to exist. Did you mean `old_declaration`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
33		}
34
35		public function find_invocation_warnings( $invocation, $warnings ) {
36		if ( $invocation instanceof Static_Call ) {
37		// check if it's instantiating this missing class
38		if ( $invocation->class_name === $this->old_declaration->class_name
39		&& $invocation->method_name === $this->old_declaration->method_name
40		&& $this->old_declaration->static ) {
41		$warnings->add( new Warning( $invocation->path, $invocation->line, 'Class static method ' . $this->old_declaration->display_name() . ' was moved from ' . $this->old_declaration->path . ' to ' . $this->new_declaration->path ) );
42		}
43		}
44		}
45		}
46

Automattic / jetpack

Push — try/code-signature-diff ( 313026...01fa4f )

Class_Method_Moved::find_invocation_warnings() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like