| Conditions | 15 | 
| Paths | 219 | 
| Total Lines | 66 | 
| Lines | 0 | 
| Ratio | 0 % | 
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php  | 
            ||
| 50 | 	static function get_setting( $setting ) { | 
            ||
| 51 | 		if ( ! isset( self::$valid_settings[ $setting ] ) ) { | 
            ||
| 52 | return false;  | 
            ||
| 53 | }  | 
            ||
| 54 | |||
| 55 | 		if ( isset( self::$settings_cache[ $setting ] ) ) { | 
            ||
| 56 | return self::$settings_cache[ $setting ];  | 
            ||
| 57 | }  | 
            ||
| 58 | |||
| 59 | 		if ( self::is_network_setting( $setting ) ) { | 
            ||
| 60 | 			if ( is_multisite() ) { | 
            ||
| 61 | $value = get_site_option( self::SETTINGS_OPTION_PREFIX . $setting );  | 
            ||
| 62 | 			} else { | 
            ||
| 63 | // On single sites just return the default setting  | 
            ||
| 64 | $value = Defaults::get_default_setting( $setting );  | 
            ||
| 65 | self::$settings_cache[ $setting ] = $value;  | 
            ||
| 66 | return $value;  | 
            ||
| 67 | }  | 
            ||
| 68 | 		} else { | 
            ||
| 69 | $value = get_option( self::SETTINGS_OPTION_PREFIX . $setting );  | 
            ||
| 70 | }  | 
            ||
| 71 | |||
| 72 | 		if ( false === $value ) { // no default value is set. | 
            ||
| 73 | $value = Defaults::get_default_setting( $setting );  | 
            ||
| 74 | 			if ( self::is_network_setting( $setting ) ) { | 
            ||
| 75 | update_site_option( self::SETTINGS_OPTION_PREFIX . $setting, $value );  | 
            ||
| 76 | 			} else { | 
            ||
| 77 | // We set one so that it gets autoloaded  | 
            ||
| 78 | update_option( self::SETTINGS_OPTION_PREFIX . $setting, $value, true );  | 
            ||
| 79 | }  | 
            ||
| 80 | }  | 
            ||
| 81 | |||
| 82 | 		if ( is_numeric( $value ) ) { | 
            ||
| 83 | $value = intval( $value );  | 
            ||
| 84 | }  | 
            ||
| 85 | $default_array_value = null;  | 
            ||
| 86 | 		switch ( $setting ) { | 
            ||
| 87 | case 'post_types_blacklist':  | 
            ||
| 88 | $default_array_value = Defaults::$blacklisted_post_types;  | 
            ||
| 
                                                                                                    
                        
                         | 
                |||
| 89 | break;  | 
            ||
| 90 | case 'taxonomies_blacklist':  | 
            ||
| 91 | $default_array_value = Defaults::$blacklisted_taxonomies;  | 
            ||
| 92 | break;  | 
            ||
| 93 | case 'post_meta_whitelist':  | 
            ||
| 94 | $default_array_value = Defaults::get_post_meta_whitelist();  | 
            ||
| 95 | break;  | 
            ||
| 96 | case 'comment_meta_whitelist':  | 
            ||
| 97 | $default_array_value = Defaults::get_comment_meta_whitelist();  | 
            ||
| 98 | break;  | 
            ||
| 99 | case 'known_importers':  | 
            ||
| 100 | $default_array_value = Defaults::get_known_importers();  | 
            ||
| 101 | break;  | 
            ||
| 102 | }  | 
            ||
| 103 | |||
| 104 | 		if ( $default_array_value ) { | 
            ||
| 105 | 			if ( is_array( $value ) ) { | 
            ||
| 106 | $value = array_unique( array_merge( $value, $default_array_value ) );  | 
            ||
| 107 | 			} else { | 
            ||
| 108 | $value = $default_array_value;  | 
            ||
| 109 | }  | 
            ||
| 110 | }  | 
            ||
| 111 | |||
| 112 | self::$settings_cache[ $setting ] = $value;  | 
            ||
| 113 | |||
| 114 | return $value;  | 
            ||
| 115 | }  | 
            ||
| 116 | |||
| 223 | 
This check looks for access to properties that are not accessible from the current context.
If you need to make a property accessible to another context you can either raise its visibility level or provide an accessible getter in the defining class.