Jetpack_PWA_Web_Push_Subscribe_Widget::widget() - Code Metrics - Inspection of "Empty optimize_jetpack function" - Automattic/jetpack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — add/pwa ( 271bee...a1e925 )

unknown

created 2017-10-30 22:10 UTC

Jetpack_PWA_Web_Push_Subscribe_Widget::widget() A

↳ Parent: Jetpack_PWA_Web_Push_Subscribe_Widget

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	9
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
eloc	6
nc	1
nop	2
dl	9
loc	9
rs	9.6666
c	0
b	0
f	0

<?php

// TODO output web push JS from this module


class Jetpack_PWA_Web_Push {
	private static $__instance = null;
	/**
	 * Singleton implementation
	 *
	 * @return object
	 */
	public static function instance() {
		if ( ! is_a( self::$__instance, 'Jetpack_PWA_Web_Push' ) ) {
			self::$__instance = new Jetpack_PWA_Web_Push();
		}

		return self::$__instance;
	}

	private function __construct() {
		if ( get_option( 'pwa_web_push' ) ) {
			add_filter( 'jetpack_published_post_flags', array( $this, 'modify_published_post_flags' ), 10, 2 );
			add_action( 'widgets_init', array( $this, 'register_subscribe_widget' ) );
		}
	}

	public function modify_published_post_flags( $flags, $post ) {
		if ( ! $this->post_type_is_web_pushable( $post->post_type ) ) {
			return $flags;
		}

		/**
		 * Determines whether a post being published gets sent to web push subscribers.
		 *
		 * @module pwa
		 *
		 * @since 5.6.0
		 *
		 * @param bool $should_publicize Should the post be web_pushed? Default to true.
		 * @param WP_POST $post Current Post object.
		 */
		if ( ! apply_filters( 'pwa_should_web_push_published_post', true, $post ) ) {
			return $flags;
		}

		$flags['web_push'] = true;

		return $flags;
	}

	protected function post_type_is_web_pushable( $post_type ) {
		if ( 'post' == $post_type )
			return true;

		return post_type_supports( $post_type, 'web_push' );
	}

	public function register_subscribe_widget() {
		register_widget( 'Jetpack_PWA_Web_Push_Subscribe_Widget' );
	}
}

if ( ! class_exists( 'Jetpack_PWA_Web_Push_Subscribe_Widget' ) ) {
	class Jetpack_PWA_Web_Push_Subscribe_Widget extends WP_Widget {

		/**
		 * Constructor
		 */
		public function __construct() {
			parent::__construct(
				'web_push_subscribe_widget',
				apply_filters( 'jetpack_widget_name', esc_html__( 'Jetpack Web Push Subscribe', 'jetpack' ) ),
				array(
					'description' => 'Web Push Subscribe',
				),
				array()
			);

			if ( is_active_widget( false, false, $this->id_base ) || is_customize_preview() ) {
				add_action( 'wp_enqueue_scripts', array( $this, 'enqueue_frontend_scripts' ) );
			}
		}

		/**
		 * Enqueue scripts and styles.
		 */
		function enqueue_frontend_scripts() {
			// TODO:

			// wp_enqueue_style( 'eu-cookie-law-style', plugins_url( 'eu-cookie-law/style.css', __FILE__ ), array(), '20170403' );
			// wp_enqueue_script( 'eu-cookie-law-script', plugins_url( 'eu-cookie-law/eu-cookie-law.js', __FILE__ ), array( 'jquery' ), '20170404', true );
		}

		function defaults() {
			// TODO:

			return array();
		}

		/**
		 * Outputs the content of the widget
		 *
		 * @param array $args
		 * @param array $instance
		 */
		public function widget( $args, $instance ) {
			$instance = wp_parse_args( $instance, $this->defaults() );
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
			echo $args['before_widget'];
			// require( dirname( __FILE__ ) . '/widget.php' );
			echo "The widget body";
			echo $args['after_widget'];
			/** This action is already documented in modules/widgets/gravatar-profile.php */
			do_action( 'jetpack_stats_extra', 'widget_view', 'web_push_subscribe' );
		}

		/**
		 * Back-end widget form.
		 *
		 * @param array $instance Previously saved values from database.
		 */
		public function form( $instance ) {
			$instance = wp_parse_args( $instance, $this->defaults() );
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
			// require( dirname( __FILE__ ) . '/eu-cookie-law/form.php' );
			echo "The form";
		}

		/**
		 * Processing widget options on save
		 *
		 * @param array $new_instance The new options
		 * @param array $old_instance The previous options
		 *
		 * @return array
		 */
		public function update( $new_instance, $old_instance ) {
			// processes widget options to be saved
		}
	}
}



1		<?php
2
3		// TODO output web push JS from this module
		0 ignored issues – show Coding Style Best Practice introduced 2017-10-13 05:39 UTC by Report Bug Copy Issue Report Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker. Loading history...
4
5		class Jetpack_PWA_Web_Push {
6		private static $__instance = null;
7		/**
8		* Singleton implementation
9		*
10		* @return object
11		*/
12		public static function instance() {
13		if ( ! is_a( self::$__instance, 'Jetpack_PWA_Web_Push' ) ) {
14		self::$__instance = new Jetpack_PWA_Web_Push();
15		}
16
17		return self::$__instance;
18		}
19
20		private function __construct() {
21		if ( get_option( 'pwa_web_push' ) ) {
22		add_filter( 'jetpack_published_post_flags', array( $this, 'modify_published_post_flags' ), 10, 2 );
23		add_action( 'widgets_init', array( $this, 'register_subscribe_widget' ) );
24		}
25		}
26
27		public function modify_published_post_flags( $flags, $post ) {
28		if ( ! $this->post_type_is_web_pushable( $post->post_type ) ) {
29		return $flags;
30		}
31
32		/**
33		* Determines whether a post being published gets sent to web push subscribers.
34		*
35		* @module pwa
36		*
37		* @since 5.6.0
38		*
39		* @param bool $should_publicize Should the post be web_pushed? Default to true.
40		* @param WP_POST $post Current Post object.
41		*/
42		if ( ! apply_filters( 'pwa_should_web_push_published_post', true, $post ) ) {
43		return $flags;
44		}
45
46		$flags['web_push'] = true;
47
48		return $flags;
49		}
50
51		protected function post_type_is_web_pushable( $post_type ) {
52		if ( 'post' == $post_type )
53		return true;
54
55		return post_type_supports( $post_type, 'web_push' );
56		}
57
58		public function register_subscribe_widget() {
59		register_widget( 'Jetpack_PWA_Web_Push_Subscribe_Widget' );
60		}
61		}
62
63		if ( ! class_exists( 'Jetpack_PWA_Web_Push_Subscribe_Widget' ) ) {
64		class Jetpack_PWA_Web_Push_Subscribe_Widget extends WP_Widget {
		0 ignored issues – show Coding Style Compatibility introduced 2017-10-30 22:18 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
65		/**
66		* Constructor
67		*/
68	View Code Duplication	public function __construct() {
69		parent::__construct(
70		'web_push_subscribe_widget',
71		apply_filters( 'jetpack_widget_name', esc_html__( 'Jetpack Web Push Subscribe', 'jetpack' ) ),
72		array(
73		'description' => 'Web Push Subscribe',
74		),
75		array()
76		);
77
78		if ( is_active_widget( false, false, $this->id_base ) \|\| is_customize_preview() ) {
79		add_action( 'wp_enqueue_scripts', array( $this, 'enqueue_frontend_scripts' ) );
80		}
81		}
82
83		/**
84		* Enqueue scripts and styles.
85		*/
86		function enqueue_frontend_scripts() {
87		// TODO:
		0 ignored issues – show Coding Style introduced 2017-10-30 22:18 UTC by Report Bug Copy Issue Report Comment refers to a TODO task This check looks `TODO` comments that have been left in the code. ``TODO``s show that something is left unfinished and should be attended to. Loading history...
88		// wp_enqueue_style( 'eu-cookie-law-style', plugins_url( 'eu-cookie-law/style.css', __FILE__ ), array(), '20170403' );
89		// wp_enqueue_script( 'eu-cookie-law-script', plugins_url( 'eu-cookie-law/eu-cookie-law.js', __FILE__ ), array( 'jquery' ), '20170404', true );
90		}
91
92		function defaults() {
93		// TODO:
		0 ignored issues – show Coding Style introduced 2017-10-30 22:18 UTC by Report Bug Copy Issue Report Comment refers to a TODO task This check looks `TODO` comments that have been left in the code. ``TODO``s show that something is left unfinished and should be attended to. Loading history...
94		return array();
95		}
96
97		/**
98		* Outputs the content of the widget
99		*
100		* @param array $args
101		* @param array $instance
102		*/
103	View Code Duplication	public function widget( $args, $instance ) {
104		$instance = wp_parse_args( $instance, $this->defaults() );
		0 ignored issues – show Unused Code introduced 2017-10-30 22:18 UTC by Report Bug Copy Issue Report `$instance` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
105		echo $args['before_widget'];
106		// require( dirname( __FILE__ ) . '/widget.php' );
107		echo "The widget body";
108		echo $args['after_widget'];
109		/** This action is already documented in modules/widgets/gravatar-profile.php */
110		do_action( 'jetpack_stats_extra', 'widget_view', 'web_push_subscribe' );
111		}
112
113		/**
114		* Back-end widget form.
115		*
116		* @param array $instance Previously saved values from database.
117		*/
118		public function form( $instance ) {
119		$instance = wp_parse_args( $instance, $this->defaults() );
		0 ignored issues – show Unused Code introduced 2017-10-30 22:18 UTC by Report Bug Copy Issue Report `$instance` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
120		// require( dirname( __FILE__ ) . '/eu-cookie-law/form.php' );
121		echo "The form";
122		}
123
124		/**
125		* Processing widget options on save
126		*
127		* @param array $new_instance The new options
128		* @param array $old_instance The previous options
129		*
130		* @return array
131		*/
132		public function update( $new_instance, $old_instance ) {
133		// processes widget options to be saved
134		}
135		}
136		}
137
138

Automattic / jetpack

Push — add/pwa ( 271bee...a1e925 )

Jetpack_PWA_Web_Push_Subscribe_Widget::widget() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like